Public report of EhPanda-Team/EhPanda, published 14 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 14 November 2026, 22:18 UTC · Survey ID cd_e35b2dfaac754205b2ea2d670cbcc797

EhPanda-Team/EhPanda

Measured 14 November 2026, 22:17 UTC, at code version 4d98daa

CAI score 62out of 100 Adequate
CriticalWeakAdequateStrongExemplary
Up 2 since the last survey

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 81,860 lines of product code in 2 projects, tests not counted · Estimated rebuild effort: about 1.3 person-years · Weakest lens: Accessibility, 55

Findings by how serious they are

168 critical 772 serious 59 minor

24 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
14 November 2026, 22:17 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

48of 48 dimensions measured by tools.
986of 999 findings point to an exact file and line, so you can open each one in the code. The other 13 concern the repository as a whole, such as missing documentation.
48dimensions across 7 lenses, read from 81,860 lines of product code in 2 projects.
Chapters

Executive summary

EhPanda-Team/EhPanda falls short of our standard for production because it has controls that only work with a mouse. It scores 62 out of 100 and is rated Adequate, and 77 of its 168 critical findings are security problems in the build pipeline and in its automatic dependency updates.

Accessibility, at 55, is the weakest lens and counts most in the score. The best first step is making the controls keyboard-usable, worth about 5 points. Structuring the pages comes next, worth about 3 points. Raising Accessibility to 70 would lift the score to about 67.

Seventy-three pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Thirty-eight controls can't be used without a mouse, and thirty-two form fields can't be read by a screen reader. Making the controls work with a keyboard, pinning each tool to an exact version and labelling the form fields would close these risks. Limiting each secret to its own step would fix the three secrets exposed to more of the pipeline than needed, and setting a waiting period for automatic updates would deal with the automatic dependency update that takes a new release at once. The 13 images with no text description need a text description.

The product code is 81,860 lines, about €190,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Accessibility 55 · counts for 46%Production Readiness 61 · counts for 25%Security and Compliance 66 · counts for 14%Code Health 74 · counts for 8%Maturity 82 · counts for 4%Architecture 87 · counts for 2%Performance 100 · counts for 1%

If Accessibility rose from 55 to 70, the lowest score rated Strong, the score would rise from 62 to about 67.

Code composition: what the lines of code are
Product code 49%Tests 51%
New since the last survey: 928 findings

These 928 critical or serious findings weren't in the previous survey, on 28 October 2026. The first 100 are listed here, and the findings file in the download package lists them all.

  • Cyclomatic Complexity · AppReducer.body (cyclomatic 96) AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift
  • Cyclomatic Complexity · Parser.parseEhSetting (cyclomatic 92) AppPackage/Sources/ParserFeature/Parser+Profile.swift
  • Cyclomatic Complexity · ReadingReducer.imageFetchReducer (cyclomatic 77) AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift
  • Cyclomatic Complexity · DownloadsReducer.body (cyclomatic 66) AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift
  • Cyclomatic Complexity · DetailReducer.downloadReducer (cyclomatic 63) AppPackage/Sources/DetailFeature/DetailReducer+Download.swift
  • Cyclomatic Complexity · HomeReducer.reducerBody (cyclomatic 62) AppPackage/Sources/HomeFeature/HomeReducer+Body.swift
  • Cyclomatic Complexity · FavoritesReducer.body (cyclomatic 61) AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift
  • Cyclomatic Complexity · FullContentHost.capture (cyclomatic 56) AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift
  • Cyclomatic Complexity · SettingReducer.reducerBody (cyclomatic 55) AppPackage/Sources/SettingFeature/SettingReducer+Body.swift
  • Cyclomatic Complexity · DownloadInspectorReducer.body (cyclomatic 46) AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift
  • Cyclomatic Complexity · CommentsReducer.body (cyclomatic 44) AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift
  • Cyclomatic Complexity · WatchedReducer.body (cyclomatic 43) AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift
  • Cyclomatic Complexity · SearchReducer.body (cyclomatic 39) AppPackage/Sources/SearchFeature/SearchReducer.swift
  • Cyclomatic Complexity · ReadingReducer.lifecycleReducer (cyclomatic 38) AppPackage/Sources/ReadingFeature/ReadingReducer+Body.swift
  • Cyclomatic Complexity · PresentationFeature.body (cyclomatic 36) AppPackage/Sources/AppFeature/DataFlow/PresentationFeature.swift
  • Cyclomatic Complexity · Parser.parseGalleryDetail (cyclomatic 36) AppPackage/Sources/ParserFeature/Parser+Detail.swift
  • Cyclomatic Complexity · ToplistsReducer.body (cyclomatic 32) AppPackage/Sources/HomeFeature/Toplists/ToplistsReducer.swift
  • Cyclomatic Complexity · UITestAutomation.resolve (cyclomatic 31) AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift
  • Cyclomatic Complexity · FrontPageReducer.body (cyclomatic 31) AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift
  • Cyclomatic Complexity · PreviewsReducer.body (cyclomatic 30) AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift
  • Cyclomatic Complexity · DetailSearchReducer.body (cyclomatic 29) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift
  • Cyclomatic Complexity · ReportFormFeature.body (cyclomatic 29) AppPackage/Sources/DetailFeature/Moderation/ReportFormFeature.swift
  • Cyclomatic Complexity · HistoryReducer.body (cyclomatic 29) AppPackage/Sources/HomeFeature/History/HistoryReducer.swift
  • Cyclomatic Complexity · SearchRootReducer.body (cyclomatic 29) AppPackage/Sources/SearchFeature/SearchRootReducer.swift
  • Cyclomatic Complexity · RenderServerCapture.slicePlan (cyclomatic 28) AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift
  • Cyclomatic Complexity · DetailReducer.galleryOpsReducer (cyclomatic 27) AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift
  • Cyclomatic Complexity · ArchivesReducer.body (cyclomatic 27) AppPackage/Sources/DetailFeature/Archives/ArchivesReducer.swift
  • Cyclomatic Complexity · Parser.parseThumbnailPanel (cyclomatic 27) AppPackage/Sources/ParserFeature/Parser+List.swift
  • Cyclomatic Complexity · altstore_languages.check_screenshots (cyclomatic 27) actions-tool/altstore_languages.py
  • Cyclomatic Complexity · pal_publish.publish (cyclomatic 27) REDACTED
  • Cyclomatic Complexity · FolderManagerReducer.body (cyclomatic 26) AppPackage/Sources/DetailFeature/FolderManager/FolderManagerReducer.swift
  • Cyclomatic Complexity · Parser.parseGalleryTorrents (cyclomatic 26) AppPackage/Sources/ParserFeature/Parser+Torrent.swift
  • Cyclomatic Complexity · EhSettingReducer.body (cyclomatic 25) AppPackage/Sources/SettingFeature/EhSetting/EhSettingReducer.swift
  • Cyclomatic Complexity · DetailReducer.fetchReducer (cyclomatic 23) AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift
  • Cyclomatic Complexity · 18-copy-check.check (cyclomatic 23) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py
  • Cyclomatic Complexity · Parser.parseComments (cyclomatic 22) AppPackage/Sources/ParserFeature/Parser+Comment.swift
  • Cyclomatic Complexity · GeneralSettingReducer.body (cyclomatic 22) AppPackage/Sources/SettingFeature/GeneralSetting/GeneralSettingReducer.swift
  • Cyclomatic Complexity · LoginReducer.body (cyclomatic 22) AppPackage/Sources/SettingFeature/Login/LoginReducer.swift
  • Cyclomatic Complexity · ReadLayout.init (cyclomatic 22) AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift
  • Cyclomatic Complexity · release_notes.main (cyclomatic 20) actions-tool/release_notes.py
  • Cyclomatic Complexity · UITestAutomation.prepare (cyclomatic 19) AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift
  • Cyclomatic Complexity · Parser.parseGreeting (cyclomatic 19) AppPackage/Sources/ParserFeature/Parser+Greeting.swift
  • Cyclomatic Complexity · GalleryURLParser.parse (cyclomatic 18) AppPackage/Sources/AppTools/GalleryURLParser.swift
  • Cyclomatic Complexity · GalleryPage.init (cyclomatic 18) AppPackage/Sources/DetailFeature/Moderation/CommentReportTarget.swift
  • Cyclomatic Complexity · TorrentsReducer.body (cyclomatic 18) AppPackage/Sources/DetailFeature/Torrents/TorrentsReducer.swift
  • Cyclomatic Complexity · SubmitEhSettingChangesRequest.response (cyclomatic 18) AppPackage/Sources/NetworkingFeature/Request+Account.swift
  • Cyclomatic Complexity · Parser.parseBanInterval (cyclomatic 18) AppPackage/Sources/ParserFeature/Parser+Shared.swift
  • Cyclomatic Complexity · 18-copy-check.build_expectations (cyclomatic 18) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py
  • Cyclomatic Complexity · 1-copy-check.parse_copy (cyclomatic 18) .planning/phases/18.1-native-report-form/18.1-copy-check.py
  • Cyclomatic Complexity · 1-copy-check.check (cyclomatic 18) .planning/phases/18.1-native-report-form/18.1-copy-check.py
  • Cyclomatic Complexity · altstore_languages.check_source (cyclomatic 18) actions-tool/altstore_languages.py
  • Cyclomatic Complexity · View.liveTextTranslations (cyclomatic 17) AppPackage/Sources/LiveTextTranslation/LiveTextTranslations.swift
  • Cyclomatic Complexity · AppReducer.tabSelectionEffect (cyclomatic 17) AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift
  • Cyclomatic Complexity · MarketingGalleries.download (cyclomatic 17) AppPackage/Sources/AppFeature/UITestSupport/CaptureScenePreparation.swift
  • Cyclomatic Complexity · CookieClient.live (cyclomatic 17) AppPackage/Sources/CookieClient/CookieClient.swift
  • Cyclomatic Complexity · CommentModerationFeature.body (cyclomatic 17) AppPackage/Sources/DetailFeature/Moderation/CommentModeration.swift
  • Cyclomatic Complexity · Parser.parseInfoPanel (cyclomatic 17) AppPackage/Sources/ParserFeature/Parser+Detail.swift
  • Cyclomatic Complexity · 18-copy-check.check_readmes (cyclomatic 17) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py
  • Cyclomatic Complexity · Data.isAnimatedGIFFormat (cyclomatic 16) AppPackage/Sources/AnimatedImageFeature/AnimatedImage+.swift
  • Cyclomatic Complexity · DetailView.content (cyclomatic 16) AppPackage/Sources/DetailFeature/DetailView.swift
  • Cyclomatic Complexity · HomePrimaryNavigationView.body (cyclomatic 16) AppPackage/Sources/HomeFeature/HomeNavigationView.swift
  • Cyclomatic Complexity · LiveTextPaint.init (cyclomatic 16) AppPackage/Sources/LiveTextTranslation/LiveTextBalloon.swift
  • Cyclomatic Complexity · LiveTextBalloonRegion.init (cyclomatic 16) AppPackage/Sources/LiveTextTranslation/LiveTextBalloon.swift
  • Cyclomatic Complexity · Parser.parseGalleryTags (cyclomatic 16) AppPackage/Sources/ParserFeature/Parser+List.swift
  • Cyclomatic Complexity · LiveTextHandler.polygonsIntersecting (cyclomatic 16) AppPackage/Sources/ReadingFeature/Support/LiveTextHandler.swift
  • Cyclomatic Complexity · split_legacy_release_notes.main (cyclomatic 16) actions-tool/split_legacy_release_notes.py
  • Cognitive Complexity · Parser.parseEhSetting (cognitive 151) AppPackage/Sources/ParserFeature/Parser+Profile.swift
  • Cognitive Complexity · ReadingReducer.imageFetchReducer (cognitive 114) AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift
  • Cognitive Complexity · AppReducer.body (cognitive 99) AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift
  • Cognitive Complexity · DetailReducer.downloadReducer (cognitive 76) AppPackage/Sources/DetailFeature/DetailReducer+Download.swift
  • Cognitive Complexity · FavoritesReducer.body (cognitive 69) AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift
  • Cognitive Complexity · FullContentHost.capture (cognitive 68) AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift
  • Cognitive Complexity · Parser.parseGalleryTorrents (cognitive 59) AppPackage/Sources/ParserFeature/Parser+Torrent.swift
  • Cognitive Complexity · 18-copy-check.check (cognitive 58) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py
  • Cognitive Complexity · DownloadInspectorReducer.body (cognitive 57) AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift
  • Cognitive Complexity · HomeReducer.reducerBody (cognitive 54) AppPackage/Sources/HomeFeature/HomeReducer+Body.swift
  • Cognitive Complexity · Parser.parseComments (cognitive 54) AppPackage/Sources/ParserFeature/Parser+Comment.swift
  • Cognitive Complexity · DownloadsReducer.body (cognitive 52) AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift
  • Cognitive Complexity · altstore_languages.check_screenshots (cognitive 48) actions-tool/altstore_languages.py
  • Cognitive Complexity · WatchedReducer.body (cognitive 45) AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift
  • Cognitive Complexity · Parser.parseGalleryDetail (cognitive 45) AppPackage/Sources/ParserFeature/Parser+Detail.swift
  • Cognitive Complexity · DetailReducer.fetchReducer (cognitive 41) AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift
  • Cognitive Complexity · 18-copy-check.check_readmes (cognitive 40) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py
  • Cognitive Complexity · SearchReducer.body (cognitive 39) AppPackage/Sources/SearchFeature/SearchReducer.swift
  • Cognitive Complexity · Parser.parseGreeting (cognitive 37) AppPackage/Sources/ParserFeature/Parser+Greeting.swift
  • Cognitive Complexity · PresentationFeature.body (cognitive 36) AppPackage/Sources/AppFeature/DataFlow/PresentationFeature.swift
  • Cognitive Complexity · ToplistsReducer.body (cognitive 36) AppPackage/Sources/HomeFeature/Toplists/ToplistsReducer.swift
  • Cognitive Complexity · ReadingReducer.lifecycleReducer (cognitive 35) AppPackage/Sources/ReadingFeature/ReadingReducer+Body.swift
  • Cognitive Complexity · SettingReducer.reducerBody (cognitive 35) AppPackage/Sources/SettingFeature/SettingReducer+Body.swift
  • Cognitive Complexity · pal_publish.publish (cognitive 35) REDACTED
  • Cognitive Complexity · AppReducer.tabSelectionEffect (cognitive 34) AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift
  • Cognitive Complexity · UITestAutomation.resolve (cognitive 33) AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift
  • Cognitive Complexity · PreviewsReducer.body (cognitive 33) AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift
  • Cognitive Complexity · Parser.parseGalleryArchive (cognitive 33) AppPackage/Sources/ParserFeature/Parser+Archive.swift
  • Cognitive Complexity · DetailSearchReducer.body (cognitive 32) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift
  • Cognitive Complexity · FrontPageReducer.body (cognitive 32) AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift
  • Cognitive Complexity · LiveTextHandler.polygonsIntersecting (cognitive 32) AppPackage/Sources/ReadingFeature/Support/LiveTextHandler.swift
  • Cognitive Complexity · split_legacy_release_notes.main (cognitive 32) actions-tool/split_legacy_release_notes.py
  • Cognitive Complexity · LiveTextPaint.init (cognitive 31) AppPackage/Sources/LiveTextTranslation/LiveTextBalloon.swift
  • Cognitive Complexity · Parser.parseThumbnailPanel (cognitive 31) AppPackage/Sources/ParserFeature/Parser+List.swift

We compare every finding with the previous survey's. A finding that has only moved to another line in the same file counts as the same finding, so only new findings appear here. Advisory notes from the AI model are left out, because the model words them afresh in every survey.

Fixed since the last survey: 193 findings

These 193 critical or serious findings were in the previous survey, on 28 October 2026, and are gone from this one. The first 100 are listed here.

  • Cyclomatic Complexity · Parser.parseEhSetting (cyclomatic 108) EhPanda/App/Tools/Parser.swift
  • Cyclomatic Complexity · ReadingReducer.body (cyclomatic 96) EhPanda/View/Reading/ReadingReducer.swift
  • Cyclomatic Complexity · SettingReducer.body (cyclomatic 77) EhPanda/View/Setting/SettingReducer.swift
  • Cyclomatic Complexity · DetailReducer.coreReducer (cyclomatic 66) EhPanda/View/Detail/DetailReducer.swift
  • Cyclomatic Complexity · AppReducer.body (cyclomatic 44) EhPanda/DataFlow/AppReducer.swift
  • Cyclomatic Complexity · HomeReducer.body (cyclomatic 38) EhPanda/View/Home/HomeReducer.swift
  • Cyclomatic Complexity · CommentsReducer.body (cyclomatic 38) EhPanda/View/Detail/Comments/CommentsReducer.swift
  • Cyclomatic Complexity · URL.applyingFilter (cyclomatic 36) EhPanda/App/Tools/Utilities/URLUtil.swift
  • Cyclomatic Complexity · Parser.parseGalleryDetail (cyclomatic 36) EhPanda/App/Tools/Parser.swift
  • Cyclomatic Complexity · ToplistsReducer.body (cyclomatic 35) EhPanda/View/Home/Toplists/ToplistsReducer.swift
  • Cyclomatic Complexity · Parser.parseCommentContent (cyclomatic 32) EhPanda/App/Tools/Parser.swift
  • Cyclomatic Complexity · FavoritesReducer.body (cyclomatic 31) EhPanda/View/Favorites/FavoritesReducer.swift
  • Cyclomatic Complexity · SearchReducer.body (cyclomatic 29) EhPanda/View/Search/SearchReducer.swift
  • Cyclomatic Complexity · DetailSearchReducer.body (cyclomatic 29) EhPanda/View/Detail/DetailSearch/DetailSearchReducer.swift
  • Cyclomatic Complexity · WatchedReducer.body (cyclomatic 29) EhPanda/View/Home/Watched/WatchedReducer.swift
  • Cyclomatic Complexity · ArchivesReducer.body (cyclomatic 28) EhPanda/View/Detail/Archives/ArchivesReducer.swift
  • Cyclomatic Complexity · AppRouteReducer.body (cyclomatic 27) EhPanda/DataFlow/AppRouteReducer.swift
  • Cyclomatic Complexity · Parser.parseGalleryTorrents (cyclomatic 26) EhPanda/App/Tools/Parser.swift
  • Cyclomatic Complexity · FrontpageReducer.body (cyclomatic 26) EhPanda/View/Home/Frontpage/FrontpageReducer.swift
  • Cyclomatic Complexity · Parser.parseGalleries::parseThumbnailPanel (cyclomatic 25) EhPanda/App/Tools/Parser.swift
  • Cyclomatic Complexity · Parser.parsePreviewURLs (cyclomatic 25) EhPanda/App/Tools/Parser.swift
  • Cyclomatic Complexity · Parser.parseGreeting (cyclomatic 23) EhPanda/App/Tools/Parser.swift
  • Cyclomatic Complexity · PreviewsReducer.body (cyclomatic 23) EhPanda/View/Detail/Previews/PreviewsReducer.swift
  • Cyclomatic Complexity · EhSettingReducer.body (cyclomatic 22) EhPanda/View/Setting/EhSetting/EhSettingReducer.swift
  • Cyclomatic Complexity · Parser.parseComments (cyclomatic 21) EhPanda/App/Tools/Parser.swift
  • Cyclomatic Complexity · Parser.parseBanInterval (cyclomatic 18) EhPanda/App/Tools/Parser.swift
  • Cyclomatic Complexity · Parser.parseGalleryDetail::parseInfoPanel (cyclomatic 17) EhPanda/App/Tools/Parser.swift
  • Cyclomatic Complexity · TorrentsReducer.body (cyclomatic 17) EhPanda/View/Detail/Torrents/TorrentsReducer.swift
  • Cyclomatic Complexity · SubmitEhSettingChangesRequest.publisher (cyclomatic 16) EhPanda/Network/Request.swift
  • Cyclomatic Complexity · LiveTextHandler.polygonsIntersecting (cyclomatic 16) EhPanda/View/Reading/Support/LiveTextHandler.swift
  • Cognitive Complexity · Parser.parseEhSetting (cognitive 173) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · ReadingReducer.body (cognitive 106) EhPanda/View/Reading/ReadingReducer.swift
  • Cognitive Complexity · SettingReducer.body (cognitive 80) EhPanda/View/Setting/SettingReducer.swift
  • Cognitive Complexity · Parser.parseGalleryTorrents (cognitive 59) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · AppReducer.body (cognitive 56) EhPanda/DataFlow/AppReducer.swift
  • Cognitive Complexity · Parser.parseCommentContent (cognitive 55) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · Parser.parseComments (cognitive 53) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · Parser.parseGalleryDetail (cognitive 45) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · DetailReducer.coreReducer (cognitive 45) EhPanda/View/Detail/DetailReducer.swift
  • Cognitive Complexity · Parser.parseGreeting (cognitive 42) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · URL.applyingFilter (cognitive 39) EhPanda/App/Tools/Utilities/URLUtil.swift
  • Cognitive Complexity · ToplistsReducer.body (cognitive 36) EhPanda/View/Home/Toplists/ToplistsReducer.swift
  • Cognitive Complexity · FavoritesReducer.body (cognitive 34) EhPanda/View/Favorites/FavoritesReducer.swift
  • Cognitive Complexity · Parser.parseGalleryArchive (cognitive 33) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · Parser.parseGalleryDetail::parseInfoPanel (cognitive 32) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · LiveTextHandler.polygonsIntersecting (cognitive 32) EhPanda/View/Reading/Support/LiveTextHandler.swift
  • Cognitive Complexity · HomeReducer.body (cognitive 30) EhPanda/View/Home/HomeReducer.swift
  • Cognitive Complexity · Parser.parseGalleries::parseThumbnailPanel (cognitive 29) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · SearchReducer.body (cognitive 29) EhPanda/View/Search/SearchReducer.swift
  • Cognitive Complexity · ArchivesReducer.body (cognitive 29) EhPanda/View/Detail/Archives/ArchivesReducer.swift
  • Cognitive Complexity · DetailSearchReducer.body (cognitive 29) EhPanda/View/Detail/DetailSearch/DetailSearchReducer.swift
  • Cognitive Complexity · CommentsReducer.body (cognitive 28) EhPanda/View/Detail/Comments/CommentsReducer.swift
  • Cognitive Complexity · WatchedReducer.body (cognitive 28) EhPanda/View/Home/Watched/WatchedReducer.swift
  • Cognitive Complexity · Parser.parsePreviewURLs (cognitive 26) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · FrontpageReducer.body (cognitive 26) EhPanda/View/Home/Frontpage/FrontpageReducer.swift
  • Cognitive Complexity · AppRouteReducer.body (cognitive 24) EhPanda/DataFlow/AppRouteReducer.swift
  • Cognitive Complexity · Parser.parseBanInterval (cognitive 24) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · Parser.parseGalleries::parseGalleryTags (cognitive 23) EhPanda/App/Tools/Parser.swift
  • Cognitive Complexity · DFStreamEventHandler.endEncountered (cognitive 19) EhPanda/Network/DFStreamHandler.swift
  • Cognitive Complexity · PreviewsReducer.body (cognitive 18) EhPanda/View/Detail/Previews/PreviewsReducer.swift
  • Cognitive Complexity · SubmitEhSettingChangesRequest.publisher (cognitive 17) EhPanda/Network/Request.swift
  • God Classes · MethodTooLong: ReadingReducer.body EhPanda/View/Reading/ReadingReducer.swift
  • God Classes · MethodTooLong: SettingReducer.body EhPanda/View/Setting/SettingReducer.swift
  • God Classes · FileTooLong: Tools/Parser.swift EhPanda/App/Tools/Parser.swift
  • God Classes · MethodTooLong: DetailReducer.coreReducer EhPanda/View/Detail/DetailReducer.swift
  • God Classes · MethodTooLong: Parser.parseGalleries EhPanda/App/Tools/Parser.swift
  • God Classes · MethodTooLong: Parser.parseGalleryDetail EhPanda/App/Tools/Parser.swift
  • God Classes · ClassTooLong: Parser EhPanda/App/Tools/Parser.swift
  • God Classes · MethodTooLong: Parser.parseEhSetting EhPanda/App/Tools/Parser.swift
  • God Classes · TooManyMethods: DatabaseClient EhPanda/App/Tools/Clients/DatabaseClient.swift
  • God Classes · FileTooLong: Network/Request.swift EhPanda/Network/Request.swift
  • God Classes · MethodTooLong: CommentsReducer.body EhPanda/View/Detail/Comments/CommentsReducer.swift
  • God Classes · MethodTooLong: HomeReducer.body EhPanda/View/Home/HomeReducer.swift
  • God Classes · FileTooLong: Detail/DetailView.swift EhPanda/View/Detail/DetailView.swift
  • God Classes · FileTooLong: EhSetting/EhSettingView.swift EhPanda/View/Setting/EhSetting/EhSettingView.swift
  • God Classes · ClassTooLong: ReadingReducer EhPanda/View/Reading/ReadingReducer.swift
  • God Classes · MethodTooLong: Parser.parseCommentContent EhPanda/App/Tools/Parser.swift
  • God Classes · MethodTooLong: AppReducer.body EhPanda/DataFlow/AppReducer.swift
  • God Classes · FileTooLong: Support/BrowsingCountry.swift EhPanda/Models/Support/BrowsingCountry.swift
  • Code Duplication · Near-duplicate member family (5 members, 22 shared lines) EhPanda/View/Detail/DetailSearch/DetailSearchView.swift
  • Code Duplication · Near-duplicate member pair (40 shared lines) EhPanda/View/Favorites/FavoritesReducer.swift
  • Code Duplication · Members sharing a duplicated core (12 members, 50+ identical tokens) EhPanda/DataFlow/AppRouteReducer.swift
  • Code Duplication · Members sharing a duplicated core (11 members, 50+ identical tokens) EhPanda/View/Detail/Comments/CommentsView.swift
  • Code Duplication · Members sharing a duplicated core (8 members, 50+ identical tokens) EhPanda/Network/Request.swift
  • Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) EhPanda/Network/Request.swift
  • Code Duplication · Duplicated block (33 lines × 2) EhPanda/View/Detail/DetailSearch/DetailSearchView.swift
  • Code Duplication · Duplicated block (31 lines × 2) EhPanda/View/Detail/DetailSearch/DetailSearchReducer.swift
  • Code Duplication · Duplicated block (28 lines × 4) EhPanda/View/Detail/DetailSearch/DetailSearchReducer.swift
  • Code Duplication · Duplicated block (25–28 lines × 2) EhPanda/App/Tools/Parser.swift
  • Code Duplication · Duplicated block (25–27 lines × 4) EhPanda/View/Detail/DetailSearch/DetailSearchReducer.swift
  • Code Duplication · Duplicated block (25 lines × 2) EhPanda/View/Detail/DetailSearch/DetailSearchReducer.swift
  • Code Duplication · Duplicated block (15–23 lines × 2) EhPanda/View/Reading/ReadingView.swift
  • Code Duplication · Duplicated block (19 lines × 2) EhPanda/DataFlow/AppRouteReducer.swift
  • Code Duplication · Duplicated block (19 lines × 2) EhPanda/View/Home/Frontpage/FrontpageView.swift
  • Code Duplication · Duplicated block (18 lines × 2) EhPanda/View/Home/Frontpage/FrontpageReducer.swift
  • Code Duplication · Duplicated block (17 lines × 2) EhPanda/View/Detail/DetailSearch/DetailSearchView.swift
  • Code Duplication · Duplicated block (16 lines × 8) EhPanda/View/Detail/DetailSearch/DetailSearchView.swift
  • Code Duplication · Duplicated block (16 lines × 2) EhPanda/View/Favorites/FavoritesReducer.swift
  • Code Duplication · Duplicated block (2–15 lines × 4) EhPanda/View/Detail/DetailSearch/DetailSearchReducer.swift
  • Code Duplication · Duplicated block (15 lines × 2) EhPanda/View/Favorites/FavoritesView.swift
Rebuild cost: about €190,000 · Estimate
Cost to rebuild€62,000 to €310,000, for 1,032 to 3,273 hours of work, about 1.3 person-years for 1 to 3 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.9 at a score of 62. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 81,860 lines of product code
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty. For this code, every line is priced as straight logic, which keeps the estimate on the low side.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
Raises the score by about 5 points · Medium effort · Keyboard semantics
2
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
Raises the score by about 3 points · Medium effort · Page structure
3
Add a SAST step to CI running what this repository's stack ships: CodeQL's Swift pack (Swift/Xcode) — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
Raises the score by about 2 points · Medium effort · Security & performance tooling

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €190,000 to build again, about 1.3 person-years of work. Its weakest lens is Accessibility, at 55 (Adequate). Accessibility is about whether the interface is built so that everyone can use it, including people who can't see the screen or can't use a mouse. Because the weakest lens counts most in the score, work on Accessibility also moves the score most.
Based on: the rebuild estimate · the Accessibility grade · how much each lens counts
What to do: Start with the Accessibility actions in Top priorities.
If you do one thing first · First action
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href. Of all the actions in this report, it raises the score most for the work it takes: about 5 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 7.2 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 2% to 5% on every change. The history of the code shows how much it changes: about 631,940 lines over the last 90 days, which is about 2,562,868 lines a year. At that pace, the extra work comes to an estimated 128.1 to 854.3 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

69 modules, with 201 dependencies between them. One loop runs through 25 of the modules, marked above the diagonal.

The table shows the 40 modules with the most connections; 29 more are left out to keep it readable.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 AppPackage~ApplicationClient2 AppPackage~ClipboardClient3 AppPackage~DFClient4 AppPackage~DeviceClient5 AppPackage~HapticsClient6 AppPackage~Resources7 AppPackage~ImageColors8 AppPackage~SFSafeSymbolsExt9 AppPackage~AppTools10 AppPackage~AppLaunchAutomationClient11 AppPackage~BackgroundProcessingClient12 AppPackage~CookieClient13 AppPackage~DownloadsFeature14 AppPackage~LibraryClient15 AppPackage~LiveTextTranslation16 AppPackage~NetworkingFeature17 AppPackage~SearchFeature18 AppPackage~SettingFeature19 AppPackage~SystemNotification20 AppPackage~DownloadClient21 AppPackage~GalleryListComponents22 AppPackage~HomeFeature23 AppPackage~ReadingFeature24 AppPackage~AppFeature25 AppPackage~DetailFeature26 AppPackage~AppComponents27 AppPackage~AppModels28 repository29 AppPackage~AnimatedImageFeature30 AppPackage~DateSeekFeature31 AppPackage~FavoritesFeature32 AppPackage~FiltersFeature33 AppPackage~LogsClient34 AppPackage~ParserFeature35 AppPackage~QuickSearchFeature36 AppPackage~ReadingSettingFeature37 AppPackage~FileClient38 AppPackage~ImageClient39 AppPackage~VisualSnapshotSupport40 AppPackage~AnalyticsClient
1 AppPackage~ApplicationClient
2 AppPackage~ClipboardClient
3 AppPackage~DFClient
4 AppPackage~DeviceClient
5 AppPackage~HapticsClient
6 AppPackage~Resources
7 AppPackage~ImageColors1
8 AppPackage~SFSafeSymbolsExt1
9 AppPackage~AppTools132
10 AppPackage~AppLaunchAutomationClient32
11 AppPackage~BackgroundProcessingClient5
12 AppPackage~CookieClient82
13 AppPackage~DownloadsFeature3159161
14 AppPackage~LibraryClient12
15 AppPackage~LiveTextTranslation12514818
16 AppPackage~NetworkingFeature611678
17 AppPackage~SearchFeature2118129
18 AppPackage~SettingFeature128121531241
19 AppPackage~SystemNotification222
20 AppPackage~DownloadClient482121322
21 AppPackage~GalleryListComponents41121017
22 AppPackage~HomeFeature6262103137111
23 AppPackage~ReadingFeature1341712121312
24 AppPackage~AppFeature2611853121225112872
25 AppPackage~DetailFeature108134311111152442
26 AppPackage~AppComponents12462412211111215
27 AppPackage~AppModels297510521212
28 repository154
29 AppPackage~AnimatedImageFeature21
30 AppPackage~DateSeekFeature1111226
31 AppPackage~FavoritesFeature12127
32 AppPackage~FiltersFeature1256
33 AppPackage~LogsClient42
34 AppPackage~ParserFeature321
35 AppPackage~QuickSearchFeature111
36 AppPackage~ReadingSettingFeature11121
37 AppPackage~FileClient533
38 AppPackage~ImageClient23
39 AppPackage~VisualSnapshotSupport441412212
40 AppPackage~AnalyticsClient11121126111111111281111
Uses a module listed above itPart of a loopThe module itself
1 AppPackage~ApplicationClient2 AppPackage~ClipboardClient3 AppPackage~DFClient4 AppPackage~DeviceClient5 AppPackage~HapticsClient6 AppPackage~Resources7 AppPackage~ImageColors8 AppPackage~SFSafeSymbolsExt9 AppPackage~AppTools10 AppPackage~AppLaunchAutomationClient11 AppPackage~BackgroundProcessingClient12 AppPackage~CookieClient13 AppPackage~DownloadsFeature14 AppPackage~LibraryClient15 AppPackage~LiveTextTranslation16 AppPackage~NetworkingFeature17 AppPackage~SearchFeature18 AppPackage~SettingFeature19 AppPackage~SystemNotification20 AppPackage~DownloadClient21 AppPackage~GalleryListComponents22 AppPackage~HomeFeature23 AppPackage~ReadingFeature24 AppPackage~AppFeature25 AppPackage~DetailFeature26 AppPackage~AppComponents27 AppPackage~AppModels28 repository29 AppPackage~AnimatedImageFeature30 AppPackage~DateSeekFeature31 AppPackage~FavoritesFeature32 AppPackage~FiltersFeature33 AppPackage~LogsClient34 AppPackage~ParserFeature35 AppPackage~QuickSearchFeature36 AppPackage~ReadingSettingFeature37 AppPackage~FileClient38 AppPackage~ImageClient39 AppPackage~VisualSnapshotSupport40 AppPackage~AnalyticsClientAppPackage~ApplicationClient1AppPackage~ClipboardClient2AppPackage~DFClient3AppPackage~DeviceClient4AppPackage~HapticsClient5AppPackage~Resources6AppPackage~ImageColors7AppPackage~SFSafeSymbolsExt8AppPackage~AppTools9AppPackage~AppLaunchAutomationClient10AppPackage~BackgroundProcessingClient11AppPackage~CookieClient12AppPackage~DownloadsFeature13AppPackage~LibraryClient14AppPackage~LiveTextTranslation15AppPackage~NetworkingFeature16AppPackage~SearchFeature17AppPackage~SettingFeature18AppPackage~SystemNotification19AppPackage~DownloadClient20AppPackage~GalleryListComponents21AppPackage~HomeFeature22AppPackage~ReadingFeature23AppPackage~AppFeature24AppPackage~DetailFeature25AppPackage~AppComponents26AppPackage~AppModels27repository28AppPackage~AnimatedImageFeature29AppPackage~DateSeekFeature30AppPackage~FavoritesFeature31AppPackage~FiltersFeature32AppPackage~LogsClient33AppPackage~ParserFeature34AppPackage~QuickSearchFeature35AppPackage~ReadingSettingFeature36AppPackage~FileClient37AppPackage~ImageClient38AppPackage~VisualSnapshotSupport39AppPackage~AnalyticsClient401113232582315916112125148186116782118129128121531241222482121322411210176262103137111134171212131226118531212251128721081343111111524421246241221111121529751052121215421111122612127125642321111111215332344141221211121126111111111281111+29 more modules (most-connected shown)

At a glance — Code Health · 74% · Strong ·

At a glance — Architecture · 87% · Adequate · gated by D26 ·

At a glance — Maturity · 82% · Adequate · gated by D16 ·

At a glance — Readiness · 61% · Adequate · gated by P3 ·

At a glance — Security · 66% · Adequate · gated by D36 ·

At a glance — Accessibility · 55% · Adequate · gated by AC4 ·

At a glance — Performance · 100% · Exemplary ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A05:2025 — Injection82High / Critical
A03:2025 — Software Supply Chain Failures5Medium

Roadmap

Top priorities: Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href; Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh; Resolve the 274 No assertions finding(s) in Test Quality — start with AnalyticsEmissionTests.swift (39), AccessibilityAuditUITests.swift (20), ReaderListPositionTests.swift (13).

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.+5.2 ptsMediumKeyboard semantics
Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.+3.2 ptsMediumPage structure
Add a SAST step to CI running what this repository's stack ships: CodeQL's Swift pack (Swift/Xcode) — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.+2.4 ptsMediumSecurity & performance tooling
Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.+1.6 ptsMediumObservability
Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.+1.4 ptsMediumText alternatives
Resolve the 274 No assertions finding(s) in Test Quality — start with AnalyticsEmissionTests.swift (39), AccessibilityAuditUITests.swift (20), ReaderListPositionTests.swift (13).+2.8 ptsHighTest Quality
Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.+1.3 ptsMediumForms & labels
Pin third-party scripts and verify them: name an exact version in the URL and add an `integrity="sha384-…"` hash alongside `crossorigin="anonymous"` (both are required — an integrity hash on a cross-origin script without `crossorigin` is not evaluated, it blocks the script). Where the vendor ships a continuously-updated loader and publishes no stable hash (tag managers, analytics, chat widgets), Subresource Integrity is not available: constrain it instead with a `Content-Security-Policy` that names the exact origins allowed to execute, and drop the script from the pages that do not need it. Where the page is shipped inside a package that others host, prefer vendoring the asset and serving it from the app’s own origin, so no consumer inherits a third-party dependency they did not choose.+1.1 ptsMediumWeb-Security Posture

File quality

Per-file score 0–10 — a quality signature. Of 240 files carrying findings, judged against the Production bar: 0% slop · 64% mixed · 36% near-clean.

FileScoreBandWorst signal
REDACTED3.0SlopStatic Analysis (SAST): High: REDACTED
REDACTED4.4MixedStatic Analysis (SAST): High: REDACTED
REDACTED4.4MixedStatic Analysis (SAST): High: REDACTED
REDACTED4.6MixedStatic Analysis (SAST): High: REDACTED
REDACTED4.8MixedStatic Analysis (SAST): High: REDACTED
REDACTED4.8MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
REDACTED5.1MixedStatic Analysis (SAST): High: REDACTED
AppPackage/Sources/DetailFeature/DetailView.swift5.5MixedCyclomatic Complexity: DetailView.content (cyclomatic 16)
AppPackage/Sources/HomeFeature/History/HistoryView.swift5.5MixedCode Duplication: Edited copy of a member (19 corresponding lines)
AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift5.5MixedCode Duplication: Edited copy of a member (42 corresponding lines)
AppPackage/Sources/FavoritesFeature/FavoritesView.swift5.9MixedCode Duplication: Edited copy of a member (16 corresponding lines)
AppPackage/Sources/HomeFeature/Watched/WatchedView.swift6.3MixedCode Duplication: Edited copy of a member (39 corresponding lines)
AppPackage/Sources/DetailFeature/Comments/CommentsView.swift6.3MixedCode Duplication: Edited copy of a member (21 corresponding lines)
AppPackage/Sources/DetailFeature/GalleryNavigation.swift6.3MixedCode Duplication: Edited copy of a member (9 corresponding lines)
AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift6.3MixedCode Duplication: Duplicated block (17 lines × 3)
REDACTED6.3MixedCyclomatic Complexity: pal_publish.publish (cyclomatic 27)
AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift7.0MixedCyclomatic Complexity: FrontPageReducer.body (cyclomatic 31)
.planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py7.0MixedCyclomatic Complexity: 18-copy-check.check (cyclomatic 23)

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 168

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 772

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 59

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 24

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 48 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 48 dimensions across the health lenses
D1D2D3D4D6D7D10D12D13D14D15D16D17D20D21D26D27D28D29D30D34D35D36D43AC1AC2AC3AC4AC5AC6AX10AX3AX4AX8AX9M1M2M3M4P1P2P3P4P6PF3S1X28X3

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 986 of 999 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1dc23-5a89-7ae1-aec0-f2b0f99ce01f.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D8 Code Coverage — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Coverage NOT MEASURED: the Swift half could not be measured — the Swift suite in AppPackage produced no coverage export. Coverage is excluded from the score rather than counted as a near-zero. This is OUR limitation, not a defect in the repo.
  • D10 Test Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The 2,148 test(s) behind this row are the ones the code-model census could read, and this repository also carries at least 38 test source file(s) (.py) that it cannot: it reads the test types the .swift frontend declared, so a suite in any other language is invisible to it. Skipped tests, zero-assertion tests and the other quality signals on this row are UNMEASURED in that suite — their absence from the counts above is a gap in this analyzer's language coverage, not a finding that those tests are sound.
  • D11 Test Reliability — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Test source is present (.py, .swift) and this repository declares a SwiftPM test suite (AppPackage), but it was not re-run: the analyzer environment could not run it. Not scored — this is a gap in the analyzer's language coverage, not a finding about this repository.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D21's naming rules read C# through Roslyn and every other language through its sidecar model; these languages are left out (PHP's reading is its own change, a Roslyn-loaded VB or F# project has no population builder yet). Their declarations carry no naming verdict this run — this says nothing about whether their names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D21 Naming Consistency — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D22 Internal API Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. D22 identifies the intentionally-exposed surface from `IsPackable` and `.Contracts` project names, MSBuild conventions read off the loaded project set. This target exposed no such projects, so the probe never ran; this says nothing about whether the repository has a public API. This repository commits no C#/VB source at all, so there was never an MSBuild project set to read these conventions off. That is OUR side and it is a COLLECTOR gap, not an environment fault: it declares a published package (AppPackage/Package.swift), but no published-package marker D22 reads admitted any project here, so this ecosystem's public API has no collector, and the remedy is to write one — no change to the scan image can close it.
  • D24 Comment Value — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover the language this repository's product is written in, so it had nothing of the product to read. That is a gap in this analyzer's language reach — not a finding about this repository.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `AppPackage/Sources/AppComponents/AdaptiveStack.swift`, `AppPackage/Sources/AppComponents/CategoryView.swift`, `AppPackage/Sources/AppComponents/CheckboxToggleStyle.swift`, `AppPackage/Sources/AppComponents/ChoiceCard.swift`, `AppPackage/Sources/AppComponents/FirstLaunchContinueButton.swift`, … (+103 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • D44 Platform End-of-Life — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This dimension reads a project's own statement about the platform it runs on: a TargetFramework in a .NET project file, a .nvmrc or .python-version, a capped requires-python, a Rust toolchain file or Cargo.toml rust-version, a .go-version, .java-version, .ruby-version, .tool-versions or .sdkmanrc, a go.mod go directive, a Maven or Gradle Java level or toolchain, a Gemfile's ruby directive, a mix.exs elixir requirement, a rebar.config minimum_otp_vsn, a pubspec.yaml SDK constraint, a build.sbt scalaVersion, or a framework major pinned by a dependency constraint. This repository carries none of them, so nothing about its platform was established. That is a gap in this analyzer's coverage, NOT a finding that the platform is supported — a language whose runtime is declared elsewhere (Package.swift, a Dockerfile) is simply not read here yet.
  • AC2 Forms & labels — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 49 further occurrence(s) are not listed individually; the score already reflects all 89.
  • AC3 Page structure — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 27 further occurrence(s) are not listed individually; the score already reflects all 67.
  • AC4 Keyboard semantics — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 98 further occurrence(s) are not listed individually; the score already reflects all 138.
  • AX1 Captive dependencies — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads Microsoft.Extensions.DependencyInjection registrations in C# and Spring beans in Java/Kotlin only, and this repository's container is swift-dependencies, whose lifetimes are not modelled yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • AX6 Interface segregation — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check is computed over the public interfaces this run's compilations declare, and none was loaded, so it had nothing to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • AXB1 Runtime evidence locked — no reproducible boot — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Subject: 36 markup document(s) — HTML, Razor, JSX, Vue, Svelte or server templates. The Runtime Evidence tier boots an app only via docker-compose, an Aspire AppHost, a Dockerfile, an npm dev script, a web service's own toolchain entry point (cargo, go, dotnet, Python, Spring Boot), or an Android app's own Gradle wrapper (run on an emulator); an Apple or Flutter app needs a host it lacks. None applied, so no live runtime a11y/egress/header evidence was collected. You can widen what we reach: add a docker-compose.yml (or an Aspire AppHost) that brings the app up with its dependencies. We then boot it in an isolated sandbox and gathers real runtime evidence — you change nothing in your pipeline (no CI step, no SDK).
  • C1 Data Protection — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These personal data controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks personal data controls.
  • C2 Access Controls — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These authorization controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks authorization controls.
  • C3 Audit Trail — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. These audit controls are read from declarative annotations, request middleware, entity/column names and guard methods in a C# source model, and none was loaded on this run, so there was nothing to gather. That is a gap in this analyzer's language reach — not a finding that the repository lacks audit controls.
  • GD1 Unfinished & placeholder code — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, F#, JavaScript/TypeScript, Dart, Ruby and Scala source only, and no C#, F#, JavaScript/TypeScript, Dart, Ruby or Scala was found, and this repository's Python, Swift is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • IC1 Incompleteness & stubs — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, JavaScript/TypeScript, Java, Dart, Ruby and Scala source only, and no C#, JavaScript/TypeScript, Java, Dart, Ruby or Scala was found, and this repository's Python, Swift is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
  • X12 Unreachable branch — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X16 Unfloored truncation loop — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Java, PHP, Dart, Ruby, Scala and Kotlin source only, and no C# was loaded and no JavaScript/TypeScript, Java, PHP, Dart, Ruby, Scala or Kotlin was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X18 Disposal-pattern correctness — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Java, Kotlin, Dart, Ruby, Scala and PHP source only, and no C# was loaded and no JavaScript/TypeScript, Java, Kotlin, Dart, Ruby, Scala or PHP was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X2 Cancellation propagation — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Go, PHP, Dart, Kotlin, Ruby, Scala, Java, Python and Rust source only, and no C# was loaded, and no named async function in this repository's JavaScript/TypeScript, nor any Go, PHP or Dart function or Kotlin suspend function, makes a request that can be cancelled (fetch, axios, ky, ofetch, got, undici, node:http; net/http, net.Dial; amphp; Dio; Ktor, OkHttp), so there is nothing to judge, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X24 Document value interpolated into markup unescaped — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X27 Collection changed while being enumerated — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X29 Per-element action decided by a fixed element — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript (Vue and Svelte components included), Java, Rust, Dart, Ruby, Scala and Kotlin source only, and no C# was loaded and no JavaScript/TypeScript, Java, Rust, Dart, Ruby, Scala or Kotlin was found in this repository, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X30 Support guard that admits what it rejects — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check's reader does not cover most of the languages this repository's product is written in. What it read is kept, but it is too small a share to grade the product by. That is a gap in this analyzer's language reach — not a finding about this repository.
  • X4 Structured logging — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax, and JavaScript/TypeScript, Java, Kotlin, Python, PHP, Dart, Ruby, Scala and Rust source only, and no C# was loaded, and this repository's JavaScript/TypeScript, Python and PHP make no call through a named logger, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.
  • X5 Nullable reference types — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. This check reads C# syntax and MSBuild project configuration, TypeScript source and its tsconfig files, Java source and its package and module declarations, PHP source and its PHPStan and Psalm configuration, Dart source and its pubspec language version, Ruby source and its Sorbet and Steep configuration, Scala source and its build's explicit-nulls, WartRemover and Scalafix settings, and Kotlin source only, and no C# was loaded, no TypeScript was found, and this repository's Python, Swift is not read yet, so it had nothing of this repository's product to read. That is a gap in this analyzer's language reach — not a finding that the repository is free of what this check looks for.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D7 Architectural Integrity: Layering is checked against detected/declared rules — an architecture whose boundaries live in convention or in code review, not in a rule a scanner can read, is not enforced here.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
  • D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D21 Naming Consistency: Naming consistency compares each name with the convention its structural peers follow in this repository: it cannot tell whether a consistently used name is a good one, and languages other than C# and TypeScript are not measured.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • AC1 Text alternatives: Alt-text is detected structurally — the scan sees that an alternative EXISTS, not whether it meaningfully describes the image, and decorative-vs-missing is judged by attribute shape; runtime-injected images and a non-role=img decorative svg are out of scope. This is accessibility readiness, never a WCAG conformance claim.
  • AC2 Forms & labels: Label association is read from static markup — a label wired up at runtime (JS-set aria-labelledby, framework-injected ids) reads as missing, a present label says nothing about whether its text is correct. A known UI-library field component (e.g. a JSX <TextField>) is now checked conservatively — flagged only when it carries NO label/aria-label/aria-labelledby/id/name — but wrapper/context-labelled libraries (Chakra/Radix FormControl+FormLabel) aren't statically visible (possible false positive) and non-JSX lowercased components are still skipped. A click handler on a plain element is now asked for a name too (it is a control the author declared), but the subtree test that answers it is deliberately generous: any DYNAMIC text expression in the subtree counts as a name, so an icon chosen by a ternary ({cond ? <IconA/> : <IconB/>}) reads as named, and a glyph component from a library the icon-import list does not know still names its parent. A clean result is "no unlabelled control found", not a labelling proof.
  • AC3 Page structure: Page structure is read from the static markup tree — landmarks, headings and lang injected at runtime aren't seen, heading ORDER is checked structurally (not against the rendered visual hierarchy), and lang/title/main fire only on full documents, never partials, and the data-table check sees header-cell presence (a <th> exists), not whether each header correctly associates with its cells. Static readiness, not conformance.
  • AC4 Keyboard semantics: Keyboard semantics are inferred from markup attributes — interactivity wired purely in script, focus managed at runtime, and component-level handlers are invisible. A clean result means "no static keyboard-trap shape", not a keyboard-operability proof.
  • AC5 ARIA correctness: ARIA correctness is checked against the static role/attribute shape — roles/attributes set dynamically aren't seen, a valid role says nothing about whether it matches the element's real behaviour, and required-state checks are suppressed when a JSX spread could supply them. The two-branch toggle check (a control whose state is conveyed only by which of two mutually exclusive branches renders) reads CONDITIONALS THAT ARE ATTRIBUTES — Vue v-if/v-else/v-show and Alpine x-if/x-show — so the same toggle written as a Svelte {#if} block or a JSX ternary is control flow the markup model never projects as a branch and is not seen at all.
  • AC6 Visual & motion safety: Contrast and motion safety are PARTIAL by construction — literal colours (hex/rgb/hsl/named) in inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS top-level declarations are read (same-rule/same-element colour+background pairs only); computed/runtime/theme colour, external-CDN stylesheets, CSS-in-JS dynamic (${…}) and nested-selector colours, cross-element pairs and image contrast stay out of reach, so a clean result is bounded by what the static CSS itself shows.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • AX9 CQS / query purity: Handlers are found by interface/name convention — a query handler using neither is not seen. Mutation is a resolved write/publish invocation (SaveChanges/repository/bus), so a write hidden behind a hand-rolled wrapper, reflection, or a string-keyed service locator resolves to a non-persistence type and isn't flagged; it detects that a query writes state, not whether the write is a legitimate read-side cache update. Clean means "no resolved write/publish in a query body", not a proof of CQS purity.
  • M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
  • P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity6.0 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Prevented

66 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was AppReducer.body at 96. A further 13 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being BrowsingCountry.englishName at 252 — they are counted neither in the figure above nor in this dimension's score. 10 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: AppPackage/Sources/AppModels/Support/BrowsingCountry+EnglishName.swift (BrowsingCountry.englishName at 252), AppPackage/Sources/AppModels/Support/BrowsingCountry.swift (BrowsingCountry.name at 252), AppPackage/Sources/AppModels/Gallery/Language.swift (Language.value at 67), AppPackage/Sources/AnalyticsClient/AnalyticsSignal+Rendering.swift (AnalyticsSignal.rendered at 21), AppPackage/Sources/AppFeature/UITestSupport/CaptureSceneConfiguration.swift (CaptureFailure.description at 20), and 5 more not listed here. They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

AppReducer.body (cyclomatic 96)AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift:98
Parser.parseEhSetting (cyclomatic 92)AppPackage/Sources/ParserFeature/Parser+Profile.swift:24
ReadingReducer.imageFetchReducer (cyclomatic 77)AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift:12
DownloadsReducer.body (cyclomatic 66)AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:172
DetailReducer.downloadReducer (cyclomatic 63)AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:16

+ 61 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 7 bodies over 60 down to 60 or less in Cyclomatic Complexity — start with AppReducer.body (cyclomatic 96), Parser.parseEhSetting (cyclomatic 92), ReadingReducer.imageFetchReducer (cyclomatic 77). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 7 together lifts Cyclomatic Complexity from 6.1 to about 6.5/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity5.6 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.6 / 10 · rule-coverage 100% · ceiling Prevented

78 method(s) exceeded the cognitive complexity threshold of 15; the worst was Parser.parseEhSetting at 151.

Parser.parseEhSetting (cognitive 151)AppPackage/Sources/ParserFeature/Parser+Profile.swift:24
ReadingReducer.imageFetchReducer (cognitive 114)AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift:12
AppReducer.body (cognitive 99)AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift:98
DetailReducer.downloadReducer (cognitive 76)AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:16
FavoritesReducer.body (cognitive 69)AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:130

+ 73 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 1 body over 120 down to 120 or less in Cognitive Complexity — start with Parser.parseEhSetting (cognitive 151). — Refactoring it lifts Cognitive Complexity from 5.6 to about 5.8/10.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes8.2 / 10Strong✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.2 / 10 · rule-coverage 100% · ceiling Prevented

33 god class(es) detected.

MethodTooLong: ReadingReducer.imageFetchReducer · ×25AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift:12
FileTooLong: VisualSnapshotSupport/FullContentHost.swift · ×3AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift
TooManyMethods: DownloadCoordinator · ×2AppPackage/Sources/DownloadClient/DownloadClient+Manager.swift:54
ClassTooLong: FullContentHost · ×2AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift:61
FunctionTooLong: DetailView+Subviews.swift.top-level codeAppPackage/Sources/DetailFeature/DetailView+Subviews.swift:243

What to do

  1. Resolve the 25 MethodTooLong finding(s) in God Classes — start with ReadingReducer+ImageFetch.swift, BrowsingCountry+EnglishName.swift, BrowsingCountry.swift. — One of this dimension's main actionable groups (25 warning-level).
  2. Resolve the 3 FileTooLong finding(s) in God Classes — start with FullContentHost.swift, CaptureScenePreparation.swift, Request+Account.swift. — One of this dimension's main actionable groups (3 warning-level).
  3. Resolve the 2 TooManyMethods finding(s) in God Classes — start with DownloadClient+Manager.swift, DownloadStore.swift. — One of this dimension's main actionable groups (2 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication8.2 / 10Strong✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.2 / 10 · rule-coverage 100% · ceiling Verified

85 duplicated block group(s) detected. 4.6 % of the production lines (3,742 of 81,860) are in a reported copy. A further 75 rows report members as variants of one another; the share counts each copied line once, however many rows cite it. 3 of the 160 are in trees this repository does not ship — vendored, example/demo, project-template, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.

Duplicated block (9 lines × 2) · ×7AppPackage/Sources/AppFeature/UITestSupport/CaptureFixtureManifest.swift:499
Duplicated block (8 lines × 2) · ×7AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:219
Members sharing a duplicated core (4 members, 50+ identical tokens) · ×6.planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:16
Duplicated block (7 lines × 2) · ×6AppPackage/Sources/DetailFeature/HeaderActionsLayout.swift:11
Duplicated block (6 lines × 2) · ×6AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift:154

+ 82 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 7 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with CaptureFixtureManifest.swift, DetailView+CommentCells.swift, DownloadClient+BackgroundDownloads.swift. — One of this dimension's main actionable groups (7 warning-level).
  2. Resolve the 7 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with DownloadsView.swift (2), 18-copy-check.py (2), DetailReducer+Download.swift. — One of this dimension's main actionable groups (7 warning-level).
  3. Resolve the 6 Members sharing a duplicated core (4 members, 50+ identical tokens) finding(s) in Code Duplication — start with LibraryCustomTitleArrowProbe.swift (3), DetailSearchReducer.swift, FrontPageReducer.swift. — One of this dimension's main actionable groups (6 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)9.2 / 10Stronggated by 3 serious findings✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 9.2 / 10 · rule-coverage 100% · ceiling Verified

3 of 44 classes have LCOM4 above 3.

Low cohesion: Array (LCOM4 11) · ×3AppPackage/Sources/AppTools/Extensions.swift:180

What to do

  1. Resolve the 3 Low cohesion finding(s) in Cohesion (LCOM4) — start with Extensions.swift, DFURLProtocol.swift, GalleryNavigation.swift. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d6_recommendation.md · top locations in Appendix A, every location in findings.md.

D7 · Architectural Integrity6.0 / 10Adequate✓ Tool-verified

What it measures: Whether the code respects its intended layering / architecture rules.

Method: Enforcement rung (Prevented/Verified/Documented) per checkable ADR via Roslyn, plus dependency cycles via the engine shared with D5/AX3. Deterministic, exact.

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Prevented

No mechanizable ADR was identified, so enforcement is not measured. Dependency cycles not checked (no project-reference graph; where this repository's language has an import-cycle lens, cycles are reported there).

Detailed fixes: d7_recommendation.md.

D10 · Test Quality8.0 / 10Strong✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 8.0 / 10 · rule-coverage 100% · ceiling Prevented

19 skipped (8 with a documented reason), 296 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 2148 tests (2 harness-style project(s) excluded from the assertion penalty). Measured on the .swift suite only — at least 38 test source file(s) (.py) went unread, so its test quality is unmeasured and is not in these counts.

No assertions: testHomeRootAudit · ×274EhPandaUITests/AccessibilityAuditUITests.swift:95
Skipped test: testPadSettingAndDetailModalsAudit · ×11EhPandaUITests/AccessibilityAuditUITests.swift:388
No direct assertions: trackingFollowsTheRowThePersonSeesFirst · ×22AppPackage/Tests/GalleryListComponentsTests/GalleryRowAnchorTrackerTests.swift:20
Skipped (documented): theUnimplementedClientReportsAnIssueWhenSendIsCalled · ×8AppPackage/Tests/AnalyticsClientTests/AnalyticsClientGateTests.swift:44

What to do

  1. Resolve the 274 No assertions finding(s) in Test Quality — start with AnalyticsEmissionTests.swift (39), AccessibilityAuditUITests.swift (20), ReaderListPositionTests.swift (13). — One of this dimension's main actionable groups (274 warning-level).
  2. Resolve the 22 No direct assertions finding(s) in Test Quality — start with AnalyticsEmissionTests.swift (8), GalleryRowAnchorTrackerTests.swift (6), GalleryScrollAnchorTests.swift (6). — One of this dimension's main actionable groups (22 recommendation-level).
  3. Resolve the 11 Skipped test finding(s) in Test Quality — start with LandscapePaneUITests.swift (4), ReadingOrientationUITests.swift (3), ReportFormUITests.swift (2). — One of this dimension's main actionable groups (11 warning-level).

Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.

D12 · Dependency Hygiene9.7 / 10Exemplary✓ Tool-verified

What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.

Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Verified

7 outdated direct SwiftPM dependencies, 0 pinning defect(s). SwiftPM has no package registry: a dependency is a repository URL and its releases are that repository's semver tags, so currency is answered by listing tags rather than by querying an index. Only a newer tag on the SAME MAJOR is reported — a `from:` requirement admits everything below the next major and nothing above it, so a major crossing needs a Package.swift edit rather than an update, and naming the update as its remedy would be wrong. Whether any dependency is DEPRECATED or ABANDONED is not graded and cannot be: a repository publishes no such marker, and there is no registry that could carry one. Known CVEs in this dependency graph are D30's question.

Outdated: kingfisher · ×5

✓ On the Gold path — maintain.

Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.

D13 · Secret Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

Secret scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 30 SwiftPM package(s) use a banned license. SwiftPM has no package registry, so each package's licence is the one its repository declares: 29 of them read from the licence file the repository carries at the revision Package.resolved pins, and 1 — unpinned, or whose licence file could not be read or named — from api.deps.dev, which reports the licence the repository declares today. Graded: every package a committed Package.resolved pins, direct and transitive, and every declared dependency none pins. 1 of them declare no licence that matches a known SPDX licence; that is missing data, not a violation, and none of them is charged.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots9.7 / 10Stronggated by 65 serious findings✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 9.7 / 10 · rule-coverage 100% · ceiling Documented

Top hotspots: AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift (75×96=7200); AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift (68×66=4488); AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift (52×61=3172) Repeated repair below the complexity floor: AppPackage/Sources/DownloadClient/DownloadClient+Manager.swift (24 of 46 changes were fixes); AppPackage/Sources/DownloadClient/DownloadClient+ContinuedSession.swift (24 of 34 changes were fixes); AppPackage/Sources/AppFeature/View/Library/LibraryView.swift (6 of 11 changes were fixes)

Hotspot: AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift · ×52AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift:98
Repeated repair: AppPackage/Sources/DownloadClient/DownloadClient+Manager.swift · ×13AppPackage/Sources/DownloadClient/DownloadClient+Manager.swift:897

What to do

  1. Resolve the 52 Hotspot finding(s) in Churn × Complexity Hotspots — start with AppReducer.swift, DownloadsReducer.swift, FavoritesReducer.swift. — One of this dimension's main actionable groups (52 warning-level).
  2. Resolve the 13 Repeated repair finding(s) in Churn × Complexity Hotspots — start with DownloadClient+Manager.swift, DownloadClient+ContinuedSession.swift, LibraryView.swift. — One of this dimension's main actionable groups (13 warning-level).

Detailed fixes: d15_recommendation.md · top locations in Appendix A, every location in findings.md.

D16 · Bus Factor1.8 / 10Critical✓ Tool-verified

What it measures: Whether knowledge is concentrated in too few people (the "bus factor").

Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.

Maturity: Documented → Verified → Prevented · effective 1.8 / 10 · rule-coverage 100% · ceiling Documented

291 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is AppPackage/Sources/DownloadClient/DownloadClient+ContinuedSession.swift. Counted over 355 of the 527 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Off-boarding risk: anonymized user #1

What to do

  1. Resolve the 1 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.

D17 · Explicit Debt10.0 / 10Exemplary○ Nothing flagged

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

0 deducted task-comment markers across 81860 LoC (0.0/KLoC) → score 10.0. Task comments only: this repository's language is read without a compiler, so D17's suppression, dead-code and commented-out-code arms did not run and this score counts fewer marker kinds than a .NET repository's would.

✓ On the Gold path — maintain.

Detailed fixes: d17_recommendation.md.

D20 · ADR Quality10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

0 of 4 evaluated ADRs have a defect readable from the log itself (a missing or empty section, no title, a single option, consequences with no cost, no status, a missing enforcement field, a status the log contradicts, a dangling link, an unlinked second decision on one question, a date that is no calendar day). How well each record argues its case is not measured.

✓ On the Gold path — maintain.

Detailed fixes: d20_recommendation.md.

D21 · Naming Consistency9.6 / 10Exemplary✓ Tool-verified

What it measures: Whether names — types, methods, variables — are clear and consistent.

Method: Seven vocabulary-free rules (N1-N7) mine each naming convention from the repository and flag a name that breaks a convention its structural peers in the same unit follow; production C# and TypeScript, each its own population. Deterministic, no model, no sample. Advisory.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Verified

2 naming inconsistencies among 449 declarations measured against a convention their peers follow.

`ipbMemberId` spells `Id` where 160 names in the project spell it `ID`AppPackage/Sources/AppTools/Defaults.swift:33
`loadUrl` spells `Url` where 287 names in the project spell it `URL`AppPackage/Sources/SettingFeature/Components/WebView.swift:83

✓ On the Gold path — maintain.

Detailed fixes: d21_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion0.0 / 10Critical✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

2 of 2 build units (SwiftPM, Xcode) flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion

What to do

  1. Resolve the 1 Projects may be oversized for their cohesion finding(s) in Project Cohesion. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability10.0 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

13 % of calls cross a namespace and 1 % go through an interface, but 100 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: small — navigation cost is tolerated.

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md.

D28 · Secrets (history)10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

gitleaks scanned the full history AND the current working tree and found no secrets.

✓ On the Gold path — maintain.

Detailed fixes: d28_recommendation.md.

D29 · Static Analysis (SAST)4.3 / 10Weak✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 4.3 / 10 · rule-coverage 100% · ceiling Documented

82 finding(s): 0 critical, 77 high, 2 medium, 3 low. 73 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 20 file(s) — `AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html`, `AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html`, `AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html`, `AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalList.html`, `AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalPlusList.html`, … (+15 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. Separately, one or more rules could not re-parse an embedded snippet in 4 file(s) (e.g. a workflow `run:` block read as shell). Those files WERE scanned and their other rows are unaffected; only those rules' view of those snippets is missing.

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED, REDACTED. — One of this dimension's main actionable groups (3 issue-level).
  2. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 issue-level).
  3. No action in Static Analysis (SAST) — all 73 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (73 issue-level, 0 of them charged here).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No known-vulnerable dependencies in any ecosystem this repository declares.

✓ On the Gold path — maintain.

Detailed fixes: d30_recommendation.md.

D34 · Knowledge Freshness10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

Every significant source file has living knowledge — recently and meaningfully worked. Counted over 355 of the 527 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

✓ On the Gold path — maintain.

Detailed fixes: d34_recommendation.md.

D35 · Change Coupling8.8 / 10Strong✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 8.8 / 10 · rule-coverage 100% · ceiling Documented

Strongest change-coupling: FrontPageView.swift↔PopularView.swift 94%; PopularView.swift↔WatchedView.swift 88%; PopularView.swift↔ToplistsView.swift 79%

Change coupling: PopularView.swift ↔ ToplistsView.swift · ×13AppPackage/Sources/HomeFeature/Popular/PopularView.swift:1
Change-coupling hub: FrontPageView.swift → FavoritesView.swift, HistoryView.swift, PopularView.swift, ToplistsView.swift, WatchedView.swift, SearchView.swift · ×7AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift
Change coupling clique: GalleryThumbnailCell.swift, GalleryCardCell.swift, GalleryRankingCell.swift, GalleryHistoryCell.swiftAppPackage/Sources/GalleryListComponents/Cells/GalleryThumbnailCell.swift

What to do

  1. Resolve the 13 Change coupling finding(s) in Change Coupling — start with HistoryView.swift (2), DetailView.swift (2), PopularView.swift. — One of this dimension's main actionable groups (13 warning-level).
  2. Resolve the 7 Change-coupling hub finding(s) in Change Coupling — start with FrontPageView.swift, WatchedView.swift, DetailSearchView.swift. — One of this dimension's main actionable groups (7 warning-level).
  3. Resolve the 1 Change coupling clique finding(s) in Change Coupling — start with GalleryThumbnailCell.swift. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.

D36 · Supply-chain Provenance & Signing2.5 / 10Weak✓ Tool-verified

What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.

Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.

Maturity: Documented → Verified → Prevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

1/4 supply-chain integrity signals present (provenance, signing, SBOM, pinned actions).

REDACTED
REDACTED
REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).
  2. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 REDACTED finding(s) in Supply-chain Provenance & Signing. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d36_recommendation.md · top locations in Appendix A, every location in findings.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AC1 · Text alternatives7.6 / 10Strong✓ Tool-verified

Other · Accessibility — Whether non-text content carries a text alternative — img/area/input[type=image] have alt, a meaningful svg has a title or aria-label, video has a captions track, and object/embed/canvas have a name or fallback content. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: every img/area/input[type=image] checked for alt, svg[role=img] for a title/aria-label, video for a captions <track>. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: image/media elements — img, area, input[type=image], svg, video, object, embed, canvas — across the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and dynamic-attribute elements are skipped. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is NOT read by any producer, so it contributes no element to this population; where such a frontend is present the card discloses it as an analyzer gap rather than scoring around it.

  • An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative. (×13) — AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36, AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:28, AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:29, …

What to do

  • Add a text alternative — alt on images (alt="" for purely decorative ones), a title or aria-label on meaningful svg, an aria-label or inner fallback content on canvas, and a captions <track> on video.
AC2 · Forms & labels7.7 / 10Strong✓ Tool-verified

Other · Accessibility — Whether form controls have a programmatic label (an associated label, aria-label or aria-labelledby), buttons have text, links have an accessible name, a click handler on a plain element names the control it declares, fieldsets have a non-empty legend, known UI-library field components carry a label prop, and a placeholder isn't used as the only label. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: inputs/selects/textareas checked for an associated label[for]/wrapping label/aria-label/aria-labelledby (per document), buttons for accessible text, fieldsets for a legend; placeholder-only labelling flagged. Deterministic, hard fact per control.

Coverage: Population: form controls, buttons, links, fieldsets and known UI-library field components in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx); components, hidden subtrees and spread/dynamic-attribute elements are skipped, so a control whose label arrives through a spread or a runtime expression is deliberately not judged. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • This <area> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label. — AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36
  • This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label. (×11) — AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36, AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:166, AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:166, …
  • This <img> carries a click handler, which makes it a control, and its only name is a title attribute. A plain element maps to role="generic", which does not support a name from the author, so the title is announced as nothing at all — it is a mouse-only tooltip, unreachable on touch. Give it role="button" (which it needs anyway to be operable) so the title becomes a real name, or add an aria-label. (×7) — AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:28, AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:29, AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:30, …
  • This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it. (×21) — AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:185, AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:187, AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:190, …

What to do

  • Give every control a programmatic label (a <label for> / wrapping <label> / aria-label) and every button text — a placeholder is not a label.
AC3 · Page structure5.5 / 10Adequate✓ Tool-verified

Other · Accessibility — Whether pages declare a language (well-formed BCP-47) and a non-empty title, expose exactly one main landmark and a sane heading order with non-empty headings, keep zoom enabled, title their iframes, give data tables header cells, and avoid meta-refresh. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: html lang, document <title>, a main landmark and heading order on full documents only, plus zoom-disabling viewports, untitled iframes and meta-refresh anywhere. Deterministic, per structural checkpoint.

Coverage: Population: the PARSED MARKUP documents (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx). The page-level checks — lang, title, single main landmark — fire ONCE PER FULL DOCUMENT (an <html> root) and never on a partial or component fragment, so a repo of fragments is assessed only on the per-element checks (heading order, table headers, iframe titles, meta-refresh, zoom). Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

  • No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>. (×24) — .planning/quick/261015-duo-session-record/evidence/library-title-matrix/index.html:2, .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/index.html:2, AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:2, …
  • An empty heading appears in the document outline announced with no text. Give the heading text, or remove it if it's decorative. — .planning/quick/261015-duo-session-record/proposal/index.html:21
  • A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope). (×15) — AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36, AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:188, AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageCompactList.html:23, …

What to do

  • Declare <html lang>, a document <title> and a <main> landmark, keep headings in order, leave zoom enabled, title iframes and drop meta-refresh.
AC4 · Keyboard semantics1.0 / 10Critical✓ Tool-verified

Other · Accessibility — Whether interactive behaviour is keyboard-reachable — no click handler on a non-interactive element lacking a role, tabindex and key handler, no element the repo's own CSS styles `cursor: pointer` without giving it any of the three, no unfocusable element whose only binding is a mouse enter/leave pair or a double-click, no positive tabindex, no href-less anchor, no placeholder-href (#/javascript) link acting as a button. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: click handlers on non-interactive elements lacking role+tabindex+key handler, positive tabindex values, and href-less anchors. Components skipped, spreads suppressed. Deterministic, hard fact per element.

Coverage: Population: elements that pose a keyboard-semantics question, in the PARSED MARKUP files only (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) — a non-natively-interactive element carrying a click handler, a double-click or hover enter/leave binding, a pointer-only gesture on a tabindex="0" element, or `cursor: pointer` from the repo's own CSS; an href-less or placeholder-href (#, javascript:) anchor; and any element with a positive tabindex. Natively interactive elements used correctly (<button>, <a href>, form controls) are NOT in the population — there is nothing to judge — so a page of nothing but correct controls gives AC4 nothing to measure. Keyboard reachability is judged from the markup, never from a rendered page. ★ An interactive element declared in a tagged-template (html`…`) or hyperscript frontend is NOT in this population — no producer reads either — so an empty population is reported as an analyzer gap, never as "this repository has no interactive elements".

  • A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler. (×37) — AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36, AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36, AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36, …
  • An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action. (×2) — AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36, REDACTED:14
  • This <td> binds mouse-enter and mouse-leave and nothing else — no click, no key handler, no focus handler, and no tabindex="0", so it cannot even take focus. A keyboard user cannot hover, so whatever the pair reveals or highlights is reachable with a mouse only. Bind the same state to focus/blur as well, and add tabindex="0"="0" so the element can receive that focus. — AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:188

What to do

  • Make custom controls keyboard-operable (role + tabindex + key handler), drop positive tabindex, and give anchors a real href.
AC5 · ARIA correctness10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether ARIA is used correctly — valid non-abstract roles, the ARIA state a role requires, valid (non-misspelled) aria-* attribute names, in-enum values for token-typed aria-* attributes, and no aria-hidden on (or wrapping) a focusable element. Static markup readiness, not a WCAG conformance claim.

Method: Static markup-model scan: role values checked against the WAI-ARIA role set (abstract/invalid flagged), required ARIA state for a role, and aria-hidden on a focusable element. Deterministic, role/attribute level.

Coverage: Population: elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx) that carry a role or an aria-* attribute; roles and token values are checked against the ARIA enums exhaustively within that set. An expression-valued (dynamic) role or aria-* value is skipped rather than guessed, and markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AC6 · Visual & motion safety10.0 / 10Exemplary○ Nothing flagged

Other · Accessibility — Whether focus outlines aren't removed without a replacement, motion respects prefers-reduced-motion, and literal CSS colour pairs meet contrast — PARTIAL: inline styles, in-repo <style> blocks, in-repo .css files, var() tokens, Tailwind neutral utilities and CSS-in-JS literals are read (hex/rgb/hsl/named), never computed/runtime/external-CDN colour. Static markup readiness, not a WCAG conformance claim.

Method: Static markup/CSS scan: inline outline:none/0, literal inline colour/background contrast against the 4.5:1 AA floor, and <style>-block animation without a prefers-reduced-motion guard. Deterministic but PARTIAL — only inline styles and in-repo CSS literals are visible.

Coverage: Population: styled elements in the PARSED MARKUP files (.html/.htm/.cshtml/.razor/.vue/.svelte/.jsx/.tsx), plus in-repo <style> blocks, in-repo .css files and CSS-in-JS literals. Colour contrast is computed from LITERAL colour pairs only (hex/rgb/hsl/named, including var() tokens and Tailwind neutral utilities) — computed, runtime-themed and external-CDN colour is never resolved, so this is a partial read of contrast by construction. Markup built in script — tagged-template (html`…`) UIs and hyperscript DOM factories — is not read at all.

AX10 · Code composition10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does. On this repository the split was taken from the source tree on disk rather than from a loaded .NET workspace, so a file's role is decided by its PATH segments alone — no declared namespace was available to add to the evidence — and generated output is excluded from the census entirely rather than counted as a generated share.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.

Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.

AX9 · CQS / query purity10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether read (query) handlers stay side-effect-free — a query that writes persistent state or raises events breaks CQS and makes reads unsafe to retry, cache, or route to a read replica.

Method: Roslyn scan: CQRS handlers classified query-vs-command by interface (IQueryHandler/ICommandHandler/IRequestHandler<TQuery,TResult>) and name convention (*Query/Get*/Find* vs *Command); each query handler's body checked for persistent-state writes (SaveChanges/repository Add-Update) or event publishes by resolved invocation. Deterministic, type-level, exhaustive over the detected handlers.

Coverage: Population: CQRS handlers identified by IQueryHandler/ICommandHandler/IRequestHandler interface + *Query/Get*/Find*/*Command NAME convention; query purity then checked exhaustively within that set — a query handler using neither convention is invisible, and mutation is a resolved persistence/publish CALL, not full dataflow.

M1 · Documentation (README)6.7 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
M2 · Architecture documentation10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.

Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.

P1 · CI/CD gates10.0 / 10Exemplary○ Nothing flagged

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

P2 · Observability5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.

Method: Filesystem/Roslyn scan: structured-logging frameworks (Serilog, NLog), OpenTelemetry, and health-check endpoint patterns. Exhaustive, deterministic.

  • Only 1/3 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `.`, `.`.

What to do

  • Extend structured logging to the remaining runnable modules so everything you run is diagnosable in production.
P3 · Security & performance tooling3.0 / 10Weak✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add CodeQL's Swift pack (Swift/Xcode) (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 10 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner. — REDACTED:6

What to do

  • Add a SAST step to CI running what this repository's stack ships: CodeQL's Swift pack (Swift/Xcode) — or `semgrep --config=auto`, which runs on any language — so a security regression fails the build instead of landing.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P4 · Deployment & Rollback7.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.

Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.

P6 · Release Hygiene8.0 / 10Strong✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

  • The changelog this check read carries 1 versioned entry, against a bar of 3. Counted as either the distinct `x.y.z` versions it names (a link's target is not counted) or its version-shaped section headings (`## [1.2.0]`, `## V14.x.x`, `## Updates in 8.0.x`), whichever is the larger — so a log sectioned by minor series counts its sections, not its individual patch numbers. Entries recorded somewhere this check does not read — release notes generated at tag time from a generator config it did not recognise, or a log kept outside the repository — are not counted here, and this row is about what is re-findable in the tree rather than about how often you release.

What to do

  • Keep the changelog current — add a versioned entry (Keep-a-Changelog ## [x.y.z]) for each release so the history isn't a stub.
PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

S1 · Web-Security Posture8.0 / 10Strong✓ Tool-verified

Other · Security — Only what this repository's own non-C# files could be read for was assessed — markup this repository SHIPS is scored for third-party script integrity whether or not the repository serves it itself, since a page handed to a consumer runs in that consumer’s origin. Nothing else in this dimension was assessed: the transport, cookie, input-validation and crypto controls are read from a source model that was not loaded for this repository’s language, so their absence here is not a finding about this repository.

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • `https://e-hentai.org/z/0377/ehg_gallery.c.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. The URL also names no version, so it resolves to whatever that origin serves at fetch time — the executed bytes can change with nobody touching this repository. 33 such include(s) across the repository's markup. — AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:35

What to do

  • Pin third-party scripts and verify them: name an exact version in the URL and add an `integrity="sha384-…"` hash alongside `crossorigin="anonymous"` (both are required — an integrity hash on a cross-origin script without `crossorigin` is not evaluated, it blocks the script). Where the vendor ships a continuously-updated loader and publishes no stable hash (tag managers, analytics, chat widgets), Subresource Integrity is not available: constrain it instead with a `Content-Security-Policy` that names the exact origins allowed to execute, and drop the script from the pages that do not need it. Where the page is shipped inside a package that others host, prefer vendoring the asset and serving it from the app’s own origin, so no consumer inherits a third-party dependency they did not choose.
X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X3 · Exception handling6.2 / 10Adequate✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter. (×19) — AppPackage/Sources/VisualSnapshotSupport/HostedWindowCapture.swift:384, AppPackage/Sources/VisualSnapshotSupport/SnapshotResultWriter.swift:148, AppPackage/Sources/ReadingFeature/ReadingView.swift:475, …

What to do

  • Swallowed exception (caught, then discarded)

WCAG coverage — what static analysis assessed

Statically assessed 15 of 55 WCAG 2.2 Level A/AA success criteria (27%; ≈30% of the 50 WCAG 2.1 AA criteria for EN 301 549). The other 40 require runtime or manual evaluation. Partial signal only (a clean result is necessary, not sufficient; static analysis fully verifies none). This is accessibility readiness, not a conformance claim — a WCAG conformance claim requires manual evaluation (WCAG-EM 1.0).

DimensionWCAG 2.2 A/AA criteriaCoverage
AC1 · Text alternatives1.1.1, 1.2.2, 1.2.5Partial signal
AC2 · Forms & labels1.3.1, 3.3.2, 4.1.2Partial signal
AC3 · Page structure1.4.4, 2.2.1, 2.4.1, 2.4.2, 3.1.1, 4.1.2Partial signal
AC4 · Keyboard semantics2.1.1, 2.4.3Partial signal
AC5 · ARIA correctness4.1.2Partial signal
AC6 · Visual & motion safety1.4.3, 2.4.7Partial — literal CSS only

Not statically assessed — these 40 Level A/AA criteria need runtime or manual evaluation (WCAG-EM): 1.2.1, 1.2.3, 1.2.4, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.4.1, 1.4.2, 1.4.5, 1.4.10, 1.4.11, 1.4.12, 1.4.13, 2.1.2, 2.1.4, 2.2.2, 2.3.1, 2.4.4, 2.4.5, 2.4.6, 2.4.11, 2.5.1, 2.5.2, 2.5.3, 2.5.4, 2.5.7, 2.5.8, 3.1.2, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.6, 3.3.1, 3.3.3, 3.3.4, 3.3.7, 3.3.8, 4.1.3.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health74%StrongSolid.
Architecture87%Adequate — gated by D26Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Maturity82%Adequate — gated by D16Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness61%Adequate — gated by P3Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security66%Adequate — gated by D36Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Accessibility55%Adequate — gated by AC4Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance100%ExemplaryStrongest area.
Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • X10 Duplicated predicate — 9 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X7 Silent fallback defaults — 3 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 2 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Not assessed: these audit controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks audit controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 63 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AX1 Captive dependencies — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX2 Stateful singletons — No container singleton was found, so there is no shared instance for concurrent requests to race on. No function in this Python code is served by a threaded web framework (a Flask, Bottle or FastAPI route, a Django or Pyramid view), so no module is shared between request threads. No Swift request handler (a Vapor, Hummingbird, Kitura, Swifter or Perfect route handler, as a method or a registered closure) is declared, so no state is shared between request threads.
  • AX5 Architecture & structure — not assessed — architecture style/structure is computed from a project graph (projects, types, module namespaces) that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX6 Interface segregation — not assessed — interface segregation is computed over a type surface that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AXB1 Runtime evidence locked — no reproducible boot — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C1 Data Protection — Not assessed: these personal data controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks personal data controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C2 Access Controls — Not assessed: these authorization controls are read from a source model (declarative annotations, request middleware, entity/column names, guard methods) that was not loaded for this repository — because the repository is written in a language this check does not yet model, or because its projects failed to load. Absence of an idiom this check recognises is NOT evidence that this repository lacks authorization controls: it may implement them entirely in its own ecosystem. This is a gap in the analyzer's language coverage, not a finding about this repository.
  • C4 Data Retention — No personal data detected in a persisted data model — no PII-named property (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a SwiftData @Model, a Core Data, Realm, GRDB or Fluent type, a GRDB or SQLite.swift column, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (CoreData, SwiftData, GRDB, RealmSwift, SQLite, Firebase, …) imported either, so this repository keeps no personal data whose lifetime a retention limit would bound.
  • C5 Data-Subject Rights — No personal data detected in a persisted data model — no PII-named property (email, firstName, dateOfBirth, phoneNumber, …) or stored credential on a SwiftData @Model, a Core Data, Realm, GRDB or Fluent type, a GRDB or SQLite.swift column, or in a SQL CREATE TABLE or ALTER TABLE — and no database or data-store client (CoreData, SwiftData, GRDB, RealmSwift, SQLite, Firebase, …) imported either, so this repository keeps no personal data for a data subject to erase, export or consent over.
  • D11 Test Reliability — Test reliability not included — the .swift suite was found but not re-run
  • D18 Solution Shape — D18 scores the shape of a .NET solution; this repository has no .NET solution or project files, so the dimension does not apply.
  • D19 Documentation Quality — No runnable or published unit to look for an example in, and no multi-project root README to look for a map in; the other documentation kinds are withheld (see the gaps), so documentation quality is not applicable here.
  • D22 Internal API Consistency — The exposed public-API surface could not be collected — no C#/VB projects loaded.
  • D23 Boundary Type-Coupling — No bounded-context organisation was detected either — neither a context-shaped layout, nor 2+ sibling source directories each declaring an aggregate root, nor 2+ sibling projects each declaring an entity of their own or taking another project's integration events. Declaring this codebase's bounded contexts (≥2) would let cross-boundary type coupling be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
  • D24 Comment Value — D24 reads C#, Visual Basic, TypeScript and JavaScript comments only — this repository's production source is .py, .swift, which was left unread. Not scored: this is a gap in the analyzer, not a verdict about this repository.
  • D25 ADR Conformance — None of 1 binding record(s) states a rule in checkable form (a backticked element with a prohibition, or an `adr-rules` block), so conformance cannot be read from the code. Write the rule as an `adr-rules` block (`forbid:` a symbol, a package or a dependency) to make it checkable.
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 108 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D44 Platform End-of-Life — Platform end-of-life not assessed — this repository declares no platform this pass reads
  • D5 Coupling — Not applicable — this Xcode build ships 1 production module(s), so there is no coupling BETWEEN modules to measure. (Its test and non-production modules are not part of the shipped graph.)
  • D8 Code Coverage — Coverage not measured — Swift suite
  • DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (2 value object(s))
  • ED2 Event/command shape — not scored — deciding whether a command has more than one competing handler requires resolving the call graph, and this analysis resolves a call's owner only where the receiver's type is written down in the source. Reported as guidance rather than measured
  • ED5 Idempotency — no mutating command handlers or message consumers detected — idempotency check not applicable
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • GD1 Unfinished & placeholder code — no source files were read — this check reads C#, F#, JavaScript/TypeScript, Dart, Ruby and Scala, and none was read for this repository's product. That is a limit of the analyzer, not a finding about your code.
  • IC1 Incompleteness & stubs — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
  • P7 Outbound HTTP resilience — not applicable — no HTTP server, API framework or worker entry point was found in the Python, Swift source, so there is no service whose uptime a failing dependency could take down
  • P8 Schema migrations — no ORM, schema-migration tool or schema auto-create was found in this repository's dependency manifests or source, so there is no database schema for this check to judge
  • P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found. This check searched for `Benchmark("…")` in a file importing package-benchmark, or package-benchmark in Package.swift, and for a `*benchmark*` script that this repository's CI runs. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • X1 Async correctness — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X12 Unreachable branch — X12 reached only 9% of this repository's production lines — swift (74,878 lines), objectivec (80 lines), c (5 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X16 Unfloored truncation loop — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X18 Disposal-pattern correctness — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X2 Cancellation propagation — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X20 Mistyped argument guard — This check asks whether an argument guard reports an EMPTY value as a NULL one, which needs a language that throws a null-specific argument exception — .NET's ArgumentNullException, the JVM's NullPointerException, Dart's ArgumentError.notNull. This repository contains none of those languages: the ones it is written in have a single exception for a bad argument, so there is no pair of exceptions to confuse and nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X21 Side-effecting pattern guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X23 Unguarded diagnostic materialisation — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X24 Document value interpolated into markup unescaped — X24 reached only 9% of this repository's production lines — swift (74,878 lines), objectivec (80 lines), c (5 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X25 Inert configuration knob — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X27 Collection changed while being enumerated — X27 reached only 8% of this repository's production lines — swift (74,878 lines), javascript (779 lines), objectivec (80 lines), c (5 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X29 Per-element action decided by a fixed element — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X30 Support guard that admits what it rejects — X30 reached only 9% of this repository's production lines — swift (74,878 lines), objectivec (80 lines), c (5 lines) was left unread. Not scored: a score over a minority of the product would be published as the whole of it.
  • X32 Type resolved by simple name across every loaded assembly — This check is about how a .NET program searches the assemblies loaded into its process for a type, and this repository contains no .NET source, so there is nothing here for it to assess. Not a gap in the analyzer and not a finding about your code.
  • X4 Structured logging — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X5 Nullable reference types — not analysed — these correctness checks read a source model that was not loaded for this repository, because the repository is written in a language this check does not yet model, or because its projects failed to load. This is a gap in the analyzer, not a finding about this repository
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 168 finding(s)
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 48 more in this group — see findings.md.
AC4 · Keyboard semantics · Click handler on a non-interactive <div> · ×28
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:41 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:97 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:103 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:109 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:115 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:121 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:127 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:133 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:139 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:145 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:151 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:158 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:188 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:97 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:103 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:109 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:115 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:121 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:127 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:133 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:139 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:145 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:151 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <div> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:158 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • + 3 more in this group — see findings.md.
AC2 · Forms & labels · <select> without a programmatic label · ×21
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:185 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:187 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:190 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:185 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:187 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:190 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalList.html:185 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalList.html:187 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalList.html:190 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalPlusList.html:185 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalPlusList.html:187 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalPlusList.html:190 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesThumbnailList.html:185 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesThumbnailList.html:187 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesThumbnailList.html:190 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageCompactList.html:45 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageExtendedList.html:45 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageMinimalList.html:45 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageMinimalPlusList.html:45 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageThumbnailList.html:48 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
  • <select> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/PopularCompactList.html:45 — This control has no associated label. Add a <label for> / wrapping <label> / aria-label / aria-labelledby so assistive tech can name it.
AC1 · Text alternatives · <img> without a text alternative · ×13
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:28 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:29 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:30 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:31 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:32 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:33 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:34 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative REDACTED:14 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Other/GalleryDetailWithGreeting.html:36 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Other/ReportChild.html:36 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Other/ReportOther.html:36 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
  • <img> without a text alternative AppPackage/Sources/TestingSupport/Resources/Parser/Other/ReportSelect.html:37 — An image with no alt (and no aria-label/aria-labelledby) is unreadable to assistive tech. Add alt — alt="" if it's purely decorative.
AC2 · Forms & labels · <input> without a programmatic label · ×11
  • <input> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:166 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:166 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalList.html:166 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalPlusList.html:166 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesThumbnailList.html:166 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageCompactList.html:23 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageExtendedList.html:23 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageMinimalList.html:23 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageMinimalPlusList.html:23 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
  • <input> without a programmatic label AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageThumbnailList.html:26 — This control has only a placeholder — a placeholder is not a label (it vanishes on input and many AT ignore it). Add a <label for>, a wrapping <label>, or aria-label.
AC2 · Forms & labels · Custom control named only by title on <img> · ×7
  • Custom control named only by title on <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:28 — This <img> carries a click handler, which makes it a control, and its only name is a title attribute. A plain element maps to role="generic", which does not support a name from the author, so the title is announced as nothing at all — it is a mouse-only tooltip, unreachable on touch. Give it role="button" (which it needs anyway to be operable) so the title becomes a real name, or add an aria-label.
  • Custom control named only by title on <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:29 — This <img> carries a click handler, which makes it a control, and its only name is a title attribute. A plain element maps to role="generic", which does not support a name from the author, so the title is announced as nothing at all — it is a mouse-only tooltip, unreachable on touch. Give it role="button" (which it needs anyway to be operable) so the title becomes a real name, or add an aria-label.
  • Custom control named only by title on <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:30 — This <img> carries a click handler, which makes it a control, and its only name is a title attribute. A plain element maps to role="generic", which does not support a name from the author, so the title is announced as nothing at all — it is a mouse-only tooltip, unreachable on touch. Give it role="button" (which it needs anyway to be operable) so the title becomes a real name, or add an aria-label.
  • Custom control named only by title on <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:31 — This <img> carries a click handler, which makes it a control, and its only name is a title attribute. A plain element maps to role="generic", which does not support a name from the author, so the title is announced as nothing at all — it is a mouse-only tooltip, unreachable on touch. Give it role="button" (which it needs anyway to be operable) so the title becomes a real name, or add an aria-label.
  • Custom control named only by title on <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:32 — This <img> carries a click handler, which makes it a control, and its only name is a title attribute. A plain element maps to role="generic", which does not support a name from the author, so the title is announced as nothing at all — it is a mouse-only tooltip, unreachable on touch. Give it role="button" (which it needs anyway to be operable) so the title becomes a real name, or add an aria-label.
  • Custom control named only by title on <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:33 — This <img> carries a click handler, which makes it a control, and its only name is a title attribute. A plain element maps to role="generic", which does not support a name from the author, so the title is announced as nothing at all — it is a mouse-only tooltip, unreachable on touch. Give it role="button" (which it needs anyway to be operable) so the title becomes a real name, or add an aria-label.
  • Custom control named only by title on <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:34 — This <img> carries a click handler, which makes it a control, and its only name is a title attribute. A plain element maps to role="generic", which does not support a name from the author, so the title is announced as nothing at all — it is a mouse-only tooltip, unreachable on touch. Give it role="button" (which it needs anyway to be operable) so the title becomes a real name, or add an aria-label.
AC4 · Keyboard semantics · Click handler on a non-interactive <img> · ×7
  • Click handler on a non-interactive <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:28 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:29 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:30 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:31 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:32 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:33 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
  • Click handler on a non-interactive <img> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:34 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
AC2 · Forms & labels · Custom control with no accessible name on <area> · ×1
  • Custom control with no accessible name on <area> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36 — This <area> carries a click handler, which makes it a control, but it has no text, aria-label or labelled child (the icon-only case), so assistive tech has no name to announce for it. Note that switching it to <button type="button"> — the right fix for its keyboard operability — does not give it a name either: an icon-only button still needs one. Add visible text or an aria-label.
AC4 · Keyboard semantics · Click handler on a non-interactive <area> · ×1
  • Click handler on a non-interactive <area> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
AC4 · Keyboard semantics · Click handler on a non-interactive <td> · ×1
  • Click handler on a non-interactive <td> AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36 — A click handler on a plain element isn't keyboard-operable. Use a <button>, or add role + tabindex="0" + a key handler.
AC4 · Keyboard semantics · Hover-only interaction on <td> · ×1
  • Hover-only interaction on <td> AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:188 — This <td> binds mouse-enter and mouse-leave and nothing else — no click, no key handler, no focus handler, and no tabindex="0", so it cannot even take focus. A keyboard user cannot hover, so whatever the pair reveals or highlights is reachable with a mouse only. Bind the same state to focus/blur as well, and add tabindex="0"="0" so the element can receive that focus.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
Serious — 772 finding(s)
D10 · Test Quality · No assertions · ×274
  • No assertions: testHomeRootAudit EhPandaUITests/AccessibilityAuditUITests.swift:95 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testSearchRootAudit EhPandaUITests/AccessibilityAuditUITests.swift:108 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testDownloadsEmptyStateAudit EhPandaUITests/AccessibilityAuditUITests.swift:127 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testSettingRootAudit EhPandaUITests/AccessibilityAuditUITests.swift:145 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testFrontPageAudit EhPandaUITests/AccessibilityAuditUITests.swift:153 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testPopularAudit EhPandaUITests/AccessibilityAuditUITests.swift:159 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testFiltersSheetAudit EhPandaUITests/AccessibilityAuditUITests.swift:184 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testDateSeekSheetAudit EhPandaUITests/AccessibilityAuditUITests.swift:192 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testQuickSearchSheetAudit EhPandaUITests/AccessibilityAuditUITests.swift:201 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testAccountSettingAudit EhPandaUITests/AccessibilityAuditUITests.swift:213 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testGeneralSettingAudit EhPandaUITests/AccessibilityAuditUITests.swift:219 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testAppearanceSettingAudit EhPandaUITests/AccessibilityAuditUITests.swift:238 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testReadingSettingAudit EhPandaUITests/AccessibilityAuditUITests.swift:244 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testDownloadSettingAudit EhPandaUITests/AccessibilityAuditUITests.swift:250 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testLaboratorySettingAudit EhPandaUITests/AccessibilityAuditUITests.swift:256 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testAboutAudit EhPandaUITests/AccessibilityAuditUITests.swift:263 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testGalleryDetailAudit EhPandaUITests/AccessibilityAuditUITests.swift:271 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testPreviewsAudit EhPandaUITests/AccessibilityAuditUITests.swift:277 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testReadingPageAudit EhPandaUITests/AccessibilityAuditUITests.swift:342 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testReadingControlPanelAudit EhPandaUITests/AccessibilityAuditUITests.swift:348 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testEnglishTitle EhPandaUITests/BlockedUsersTitleLayoutUITests.swift:21 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testGermanTitle EhPandaUITests/BlockedUsersTitleLayoutUITests.swift:25 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testKoreanTitle EhPandaUITests/BlockedUsersTitleLayoutUITests.swift:29 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testJapaneseTitle EhPandaUITests/BlockedUsersTitleLayoutUITests.swift:33 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • No assertions: testSimplifiedChineseTitle EhPandaUITests/BlockedUsersTitleLayoutUITests.swift:37 — This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
  • + 249 more in this group — see findings.md.
D15 · Churn × Complexity Hotspots · Hotspot · ×52
  • Hotspot: AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift:98 — AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift changed 75 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 96 in AppReducer.body at line 98. 5 of those changes were fix/bug commits, and the other 70 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:172 — AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift changed 68 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 66 in DownloadsReducer.body at line 172. 3 of those changes were fix/bug commits, and the other 65 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:130 — AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift changed 52 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 61 in FavoritesReducer.body at line 130. 2 of those changes were fix/bug commits, and the other 50 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/DetailFeature/DetailReducer+Download.swift AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:16 — AppPackage/Sources/DetailFeature/DetailReducer+Download.swift changed 42 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 63 in DetailReducer.downloadReducer at line 16. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DetailFeature/DetailReducer+Download.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/SettingFeature/SettingReducer+Body.swift AppPackage/Sources/SettingFeature/SettingReducer+Body.swift:16 — AppPackage/Sources/SettingFeature/SettingReducer+Body.swift changed 43 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 55 in SettingReducer.reducerBody at line 16. 2 of those changes were fix/bug commits, and the other 41 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/SettingFeature/SettingReducer+Body.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/HomeFeature/HomeReducer+Body.swift AppPackage/Sources/HomeFeature/HomeReducer+Body.swift:13 — AppPackage/Sources/HomeFeature/HomeReducer+Body.swift changed 38 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 62 in HomeReducer.reducerBody at line 13. 2 of those changes were fix/bug commits, and the other 36 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/HomeFeature/HomeReducer+Body.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift:105 — AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift changed 48 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 44 in CommentsReducer.body at line 105. 1 of those changes was a fix/bug commit, and the other 47 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:85 — AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift changed 43 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 43 in WatchedReducer.body at line 85. 1 of those changes was a fix/bug commit, and the other 42 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/SearchFeature/SearchReducer.swift AppPackage/Sources/SearchFeature/SearchReducer.swift:86 — AppPackage/Sources/SearchFeature/SearchReducer.swift changed 44 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 39 in SearchReducer.body at line 86. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/SearchFeature/SearchReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/AppFeature/DataFlow/PresentationFeature.swift AppPackage/Sources/AppFeature/DataFlow/PresentationFeature.swift:76 — AppPackage/Sources/AppFeature/DataFlow/PresentationFeature.swift changed 47 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 36 in PresentationFeature.body at line 76. 4 of those changes were fix/bug commits, and the other 43 changed it for other reasons — this file is under both repair and feature pressure. Before the next change lands here, make sure the area it touches is under test, then split that area out of the file so the following change is smaller than this one — a file this often edited pays the complexity back every time. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/AppFeature/DataFlow/PresentationFeature.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift:12 — AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift changed 21 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 77 in ReadingReducer.imageFetchReducer at line 12. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift:76 — AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift changed 34 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 46 in DownloadInspectorReducer.body at line 76. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/ReadingFeature/ReadingReducer+Body.swift AppPackage/Sources/ReadingFeature/ReadingReducer+Body.swift:63 — AppPackage/Sources/ReadingFeature/ReadingReducer+Body.swift changed 38 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 38 in ReadingReducer.lifecycleReducer at line 63. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/ReadingFeature/ReadingReducer+Body.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:77 — AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift changed 42 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 31 in FrontPageReducer.body at line 77. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/DetailFeature/DetailView.swift AppPackage/Sources/DetailFeature/DetailView.swift:71 — AppPackage/Sources/DetailFeature/DetailView.swift changed 79 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 16 in DetailView.content at line 71. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DetailFeature/DetailView.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/HomeFeature/Toplists/ToplistsReducer.swift AppPackage/Sources/HomeFeature/Toplists/ToplistsReducer.swift:91 — AppPackage/Sources/HomeFeature/Toplists/ToplistsReducer.swift changed 38 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 32 in ToplistsReducer.body at line 91. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/HomeFeature/Toplists/ToplistsReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/SearchFeature/SearchRootReducer.swift AppPackage/Sources/SearchFeature/SearchRootReducer.swift:105 — AppPackage/Sources/SearchFeature/SearchRootReducer.swift changed 41 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 29 in SearchRootReducer.body at line 105. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/SearchFeature/SearchRootReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift:83 — AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift changed 39 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 30 in PreviewsReducer.body at line 83. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/HomeFeature/History/HistoryReducer.swift AppPackage/Sources/HomeFeature/History/HistoryReducer.swift:81 — AppPackage/Sources/HomeFeature/History/HistoryReducer.swift changed 34 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 29 in HistoryReducer.body at line 81. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/HomeFeature/History/HistoryReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:74 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift changed 33 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 29 in DetailSearchReducer.body at line 74. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift:170 — AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift changed 17 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 56 in FullContentHost.capture at line 170. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift:115 — AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift changed 33 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 27 in DetailReducer.galleryOpsReducer at line 115. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/ParserFeature/Parser+Profile.swift AppPackage/Sources/ParserFeature/Parser+Profile.swift:24 — AppPackage/Sources/ParserFeature/Parser+Profile.swift changed 9 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 92 in Parser.parseEhSetting at line 24. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/ParserFeature/Parser+Profile.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/DetailFeature/Archives/ArchivesReducer.swift AppPackage/Sources/DetailFeature/Archives/ArchivesReducer.swift:48 — AppPackage/Sources/DetailFeature/Archives/ArchivesReducer.swift changed 30 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 27 in ArchivesReducer.body at line 48. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DetailFeature/Archives/ArchivesReducer.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Hotspot: AppPackage/Sources/NetworkingFeature/Request+Account.swift AppPackage/Sources/NetworkingFeature/Request+Account.swift:331 — AppPackage/Sources/NetworkingFeature/Request+Account.swift changed 40 times in last 90 days, and the most complex body those changes touched has cyclomatic complexity 18 in SubmitEhSettingChangesRequest.response at line 331. Frequent change and high complexity in one file compound: schedule the next change to it to include carving out the part being edited, with the area under test before it moves. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/NetworkingFeature/Request+Account.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • + 27 more in this group — see findings.md.
D3 · God Classes · MethodTooLong · ×25
  • MethodTooLong: ReadingReducer.imageFetchReducer AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift:12 — MethodTooLong — imageFetchReducer runs 277 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 177 over it, 2.77× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BrowsingCountry.englishName AppPackage/Sources/AppModels/Support/BrowsingCountry+EnglishName.swift:2 — MethodTooLong — englishName runs 253 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 153 over it, 2.53× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: BrowsingCountry.name AppPackage/Sources/AppModels/Support/BrowsingCountry.swift:16 — MethodTooLong — name runs 253 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 153 over it, 2.53× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AppReducer.body AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift:98 — MethodTooLong — body runs 244 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 144 over it, 2.44× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DetailReducer.downloadReducer AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:16 — MethodTooLong — downloadReducer runs 242 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 142 over it, 2.42× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: HomeReducer.reducerBody AppPackage/Sources/HomeFeature/HomeReducer+Body.swift:13 — MethodTooLong — reducerBody runs 211 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 111 over it, 2.11× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: FavoritesReducer.body AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:130 — MethodTooLong — body runs 203 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 103 over it, 2.03× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DownloadsReducer.body AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:172 — MethodTooLong — body runs 202 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 102 over it, 2.02× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SettingReducer.reducerBody AppPackage/Sources/SettingFeature/SettingReducer+Body.swift:16 — MethodTooLong — reducerBody runs 170 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 70 over it, 1.70× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SearchReducer.body AppPackage/Sources/SearchFeature/SearchReducer.swift:86 — MethodTooLong — body runs 158 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 58 over it, 1.58× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: WatchedReducer.body AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:85 — MethodTooLong — body runs 157 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 57 over it, 1.57× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: CommentsReducer.body AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift:105 — MethodTooLong — body runs 156 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 56 over it, 1.56× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DownloadInspectorReducer.body AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift:76 — MethodTooLong — body runs 136 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 36 over it, 1.36× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: Parser.parseEhSetting AppPackage/Sources/ParserFeature/Parser+Profile.swift:24 — MethodTooLong — parseEhSetting runs 128 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 28 over it, 1.28× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ReadingReducer.lifecycleReducer AppPackage/Sources/ReadingFeature/ReadingReducer+Body.swift:63 — MethodTooLong — lifecycleReducer runs 126 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 26 over it, 1.26× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PresentationFeature.body AppPackage/Sources/AppFeature/DataFlow/PresentationFeature.swift:76 — MethodTooLong — body runs 124 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 24 over it, 1.24× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: FrontPageReducer.body AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:77 — MethodTooLong — body runs 118 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 18 over it, 1.18× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DetailReducer.galleryOpsReducer AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift:115 — MethodTooLong — galleryOpsReducer runs 116 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 16 over it, 1.16× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DetailView.content AppPackage/Sources/DetailFeature/DetailView.swift:71 — MethodTooLong — content runs 115 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 15 over it, 1.15× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: PreviewsReducer.body AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift:83 — MethodTooLong — body runs 109 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 9 over it, 1.09× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: DetailSearchReducer.body AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:74 — MethodTooLong — body runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: HistoryReducer.body AppPackage/Sources/HomeFeature/History/HistoryReducer.swift:81 — MethodTooLong — body runs 107 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 7 over it, 1.07× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: UITestAutomation.resolve AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift:342 — MethodTooLong — resolve runs 106 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 6 over it, 1.06× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: SearchRootReducer.body AppPackage/Sources/SearchFeature/SearchRootReducer.swift:105 — MethodTooLong — body runs 105 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 5 over it, 1.05× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: ToplistsReducer.body AppPackage/Sources/HomeFeature/Toplists/ToplistsReducer.swift:91 — MethodTooLong — body runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
AC3 · Page structure · Page without a main landmark · ×24
  • Page without a main landmark .planning/quick/261015-duo-session-record/evidence/library-title-matrix/index.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/index.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryMPVKeys.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark REDACTED:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesCompactList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesMinimalPlusList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesThumbnailList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageCompactList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageExtendedList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageMinimalList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageMinimalPlusList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageThumbnailList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/PopularCompactList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/PopularExtendedList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/PopularMinimalList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/PopularMinimalPlusList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/PopularThumbnailList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/ToplistsCompactList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/WatchedCompactList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/WatchedExtendedList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
  • Page without a main landmark AppPackage/Sources/TestingSupport/Resources/Parser/List/WatchedMinimalList.html:2 — No <main> (or role="main") means no "skip to content" target and a weaker landmark map. Wrap the primary content in <main>.
X3 · Exception handling · Swallowed exception (caught, then discarded) · ×19
  • Swallowed exception (caught, then discarded) AppPackage/Sources/VisualSnapshotSupport/HostedWindowCapture.swift:384 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/VisualSnapshotSupport/SnapshotResultWriter.swift:148 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/ReadingFeature/ReadingView.swift:475 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/NetworkingFeature/Request+Detail.swift:60 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/NetworkingFeature/Request.swift:27 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/LogsClient/LogsClient.swift:140 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/DownloadClient/DownloadClient+ResponseValidationHelpers.swift:296 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/DownloadClient/DownloadClient+ResponseValidationHelpers.swift:309 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/DownloadClient/DownloadClient+ResponseValidationHelpers.swift:322 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/DownloadClient/DownloadStore+Operations.swift:542 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/DownloadClient/DownloadStore.swift:541 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/DownloadClient/DownloadStore.swift:593 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/DownloadClient/DownloadStore.swift:690 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/DownloadClient/DownloadStore.swift:934 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/DetailFeature/Moderation/ReportFormFeature.swift:280 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/DetailFeature/Moderation/ReportFormFeature.swift:378 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/DetailFeature/Components/LinkedText.swift:9 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/AppModels/Persistent/Setting.swift:132 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
  • Swallowed exception (caught, then discarded) AppPackage/Sources/AppModels/Persistence/JSONValue.swift:40 — `catch` takes every exception and records none of it — the body neither logs it, rethrows it, nor even names it, so the failure is discarded as completely as by an empty catch and only the substituted value survives. Log it through whatever this codebase already uses to report problems, narrow the catch to the exception this call can actually raise, or say in a comment on the catch why the failure genuinely cannot matter.
AC3 · Page structure · Data table has no header cells · ×15
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/FavoritesExtendedList.html:188 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageCompactList.html:23 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageExtendedList.html:23 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageExtendedList.html:46 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageMinimalList.html:23 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageMinimalPlusList.html:23 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/FrontPageThumbnailList.html:26 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/PopularExtendedList.html:46 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/ToplistsCompactList.html:23 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/ToplistsCompactList.html:35 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/WatchedCompactList.html:23 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/WatchedExtendedList.html:23 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/WatchedExtendedList.html:46 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
  • Data table has no header cells AppPackage/Sources/TestingSupport/Resources/Parser/List/WatchedMinimalList.html:23 — A <table> with data cells but no <th> gives assistive technology no way to associate cells with their headers. Mark the header row/column cells as <th> (with a scope).
D15 · Churn × Complexity Hotspots · Repeated repair · ×13
  • Repeated repair: AppPackage/Sources/DownloadClient/DownloadClient+Manager.swift AppPackage/Sources/DownloadClient/DownloadClient+Manager.swift:897 — AppPackage/Sources/DownloadClient/DownloadClient+Manager.swift changed 46 times in last 90 days and 24 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 3 (its worst body is DownloadCoordinator.releaseScheduling at line 897), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(20-09): write an interrupted run's on-disk progress back to its record (G-20-09-1)”; “fix(15): abandon starved page transfers”; “fix(15): never delete a user's download folder”; “fix(15): overlay a live run's progress on the row”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DownloadClient/DownloadClient+Manager.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: AppPackage/Sources/DownloadClient/DownloadClient+ContinuedSession.swift AppPackage/Sources/DownloadClient/DownloadClient+ContinuedSession.swift:386 — AppPackage/Sources/DownloadClient/DownloadClient+ContinuedSession.swift changed 34 times in last 90 days and 24 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 8 (its worst body is DownloadCoordinator.ensureContinuedSession at line 386), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(15): nudge a stalled session's card”; “fix(15): overlay a live run's progress on the row”; “fix(15): serialize the activity-log pump”; “fix(15-65): bracket the queue-intent advance”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DownloadClient/DownloadClient+ContinuedSession.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: AppPackage/Sources/AppFeature/View/Library/LibraryView.swift AppPackage/Sources/AppFeature/View/Library/LibraryView.swift:74 — AppPackage/Sources/AppFeature/View/Library/LibraryView.swift changed 11 times in last 90 days and 6 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is LibraryDetailView.body at line 74), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “revert(library): remove rejected sheet and inspector trials”; “fix(library): show only actual download folders in sidebar”; “fix(library): restore native sidebar visibility control”; “fix(library): extend the native sidebar scroll edge to the top”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/AppFeature/View/Library/LibraryView.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: AppPackage/Sources/BackgroundProcessingClient/ContinuedProcessingSession.swift AppPackage/Sources/BackgroundProcessingClient/ContinuedProcessingSession.swift:145 — AppPackage/Sources/BackgroundProcessingClient/ContinuedProcessingSession.swift changed 11 times in last 90 days and 6 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 12 (its worst body is ContinuedProcessingSession.start at line 145), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(15): nudge a stalled session's card”; “fix(15-51): register one identifier per process, not per session”; “fix(15-37): establish request identity before submission, scan the module”; “fix(15-12): seed and identify continued progress”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/BackgroundProcessingClient/ContinuedProcessingSession.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: AppPackage/Sources/VisualSnapshotSupport/HostedWindowCapture.swift AppPackage/Sources/VisualSnapshotSupport/HostedWindowCapture.swift:201 — AppPackage/Sources/VisualSnapshotSupport/HostedWindowCapture.swift changed 7 times in last 90 days and 6 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 12 (its worst body is HostedWindowCapture.settle at line 201), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(19-10): a settle read matches its run's first read within one step and half the byte budget (iPad landscape glass)”; “fix(19-10): a failed user step is retried once and names its failure; a still settle timeout names the pixels that changed”; “fix(19-04): first-launch read floor of 6 and a sturdier front-page-search focus”; “fix(19-04): hold front-page-search focused and freeze indicators at a fixed frame”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/VisualSnapshotSupport/HostedWindowCapture.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: AppPackage/Sources/LiveTextTranslation/LiveTextTextLayout.swift AppPackage/Sources/LiveTextTranslation/LiveTextTextLayout.swift:262 — AppPackage/Sources/LiveTextTranslation/LiveTextTextLayout.swift changed 5 times in last 90 days and 5 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 7 (its worst body is LiveTextTextLayout.lineRanges at line 262), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(live-text): break CJK words before a plate”; “fix(live-text): keep CJK words whole”; “fix(live-text): shape balloon text to its balloon”; “fix(live-text): keep Korean words whole”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/LiveTextTranslation/LiveTextTextLayout.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: AppPackage/Sources/ReadingFeature/Support/ReadingToolbar.swift AppPackage/Sources/ReadingFeature/Support/ReadingToolbar.swift:19 — AppPackage/Sources/ReadingFeature/Support/ReadingToolbar.swift changed 7 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 5 (its worst body is ReadingToolbar.body at line 19), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(reader): keep the open Auto-Play menu across page turns”; “fix(live-text): animate the translation toggle”; “fix(live-text): use the translate symbol”; “fix(reader): keep the indicator in narrow windows”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/ReadingFeature/Support/ReadingToolbar.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: AppPackage/Sources/DownloadClient/DownloadClient+WorkingManifestReconciliation.swift AppPackage/Sources/DownloadClient/DownloadClient+WorkingManifestReconciliation.swift:223 — AppPackage/Sources/DownloadClient/DownloadClient+WorkingManifestReconciliation.swift changed 5 times in last 90 days and 4 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 10 (its worst body is DownloadCoordinator.reconcileWorkingManifestAgainstPageFiles at line 223), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(20-09): a repair stopped with Verify's and the stop's scans both finding every page absent reads Paused 0 of N (B1)”; “fix(20-09): a repair stopped before any page landed reads Paused 0 of N (K0-a)”; “fix(20-09): write an interrupted run's on-disk progress back to its record (G-20-09-1)”; “fix(15): never delete a user's download folder”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DownloadClient/DownloadClient+WorkingManifestReconciliation.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: Scripts/visual/snapshot_measure.py Scripts/visual/snapshot_measure.py:147 — Scripts/visual/snapshot_measure.py changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 15 (its worst body is snapshot_measure.exclusions at line 147), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(19-04): time-limit and retry the hosted simulator steps; interim 2 workers”; “fix(19-04): count a measurement run cut off before its record as missing”; “fix(19-04): pin the iPad to Full Screen Apps and give each text size its own measurement job”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- Scripts/visual/snapshot_measure.py`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: AppPackage/Sources/LiveTextTranslation/LiveTextTranslatedPage.swift AppPackage/Sources/LiveTextTranslation/LiveTextTranslatedPage.swift:54 — AppPackage/Sources/LiveTextTranslation/LiveTextTranslatedPage.swift changed 5 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 5 (its worst body is LiveTextTranslatedPage.layOut at line 54), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(live-text): shape balloon text to its balloon”; “fix(live-text): set balloon text in its rooms”; “fix(live-text): even lines, keep tight boxes' color”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/LiveTextTranslation/LiveTextTranslatedPage.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: AppPackage/Sources/LiveTextTranslation/LiveTextTextFitter.swift AppPackage/Sources/LiveTextTranslation/LiveTextTextFitter.swift:58 — AppPackage/Sources/LiveTextTranslation/LiveTextTextFitter.swift changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 6 (its worst body is LiveTextTextFitter.fit at line 58), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(live-text): break CJK words before a plate”; “fix(live-text): shape balloon text to its balloon”; “fix(live-text): set balloon text in its rooms”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/LiveTextTranslation/LiveTextTextFitter.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: AppPackage/Sources/DownloadClient/DownloadClient+PendingWork.swift AppPackage/Sources/DownloadClient/DownloadClient+PendingWork.swift:62 — AppPackage/Sources/DownloadClient/DownloadClient+PendingWork.swift changed 4 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 4 (its worst body is DownloadCoordinator.schedulableDownloads at line 62), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(15-32): close the log-privacy blind spot and wrong premises”; “fix(15-26): let the work authority see the gallery it is running”; “fix(15-13): converge vanished download deletion”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DownloadClient/DownloadClient+PendingWork.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
  • Repeated repair: AppPackage/Sources/DetailFeature/Moderation/BlockedCommentRow.swift AppPackage/Sources/DetailFeature/Moderation/BlockedCommentRow.swift:77 — AppPackage/Sources/DetailFeature/Moderation/BlockedCommentRow.swift changed 3 times in last 90 days and 3 of those changes were fix/bug commits, so repair is the majority of this file's churn. Its max cyclomatic complexity is 2 (its worst body is RevealedCommentLine.body at line 77), AT OR UNDER the 15 threshold, so this is deliberately not filed as a churn × complexity hotspot — the difficulty here is in the behaviour the file has to get right, not in its control flow, and refactoring it for complexity would be the wrong move. The repairs counted were: “fix(18): keep a revealed comment's Hide pill on one line”; “fix(18): keep Hide beside a revealed comment's label below accessibility sizes”; “fix(18): keep whole words in a revealed comment's line at large text”. Each one is a case this code did not handle. Before the next change lands here, check that every one of them is pinned by a test that fails without its fix; where the same area keeps coming back, the durable fix is usually at the interface that keeps being misused rather than at the line that was last corrected. Counted over 2026-08-15..2026-11-13, the 90 days ending at the analysed commit. Reproduce with `git log --since='2026-08-15 23:33:39 +08:00' --until='2026-11-13 23:33:39 +08:00' --full-history --no-merges -- AppPackage/Sources/DetailFeature/Moderation/BlockedCommentRow.swift`: merges are excluded because a merge re-states changes already counted at their own commits, and history is NOT path-simplified because a change that reached the file through a merged branch is still a change to it. That command counts raw commits and can read HIGHER than this row, which counts a cherry-picked re-land, and a revert together with the commit it undoes, once each — a difference of several commits on a file whose history was re-landed or reverted inside the window.
D35 · Change Coupling · Change coupling · ×13
  • Change coupling: PopularView.swift ↔ ToplistsView.swift AppPackage/Sources/HomeFeature/Popular/PopularView.swift:1 — `AppPackage/Sources/HomeFeature/Popular/PopularView.swift` and `AppPackage/Sources/HomeFeature/Toplists/ToplistsView.swift` change together 79% of the time (27 of the 34 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 27 shared commits counted here, the most recent 3 are `8eceb693` refactor(11-07): presentation lifecycle in Home; `862d8930` refactor(07-04): remove Home privacy-mask parameter drilling; `7b82b85d` refactor: rename GenericList to GalleryList — run `git show` on any of them.
  • Change coupling: HistoryView.swift ↔ PopularView.swift AppPackage/Sources/HomeFeature/History/HistoryView.swift:1 — `AppPackage/Sources/HomeFeature/History/HistoryView.swift` and `AppPackage/Sources/HomeFeature/Popular/PopularView.swift` change together 74% of the time (25 of the 34 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 25 shared commits counted here, the most recent 3 are `8eceb693` refactor(11-07): presentation lifecycle in Home; `862d8930` refactor(07-04): remove Home privacy-mask parameter drilling; `7b82b85d` refactor: rename GenericList to GalleryList — run `git show` on any of them.
  • Change coupling: HistoryView.swift ↔ ToplistsView.swift AppPackage/Sources/HomeFeature/History/HistoryView.swift:1 — `AppPackage/Sources/HomeFeature/History/HistoryView.swift` and `AppPackage/Sources/HomeFeature/Toplists/ToplistsView.swift` change together 68% of the time (26 of the 38 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 26 shared commits counted here, the most recent 3 are `8eceb693` refactor(11-07): presentation lifecycle in Home; `862d8930` refactor(07-04): remove Home privacy-mask parameter drilling; `7b82b85d` refactor: rename GenericList to GalleryList — run `git show` on any of them.
  • Change coupling: EhSettingView+Sections1.swift ↔ EhSettingView+Sections2.swift AppPackage/Sources/SettingFeature/EhSetting/EhSettingView+Sections1.swift:1 — `AppPackage/Sources/SettingFeature/EhSetting/EhSettingView+Sections1.swift` and `AppPackage/Sources/SettingFeature/EhSetting/EhSettingView+Sections2.swift` change together 67% of the time (8 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `33314b3b` fix(l10n): stop sharing dialog and field strings; `8356affb` refactor(10-02): foregroundColor to foregroundStyle sweep; `1442a1fe` fix: resolve adaptive layout review findings — run `git show` on any of them.
  • Change coupling: EhSettingView+Sections2.swift ↔ EhSettingView+Sections3.swift AppPackage/Sources/SettingFeature/EhSetting/EhSettingView+Sections2.swift:1 — `AppPackage/Sources/SettingFeature/EhSetting/EhSettingView+Sections2.swift` and `AppPackage/Sources/SettingFeature/EhSetting/EhSettingView+Sections3.swift` change together 58% of the time (7 of the 12 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in the same directory, and in this ecosystem sibling files there normally share one namespace/package — so a direct reference between them needs no import and this pass cannot see whether one exists. Read the pair before acting: if one file only DECLARES what the other consumes (a constants/types file beside its user), the co-change is definitional and the question is whether the split earns its keep; if they duplicate structure, extract the common part into a shared function or type they both call; if neither holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `681327c0` refactor(11-17): guard remaining subscript indexing; `8356affb` refactor(10-02): foregroundColor to foregroundStyle sweep; `1442a1fe` fix: resolve adaptive layout review findings — run `git show` on any of them.
  • Change coupling: ClipboardClient.swift ↔ ImageClient.swift AppPackage/Sources/ClipboardClient/ClipboardClient.swift:1 — `AppPackage/Sources/ClipboardClient/ClipboardClient.swift` and `AppPackage/Sources/ImageClient/ImageClient.swift` change together 54% of the time (7 of the 13 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 7 shared commits counted here, the most recent 3 are `172f4fd5` Extract SDWebImageExt module from AnimatedImage_Extension (at that commit the files were still `AppPackage/Sources/AppFeature/Tools/Clients/ClipboardClient.swift` and `AppPackage/Sources/AppFeature/Tools/Clients/ImageClient.swift`); `65679c7c` Improve WebP support (at that commit the files were still `EhPanda/App/Tools/Clients/ClipboardClient.swift` and `EhPanda/App/Tools/Clients/ImageClient.swift`); `3d8b3208` Rename `EffectTask` with `Effect` (at that commit the files were still `EhPanda/App/Tools/Clients/ClipboardClient.swift` and `EhPanda/App/Tools/Clients/ImageClient.swift`) — run `git show` on any of them.
  • Change coupling: ApplicationClient.swift ↔ LibraryClient.swift AppPackage/Sources/ApplicationClient/ApplicationClient.swift:1 — `AppPackage/Sources/ApplicationClient/ApplicationClient.swift` and `AppPackage/Sources/LibraryClient/LibraryClient.swift` change together 53% of the time (8 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 8 shared commits counted here, the most recent 3 are `6dca45ab` refactor(04-13): remove dead client Combine imports; `efb398ad` Use concrete dirs (at that commit the files were still `EhPanda/App/Tools/Clients/UIApplicationClient.swift` and `EhPanda/App/Tools/Clients/LibraryClient.swift`); `3d8b3208` Rename `EffectTask` with `Effect` (at that commit the files were still `EhPanda/App/Tools/Clients/UIApplicationClient.swift` and `EhPanda/App/Tools/Clients/LibraryClient.swift`) — run `git show` on any of them.
  • Change coupling: TagSuggestionView.swift ↔ TagTranslator.swift AppPackage/Sources/AppComponents/TagSuggestionView.swift:1 — `AppPackage/Sources/AppComponents/TagSuggestionView.swift` and `AppPackage/Sources/AppModels/Tags/TagTranslator.swift` change together 53% of the time (9 of the 17 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `4161bd6b` Extract TagTranslationFeature; drop CommonMarkExt from AppModels; `9fe20496` refactor: Clean codes (at that commit the files were still `EhPanda/View/Support/Components/TagSuggestionView.swift` and `EhPanda/Models/Tags/TagTranslator.swift`); `f67d6641` refactor: Lint PR codes (at that commit the files were still `EhPanda/View/Support/Components/TagSuggestionView.swift` and `EhPanda/Models/Tags/TagTranslator.swift`) — run `git show` on any of them.
  • Change coupling: Placeholder.swift ↔ ReadingView.swift AppPackage/Sources/AppComponents/Placeholder.swift:1 — `AppPackage/Sources/AppComponents/Placeholder.swift` and `AppPackage/Sources/ReadingFeature/ReadingView.swift` change together 52% of the time (13 of the 25 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 13 shared commits counted here, the most recent 3 are `dccec1ee` fix(reader): size unloaded strip pages by width; `8dd662bd` refactor(10-03): sweep bare deprecated view modifiers to current APIs; `40bceb02` Improve WebP support (at that commit the files were still `EhPanda/View/Support/Components/Placeholder.swift` and `EhPanda/View/Reading/ReadingView.swift`) — run `git show` on any of them.
  • Change coupling: DetailView.swift ↔ PreviewsView.swift AppPackage/Sources/DetailFeature/DetailView.swift:1 — `AppPackage/Sources/DetailFeature/DetailView.swift` and `AppPackage/Sources/DetailFeature/Previews/PreviewsView.swift` change together 52% of the time (17 of the 33 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 17 shared commits counted here, the most recent 3 are `e6e66f02` refactor(11-09): reader load on presentation; `6dd581b2` refactor(07-07): remove ReadingView blur drilling; `ecdec358` refactor(07-06): remove DetailFeature blur drilling — run `git show` on any of them.
  • Change coupling: DetailView.swift ↔ GalleryDetailCell.swift AppPackage/Sources/DetailFeature/DetailView.swift:1 — `AppPackage/Sources/DetailFeature/DetailView.swift` and `AppPackage/Sources/GalleryListComponents/Cells/GalleryDetailCell.swift` change together 51% of the time (38 of the 74 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 38 shared commits counted here, the most recent 3 are `300a29ac` feat(gallery): apply title preference across views and preserve appro…; `4161bd6b` Extract TagTranslationFeature; drop CommonMarkExt from AppModels; `48464e12` Split badge status from progress (at that commit the files were still `EhPanda/View/Detail/DetailView.swift` and `EhPanda/View/Support/Components/Cells/GalleryDetailCell.swift`) — run `git show` on any of them.
  • Change coupling: AccountSettingView.swift ↔ EhSettingView.swift AppPackage/Sources/SettingFeature/AccountSetting/AccountSettingView.swift:1 — `AppPackage/Sources/SettingFeature/AccountSetting/AccountSettingView.swift` and `AppPackage/Sources/SettingFeature/EhSetting/EhSettingView.swift` change together 50% of the time (27 of the 54 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 27 shared commits counted here, the most recent 3 are `262276c1` refactor(11-10): Setting screens load on presentation; `5cc80181` refactor(08-07): drain setting and detail host globals; `0a66cfe9` refactor(07-07): remove SettingFeature blur drilling — run `git show` on any of them.
  • Change coupling: CommentsView.swift ↔ GalleryInfoView.swift AppPackage/Sources/DetailFeature/Comments/CommentsView.swift:1 — `AppPackage/Sources/DetailFeature/Comments/CommentsView.swift` and `AppPackage/Sources/DetailFeature/GalleryInfo/GalleryInfoView.swift` change together 50% of the time (10 of the 20 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 10 shared commits counted here, the most recent 3 are `1f1dfc14` refactor(10-01): rename SystemNotificationExt module to SystemNotific… (at that commit the file was still `AppPackage/Sources/DetailFeature/GalleryInfos/GalleryInfosView.swift`); `e9926f0e` refactor(04-14): clear remaining TCA deprecations (at that commit the file was still `AppPackage/Sources/DetailFeature/GalleryInfos/GalleryInfosView.swift`); `388d099f` Convert component title params to resources (at that commit the file was still `AppPackage/Sources/DetailFeature/GalleryInfos/GalleryInfosView.swift`) — run `git show` on any of them.
D10 · Test Quality · Skipped test · ×11
  • Skipped test: testPadSettingAndDetailModalsAudit EhPandaUITests/AccessibilityAuditUITests.swift:388 — Skipped — throws XCTSkip
  • Skipped test: testPadTabModalReplacedByDeepLink EhPandaUITests/DeepLinkPadUITests.swift:10 — Skipped — throws XCTSkip
  • Skipped test: testHomeAndNestedSheetsUseOppositeHalves EhPandaUITests/LandscapePaneUITests.swift:22 — Skipped — throws XCTSkip
  • Skipped test: testPadHomeKeepsSinglePaneAcrossRotationAndTextSizes EhPandaUITests/LandscapePaneUITests.swift:53 — Skipped — throws XCTSkip
  • Skipped test: testWideSlideshowRevealsNeighborsAndPreservesSelectionAcrossRotation EhPandaUITests/LandscapePaneUITests.swift:92 — Skipped — throws XCTSkip
  • Skipped test: testHomePreservesOriginalTitlesAndSectionLayout EhPandaUITests/LandscapePaneUITests.swift:154 — Skipped — throws XCTSkip
  • Skipped test: testAutomaticLayoutPreservesThePageOnRotationAndReentry EhPandaUITests/ReadingOrientationUITests.swift:26 — Skipped — throws XCTSkip
  • Skipped test: testDisablingAutomationKeepsManualDirectionAfterRotation EhPandaUITests/ReadingOrientationUITests.swift:60 — Skipped — throws XCTSkip
  • Skipped test: testOrdinaryPhoneOffersTwoPagesWithoutAutomaticRotation EhPandaUITests/ReadingOrientationUITests.swift:77 — Skipped — throws XCTSkip
  • Skipped test: testTheLargestTextSizeKeepsTheButtonInReach EhPandaUITests/ReportFormUITests.swift:291 — Skipped — throws XCTSkip
  • Skipped test: testThePadFormSheetAndCommandReturn EhPandaUITests/ReportFormUITests.swift:311 — Skipped — throws XCTSkip
D35 · Change Coupling · Change-coupling hub · ×7
  • Change-coupling hub: FrontPageView.swift → FavoritesView.swift, HistoryView.swift, PopularView.swift, ToplistsView.swift, WatchedView.swift, SearchView.swift AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift — `AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift` changes together with 6 other files — `AppPackage/Sources/FavoritesFeature/FavoritesView.swift`, `AppPackage/Sources/HomeFeature/History/HistoryView.swift`, `AppPackage/Sources/HomeFeature/Popular/PopularView.swift`, `AppPackage/Sources/HomeFeature/Toplists/ToplistsView.swift`, `AppPackage/Sources/HomeFeature/Watched/WatchedView.swift`, `AppPackage/Sources/SearchFeature/SearchView.swift` — none of which declares a dependency on it: one file is the hub of 6 separate couplings, not 6 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 6.
  • Change-coupling hub: WatchedView.swift → FavoritesView.swift, HistoryView.swift, PopularView.swift, ToplistsView.swift, SearchView.swift AppPackage/Sources/HomeFeature/Watched/WatchedView.swift — `AppPackage/Sources/HomeFeature/Watched/WatchedView.swift` changes together with 5 other files — `AppPackage/Sources/FavoritesFeature/FavoritesView.swift`, `AppPackage/Sources/HomeFeature/History/HistoryView.swift`, `AppPackage/Sources/HomeFeature/Popular/PopularView.swift`, `AppPackage/Sources/HomeFeature/Toplists/ToplistsView.swift`, `AppPackage/Sources/SearchFeature/SearchView.swift` — none of which declares a dependency on it: one file is the hub of 5 separate couplings, not 5 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 5.
  • Change-coupling hub: DetailSearchView.swift → FavoritesView.swift, FrontPageView.swift, PopularView.swift, ToplistsView.swift, WatchedView.swift, SearchRootView.swift, SearchView.swift AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift — `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift` changes together with 7 other files — `AppPackage/Sources/FavoritesFeature/FavoritesView.swift`, `AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift`, `AppPackage/Sources/HomeFeature/Popular/PopularView.swift`, `AppPackage/Sources/HomeFeature/Toplists/ToplistsView.swift`, `AppPackage/Sources/HomeFeature/Watched/WatchedView.swift`, `AppPackage/Sources/SearchFeature/SearchRootView.swift`, `AppPackage/Sources/SearchFeature/SearchView.swift` — none of which declares a dependency on it: one file is the hub of 7 separate couplings, not 7 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 7.
  • Change-coupling hub: DownloadClient+PersistenceHelpers.swift → DownloadClient+PersistenceNormalize.swift, DownloadClient+PublicAPI.swift, DownloadStore+Operations.swift AppPackage/Sources/DownloadClient/DownloadClient+PersistenceHelpers.swift — `AppPackage/Sources/DownloadClient/DownloadClient+PersistenceHelpers.swift` changes together with 3 other files — `AppPackage/Sources/DownloadClient/DownloadClient+PersistenceNormalize.swift`, `AppPackage/Sources/DownloadClient/DownloadClient+PublicAPI.swift`, `AppPackage/Sources/DownloadClient/DownloadStore+Operations.swift` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
  • Change-coupling hub: FavoritesView.swift → PopularView.swift, ToplistsView.swift, SearchView.swift AppPackage/Sources/FavoritesFeature/FavoritesView.swift — `AppPackage/Sources/FavoritesFeature/FavoritesView.swift` changes together with 3 other files — `AppPackage/Sources/HomeFeature/Popular/PopularView.swift`, `AppPackage/Sources/HomeFeature/Toplists/ToplistsView.swift`, `AppPackage/Sources/SearchFeature/SearchView.swift` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
  • Change-coupling hub: TorrentsView.swift → ArchivesView.swift, CommentsView.swift, GalleryInfoView.swift, AccountSettingView.swift AppPackage/Sources/DetailFeature/Torrents/TorrentsView.swift — `AppPackage/Sources/DetailFeature/Torrents/TorrentsView.swift` changes together with 4 other files — `AppPackage/Sources/DetailFeature/Archives/ArchivesView.swift`, `AppPackage/Sources/DetailFeature/Comments/CommentsView.swift`, `AppPackage/Sources/DetailFeature/GalleryInfo/GalleryInfoView.swift`, `AppPackage/Sources/SettingFeature/AccountSetting/AccountSettingView.swift` — none of which declares a dependency on it: one file is the hub of 4 separate couplings, not 4 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 4.
  • Change-coupling hub: DownloadClient+ExecutionPerform.swift → DownloadClient+ExecutionSupport.swift, DownloadClient+PublicAPI.swift, DownloadStore+Operations.swift AppPackage/Sources/DownloadClient/DownloadClient+ExecutionPerform.swift — `AppPackage/Sources/DownloadClient/DownloadClient+ExecutionPerform.swift` changes together with 3 other files — `AppPackage/Sources/DownloadClient/DownloadClient+ExecutionSupport.swift`, `AppPackage/Sources/DownloadClient/DownloadClient+PublicAPI.swift`, `AppPackage/Sources/DownloadClient/DownloadStore+Operations.swift` — none of which declares a dependency on it: one file is the hub of 3 separate couplings, not 3 unrelated pairs. Read the hub first: if the others each duplicate a part of what it does, the shared concern belongs in ONE unit and extracting it clears every edge at once; if the hub is a registry, dispatcher or barrel that must name each of them, the coupling is structural and the question is whether that list can be discovered instead of enumerated. Fixing the hub is one change; breaking the couplings one pair at a time is 3.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×7
  • Duplicated block (9 lines × 2) AppPackage/Sources/AppFeature/UITestSupport/CaptureFixtureManifest.swift:499 — AppPackage/Sources/AppFeature/UITestSupport/CaptureFixtureManifest.swift:499-507 | AppPackage/Sources/AppFeature/UITestSupport/CaptureFixtureManifest.swift:554-562 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/AppFeature/UITestSupport/CaptureFixtureManifest.swift:499` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) AppPackage/Sources/DetailFeature/DetailView+CommentCells.swift:135 — AppPackage/Sources/DetailFeature/DetailView+CommentCells.swift:135-143 | AppPackage/Sources/DetailFeature/DetailView+CommentCells.swift:151-159 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (9 lines × 2) AppPackage/Sources/DownloadClient/DownloadClient+BackgroundDownloads.swift:239 — AppPackage/Sources/DownloadClient/DownloadClient+BackgroundDownloads.swift:239-247 | AppPackage/Sources/DownloadClient/DownloadStore.swift:166-175 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DownloadClient/DownloadStore.swift:166` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift:53 — AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift:53-61 | AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift:68-76 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift:53` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) AppPackage/Sources/AppModels/Utilities/URLUtil.swift:67 — AppPackage/Sources/AppModels/Utilities/URLUtil.swift:67-75 | AppPackage/Sources/AppModels/Utilities/URLUtil.swift:94-102 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `AppPackage/Sources/AppModels/Utilities/URLUtil.swift:93` calls `appending`, `joined` and `AppPackage/Sources/AppModels/Utilities/URLUtil.swift:66` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:461 — AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:461-469 | AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:195-203 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:461` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:676 — .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:676-684 | .planning/phases/18.1-native-report-form/18.1-copy-check.py:290-298 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×7
  • Duplicated block (8 lines × 2) AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:219 — AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:219-226 | AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:310-317 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:219` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) AppPackage/Sources/DownloadsFeature/DownloadsView.swift:62 — AppPackage/Sources/DownloadsFeature/DownloadsView.swift:62-71 | AppPackage/Sources/FavoritesFeature/FavoritesView.swift:64-71 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DownloadsFeature/DownloadsView.swift:62` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift:496 — AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift:496-503 | AppPackage/Sources/AppLaunchAutomationClient/AppLaunchAutomation.swift:162-169 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (8 lines × 2) AppPackage/Sources/AppModels/Gallery/Gallery.swift:81 — AppPackage/Sources/AppModels/Gallery/Gallery.swift:81-88 | AppPackage/Sources/AppModels/Gallery/GalleryDetail.swift:80-87 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) AppPackage/Sources/DownloadsFeature/DownloadsView.swift:24 — AppPackage/Sources/DownloadsFeature/DownloadsView.swift:24-31 | AppPackage/Sources/FavoritesFeature/FavoritesView.swift:25-32 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Note first that the copies are not typed on the same thing: the declarations holding them bind `store` to `StoreOf<DownloadsReducer>` in one and `StoreOf<FavoritesReducer>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (8 lines × 2) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:156 — .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:156-163 | .planning/phases/18.1-native-report-form/18.1-copy-check.py:75-82 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:300 — .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:300-307 | .planning/phases/18.1-native-report-form/18.1-copy-check.py:163-170 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Members sharing a duplicated core (4 members, 50+ identical tokens) · ×6
  • Members sharing a duplicated core (4 members, 50+ identical tokens) .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:16 — .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:16-40 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift:16-40 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/NeverOnlyProbe.swift:16-40 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/probe/CustomArrowProbe.swift:16-40 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:47 — .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:47-67 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift:47-69 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/NeverOnlyProbe.swift:47-68 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/probe/CustomArrowProbe.swift:47-67 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:73 — .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:73-93 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift:75-95 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/NeverOnlyProbe.swift:74-94 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/probe/CustomArrowProbe.swift:73-93 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:74 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:74-218 | AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:77-234 | AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:85-300 | AppPackage/Sources/SearchFeature/SearchReducer.swift:86-307 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:77 — AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:77-234 | AppPackage/Sources/HomeFeature/Popular/PopularReducer.swift:59-126 | AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:85-300 | AppPackage/Sources/SearchFeature/SearchReducer.swift:86-307 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
  • Members sharing a duplicated core (4 members, 50+ identical tokens) AppPackage/Sources/ParserFeature/Parser+List.swift:59 — AppPackage/Sources/ParserFeature/Parser+List.swift:59-92 | AppPackage/Sources/ParserFeature/Parser+List.swift:94-126 | AppPackage/Sources/ParserFeature/Parser+List.swift:128-157 | AppPackage/Sources/ParserFeature/Parser+List.swift:159-187 — These 4 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 4 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 4 times.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×6
  • Duplicated block (7 lines × 2) AppPackage/Sources/DetailFeature/HeaderActionsLayout.swift:11 — AppPackage/Sources/DetailFeature/HeaderActionsLayout.swift:11-17 | AppPackage/Sources/HomeFeature/GalleryCardLayout.swift:14-20 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/HeaderActionsLayout.swift:11` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) AppPackage/Sources/FavoritesFeature/FavoritesView.swift:45 — AppPackage/Sources/FavoritesFeature/FavoritesView.swift:45-51 | AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:23-29 — before extracting anything, compare `AppPackage/Sources/FavoritesFeature/FavoritesView.swift` and `AppPackage/Sources/HomeFeature/Watched/WatchedView.swift` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/FavoritesFeature/FavoritesView.swift:45` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `store` to `store` in one and `StoreOf<WatchedReducer>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (7 lines × 2) AppPackage/Sources/HomeFeature/History/HistoryView.swift:30 — AppPackage/Sources/HomeFeature/History/HistoryView.swift:30-36 | AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:74-80 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/HomeFeature/History/HistoryView.swift:30` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `store` to `StoreOf<HistoryReducer>` in one and `StoreOf<WatchedReducer>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (7 lines × 2) AppPackage/Sources/ParserFeature/Parser+Preview.swift:45 — AppPackage/Sources/ParserFeature/Parser+Preview.swift:45-51 | AppPackage/Sources/ParserFeature/Parser+Preview.swift:78-84 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/ParserFeature/Parser+Preview.swift:45` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) AppPackage/Sources/AppFeature/FirstLaunch/AgeWallView.swift:17 — AppPackage/Sources/AppFeature/FirstLaunch/AgeWallView.swift:17-23 | AppPackage/Sources/AppFeature/FirstLaunch/AnalyticsChoiceView.swift:21-27 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `AppPackage/Sources/AppFeature/FirstLaunch/AgeWallView.swift:12` calls `Environment` and `AppPackage/Sources/AppFeature/FirstLaunch/AnalyticsChoiceView.swift:17` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 2) AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:87 — AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:87-93 | AppPackage/Sources/HomeFeature/Toplists/ToplistsReducer.swift:59-65 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×6
  • Duplicated block (6 lines × 2) AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift:154 — AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift:154-159 | AppPackage/Sources/DetailFeature/DetailReducer+Actions.swift:76-81 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift:154` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift:119 — AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift:119-124 | AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift:202-207 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:27 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:27-32 | AppPackage/Sources/HomeFeature/Popular/PopularView.swift:26-31 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:27` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: the declarations holding them bind `store` to `StoreOf<DetailSearchReducer>` in one and `StoreOf<PopularReducer>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (6 lines × 2) AppPackage/Sources/DownloadClient/DownloadClient+PageTransferProgress.swift:304 — AppPackage/Sources/DownloadClient/DownloadClient+PageTransferProgress.swift:304-309 | AppPackage/Sources/DownloadClient/DownloadClient+PageTransferProgress.swift:330-335 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DownloadClient/DownloadClient+PageTransferProgress.swift:304` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:272 — AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:272-277 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:365-370 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:272` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (6 lines × 2) AppPackage/Sources/ParserFeature/Parser+Preview.swift:56 — AppPackage/Sources/ParserFeature/Parser+Preview.swift:56-61 | AppPackage/Sources/ParserFeature/Parser+Preview.swift:85-90 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/ParserFeature/Parser+Preview.swift:56` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Edited copy of a member (16 corresponding lines) · ×5
  • Edited copy of a member (16 corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Account.swift:543 — AppPackage/Sources/NetworkingFeature/Request+Account.swift:543-558 | AppPackage/Sources/NetworkingFeature/Request+Account.swift:741-757 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) AppPackage/Sources/DownloadClient/DownloadClient+PageTransferProgress.swift:298 — AppPackage/Sources/DownloadClient/DownloadClient+PageTransferProgress.swift:298-314 | AppPackage/Sources/DownloadClient/DownloadClient+PageTransferProgress.swift:324-339 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) AppPackage/Sources/NetworkingFeature/Request.swift:98 — AppPackage/Sources/NetworkingFeature/Request.swift:98-113 | AppPackage/Sources/NetworkingFeature/Request.swift:115-136 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) AppPackage/Sources/FavoritesFeature/FavoritesView.swift:170 — AppPackage/Sources/FavoritesFeature/FavoritesView.swift:170-185 | AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:109-126 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (16 corresponding lines) AppPackage/Sources/AppFeature/UITestSupport/CaptureDiagnostics.swift:297 — AppPackage/Sources/AppFeature/UITestSupport/CaptureDiagnostics.swift:297-312 | AppPackage/Sources/AppFeature/UITestSupport/CaptureScenePreparation.swift:860-875 — These two members are one piece of code written twice and then edited apart: 16 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (11 corresponding lines) · ×5
  • Edited copy of a member (11 corresponding lines) AppPackage/Sources/AppModels/Utilities/URLUtil.swift:35 — AppPackage/Sources/AppModels/Utilities/URLUtil.swift:35-45 | AppPackage/Sources/AppModels/Utilities/URLUtil.swift:47-58 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) AppPackage/Sources/GalleryListComponents/Cells/GalleryThumbnailCell.swift:32 — AppPackage/Sources/GalleryListComponents/Cells/GalleryThumbnailCell.swift:32-44 | AppPackage/Sources/GalleryListComponents/Cells/GalleryDetailCell.swift:26-36 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Account.swift:248 — AppPackage/Sources/NetworkingFeature/Request+Account.swift:248-260 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:386-396 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Account.swift:416 — AppPackage/Sources/NetworkingFeature/Request+Account.swift:416-428 | AppPackage/Sources/NetworkingFeature/Request+Detail.swift:120-130 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (11 corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Detail.swift:297 — AppPackage/Sources/NetworkingFeature/Request+Detail.swift:297-307 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:248-260 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (3 corresponding lines) · ×5
  • Edited copy of a member (3 corresponding lines) AppPackage/Sources/HomeFeature/GalleryCardHeightLayout.swift:13 — AppPackage/Sources/HomeFeature/GalleryCardHeightLayout.swift:13-15 | AppPackage/Sources/ReadingFeature/Support/UnloadedPage.swift:130-132 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (3 corresponding lines) AppPackage/Sources/SettingFeature/Components/ChallengeWebView.swift:175 — AppPackage/Sources/SettingFeature/Components/ChallengeWebView.swift:175-177 | AppPackage/Sources/SettingFeature/Components/WebView.swift:43-45 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (3 corresponding lines) AppPackage/Sources/AppModels/Support/LiveText.swift:145 — AppPackage/Sources/AppModels/Support/LiveText.swift:145-147 | AppPackage/Sources/ReadingFeature/Support/LiveTextView.swift:192-194 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (3 corresponding lines) AppPackage/Sources/DetailFeature/HeaderActionsLayout.swift:5 — AppPackage/Sources/DetailFeature/HeaderActionsLayout.swift:5-7 | AppPackage/Sources/HomeFeature/GalleryCardLayout.swift:8-10 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (3 corresponding lines) Scripts/visual/capture-native.py:66 — Scripts/visual/capture-native.py:66-68 | Scripts/visual/run-regression.py:41-43 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (9 corresponding lines) · ×4
  • Edited copy of a member (9 corresponding lines) AppPackage/Sources/AppFeature/UITestSupport/CaptureLiveText.swift:235 — AppPackage/Sources/AppFeature/UITestSupport/CaptureLiveText.swift:235-244 | AppPackage/Sources/AppFeature/UITestSupport/CaptureTagTranslation.swift:67-75 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) AppPackage/Sources/DetailFeature/GalleryNavigation.swift:125 — AppPackage/Sources/DetailFeature/GalleryNavigation.swift:125-133 | AppPackage/Sources/HomeFeature/HomePath.swift:40-48 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Detail.swift:28 — AppPackage/Sources/NetworkingFeature/Request+Detail.swift:28-38 | AppPackage/Sources/NetworkingFeature/Request+Image.swift:25-33 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Account.swift:562 — AppPackage/Sources/NetworkingFeature/Request+Account.swift:562-570 | AppPackage/Sources/NetworkingFeature/Request+Detail.swift:253-261 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×4
  • Duplicated block (10 lines × 2) AppPackage/Sources/AppComponents/ViewModifiers.swift:84 — AppPackage/Sources/AppComponents/ViewModifiers.swift:84-93 | AppPackage/Sources/AppComponents/ViewModifiers.swift:98-107 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/AppComponents/ViewModifiers.swift:84` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (10 lines × 2) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:157 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:157-166 | AppPackage/Sources/SearchFeature/SearchReducer.swift:196-205 — before extracting anything, compare `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift` and `AppPackage/Sources/SearchFeature/SearchReducer.swift` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:157` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) AppPackage/Sources/DetailFeature/FolderManager/FolderManagerReducer.swift:87 — AppPackage/Sources/DetailFeature/FolderManager/FolderManagerReducer.swift:87-96 | AppPackage/Sources/QuickSearchFeature/QuickSearchReducer.swift:98-107 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/FolderManager/FolderManagerReducer.swift:87` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) AppPackage/Sources/NetworkingFeature/Request+Account.swift:283 — AppPackage/Sources/NetworkingFeature/Request+Account.swift:283-292 | AppPackage/Sources/NetworkingFeature/Request+Account.swift:403-412 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/NetworkingFeature/Request+Account.swift:283` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D3 · God Classes · FileTooLong · ×3
  • FileTooLong: VisualSnapshotSupport/FullContentHost.swift AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift — FileTooLong — 612 significant lines (blank, comment-only and punctuation-only lines excluded), about 80% of them inside a single declaration: FullContentHost (62-700). The bar is 500 significant lines; this is 112 over it, 1.22× the bar. Moving the declarations that sit BESIDE it into sibling files will not shorten this file. Extract from INSIDE that declaration instead: lift each cohesive group of its body — the parts that share the same inputs and are named together — into its own unit in a sibling file, and have the original call them.
  • FileTooLong: UITestSupport/CaptureScenePreparation.swift AppPackage/Sources/AppFeature/UITestSupport/CaptureScenePreparation.swift — FileTooLong — 569 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 69 over it, 1.14× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
  • FileTooLong: NetworkingFeature/Request+Account.swift AppPackage/Sources/NetworkingFeature/Request+Account.swift — FileTooLong — 511 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 11 over it, 1.02× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×3
  • Edited copy of a member (12 corresponding lines) AppPackage/Sources/AppModels/Moderation/BlockedCommentUser.swift:35 — AppPackage/Sources/AppModels/Moderation/BlockedCommentUser.swift:35-46 | AppPackage/Sources/AppModels/Persistent/GalleryHistoryEntry.swift:51-64 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift:115 — AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift:115-127 | AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift:132-143 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) AppPackage/Sources/DownloadClient/DownloadClient+BackgroundDownloads.swift:236 — AppPackage/Sources/DownloadClient/DownloadClient+BackgroundDownloads.swift:236-247 | AppPackage/Sources/DownloadClient/DownloadStore.swift:164-175 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (14 corresponding lines) · ×3
  • Edited copy of a member (14 corresponding lines) AppPackage/Sources/AppComponents/CheckboxToggleStyle.swift:71 — AppPackage/Sources/AppComponents/CheckboxToggleStyle.swift:71-84 | AppPackage/Sources/AppComponents/ChoiceCard.swift:86-99 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) AppPackage/Sources/AppTools/Extensions.swift:86 — AppPackage/Sources/AppTools/Extensions.swift:86-99 | AppPackage/Sources/MarkdownExt/MarkdownUtil.swift:53-66 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) AppPackage/Sources/AppComponents/CheckboxToggleStyle.swift:56 — AppPackage/Sources/AppComponents/CheckboxToggleStyle.swift:56-69 | AppPackage/Sources/AppComponents/ChoiceCard.swift:71-84 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (7 corresponding lines) · ×3
  • Edited copy of a member (7 corresponding lines) AppPackage/Sources/AppModels/Support/AppActivityLog.swift:54 — AppPackage/Sources/AppModels/Support/AppActivityLog.swift:54-61 | AppPackage/Sources/AppModels/Support/Misc.swift:178-184 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) AppPackage/Sources/AppFeature/UITestSupport/CaptureLiveText.swift:286 — AppPackage/Sources/AppFeature/UITestSupport/CaptureLiveText.swift:286-293 | AppPackage/Sources/AppModels/Support/AppActivityLog.swift:63-69 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) AppPackage/Sources/DownloadClient/DownloadClient+ResponseValidationHelpers.swift:306 — AppPackage/Sources/DownloadClient/DownloadClient+ResponseValidationHelpers.swift:306-312 | AppPackage/Sources/NetworkingFeature/Request.swift:24-30 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×3
  • Duplicated block (14 lines × 2) AppPackage/Sources/DetailFeature/Comments/CommentsView.swift:83 — AppPackage/Sources/DetailFeature/Comments/CommentsView.swift:83-96 | AppPackage/Sources/DetailFeature/DetailView.swift:233-246 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/Comments/CommentsView.swift:83` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (14 lines × 2) AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:179 — AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:179-192 | AppPackage/Sources/SearchFeature/SearchRootReducer.swift:142-160 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:179` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (14 lines × 2) AppPackage/Sources/GalleryListComponents/Cells/GalleryDetailCell.swift:237 — AppPackage/Sources/GalleryListComponents/Cells/GalleryDetailCell.swift:237-250 | AppPackage/Sources/GalleryListComponents/Cells/GalleryThumbnailCell.swift:64-77 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×3
  • Duplicated block (11 lines × 2) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:18 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:18-28 | AppPackage/Sources/SearchFeature/SearchView.swift:19-29 — before extracting anything, compare `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift` and `AppPackage/Sources/SearchFeature/SearchView.swift` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 64 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:18` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `store` to `StoreOf<DetailSearchReducer>` in one and `StoreOf<SearchReducer>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (11 lines × 2) AppPackage/Sources/SettingFeature/EhSetting/EhSettingView+Sections1.swift:318 — AppPackage/Sources/SettingFeature/EhSetting/EhSettingView+Sections1.swift:318-328 | AppPackage/Sources/SettingFeature/EhSetting/EhSettingView+Sections1.swift:332-342 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (11 lines × 2) AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:404 — AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:404-414 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:436-446 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:404` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D6 · Cohesion (LCOM4) · Low cohesion · ×3
  • Low cohesion: Array (LCOM4 11) AppPackage/Sources/AppTools/Extensions.swift:180 — Array's methods fall into 11 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 11 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: DFURLProtocol (LCOM4 6) AppPackage/Sources/NetworkingFeature/DFURLProtocol.swift:8 — DFURLProtocol's methods fall into 6 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 6 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
  • Low cohesion: StackState (LCOM4 4) AppPackage/Sources/DetailFeature/GalleryNavigation.swift:67 — StackState's methods fall into 4 groups that share no field and call none of each other, against a bar of more than 3 for this run (LCOM4, configurable — your repository's bar is the one quoted here). Each group is a set of methods reachable from one another through shared fields or direct calls, so 4 groups means the type has that many internally-connected clusters with nothing tying them together. Types whose shape makes a high count expected — and which would otherwise dominate this list — are excluded before this row is raised, so this is a genuine split candidate rather than a metric reading. It is still a shape, not a defect: confirm the groups match responsibilities you can name before splitting.
AC4 · Keyboard semantics · Link used as a button (placeholder href) · ×2
  • Link used as a button (placeholder href) AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:36 — An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
  • Link used as a button (placeholder href) REDACTED:14 — An <a href="#"> (or javascript:) with a click handler is a button dressed as a link — it announces the wrong role and stops working without JS. Use a <button> for an action.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D3 · God Classes · TooManyMethods · ×2
  • TooManyMethods: DownloadCoordinator AppPackage/Sources/DownloadClient/DownloadClient+Manager.swift:54 — TooManyMethods — 282 methods, declared across 32 files: DownloadClient/DownloadClient+Testing.swift (30), DownloadClient/DownloadClient+ResponseValidationHelpers.swift (24), DownloadClient/DownloadClient+Persistence.swift (17), DownloadClient/DownloadClient+Scheduling.swift (17), +28 more file(s). The bar is 30 methods; this is 252 over it, 9.40× the bar. That list is where to read them, not a suggestion to split the file: the members belong to the type wherever they are declared, so moving them between files leaves the count unchanged. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • TooManyMethods: DownloadStore AppPackage/Sources/DownloadClient/DownloadStore.swift:59 — TooManyMethods — 72 methods, declared across 3 files: DownloadClient/DownloadStore.swift (52), DownloadClient/DownloadStore+Operations.swift (18), DownloadClient/DownloadStore+JSONCoding.swift (2). The bar is 30 methods; this is 42 over it, 2.40× the bar. That list is where to read them, not a suggestion to split the file: the members belong to the type wherever they are declared, so moving them between files leaves the count unchanged. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D3 · God Classes · ClassTooLong · ×2
  • ClassTooLong: FullContentHost AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift:61 — ClassTooLong — 489 significant lines (blank, comment-only and punctuation-only lines excluded), 15 methods. The bar is 400 significant lines; this is 89 over it, 1.22× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
  • ClassTooLong: DownloadStore AppPackage/Sources/DownloadClient/DownloadStore.swift:59 — ClassTooLong — 424 significant lines (blank, comment-only and punctuation-only lines excluded), 72 methods. The bar is 400 significant lines; this is 24 over it, 1.06× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Edited copies of one member (3 members, 9+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 9+ corresponding lines) AppPackage/Sources/AppComponents/FlowLayout.swift:46 — AppPackage/Sources/AppComponents/FlowLayout.swift:46-59 | AppPackage/Sources/DetailFeature/HeaderActionsLayout.swift:9-17 | AppPackage/Sources/HomeFeature/GalleryCardLayout.swift:12-20 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 9+ corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Detail.swift:338 — AppPackage/Sources/NetworkingFeature/Request+Detail.swift:338-347 | AppPackage/Sources/NetworkingFeature/Request.swift:310-318 | AppPackage/Sources/NetworkingFeature/Request.swift:355-363 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×2
  • Edited copy of a member (15 corresponding lines) AppPackage/Sources/ReadingFeature/ReadingView.swift:483 — AppPackage/Sources/ReadingFeature/ReadingView.swift:483-498 | AppPackage/Sources/ReadingFeature/ReadingView.swift:503-517 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) AppPackage/Sources/HomeFeature/HomeView+Sections.swift:309 — AppPackage/Sources/HomeFeature/HomeView+Sections.swift:309-323 | AppPackage/Sources/HomeFeature/HomeView+Sections.swift:416-431 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (5 corresponding lines) · ×2
  • Edited copy of a member (5 corresponding lines) AppPackage/Sources/DetailFeature/GalleryNavigation.swift:75 — AppPackage/Sources/DetailFeature/GalleryNavigation.swift:75-80 | AppPackage/Sources/SettingFeature/SettingPath.swift:38-42 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) AppPackage/Sources/DownloadClient/DownloadClient+Execution.swift:249 — AppPackage/Sources/DownloadClient/DownloadClient+Execution.swift:249-255 | AppPackage/Sources/DownloadClient/DownloadClient+Scheduling.swift:331-335 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×2
  • Duplicated block (22 lines × 2) AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:140 — AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:140-161 | AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift:160-181 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:140` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (22 lines × 2) AppPackage/Sources/HomeFeature/HomeReducer+Body.swift:171 — AppPackage/Sources/HomeFeature/HomeReducer+Body.swift:171-192 | AppPackage/Sources/SearchFeature/SearchRootReducer.swift:170-191 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/HomeFeature/HomeReducer+Body.swift:171` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×2
  • Duplicated block (15 lines × 2) AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:319 — AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:319-333 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:368-382 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:319` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (15 lines × 2) AppPackage/Sources/ReadingFeature/Support/LiveTextHandler.swift:383 — AppPackage/Sources/ReadingFeature/Support/LiveTextHandler.swift:383-397 | AppPackage/Sources/ReadingFeature/Support/LiveTextHandler.swift:399-413 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×2
  • Duplicated block (14 lines × 3) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:150 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:150-163 | AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:136-149 | AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:182-195 — before extracting anything, compare `AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift` and `AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 135 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:150` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (14 lines × 3) AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift:74 — AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift:74-87 | AppPackage/Sources/HomeFeature/History/HistoryView.swift:58-71 | AppPackage/Sources/HomeFeature/Popular/PopularView.swift:52-65 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift:74` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×2
  • Duplicated block (13 lines × 2) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:74 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:74-86 | AppPackage/Sources/SearchFeature/SearchReducer.swift:86-98 — before extracting anything, compare `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift` and `AppPackage/Sources/SearchFeature/SearchReducer.swift` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:74` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (13 lines × 2) AppPackage/Sources/ReadingFeature/ReadingView.swift:486 — AppPackage/Sources/ReadingFeature/ReadingView.swift:486-498 | AppPackage/Sources/ReadingFeature/ReadingView.swift:505-517 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/ReadingFeature/ReadingView.swift:486` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×2
  • Duplicated block (12 lines × 2) AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:331 — AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:331-342 | AppPackage/Sources/HomeFeature/Toplists/ToplistsReducer.swift:217-228 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:331` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) AppPackage/Sources/SettingFeature/AccountSetting/AccountSettingView.swift:314 — AppPackage/Sources/SettingFeature/AccountSetting/AccountSettingView.swift:314-325 | AppPackage/Sources/SettingFeature/AccountSetting/AccountSettingView.swift:329-340 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (11 lines × 4) · ×2
  • Duplicated block (11 lines × 4) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:47 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:47-57 | AppPackage/Sources/FavoritesFeature/FavoritesView.swift:72-82 | AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:51-61 | AppPackage/Sources/SearchFeature/SearchView.swift:60-70 — before extracting anything, compare `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift` and `AppPackage/Sources/HomeFeature/Watched/WatchedView.swift` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:47` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `store` to `StoreOf<DetailSearchReducer>` in one and `store` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `AppPackage/Sources/FavoritesFeature/FavoritesView.swift:71` calls `toast`, `scope` and `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:46` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 4) AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:92 — AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:92-102 | AppPackage/Sources/HomeFeature/Popular/PopularReducer.swift:74-84 | AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:122-132 | AppPackage/Sources/SearchFeature/SearchReducer.swift:108-119 — before extracting anything, compare `AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift` and `AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 135 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:92` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7 lines × 4) · ×2
  • Duplicated block (7 lines × 4) AppPackage/Sources/AppComponents/RatingView.swift:17 — AppPackage/Sources/AppComponents/RatingView.swift:17-23 | AppPackage/Sources/AppComponents/RatingView.swift:24-30 | AppPackage/Sources/AppComponents/RatingView.swift:31-37 | AppPackage/Sources/AppComponents/RatingView.swift:38-44 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/AppComponents/RatingView.swift:17` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `AppPackage/Sources/AppComponents/RatingView.swift:23` calls `ForEach`, `FilledStar` and `AppPackage/Sources/AppComponents/RatingView.swift:16` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (7 lines × 4) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:46 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:46-52 | AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:48-54 | AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:49-55 | AppPackage/Sources/SearchFeature/SearchReducer.swift:53-59 — before extracting anything, compare `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift` and `AppPackage/Sources/SearchFeature/SearchReducer.swift` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×2
  • Duplicated block (5 lines × 2) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:288 — .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:288-292 | .planning/phases/18.1-native-report-form/18.1-copy-check.py:149-153 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `.planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:286` calls `get` and `.planning/phases/18.1-native-report-form/18.1-copy-check.py:147` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (5 lines × 2) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:572 — .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:572-576 | .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:653-657 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Edited copy of a member (2 corresponding lines) · ×2
  • Edited copy of a member (2 corresponding lines) Scripts/visual/capture-native.py:72 — Scripts/visual/capture-native.py:72-73 | Scripts/visual/record-live-text.py:52-53 — These two members are one piece of code written twice and then edited apart: 2 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (2 corresponding lines) Scripts/visual/environment.py:30 — Scripts/visual/environment.py:30-31 | Scripts/visual/fixtures.py:85-86 — These two members are one piece of code written twice and then edited apart: 2 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
AC3 · Page structure · Empty <h2> heading · ×1
  • Empty <h2> heading .planning/quick/261015-duo-session-record/proposal/index.html:21 — An empty heading appears in the document outline announced with no text. Give the heading text, or remove it if it's decorative.
D1 · Cyclomatic Complexity · AppReducer.body (cyclomatic 96) · ×1
  • AppReducer.body (cyclomatic 96) AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift:98 — AppReducer.body has cyclomatic complexity 96 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Parser.parseEhSetting (cyclomatic 92) · ×1
  • Parser.parseEhSetting (cyclomatic 92) AppPackage/Sources/ParserFeature/Parser+Profile.swift:24 — Parser.parseEhSetting has cyclomatic complexity 92 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ReadingReducer.imageFetchReducer (cyclomatic 77) · ×1
  • ReadingReducer.imageFetchReducer (cyclomatic 77) AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift:12 — ReadingReducer.imageFetchReducer has cyclomatic complexity 77 (threshold 15). Of this number, 71 points are the body's own statements and 6 belong to 2 function items inside it that branch. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DownloadsReducer.body (cyclomatic 66) · ×1
  • DownloadsReducer.body (cyclomatic 66) AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:172 — DownloadsReducer.body has cyclomatic complexity 66 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · DetailReducer.downloadReducer (cyclomatic 63) · ×1
  • DetailReducer.downloadReducer (cyclomatic 63) AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:16 — DetailReducer.downloadReducer has cyclomatic complexity 63 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · HomeReducer.reducerBody (cyclomatic 62) · ×1
  • HomeReducer.reducerBody (cyclomatic 62) AppPackage/Sources/HomeFeature/HomeReducer+Body.swift:13 — HomeReducer.reducerBody has cyclomatic complexity 62 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · FavoritesReducer.body (cyclomatic 61) · ×1
  • FavoritesReducer.body (cyclomatic 61) AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:130 — FavoritesReducer.body has cyclomatic complexity 61 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FullContentHost.capture (cyclomatic 56) · ×1
  • FullContentHost.capture (cyclomatic 56) AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift:170 — FullContentHost.capture has cyclomatic complexity 56 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · SettingReducer.reducerBody (cyclomatic 55) · ×1
  • SettingReducer.reducerBody (cyclomatic 55) AppPackage/Sources/SettingFeature/SettingReducer+Body.swift:16 — SettingReducer.reducerBody has cyclomatic complexity 55 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · DownloadInspectorReducer.body (cyclomatic 46) · ×1
  • DownloadInspectorReducer.body (cyclomatic 46) AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift:76 — DownloadInspectorReducer.body has cyclomatic complexity 46 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CommentsReducer.body (cyclomatic 44) · ×1
  • CommentsReducer.body (cyclomatic 44) AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift:105 — CommentsReducer.body has cyclomatic complexity 44 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · WatchedReducer.body (cyclomatic 43) · ×1
  • WatchedReducer.body (cyclomatic 43) AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:85 — WatchedReducer.body has cyclomatic complexity 43 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · SearchReducer.body (cyclomatic 39) · ×1
  • SearchReducer.body (cyclomatic 39) AppPackage/Sources/SearchFeature/SearchReducer.swift:86 — SearchReducer.body has cyclomatic complexity 39 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ReadingReducer.lifecycleReducer (cyclomatic 38) · ×1
  • ReadingReducer.lifecycleReducer (cyclomatic 38) AppPackage/Sources/ReadingFeature/ReadingReducer+Body.swift:63 — ReadingReducer.lifecycleReducer has cyclomatic complexity 38 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PresentationFeature.body (cyclomatic 36) · ×1
  • PresentationFeature.body (cyclomatic 36) AppPackage/Sources/AppFeature/DataFlow/PresentationFeature.swift:76 — PresentationFeature.body has cyclomatic complexity 36 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Parser.parseGalleryDetail (cyclomatic 36) · ×1
  • Parser.parseGalleryDetail (cyclomatic 36) AppPackage/Sources/ParserFeature/Parser+Detail.swift:14 — Parser.parseGalleryDetail has cyclomatic complexity 36 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · ToplistsReducer.body (cyclomatic 32) · ×1
  • ToplistsReducer.body (cyclomatic 32) AppPackage/Sources/HomeFeature/Toplists/ToplistsReducer.swift:91 — ToplistsReducer.body has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · UITestAutomation.resolve (cyclomatic 31) · ×1
  • UITestAutomation.resolve (cyclomatic 31) AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift:342 — UITestAutomation.resolve has cyclomatic complexity 31 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · FrontPageReducer.body (cyclomatic 31) · ×1
  • FrontPageReducer.body (cyclomatic 31) AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:77 — FrontPageReducer.body has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · PreviewsReducer.body (cyclomatic 30) · ×1
  • PreviewsReducer.body (cyclomatic 30) AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift:83 — PreviewsReducer.body has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DetailSearchReducer.body (cyclomatic 29) · ×1
  • DetailSearchReducer.body (cyclomatic 29) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:74 — DetailSearchReducer.body has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ReportFormFeature.body (cyclomatic 29) · ×1
  • ReportFormFeature.body (cyclomatic 29) AppPackage/Sources/DetailFeature/Moderation/ReportFormFeature.swift:255 — ReportFormFeature.body has cyclomatic complexity 29 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · HistoryReducer.body (cyclomatic 29) · ×1
  • HistoryReducer.body (cyclomatic 29) AppPackage/Sources/HomeFeature/History/HistoryReducer.swift:81 — HistoryReducer.body has cyclomatic complexity 29 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SearchRootReducer.body (cyclomatic 29) · ×1
  • SearchRootReducer.body (cyclomatic 29) AppPackage/Sources/SearchFeature/SearchRootReducer.swift:105 — SearchRootReducer.body has cyclomatic complexity 29 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · RenderServerCapture.slicePlan (cyclomatic 28) · ×1
  • RenderServerCapture.slicePlan (cyclomatic 28) AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift:296 — RenderServerCapture.slicePlan has cyclomatic complexity 28 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · DetailReducer.galleryOpsReducer (cyclomatic 27) · ×1
  • DetailReducer.galleryOpsReducer (cyclomatic 27) AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift:115 — DetailReducer.galleryOpsReducer has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ArchivesReducer.body (cyclomatic 27) · ×1
  • ArchivesReducer.body (cyclomatic 27) AppPackage/Sources/DetailFeature/Archives/ArchivesReducer.swift:48 — ArchivesReducer.body has cyclomatic complexity 27 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · Parser.parseThumbnailPanel (cyclomatic 27) · ×1
  • Parser.parseThumbnailPanel (cyclomatic 27) AppPackage/Sources/ParserFeature/Parser+List.swift:192 — Parser.parseThumbnailPanel has cyclomatic complexity 27 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · altstore_languages.check_screenshots (cyclomatic 27) · ×1
  • altstore_languages.check_screenshots (cyclomatic 27) actions-tool/altstore_languages.py:110 — altstore_languages.check_screenshots has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · pal_publish.publish (cyclomatic 27) · ×1
  • pal_publish.publish (cyclomatic 27) REDACTED:439 — pal_publish.publish has cyclomatic complexity 27 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FolderManagerReducer.body (cyclomatic 26) · ×1
  • FolderManagerReducer.body (cyclomatic 26) AppPackage/Sources/DetailFeature/FolderManager/FolderManagerReducer.swift:78 — FolderManagerReducer.body has cyclomatic complexity 26 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · Parser.parseGalleryTorrents (cyclomatic 26) · ×1
  • Parser.parseGalleryTorrents (cyclomatic 26) AppPackage/Sources/ParserFeature/Parser+Torrent.swift:8 — Parser.parseGalleryTorrents has cyclomatic complexity 26 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · EhSettingReducer.body (cyclomatic 25) · ×1
  • EhSettingReducer.body (cyclomatic 25) AppPackage/Sources/SettingFeature/EhSetting/EhSettingReducer.swift:71 — EhSettingReducer.body has cyclomatic complexity 25 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · DetailReducer.fetchReducer (cyclomatic 23) · ×1
  • DetailReducer.fetchReducer (cyclomatic 23) AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift:12 — DetailReducer.fetchReducer has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · 18-copy-check.check (cyclomatic 23) · ×1
  • 18-copy-check.check (cyclomatic 23) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:267 — 18-copy-check.check has cyclomatic complexity 23 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Parser.parseComments (cyclomatic 22) · ×1
  • Parser.parseComments (cyclomatic 22) AppPackage/Sources/ParserFeature/Parser+Comment.swift:9 — Parser.parseComments has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GeneralSettingReducer.body (cyclomatic 22) · ×1
  • GeneralSettingReducer.body (cyclomatic 22) AppPackage/Sources/SettingFeature/GeneralSetting/GeneralSettingReducer.swift:81 — GeneralSettingReducer.body has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · LoginReducer.body (cyclomatic 22) · ×1
  • LoginReducer.body (cyclomatic 22) AppPackage/Sources/SettingFeature/Login/LoginReducer.swift:122 — LoginReducer.body has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ReadLayout.init (cyclomatic 22) · ×1
  • ReadLayout.init (cyclomatic 22) AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift:387 — ReadLayout.init has cyclomatic complexity 22 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · release_notes.main (cyclomatic 20) · ×1
  • release_notes.main (cyclomatic 20) actions-tool/release_notes.py:246 — release_notes.main has cyclomatic complexity 20 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · UITestAutomation.prepare (cyclomatic 19) · ×1
  • UITestAutomation.prepare (cyclomatic 19) AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift:174 — UITestAutomation.prepare has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Parser.parseGreeting (cyclomatic 19) · ×1
  • Parser.parseGreeting (cyclomatic 19) AppPackage/Sources/ParserFeature/Parser+Greeting.swift:7 — Parser.parseGreeting has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · GalleryURLParser.parse (cyclomatic 18) · ×1
  • GalleryURLParser.parse (cyclomatic 18) AppPackage/Sources/AppTools/GalleryURLParser.swift:26 — GalleryURLParser.parse has cyclomatic complexity 18 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · GalleryPage.init (cyclomatic 18) · ×1
  • GalleryPage.init (cyclomatic 18) AppPackage/Sources/DetailFeature/Moderation/CommentReportTarget.swift:55 — GalleryPage.init has cyclomatic complexity 18 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D1 · Cyclomatic Complexity · TorrentsReducer.body (cyclomatic 18) · ×1
  • TorrentsReducer.body (cyclomatic 18) AppPackage/Sources/DetailFeature/Torrents/TorrentsReducer.swift:54 — TorrentsReducer.body has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · SubmitEhSettingChangesRequest.response (cyclomatic 18) · ×1
  • SubmitEhSettingChangesRequest.response (cyclomatic 18) AppPackage/Sources/NetworkingFeature/Request+Account.swift:331 — SubmitEhSettingChangesRequest.response has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Parser.parseBanInterval (cyclomatic 18) · ×1
  • Parser.parseBanInterval (cyclomatic 18) AppPackage/Sources/ParserFeature/Parser+Shared.swift:187 — Parser.parseBanInterval has cyclomatic complexity 18 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · 18-copy-check.build_expectations (cyclomatic 18) · ×1
  • 18-copy-check.build_expectations (cyclomatic 18) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:192 — 18-copy-check.build_expectations has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · 1-copy-check.parse_copy (cyclomatic 18) · ×1
  • 1-copy-check.parse_copy (cyclomatic 18) .planning/phases/18.1-native-report-form/18.1-copy-check.py:63 — 1-copy-check.parse_copy has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · 1-copy-check.check (cyclomatic 18) · ×1
  • 1-copy-check.check (cyclomatic 18) .planning/phases/18.1-native-report-form/18.1-copy-check.py:133 — 1-copy-check.check has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · altstore_languages.check_source (cyclomatic 18) · ×1
  • altstore_languages.check_source (cyclomatic 18) actions-tool/altstore_languages.py:188 — altstore_languages.check_source has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · View.liveTextTranslations (cyclomatic 17) · ×1
  • View.liveTextTranslations (cyclomatic 17) AppPackage/Sources/LiveTextTranslation/LiveTextTranslations.swift:7 — View.liveTextTranslations has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AppReducer.tabSelectionEffect (cyclomatic 17) · ×1
  • AppReducer.tabSelectionEffect (cyclomatic 17) AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift:558 — AppReducer.tabSelectionEffect has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · MarketingGalleries.download (cyclomatic 17) · ×1
  • MarketingGalleries.download (cyclomatic 17) AppPackage/Sources/AppFeature/UITestSupport/CaptureScenePreparation.swift:532 — MarketingGalleries.download has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · CookieClient.live (cyclomatic 17) · ×1
  • CookieClient.live (cyclomatic 17) AppPackage/Sources/CookieClient/CookieClient.swift:28 — CookieClient.live has cyclomatic complexity 17 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · CommentModerationFeature.body (cyclomatic 17) · ×1
  • CommentModerationFeature.body (cyclomatic 17) AppPackage/Sources/DetailFeature/Moderation/CommentModeration.swift:116 — CommentModerationFeature.body has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · Parser.parseInfoPanel (cyclomatic 17) · ×1
  • Parser.parseInfoPanel (cyclomatic 17) AppPackage/Sources/ParserFeature/Parser+Detail.swift:226 — Parser.parseInfoPanel has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · 18-copy-check.check_readmes (cyclomatic 17) · ×1
  • 18-copy-check.check_readmes (cyclomatic 17) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:355 — 18-copy-check.check_readmes has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Data.isAnimatedGIFFormat (cyclomatic 16) · ×1
  • Data.isAnimatedGIFFormat (cyclomatic 16) AppPackage/Sources/AnimatedImageFeature/AnimatedImage+.swift:117 — Data.isAnimatedGIFFormat has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · DetailView.content (cyclomatic 16) · ×1
  • DetailView.content (cyclomatic 16) AppPackage/Sources/DetailFeature/DetailView.swift:71 — DetailView.content has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · HomePrimaryNavigationView.body (cyclomatic 16) · ×1
  • HomePrimaryNavigationView.body (cyclomatic 16) AppPackage/Sources/HomeFeature/HomeNavigationView.swift:18 — HomePrimaryNavigationView.body has cyclomatic complexity 16 (threshold 15). To reduce it, separate the branches: extract each independent case into its own named function so the top-level body reads as a short sequence of named decisions.
D1 · Cyclomatic Complexity · LiveTextPaint.init (cyclomatic 16) · ×1
  • LiveTextPaint.init (cyclomatic 16) AppPackage/Sources/LiveTextTranslation/LiveTextBalloon.swift:320 — LiveTextPaint.init has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LiveTextBalloonRegion.init (cyclomatic 16) · ×1
  • LiveTextBalloonRegion.init (cyclomatic 16) AppPackage/Sources/LiveTextTranslation/LiveTextBalloon.swift:567 — LiveTextBalloonRegion.init has cyclomatic complexity 16 (threshold 15). Of this number, 11 points are the body's own statements and 5 belong to one function item inside it that branches. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D1 · Cyclomatic Complexity · Parser.parseGalleryTags (cyclomatic 16) · ×1
  • Parser.parseGalleryTags (cyclomatic 16) AppPackage/Sources/ParserFeature/Parser+List.swift:282 — Parser.parseGalleryTags has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · LiveTextHandler.polygonsIntersecting (cyclomatic 16) · ×1
  • LiveTextHandler.polygonsIntersecting (cyclomatic 16) AppPackage/Sources/ReadingFeature/Support/LiveTextHandler.swift:373 — LiveTextHandler.polygonsIntersecting has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · split_legacy_release_notes.main (cyclomatic 16) · ×1
  • split_legacy_release_notes.main (cyclomatic 16) actions-tool/split_legacy_release_notes.py:157 — split_legacy_release_notes.main has cyclomatic complexity 16 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D2 · Cognitive Complexity · Parser.parseEhSetting (cognitive 151) · ×1
  • Parser.parseEhSetting (cognitive 151) AppPackage/Sources/ParserFeature/Parser+Profile.swift:24 — Parser.parseEhSetting has cognitive complexity 151 (threshold 15). Drivers by points: if/else 48 (102 pts), boolean chains 37, loops 5 (9 pts), match/switch 1 (3 pts) (nesting depth added 60). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReadingReducer.imageFetchReducer (cognitive 114) · ×1
  • ReadingReducer.imageFetchReducer (cognitive 114) AppPackage/Sources/ReadingFeature/ReadingReducer+ImageFetch.swift:12 — ReadingReducer.imageFetchReducer has cognitive complexity 114 (threshold 15). Drivers by points: if/else 38 (81 pts), match/switch 7 (13 pts), boolean chains 11, ternaries 3 (9 pts) (nesting depth added 55). Of this number, 104 points are the body's own statements and 10 belong to 2 function items inside it that branch. The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · AppReducer.body (cognitive 99) · ×1
  • AppReducer.body (cognitive 99) AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift:98 — AppReducer.body has cognitive complexity 99 (threshold 15). Drivers by points: if/else 28 (54 pts), ternaries 10 (25 pts), boolean chains 13, match/switch 4 (7 pts) (nesting depth added 44). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DetailReducer.downloadReducer (cognitive 76) · ×1
  • DetailReducer.downloadReducer (cognitive 76) AppPackage/Sources/DetailFeature/DetailReducer+Download.swift:16 — DetailReducer.downloadReducer has cognitive complexity 76 (threshold 15). Drivers by points: if/else 30 (61 pts), match/switch 3 (7 pts), boolean chains 3, ternaries 1 (3 pts), loops 1 (2 pts) (nesting depth added 38). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · FavoritesReducer.body (cognitive 69) · ×1
  • FavoritesReducer.body (cognitive 69) AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:130 — FavoritesReducer.body has cognitive complexity 69 (threshold 15). Drivers by points: if/else 22 (51 pts), boolean chains 7, match/switch 4 (7 pts), loops 2 (4 pts) (nesting depth added 34). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · FullContentHost.capture (cognitive 68) · ×1
  • FullContentHost.capture (cognitive 68) AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift:170 — FullContentHost.capture has cognitive complexity 68 (threshold 15). Drivers by points: boolean chains 32, if/else 20 (30 pts), loops 3 (4 pts), ternaries 1 (2 pts) (nesting depth added 12). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · Parser.parseGalleryTorrents (cognitive 59) · ×1
  • Parser.parseGalleryTorrents (cognitive 59) AppPackage/Sources/ParserFeature/Parser+Torrent.swift:8 — Parser.parseGalleryTorrents has cognitive complexity 59 (threshold 15). Drivers by points: if/else 9 (40 pts), boolean chains 13, loops 3 (6 pts) (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 18-copy-check.check (cognitive 58) · ×1
  • 18-copy-check.check (cognitive 58) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:267 — 18-copy-check.check has cognitive complexity 58 (threshold 15). Drivers by points: if/else 15 (41 pts), loops 7 (15 pts), boolean chains 2 (nesting depth added 34). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DownloadInspectorReducer.body (cognitive 57) · ×1
  • DownloadInspectorReducer.body (cognitive 57) AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift:76 — DownloadInspectorReducer.body has cognitive complexity 57 (threshold 15). Drivers by points: if/else 20 (42 pts), boolean chains 8, match/switch 3 (5 pts), loops 1 (2 pts) (nesting depth added 25). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · HomeReducer.reducerBody (cognitive 54) · ×1
  • HomeReducer.reducerBody (cognitive 54) AppPackage/Sources/HomeFeature/HomeReducer+Body.swift:13 — HomeReducer.reducerBody has cognitive complexity 54 (threshold 15). Drivers by points: if/else 16 (34 pts), match/switch 8 (17 pts), ternaries 1 (3 pts) (nesting depth added 29). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Parser.parseComments (cognitive 54) · ×1
  • Parser.parseComments (cognitive 54) AppPackage/Sources/ParserFeature/Parser+Comment.swift:9 — Parser.parseComments has cognitive complexity 54 (threshold 15). Drivers by points: if/else 9 (38 pts), boolean chains 9, loops 3 (7 pts) (nesting depth added 33). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DownloadsReducer.body (cognitive 52) · ×1
  • DownloadsReducer.body (cognitive 52) AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:172 — DownloadsReducer.body has cognitive complexity 52 (threshold 15). Drivers by points: if/else 21 (40 pts), match/switch 4 (7 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 23). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · altstore_languages.check_screenshots (cognitive 48) · ×1
  • altstore_languages.check_screenshots (cognitive 48) actions-tool/altstore_languages.py:110 — altstore_languages.check_screenshots has cognitive complexity 48 (threshold 15). Drivers by points: if/else 13 (33 pts), boolean chains 9, loops 3 (6 pts) (nesting depth added 23). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · WatchedReducer.body (cognitive 45) · ×1
  • WatchedReducer.body (cognitive 45) AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:85 — WatchedReducer.body has cognitive complexity 45 (threshold 15). Drivers by points: if/else 12 (29 pts), match/switch 4 (7 pts), boolean chains 5, loops 2 (4 pts) (nesting depth added 22). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Parser.parseGalleryDetail (cognitive 45) · ×1
  • Parser.parseGalleryDetail (cognitive 45) AppPackage/Sources/ParserFeature/Parser+Detail.swift:14 — Parser.parseGalleryDetail has cognitive complexity 45 (threshold 15). Drivers by points: boolean chains 25, if/else 7 (11 pts), ternaries 4 (8 pts), loops 1 (nesting depth added 8). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · DetailReducer.fetchReducer (cognitive 41) · ×1
  • DetailReducer.fetchReducer (cognitive 41) AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift:12 — DetailReducer.fetchReducer has cognitive complexity 41 (threshold 15). Drivers by points: if/else 11 (30 pts), match/switch 3 (7 pts), boolean chains 4 (nesting depth added 23). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · 18-copy-check.check_readmes (cognitive 40) · ×1
  • 18-copy-check.check_readmes (cognitive 40) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:355 — 18-copy-check.check_readmes has cognitive complexity 40 (threshold 15). Drivers by points: if/else 10 (28 pts), loops 6 (12 pts) (nesting depth added 24). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SearchReducer.body (cognitive 39) · ×1
  • SearchReducer.body (cognitive 39) AppPackage/Sources/SearchFeature/SearchReducer.swift:86 — SearchReducer.body has cognitive complexity 39 (threshold 15). Drivers by points: if/else 11 (25 pts), match/switch 5 (9 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 19). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Parser.parseGreeting (cognitive 37) · ×1
  • Parser.parseGreeting (cognitive 37) AppPackage/Sources/ParserFeature/Parser+Greeting.swift:7 — Parser.parseGreeting has cognitive complexity 37 (threshold 15). Drivers by points: if/else 10 (26 pts), loops 4 (7 pts), match/switch 1 (3 pts), boolean chains 1 (nesting depth added 21). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · PresentationFeature.body (cognitive 36) · ×1
  • PresentationFeature.body (cognitive 36) AppPackage/Sources/AppFeature/DataFlow/PresentationFeature.swift:76 — PresentationFeature.body has cognitive complexity 36 (threshold 15). Drivers by points: if/else 14 (29 pts), match/switch 2 (3 pts), boolean chains 2, error handling 1 (2 pts) (nesting depth added 17). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ToplistsReducer.body (cognitive 36) · ×1
  • ToplistsReducer.body (cognitive 36) AppPackage/Sources/HomeFeature/Toplists/ToplistsReducer.swift:91 — ToplistsReducer.body has cognitive complexity 36 (threshold 15). Drivers by points: if/else 12 (26 pts), boolean chains 5, match/switch 3 (5 pts) (nesting depth added 16). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · ReadingReducer.lifecycleReducer (cognitive 35) · ×1
  • ReadingReducer.lifecycleReducer (cognitive 35) AppPackage/Sources/ReadingFeature/ReadingReducer+Body.swift:63 — ReadingReducer.lifecycleReducer has cognitive complexity 35 (threshold 15). Drivers by points: if/else 11 (21 pts), ternaries 2 (6 pts), boolean chains 4, match/switch 2 (4 pts) (nesting depth added 16). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · SettingReducer.reducerBody (cognitive 35) · ×1
  • SettingReducer.reducerBody (cognitive 35) AppPackage/Sources/SettingFeature/SettingReducer+Body.swift:16 — SettingReducer.reducerBody has cognitive complexity 35 (threshold 15). Drivers by points: if/else 10 (21 pts), error handling 3 (6 pts), match/switch 3 (5 pts), ternaries 1 (2 pts), boolean chains 1 (nesting depth added 17). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · pal_publish.publish (cognitive 35) · ×1
  • pal_publish.publish (cognitive 35) REDACTED:439 — pal_publish.publish has cognitive complexity 35 (threshold 15). Drivers by points: if/else 12 (18 pts), loops 6 (7 pts), ternaries 3 (5 pts), boolean chains 4, error handling 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppReducer.tabSelectionEffect (cognitive 34) · ×1
  • AppReducer.tabSelectionEffect (cognitive 34) AppPackage/Sources/AppFeature/DataFlow/AppReducer.swift:558 — AppReducer.tabSelectionEffect has cognitive complexity 34 (threshold 15). Drivers by points: if/else 13 (28 pts), match/switch 2 (5 pts), ternaries 1 (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UITestAutomation.resolve (cognitive 33) · ×1
  • UITestAutomation.resolve (cognitive 33) AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift:342 — UITestAutomation.resolve has cognitive complexity 33 (threshold 15). Drivers by points: boolean chains 20, if/else 9, ternaries 4. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · PreviewsReducer.body (cognitive 33) · ×1
  • PreviewsReducer.body (cognitive 33) AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift:83 — PreviewsReducer.body has cognitive complexity 33 (threshold 15). Drivers by points: if/else 12 (26 pts), match/switch 2 (3 pts), boolean chains 2, loops 1 (2 pts) (nesting depth added 16). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Parser.parseGalleryArchive (cognitive 33) · ×1
  • Parser.parseGalleryArchive (cognitive 33) AppPackage/Sources/ParserFeature/Parser+Archive.swift:7 — Parser.parseGalleryArchive has cognitive complexity 33 (threshold 15). Drivers by points: if/else 9 (26 pts), boolean chains 4, loops 2 (3 pts) (nesting depth added 18). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DetailSearchReducer.body (cognitive 32) · ×1
  • DetailSearchReducer.body (cognitive 32) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchReducer.swift:74 — DetailSearchReducer.body has cognitive complexity 32 (threshold 15). Drivers by points: if/else 9 (20 pts), match/switch 3 (5 pts), error handling 2 (4 pts), boolean chains 3 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FrontPageReducer.body (cognitive 32) · ×1
  • FrontPageReducer.body (cognitive 32) AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:77 — FrontPageReducer.body has cognitive complexity 32 (threshold 15). Drivers by points: if/else 9 (22 pts), match/switch 4 (7 pts), boolean chains 3 (nesting depth added 16). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · LiveTextHandler.polygonsIntersecting (cognitive 32) · ×1
  • LiveTextHandler.polygonsIntersecting (cognitive 32) AppPackage/Sources/ReadingFeature/Support/LiveTextHandler.swift:373 — LiveTextHandler.polygonsIntersecting has cognitive complexity 32 (threshold 15). Drivers by points: if/else 11 (23 pts), boolean chains 6, loops 2 (3 pts) (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · split_legacy_release_notes.main (cognitive 32) · ×1
  • split_legacy_release_notes.main (cognitive 32) actions-tool/split_legacy_release_notes.py:157 — split_legacy_release_notes.main has cognitive complexity 32 (threshold 15). Drivers by points: if/else 8 (17 pts), loops 4 (7 pts), ternaries 1 (4 pts), error handling 1 (3 pts), boolean chains 1 (nesting depth added 17). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LiveTextPaint.init (cognitive 31) · ×1
  • LiveTextPaint.init (cognitive 31) AppPackage/Sources/LiveTextTranslation/LiveTextBalloon.swift:320 — LiveTextPaint.init has cognitive complexity 31 (threshold 15). Drivers by points: if/else 8 (16 pts), loops 6 (13 pts), boolean chains 2 (nesting depth added 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Parser.parseThumbnailPanel (cognitive 31) · ×1
  • Parser.parseThumbnailPanel (cognitive 31) AppPackage/Sources/ParserFeature/Parser+List.swift:192 — Parser.parseThumbnailPanel has cognitive complexity 31 (threshold 15). Drivers by points: boolean chains 18, if/else 7 (12 pts), loops 1 (nesting depth added 5). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · 1-copy-check.check (cognitive 31) · ×1
  • 1-copy-check.check (cognitive 31) .planning/phases/18.1-native-report-form/18.1-copy-check.py:133 — 1-copy-check.check has cognitive complexity 31 (threshold 15). Drivers by points: if/else 9 (23 pts), loops 4 (6 pts), boolean chains 2 (nesting depth added 16). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · View.liveTextTranslations (cognitive 30) · ×1
  • View.liveTextTranslations (cognitive 30) AppPackage/Sources/LiveTextTranslation/LiveTextTranslations.swift:7 — View.liveTextTranslations has cognitive complexity 30 (threshold 15). Drivers by points: if/else 8 (19 pts), boolean chains 5, loops 2 (4 pts), error handling 1 (2 pts) (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Parser.parseInfoPanel (cognitive 30) · ×1
  • Parser.parseInfoPanel (cognitive 30) AppPackage/Sources/ParserFeature/Parser+Detail.swift:226 — Parser.parseInfoPanel has cognitive complexity 30 (threshold 15). Drivers by points: if/else 13 (27 pts), boolean chains 2, loops 1 (nesting depth added 14). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ArchivesReducer.body (cognitive 29) · ×1
  • ArchivesReducer.body (cognitive 29) AppPackage/Sources/DetailFeature/Archives/ArchivesReducer.swift:48 — ArchivesReducer.body has cognitive complexity 29 (threshold 15). Drivers by points: if/else 9 (17 pts), match/switch 4 (8 pts), boolean chains 2, ternaries 1 (2 pts) (nesting depth added 13). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · RenderServerCapture.slicePlan (cognitive 29) · ×1
  • RenderServerCapture.slicePlan (cognitive 29) AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift:296 — RenderServerCapture.slicePlan has cognitive complexity 29 (threshold 15). Drivers by points: boolean chains 20, if/else 5 (6 pts), ternaries 1 (2 pts), loops 1 (nesting depth added 2). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · CommentsReducer.body (cognitive 28) · ×1
  • CommentsReducer.body (cognitive 28) AppPackage/Sources/DetailFeature/Comments/CommentsReducer.swift:105 — CommentsReducer.body has cognitive complexity 28 (threshold 15). Drivers by points: if/else 9 (17 pts), match/switch 4 (7 pts), boolean chains 2, ternaries 1 (2 pts) (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · HistoryReducer.body (cognitive 28) · ×1
  • HistoryReducer.body (cognitive 28) AppPackage/Sources/HomeFeature/History/HistoryReducer.swift:81 — HistoryReducer.body has cognitive complexity 28 (threshold 15). Drivers by points: if/else 7 (18 pts), match/switch 3 (5 pts), boolean chains 3, loops 1 (2 pts) (nesting depth added 14). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · 1-copy-check.parse_copy (cognitive 28) · ×1
  • 1-copy-check.parse_copy (cognitive 28) .planning/phases/18.1-native-report-form/18.1-copy-check.py:63 — 1-copy-check.parse_copy has cognitive complexity 28 (threshold 15). Drivers by points: if/else 11 (20 pts), ternaries 2 (4 pts), boolean chains 3, loops 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Data.isAnimatedGIFFormat (cognitive 27) · ×1
  • Data.isAnimatedGIFFormat (cognitive 27) AppPackage/Sources/AnimatedImageFeature/AnimatedImage+.swift:117 — Data.isAnimatedGIFFormat has cognitive complexity 27 (threshold 15). Drivers by points: if/else 10 (22 pts), boolean chains 2, match/switch 1 (2 pts), loops 1 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReportFormFeature.body (cognitive 27) · ×1
  • ReportFormFeature.body (cognitive 27) AppPackage/Sources/DetailFeature/Moderation/ReportFormFeature.swift:255 — ReportFormFeature.body has cognitive complexity 27 (threshold 15). Drivers by points: if/else 9 (19 pts), boolean chains 3, match/switch 2 (3 pts), error handling 1 (2 pts) (nesting depth added 12). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · 18-copy-check.build_expectations (cognitive 27) · ×1
  • 18-copy-check.build_expectations (cognitive 27) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:192 — 18-copy-check.build_expectations has cognitive complexity 27 (threshold 15). Drivers by points: if/else 7 (15 pts), loops 10 (12 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · release_notes.parse (cognitive 27) · ×1
  • release_notes.parse (cognitive 27) actions-tool/release_notes.py:94 — release_notes.parse has cognitive complexity 27 (threshold 15). Drivers by points: if/else 12 (25 pts), loops 2 (nesting depth added 13). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Parser.parseMPVKeys (cognitive 26) · ×1
  • Parser.parseMPVKeys (cognitive 26) AppPackage/Sources/ParserFeature/Parser+Image.swift:51 — Parser.parseMPVKeys has cognitive complexity 26 (threshold 15). Drivers by points: if/else 6 (14 pts), error handling 2 (5 pts), boolean chains 4, loops 2 (3 pts) (nesting depth added 12). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UITestAutomation.prepare (cognitive 25) · ×1
  • UITestAutomation.prepare (cognitive 25) AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift:174 — UITestAutomation.prepare has cognitive complexity 25 (threshold 15). Drivers by points: if/else 10 (17 pts), boolean chains 7, error handling 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · 18-copy-check.self_test (cognitive 25) · ×1
  • 18-copy-check.self_test (cognitive 25) .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:441 — 18-copy-check.self_test has cognitive complexity 25 (threshold 15). Drivers by points: if/else 5 (10 pts), loops 5 (9 pts), boolean chains 3, ternaries 2 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · altstore_languages.check_source (cognitive 25) · ×1
  • altstore_languages.check_source (cognitive 25) actions-tool/altstore_languages.py:188 — altstore_languages.check_source has cognitive complexity 25 (threshold 15). Drivers by points: if/else 6 (12 pts), loops 4 (6 pts), boolean chains 4, ternaries 1 (3 pts) (nesting depth added 10). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DetailReducer.galleryOpsReducer (cognitive 24) · ×1
  • DetailReducer.galleryOpsReducer (cognitive 24) AppPackage/Sources/DetailFeature/DetailReducer+Fetch.swift:115 — DetailReducer.galleryOpsReducer has cognitive complexity 24 (threshold 15). Drivers by points: if/else 9 (17 pts), boolean chains 4, match/switch 2 (3 pts) (nesting depth added 9). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · Parser.parseGalleryTags (cognitive 24) · ×1
  • Parser.parseGalleryTags (cognitive 24) AppPackage/Sources/ParserFeature/Parser+List.swift:282 — Parser.parseGalleryTags has cognitive complexity 24 (threshold 15). Drivers by points: if/else 7 (15 pts), boolean chains 8, loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Parser.parseBanInterval (cognitive 24) · ×1
  • Parser.parseBanInterval (cognitive 24) AppPackage/Sources/ParserFeature/Parser+Shared.swift:187 — Parser.parseBanInterval has cognitive complexity 24 (threshold 15). Drivers by points: if/else 11 (14 pts), boolean chains 10 (nesting depth added 3). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · LiveTextBalloonRegion.init (cognitive 23) · ×1
  • LiveTextBalloonRegion.init (cognitive 23) AppPackage/Sources/LiveTextTranslation/LiveTextBalloon.swift:567 — LiveTextBalloonRegion.init has cognitive complexity 23 (threshold 15). Drivers by points: loops 8 (12 pts), if/else 2 (6 pts), boolean chains 4, ternaries 1 (nesting depth added 8). Of this number, 12 points are the body's own statements and 11 belong to one function item inside it that branches. To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · LoginReducer.body (cognitive 23) · ×1
  • LoginReducer.body (cognitive 23) AppPackage/Sources/SettingFeature/Login/LoginReducer.swift:122 — LoginReducer.body has cognitive complexity 23 (threshold 15). Drivers by points: if/else 9 (16 pts), boolean chains 3, ternaries 1 (3 pts), match/switch 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RenderServerCapture.capture (cognitive 22) · ×1
  • RenderServerCapture.capture (cognitive 22) AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift:147 — RenderServerCapture.capture has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (14 pts), loops 3 (6 pts), boolean chains 1, ternaries 1 (nesting depth added 11). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ReadLayout.init (cognitive 22) · ×1
  • ReadLayout.init (cognitive 22) AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift:387 — ReadLayout.init has cognitive complexity 22 (threshold 15). Drivers by points: boolean chains 14, if/else 6 (7 pts), loops 1 (nesting depth added 1). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · Client.request (cognitive 22) · ×1
  • Client.request (cognitive 22) REDACTED:174 — Client.request has cognitive complexity 22 (threshold 15). Drivers by points: if/else 6 (11 pts), error handling 2 (4 pts), boolean chains 3, ternaries 2 (3 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CapturedRaster.artworkFrame (cognitive 21) · ×1
  • CapturedRaster.artworkFrame (cognitive 21) AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift:507 — CapturedRaster.artworkFrame has cognitive complexity 21 (threshold 15). Drivers by points: if/else 7 (13 pts), boolean chains 5, loops 2 (3 pts) (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CookieClient.live (cognitive 20) · ×1
  • CookieClient.live (cognitive 20) AppPackage/Sources/CookieClient/CookieClient.swift:28 — CookieClient.live has cognitive complexity 20 (threshold 15). Drivers by points: if/else 14 (16 pts), boolean chains 3, loops 1 (nesting depth added 2). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · SubmitEhSettingChangesRequest.response (cognitive 20) · ×1
  • SubmitEhSettingChangesRequest.response (cognitive 20) AppPackage/Sources/NetworkingFeature/Request+Account.swift:331 — SubmitEhSettingChangesRequest.response has cognitive complexity 20 (threshold 15). Drivers by points: ternaries 5 (9 pts), if/else 6, loops 3, error handling 1, match/switch 1 (nesting depth added 4). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · HostedWindowCapture.settle (cognitive 20) · ×1
  • HostedWindowCapture.settle (cognitive 20) AppPackage/Sources/VisualSnapshotSupport/HostedWindowCapture.swift:201 — HostedWindowCapture.settle has cognitive complexity 20 (threshold 15). Drivers by points: if/else 4 (8 pts), ternaries 2 (5 pts), boolean chains 4, error handling 1 (2 pts), loops 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · pal_publish.bundle_facts (cognitive 20) · ×1
  • pal_publish.bundle_facts (cognitive 20) REDACTED:283 — pal_publish.bundle_facts has cognitive complexity 20 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 3, ternaries 1 (2 pts), boolean chains 1 (nesting depth added 8). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GalleryURLParser.parse (cognitive 19) · ×1
  • GalleryURLParser.parse (cognitive 19) AppPackage/Sources/AppTools/GalleryURLParser.swift:26 — GalleryURLParser.parse has cognitive complexity 19 (threshold 15). Drivers by points: boolean chains 10, if/else 7 (8 pts), match/switch 1 (nesting depth added 1). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · DFStreamEventHandler.endEncountered (cognitive 19) · ×1
  • DFStreamEventHandler.endEncountered (cognitive 19) AppPackage/Sources/NetworkingFeature/DFStreamHandler.swift:122 — DFStreamEventHandler.endEncountered has cognitive complexity 19 (threshold 15). Drivers by points: if/else 9 (12 pts), boolean chains 7 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ControlPanel.body (cognitive 19) · ×1
  • ControlPanel.body (cognitive 19) AppPackage/Sources/ReadingFeature/Support/ControlPanel.swift:56 — ControlPanel.body has cognitive complexity 19 (threshold 15). Drivers by points: ternaries 8 (16 pts), if/else 2 (3 pts) (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DownloadCoordinator.downloadPage (cognitive 18) · ×1
  • DownloadCoordinator.downloadPage (cognitive 18) AppPackage/Sources/DownloadClient/DownloadClient+PageDownloadHelpers.swift:6 — DownloadCoordinator.downloadPage has cognitive complexity 18 (threshold 15). Drivers by points: if/else 4 (10 pts), error handling 3 (6 pts), loops 1, ternaries 1 (nesting depth added 9). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · DownloadStore.pageFileScan (cognitive 18) · ×1
  • DownloadStore.pageFileScan (cognitive 18) AppPackage/Sources/DownloadClient/DownloadStore.swift:216 — DownloadStore.pageFileScan has cognitive complexity 18 (threshold 15). Drivers by points: if/else 6 (11 pts), boolean chains 4, match/switch 1 (2 pts), loops 1 (nesting depth added 6). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · CaptureFixture.load (cognitive 17) · ×1
  • CaptureFixture.load (cognitive 17) AppPackage/Sources/AppFeature/UITestSupport/CaptureFixtureManifest.swift:217 — CaptureFixture.load has cognitive complexity 17 (threshold 15). Drivers by points: if/else 3 (6 pts), loops 3 (6 pts), ternaries 1 (3 pts), boolean chains 1, match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · MarketingGalleries.download (cognitive 17) · ×1
  • MarketingGalleries.download (cognitive 17) AppPackage/Sources/AppFeature/UITestSupport/CaptureScenePreparation.swift:532 — MarketingGalleries.download has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (9 pts), boolean chains 4, ternaries 2, loops 1, match/switch 1 (nesting depth added 3). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GalleryPage.init (cognitive 17) · ×1
  • GalleryPage.init (cognitive 17) AppPackage/Sources/DetailFeature/Moderation/CommentReportTarget.swift:55 — GalleryPage.init has cognitive complexity 17 (threshold 15). Drivers by points: boolean chains 15, if/else 2. To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
D2 · Cognitive Complexity · ImageColors.accentColors (cognitive 17) · ×1
  • ImageColors.accentColors (cognitive 17) AppPackage/Sources/ImageColors/ImageColors.swift:108 — ImageColors.accentColors has cognitive complexity 17 (threshold 15). Drivers by points: if/else 6 (13 pts), boolean chains 3, loops 1 (nesting depth added 7). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AppActivityLogsPumpReducer.body (cognitive 17) · ×1
  • AppActivityLogsPumpReducer.body (cognitive 17) AppPackage/Sources/SettingFeature/AppActivityLogs/AppActivityLogsPumpReducer.swift:56 — AppActivityLogsPumpReducer.body has cognitive complexity 17 (threshold 15). Drivers by points: if/else 7 (14 pts), loops 1 (2 pts), match/switch 1 (nesting depth added 8). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · 1-copy-check.self_test (cognitive 17) · ×1
  • 1-copy-check.self_test (cognitive 17) .planning/phases/18.1-native-report-form/18.1-copy-check.py:216 — 1-copy-check.self_test has cognitive complexity 17 (threshold 15). Drivers by points: if/else 4 (6 pts), boolean chains 4, loops 2 (4 pts), ternaries 2 (3 pts) (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GalleryCardCell.body (cognitive 16) · ×1
  • GalleryCardCell.body (cognitive 16) AppPackage/Sources/HomeFeature/GalleryCardCell.swift:63 — GalleryCardCell.body has cognitive complexity 16 (threshold 15). Drivers by points: ternaries 5 (9 pts), if/else 5 (6 pts), boolean chains 1 (nesting depth added 5). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · LiveTextBalloon.paint (cognitive 16) · ×1
  • LiveTextBalloon.paint (cognitive 16) AppPackage/Sources/LiveTextTranslation/LiveTextBalloon.swift:166 — LiveTextBalloon.paint has cognitive complexity 16 (threshold 15). Drivers by points: loops 4 (10 pts), if/else 2 (4 pts), boolean chains 2 (nesting depth added 8). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
D2 · Cognitive Complexity · LiveTextBalloonFinder.flood (cognitive 16) · ×1
  • LiveTextBalloonFinder.flood (cognitive 16) AppPackage/Sources/LiveTextTranslation/LiveTextBalloon.swift:486 — LiveTextBalloonFinder.flood has cognitive complexity 16 (threshold 15). Drivers by points: if/else 5 (9 pts), boolean chains 5, loops 1, ternaries 1 (nesting depth added 4). Of this number, 14 points are the body's own statements and 2 belong to one function item inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EhSettingReducer.body (cognitive 16) · ×1
  • EhSettingReducer.body (cognitive 16) AppPackage/Sources/SettingFeature/EhSetting/EhSettingReducer.swift:71 — EhSettingReducer.body has cognitive complexity 16 (threshold 15). Drivers by points: if/else 4 (8 pts), match/switch 4 (7 pts), boolean chains 1 (nesting depth added 7). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D3 · God Classes · FunctionTooLong · ×1
  • FunctionTooLong: DetailView+Subviews.swift.top-level code AppPackage/Sources/DetailFeature/DetailView+Subviews.swift:243 — FunctionTooLong — top-level code runs 151 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 51 over it, 1.51× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D35 · Change Coupling · Change coupling clique · ×1
  • Change coupling clique: GalleryThumbnailCell.swift, GalleryCardCell.swift, GalleryRankingCell.swift, GalleryHistoryCell.swift AppPackage/Sources/GalleryListComponents/Cells/GalleryThumbnailCell.swift — 4 files — `AppPackage/Sources/GalleryListComponents/Cells/GalleryThumbnailCell.swift`, `AppPackage/Sources/HomeFeature/GalleryCardCell.swift`, `AppPackage/Sources/HomeFeature/GalleryRankingCell.swift`, `AppPackage/Sources/SearchFeature/GalleryHistoryCell.swift` — all change together with no explicit dependency: a fully-connected co-change clique, not 6 separate couplings. They share one concern (thin parallel siblings over a common abstraction), so extract the shared part into ONE unit and the whole clique's coupling clears at once — you do not need to break each pair individually.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D4 · Code Duplication · Edited copy of a member (39 corresponding lines) · ×1
  • Edited copy of a member (39 corresponding lines) AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:22 — AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:22-63 | AppPackage/Sources/SearchFeature/SearchView.swift:19-72 — These two members are one piece of code written twice and then edited apart: 39 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (5 members, 50+ identical tokens) .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:100 — .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:100-107 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift:102-109 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/NeverOnlyProbe.swift:101-108 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/probe/CustomArrowProbe.swift:100-107 | AppPackage/Sources/AppComponents/LibraryTitleMenuIndicator.swift:8-15 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication · Edited copy of a member (42 corresponding lines) · ×1
  • Edited copy of a member (42 corresponding lines) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:18 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:18-59 | AppPackage/Sources/SearchFeature/SearchView.swift:19-72 — These two members are one piece of code written twice and then edited apart: 42 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (45 corresponding lines) · ×1
  • Edited copy of a member (45 corresponding lines) AppPackage/Sources/AppModels/Persistent/Filter.swift:5 — AppPackage/Sources/AppModels/Persistent/Filter.swift:5-49 | AppPackage/Sources/AppModels/Persistent/Setting.swift:7-55 — These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 23+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 23+ corresponding lines) AppPackage/Sources/GalleryListComponents/GalleryList.swift:27 — AppPackage/Sources/GalleryListComponents/GalleryList.swift:27-57 | AppPackage/Sources/GalleryListComponents/GalleryList.swift:130-152 | AppPackage/Sources/GalleryListComponents/GalleryList.swift:223-247 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 23 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 38+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 38+ corresponding lines) AppPackage/Sources/GalleryListComponents/Cells/GalleryDetailCell.swift:328 — AppPackage/Sources/GalleryListComponents/Cells/GalleryDetailCell.swift:328-365 | AppPackage/Sources/HomeFeature/GalleryRankingCell.swift:106-150 | AppPackage/Sources/SearchFeature/GalleryHistoryCell.swift:73-114 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 38 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (32 corresponding lines) · ×1
  • Edited copy of a member (32 corresponding lines) AppPackage/Sources/DownloadClient/DownloadClient+Execution.swift:399 — AppPackage/Sources/DownloadClient/DownloadClient+Execution.swift:399-430 | AppPackage/Sources/DownloadClient/DownloadClient+WholesaleAbsenceEvidence.swift:72-103 — These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (19 corresponding lines) · ×1
  • Edited copy of a member (19 corresponding lines) AppPackage/Sources/HomeFeature/History/HistoryView.swift:19 — AppPackage/Sources/HomeFeature/History/HistoryView.swift:19-40 | AppPackage/Sources/HomeFeature/Toplists/ToplistsView.swift:22-40 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (21 corresponding lines) · ×1
  • Edited copy of a member (21 corresponding lines) AppPackage/Sources/DetailFeature/Comments/CommentsView.swift:205 — AppPackage/Sources/DetailFeature/Comments/CommentsView.swift:205-225 | AppPackage/Sources/DetailFeature/DetailView+Subviews.swift:702-722 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (17 corresponding lines) · ×1
  • Edited copy of a member (17 corresponding lines) AppPackage/Sources/AppComponents/CheckboxToggleStyle.swift:38 — AppPackage/Sources/AppComponents/CheckboxToggleStyle.swift:38-54 | AppPackage/Sources/AppComponents/ChoiceCard.swift:49-69 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (7 members, 16+ corresponding lines) · ×1
  • Edited copies of one member (7 members, 16+ corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:25 — AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:25-41 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:64-80 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:97-112 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:129-145 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:165-181 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:228-244 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:267-288 — These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 13+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 13+ corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:311 — AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:311-333 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:359-382 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:402-414 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:434-446 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (30 corresponding lines) · ×1
  • Edited copy of a member (30 corresponding lines) AppPackage/Sources/DownloadClient/DownloadClient+Networking.swift:24 — AppPackage/Sources/DownloadClient/DownloadClient+Networking.swift:24-53 | AppPackage/Sources/DownloadClient/DownloadClient+Networking.swift:93-129 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×1
  • Edited copy of a member (13 corresponding lines) AppPackage/Sources/AppComponents/ViewModifiers.swift:81 — AppPackage/Sources/AppComponents/ViewModifiers.swift:81-93 | AppPackage/Sources/AppComponents/ViewModifiers.swift:95-107 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (31 corresponding lines) · ×1
  • Edited copy of a member (31 corresponding lines) AppPackage/Sources/DownloadClient/DownloadClient+ResponseValidation.swift:75 — AppPackage/Sources/DownloadClient/DownloadClient+ResponseValidation.swift:75-109 | AppPackage/Sources/DownloadClient/DownloadClient+ResponseValidation.swift:188-218 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×1
  • Edited copy of a member (18 corresponding lines) AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:89 — AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:89-106 | AppPackage/Sources/SearchFeature/SearchView.swift:74-91 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 14+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 14+ corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Account.swift:467 — AppPackage/Sources/NetworkingFeature/Request+Account.swift:467-480 | AppPackage/Sources/NetworkingFeature/Request+Account.swift:575-588 | AppPackage/Sources/NetworkingFeature/Request+Account.swift:608-621 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (10 corresponding lines) · ×1
  • Edited copy of a member (10 corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:198 — AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:198-208 | AppPackage/Sources/NetworkingFeature/Request.swift:332-341 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 10+ corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Image.swift:38 — AppPackage/Sources/NetworkingFeature/Request+Image.swift:38-47 | AppPackage/Sources/NetworkingFeature/Request+Image.swift:67-79 | AppPackage/Sources/NetworkingFeature/Request.swift:332-341 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 15+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 15+ corresponding lines) AppPackage/Sources/GalleryListComponents/Cells/GalleryDetailCell.swift:333 — AppPackage/Sources/GalleryListComponents/Cells/GalleryDetailCell.swift:333-347 | AppPackage/Sources/HomeFeature/GalleryCardCell.swift:289-303 | AppPackage/Sources/HomeFeature/GalleryRankingCell.swift:111-125 | AppPackage/Sources/SearchFeature/GalleryHistoryCell.swift:78-92 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 17+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 17+ corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Account.swift:518 — AppPackage/Sources/NetworkingFeature/Request+Account.swift:518-534 | AppPackage/Sources/NetworkingFeature/Request+Account.swift:625-643 | AppPackage/Sources/NetworkingFeature/Request+Account.swift:713-731 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 17 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (5 members, 9+ corresponding lines) · ×1
  • Edited copies of one member (5 members, 9+ corresponding lines) AppPackage/Sources/NetworkingFeature/Request+Account.swift:236 — AppPackage/Sources/NetworkingFeature/Request+Account.swift:236-244 | AppPackage/Sources/NetworkingFeature/Request+Account.swift:306-314 | AppPackage/Sources/NetworkingFeature/Request+Detail.swift:338-347 | AppPackage/Sources/NetworkingFeature/Request.swift:310-318 | AppPackage/Sources/NetworkingFeature/Request.swift:355-363 — These 5 members are one piece of code written 5 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 5 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 6+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 6+ corresponding lines) AppPackage/Sources/AppFeature/UITestSupport/CaptureLiveText.swift:217 — AppPackage/Sources/AppFeature/UITestSupport/CaptureLiveText.swift:217-222 | AppPackage/Sources/AppFeature/UITestSupport/CaptureLiveText.swift:226-231 | AppPackage/Sources/AppFeature/UITestSupport/CaptureLiveText.swift:248-253 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (6 corresponding lines) · ×1
  • Edited copy of a member (6 corresponding lines) AppPackage/Sources/DetailFeature/DetailView+HeaderSection.swift:101 — AppPackage/Sources/DetailFeature/DetailView+HeaderSection.swift:101-106 | AppPackage/Sources/GalleryListComponents/Cells/GalleryThumbnailCell.swift:174-179 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (8 corresponding lines) · ×1
  • Edited copy of a member (8 corresponding lines) AppPackage/Sources/AppFeature/FirstLaunch/FirstLaunchGateView.swift:126 — AppPackage/Sources/AppFeature/FirstLaunch/FirstLaunchGateView.swift:126-135 | AppPackage/Sources/SettingFeature/BlockedUsers/BlockedUsersView.swift:93-100 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 3+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 3+ corresponding lines) AppPackage/Sources/AnalyticsClient/InstallSignalSender.swift:184 — AppPackage/Sources/AnalyticsClient/InstallSignalSender.swift:184-188 | AppPackage/Sources/AppFeature/UITestSupport/CaptureFixtureManifest.swift:283-285 | AppPackage/Sources/VisualSnapshotSupport/PublicVisualFixtures.swift:253-255 | AppPackage/Sources/VisualSnapshotSupport/RenderServerCapture.swift:272-274 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 3 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 4+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 4+ corresponding lines) AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:36 — AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:36-39 | AppPackage/Sources/HomeFeature/History/HistoryReducer.swift:43-46 | AppPackage/Sources/HomeFeature/Popular/PopularReducer.swift:33-36 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 4 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Duplicated block (40 lines × 3) · ×1
  • Duplicated block (40 lines × 3) AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:185 — AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:185-224 | AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:246-285 | AppPackage/Sources/SearchFeature/SearchReducer.swift:253-292 — before extracting anything, compare `AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift` and `AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 135 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:185` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (7–34 lines × 2) · ×1
  • Duplicated block (7–34 lines × 2) AppPackage/Sources/DownloadClient/DownloadClient+Folders.swift:122 — AppPackage/Sources/DownloadClient/DownloadClient+Folders.swift:122-128 | AppPackage/Sources/DownloadClient/DownloadClient+Folders.swift:207-240 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DownloadClient/DownloadClient+Folders.swift:207` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (27–32 lines × 2) · ×1
  • Duplicated block (27–32 lines × 2) AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:120 — AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:120-146 | AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:161-192 — before extracting anything, compare `AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift` and `AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 135 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:120` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (30 lines × 3) · ×1
  • Duplicated block (30 lines × 3) AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:156 — AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:156-185 | AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:203-232 | AppPackage/Sources/SearchFeature/SearchReducer.swift:210-239 — before extracting anything, compare `AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift` and `AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 135 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:156` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (23–28 lines × 2) · ×1
  • Duplicated block (23–28 lines × 2) AppPackage/Sources/HomeFeature/HomeReducer+Body.swift:61 — AppPackage/Sources/HomeFeature/HomeReducer+Body.swift:61-83 | AppPackage/Sources/SearchFeature/SearchRootReducer.swift:133-160 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (26 lines × 2) · ×1
  • Duplicated block (26 lines × 2) AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:77 — AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:77-102 | AppPackage/Sources/HomeFeature/Popular/PopularReducer.swift:59-84 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/HomeFeature/FrontPage/FrontPageReducer.swift:77` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (25 lines × 4) · ×1
  • Duplicated block (25 lines × 4) .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:16 — .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:16-40 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift:16-40 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/NeverOnlyProbe.swift:16-40 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/probe/CustomArrowProbe.swift:16-40 — before extracting anything, compare `.planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift` and `.planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (24 lines × 2) · ×1
  • Duplicated block (24 lines × 2) AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:134 — AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:134-157 | AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:88-111 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:134` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (21 lines × 4) · ×1
  • Duplicated block (21 lines × 4) .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:73 — .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:73-93 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift:75-95 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/NeverOnlyProbe.swift:74-94 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/probe/CustomArrowProbe.swift:73-93 — before extracting anything, compare `.planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift` and `.planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (18–19 lines × 2) · ×1
  • Duplicated block (18–19 lines × 2) AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift:233 — AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift:233-250 | AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:395-413 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift:233` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift:251` calls `send` and `AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:414` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (18 lines × 3) · ×1
  • Duplicated block (18 lines × 3) AppPackage/Sources/HomeFeature/History/HistoryReducer.swift:210 — AppPackage/Sources/HomeFeature/History/HistoryReducer.swift:210-227 | AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:229-246 | AppPackage/Sources/SearchFeature/SearchReducer.swift:236-253 — before extracting anything, compare `AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift` and `AppPackage/Sources/SearchFeature/SearchReducer.swift` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 115 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/HomeFeature/History/HistoryReducer.swift:210` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (18 lines × 2) · ×1
  • Duplicated block (18 lines × 2) .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:50 — .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:50-67 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/probe/CustomArrowProbe.swift:50-67 — before extracting anything, compare `.planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift` and `.planning/quick/261015-duo-session-record/evidence/library-title-matrix/probe/CustomArrowProbe.swift` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 81 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `.planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:50` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 3) · ×1
  • Duplicated block (17 lines × 3) AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift:35 — AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift:35-51 | AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:34-50 | AppPackage/Sources/SearchFeature/SearchView.swift:43-59 — before extracting anything, compare `AppPackage/Sources/HomeFeature/Watched/WatchedView.swift` and `AppPackage/Sources/SearchFeature/SearchView.swift` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 71 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift:35` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `store` to `StoreOf<FrontPageReducer>` in one and `StoreOf<WatchedReducer>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×1
  • Duplicated block (17 lines × 2) AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift:124 — AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift:124-140 | AppPackage/Sources/ReadingFeature/ReadingReducer+Session.swift:115-131 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (13–17 lines × 2) · ×1
  • Duplicated block (13–17 lines × 2) AppPackage/Sources/HomeFeature/GalleryCardCell.swift:309 — AppPackage/Sources/HomeFeature/GalleryCardCell.swift:309-321 | AppPackage/Sources/HomeFeature/GalleryCardCell.swift:329-345 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/HomeFeature/GalleryCardCell.swift:309` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (15–16 lines × 3) · ×1
  • Duplicated block (15–16 lines × 3) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:31 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:31-46 | AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:25-39 | AppPackage/Sources/SearchFeature/SearchView.swift:33-48 — before extracting anything, compare `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift` and `AppPackage/Sources/HomeFeature/Watched/WatchedView.swift` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:31` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `store` to `StoreOf<DetailSearchReducer>` in one and `StoreOf<WatchedReducer>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (14 lines × 7) · ×1
  • Duplicated block (14 lines × 7) AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:28 — AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:28-41 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:67-80 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:99-112 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:132-145 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:168-181 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:231-244 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:275-288 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:28` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:65` calls `moreSearchList` and `AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:97` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (13–14 lines × 3) · ×1
  • Duplicated block (13–14 lines × 3) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:45 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:45-57 | AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:48-61 | AppPackage/Sources/SearchFeature/SearchView.swift:57-70 — before extracting anything, compare `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift` and `AppPackage/Sources/HomeFeature/Watched/WatchedView.swift` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 41 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:45` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `store` to `StoreOf<DetailSearchReducer>` in one and `StoreOf<WatchedReducer>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (13 lines × 4) · ×1
  • Duplicated block (13 lines × 4) AppPackage/Sources/FavoritesFeature/FavoritesView.swift:54 — AppPackage/Sources/FavoritesFeature/FavoritesView.swift:54-66 | AppPackage/Sources/HomeFeature/FrontPage/FrontPageView.swift:39-51 | AppPackage/Sources/HomeFeature/Watched/WatchedView.swift:38-50 | AppPackage/Sources/SearchFeature/SearchView.swift:47-59 — before extracting anything, compare `AppPackage/Sources/FavoritesFeature/FavoritesView.swift` and `AppPackage/Sources/HomeFeature/Watched/WatchedView.swift` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 31 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/FavoritesFeature/FavoritesView.swift:54` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `store` to `store` in one and `StoreOf<FrontPageReducer>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (13 lines × 3) · ×1
  • Duplicated block (13 lines × 3) AppPackage/Sources/ParserFeature/Parser+List.swift:102 — AppPackage/Sources/ParserFeature/Parser+List.swift:102-114 | AppPackage/Sources/ParserFeature/Parser+List.swift:135-147 | AppPackage/Sources/ParserFeature/Parser+List.swift:166-178 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/ParserFeature/Parser+List.swift:102` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `AppPackage/Sources/ParserFeature/Parser+List.swift:116` calls `degrading`, `parseUploader` and `AppPackage/Sources/ParserFeature/Parser+List.swift:148` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (10–12 lines × 4) · ×1
  • Duplicated block (10–12 lines × 4) AppPackage/Sources/ParserFeature/Parser+List.swift:68 — AppPackage/Sources/ParserFeature/Parser+List.swift:68-79 | AppPackage/Sources/ParserFeature/Parser+List.swift:100-111 | AppPackage/Sources/ParserFeature/Parser+List.swift:133-144 | AppPackage/Sources/ParserFeature/Parser+List.swift:166-175 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/ParserFeature/Parser+List.swift:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `AppPackage/Sources/ParserFeature/Parser+List.swift:116` calls `degrading`, `parseUploader` and `AppPackage/Sources/ParserFeature/Parser+List.swift:148` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9–12 lines × 2) · ×1
  • Duplicated block (9–12 lines × 2) AppPackage/Sources/DownloadClient/DownloadClient+RetryHelpers.swift:19 — AppPackage/Sources/DownloadClient/DownloadClient+RetryHelpers.swift:19-27 | AppPackage/Sources/DownloadClient/DownloadClient+RetryHelpers.swift:116-127 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DownloadClient/DownloadClient+RetryHelpers.swift:19` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (4–12 lines × 3) · ×1
  • Duplicated block (4–12 lines × 3) AppPackage/Sources/GalleryListComponents/GalleryList.swift:35 — AppPackage/Sources/GalleryListComponents/GalleryList.swift:35-38 | AppPackage/Sources/GalleryListComponents/GalleryList.swift:131-142 | AppPackage/Sources/GalleryListComponents/GalleryList.swift:225-236 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/GalleryListComponents/GalleryList.swift:131` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (3–10 lines × 3) · ×1
  • Duplicated block (3–10 lines × 3) AppPackage/Sources/DetailFeature/GallerySheetFeature.swift:65 — AppPackage/Sources/DetailFeature/GallerySheetFeature.swift:65-67 | AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:471-480 | AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:205-214 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:471` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `AppPackage/Sources/DownloadsFeature/DownloadsReducer.swift:471` calls `path`, `element` and `AppPackage/Sources/DetailFeature/GallerySheetFeature.swift:65` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9 lines × 4) · ×1
  • Duplicated block (9 lines × 4) .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:47 — .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:47-55 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift:47-55 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/NeverOnlyProbe.swift:47-55 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/probe/CustomArrowProbe.swift:47-55 — before extracting anything, compare `.planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift` and `.planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `.planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:47` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `.planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift:57` calls `toolbarRole`, `toolbarMinimizationBehavior` and `.planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:57` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×1
  • Duplicated block (9 lines × 3) AppPackage/Sources/HomeFeature/GalleryCardCell.swift:339 — AppPackage/Sources/HomeFeature/GalleryCardCell.swift:339-347 | AppPackage/Sources/HomeFeature/GalleryCardCell.swift:352-360 | AppPackage/Sources/HomeFeature/GalleryCardCell.swift:365-373 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited.
D4 · Code Duplication · Duplicated block (7–9 lines × 2) · ×1
  • Duplicated block (7–9 lines × 2) AppPackage/Sources/NetworkingFeature/Request+Account.swift:665 — AppPackage/Sources/NetworkingFeature/Request+Account.swift:665-671 | AppPackage/Sources/NetworkingFeature/Request+Image.swift:315-323 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/NetworkingFeature/Request+Account.swift:665` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (8 lines × 5) · ×1
  • Duplicated block (8 lines × 5) .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:100 — .planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift:100-107 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift:102-109 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/NeverOnlyProbe.swift:101-108 | .planning/quick/261015-duo-session-record/evidence/library-title-matrix/probe/CustomArrowProbe.swift:100-107 | AppPackage/Sources/AppComponents/LibraryTitleMenuIndicator.swift:8-15 — before extracting anything, compare `.planning/quick/261015-duo-session-record/evidence/LibraryCustomTitleArrowProbe.swift` and `.planning/quick/261015-duo-session-record/evidence/library-title-matrix/persistent/probe/CustomArrowProbe.swift` as WHOLE FILES: this scan already matched 4 separate duplicated blocks between them, totalling at least 63 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×1
  • Duplicated block (8 lines × 3) AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:352 — AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:352-359 | AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift:242-249 | AppPackage/Sources/SearchFeature/SearchReducer.swift:249-256 — before extracting anything, compare `AppPackage/Sources/HomeFeature/Watched/WatchedReducer.swift` and `AppPackage/Sources/SearchFeature/SearchReducer.swift` as WHOLE FILES: this scan already matched 6 separate duplicated blocks between them, totalling at least 115 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/FavoritesFeature/FavoritesReducer.swift:352` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×1
  • Duplicated block (7 lines × 3) AppPackage/Sources/NetworkingFeature/Request+Account.swift:281 — AppPackage/Sources/NetworkingFeature/Request+Account.swift:281-287 | AppPackage/Sources/NetworkingFeature/Request+Account.swift:401-407 | AppPackage/Sources/NetworkingFeature/Request+Account.swift:503-509 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/NetworkingFeature/Request+Account.swift:281` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (12 lines × 3) · ×1
  • Duplicated block (12 lines × 3) AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:74 — AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:74-85 | AppPackage/Sources/SearchFeature/SearchRootView.swift:403-414 | AppPackage/Sources/SearchFeature/SearchView.swift:94-105 — before extracting anything, compare `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift` and `AppPackage/Sources/SearchFeature/SearchView.swift` as WHOLE FILES: this scan already matched 5 separate duplicated blocks between them, totalling at least 64 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/DetailFeature/DetailSearch/DetailSearchView.swift:74` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (9 lines × 5) · ×1
  • Duplicated block (9 lines × 5) AppPackage/Sources/NetworkingFeature/Request+Account.swift:318 — AppPackage/Sources/NetworkingFeature/Request+Account.swift:318-326 | AppPackage/Sources/NetworkingFeature/Request+Account.swift:454-462 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:84-92 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:116-124 | AppPackage/Sources/NetworkingFeature/Request+Gallery.swift:185-193 — there are 5 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 5 sites; resolving a subset leaves the remainder to drift apart.
D4 · Code Duplication · Duplicated block (6 lines × 3) · ×1
  • Duplicated block (6 lines × 3) AppPackage/Sources/ParserFeature/Parser+Shared.swift:194 — AppPackage/Sources/ParserFeature/Parser+Shared.swift:194-199 | AppPackage/Sources/ParserFeature/Parser+Shared.swift:205-210 | AppPackage/Sources/ParserFeature/Parser+Shared.swift:216-221 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `AppPackage/Sources/ParserFeature/Parser+Shared.swift:194` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
S1 · Web-Security Posture · Third-party script without Subresource Integrity · ×1
  • Third-party script without Subresource Integrity AppPackage/Sources/TestingSupport/Resources/Parser/Gallery/GalleryDetail.html:35 — `https://e-hentai.org/z/0377/ehg_gallery.c.js` is executed by this page with no Subresource Integrity. Whoever can answer that request — the CDN, anyone who compromises it, anyone on the network path — runs arbitrary script in this page's origin, with its session. The URL also names no version, so it resolves to whatever that origin serves at fetch time — the executed bytes can change with nobody touching this repository. 33 such include(s) across the repository's markup.
Minor — 46 finding(s)
D10 · Test Quality · No direct assertions · ×22
  • No direct assertions: trackingFollowsTheRowThePersonSeesFirst AppPackage/Tests/GalleryListComponentsTests/GalleryRowAnchorTrackerTests.swift:20 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: aRowScrolledOutOfTheListNoLongerCounts AppPackage/Tests/GalleryListComponentsTests/GalleryRowAnchorTrackerTests.swift:31 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: aRebuiltListKeepsItsAnchorUntilTheAnchorArrivesUncovered AppPackage/Tests/GalleryListComponentsTests/GalleryRowAnchorTrackerTests.swift:43 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: anAnchorLeftUnderTheNavigationBarIsRevealed AppPackage/Tests/GalleryListComponentsTests/GalleryRowAnchorTrackerTests.swift:61 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: anAnchorThatCannotReachTheTopResumesTrackingAtTheDeadline AppPackage/Tests/GalleryListComponentsTests/GalleryRowAnchorTrackerTests.swift:73 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: aMissingAnchorTracksImmediately AppPackage/Tests/GalleryListComponentsTests/GalleryRowAnchorTrackerTests.swift:86 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: paginationAndReorderingKeepTheSameGallery AppPackage/Tests/GalleryListComponentsTests/GalleryScrollAnchorTests.swift:7 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: removingTheVisibleGalleryKeepsTheNearestSurvivingNeighbor AppPackage/Tests/GalleryListComponentsTests/GalleryScrollAnchorTests.swift:17 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: replacingTheCollectionUsesItsFirstGalleryAndEmptyRemainsEmpty AppPackage/Tests/GalleryListComponentsTests/GalleryScrollAnchorTests.swift:27 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: theTopVisibleGalleryIsTheHighestRowWhoseCenterClearsTheBar AppPackage/Tests/GalleryListComponentsTests/GalleryScrollAnchorTests.swift:41 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: aRowMostlyCoveredByTheNavigationBarIsNotTheAnchor AppPackage/Tests/GalleryListComponentsTests/GalleryScrollAnchorTests.swift:47 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: rowsUnderTheTabBarOrMissingAreNeverTheAnchor AppPackage/Tests/GalleryListComponentsTests/GalleryScrollAnchorTests.swift:57 — No conventional assertion call was detected, and 12 of 13 tests in `GalleryListComponentsTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: aFailedSearchRecordsOnePerformedSignalWithAZeroBucket AppPackage/Tests/SearchFeatureTests/AnalyticsEmissionTests.swift:36 — No conventional assertion call was detected, and 10 of 16 tests in `SearchFeatureTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: aSuccessfulSearchRecordsThePerformedSignalWithTheResultBucket AppPackage/Tests/SearchFeatureTests/AnalyticsEmissionTests.swift:56 — No conventional assertion call was detected, and 10 of 16 tests in `SearchFeatureTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: theRecordedPerformedSignalReflectsTheKeywordShape AppPackage/Tests/SearchFeatureTests/AnalyticsEmissionTests.swift:98 — No conventional assertion call was detected, and 10 of 16 tests in `SearchFeatureTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: pushingAGalleryDetailRecordsOneSignalMatchingTheFixture AppPackage/Tests/SearchFeatureTests/AnalyticsEmissionTests.swift:142 — No conventional assertion call was detected, and 10 of 16 tests in `SearchFeatureTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: openingTheSearchFilterPanelRecordsOneSignalNamingSearch AppPackage/Tests/SearchFeatureTests/AnalyticsEmissionTests.swift:182 — No conventional assertion call was detected, and 10 of 16 tests in `SearchFeatureTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: openingTheSearchQuickSearchPanelRecordsOneSignalNamingSearch AppPackage/Tests/SearchFeatureTests/AnalyticsEmissionTests.swift:195 — No conventional assertion call was detected, and 10 of 16 tests in `SearchFeatureTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: openingTheSearchRootFilterPanelRecordsOneSignalNamingSearchRoot AppPackage/Tests/SearchFeatureTests/AnalyticsEmissionTests.swift:208 — No conventional assertion call was detected, and 10 of 16 tests in `SearchFeatureTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: openingTheSearchRootQuickSearchPanelRecordsOneSignalNamingSearchRoot AppPackage/Tests/SearchFeatureTests/AnalyticsEmissionTests.swift:221 — No conventional assertion call was detected, and 10 of 16 tests in `SearchFeatureTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: queuedMetadataCannotRestoreClearedHistory AppPackage/Tests/SearchFeatureTests/SearchHistoryRemovalTests.swift:58 — No conventional assertion call was detected, and 10 of 16 tests in `SearchFeatureTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
  • No direct assertions: metadataStillLoadsForCurrentHistory AppPackage/Tests/SearchFeatureTests/SearchHistoryRemovalTests.swift:77 — No conventional assertion call was detected, and 10 of 16 tests in `SearchFeatureTests` read the same way — so this is treated as that project's convention rather than a broken test, and it does not drag the score. Two things look like this: verification that happens indirectly (an approval/verifier harness or BDD step methods), or a project of runnable samples compiled as tests, where a run that does not throw is the only check. If it is the latter, these methods genuinely verify nothing.
X10 · Duplicated predicate · Duplicated predicate · ×9
  • Duplicated predicate .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py:163 — `is_key_table and tuple(cells[1:]) != LOCALES` appears character-identically in 2 files — .planning/phases/18-in-app-3-0-readiness-age-wall-analytics-choice-comment-moder/18-copy-check.py, .planning/phases/18.1-native-report-form/18.1-copy-check.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Scripts/visual/capture-native.py:411 — `native.source_hashes() != native_sources or producer_hashes() != sources` appears character-identically in 2 files — Scripts/visual/capture-native.py, Scripts/visual/record-live-text.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Scripts/visual/environment.py:30 — `not isinstance(value, dict) or set(value) != set(expected)` appears character-identically in 2 files — Scripts/visual/environment.py, Scripts/visual/fixtures.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Scripts/visual/validate-preview.py:52 — `not isinstance(value, str) or not value.strip()` appears character-identically in 2 files — Scripts/visual/validate-preview.py, actions-tool/altstore_languages.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Scripts/visual/capture-native.py:388 — `path.is_relative_to(args.output) or args.output.is_relative_to(path)` appears character-identically in 2 files — Scripts/visual/capture-native.py, Scripts/visual/record-live-text.py. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate AppPackage/Sources/AppFeature/RootView.swift:6 — `DEBUG && canImport(Appshot) && canImport(AppshotProtocol)` appears character-identically in 3 files — AppPackage/Sources/AppFeature/RootView.swift, AppPackage/Sources/AppFeature/UITestSupport/AppshotCapture.swift, AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate AppPackage/Sources/AppFeature/RootView.swift:66 — `canImport(Appshot) && canImport(AppshotProtocol)` appears character-identically in 2 files — AppPackage/Sources/AppFeature/RootView.swift, AppPackage/Sources/AppFeature/UITestSupport/CaptureDiagnostics.swift. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift:131 — `hasRelevantDownloads || hadRelevantDownloads` appears character-identically in 3 files — AppPackage/Sources/DetailFeature/Previews/PreviewsReducer.swift, AppPackage/Sources/DownloadsFeature/DownloadInspectorReducer.swift, AppPackage/Sources/ReadingFeature/ReadingReducer+Session.swift. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate AppPackage/Sources/ReadingFeature/ReadingReducer.swift:204 — `isLandscape && setting.enableDualPageMode && setting.readingDirection != .vertical` appears character-identically in 2 files — AppPackage/Sources/ReadingFeature/ReadingReducer.swift, AppPackage/Sources/ReadingFeature/Support/PageHandler.swift. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
X7 · Silent fallback defaults · Silent fallback default in catch · ×3
  • Silent fallback default in catch AppPackage/Sources/AppFeature/UITestSupport/UITestAutomation.swift:290 — `blockedUsers` turns every thrown error into `[]` — a data error becomes a silent behavior change with no trail. Log the error or let it propagate (`throws`). If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment at the `catch`, `guard` or `??`, or in the doc comment, and the row stops firing.
  • Silent fallback default in catch AppPackage/Sources/DownloadClient/DownloadStore.swift:664 — `directoryURLs` turns every thrown error into `[]` — a data error becomes a silent behavior change with no trail. Log the error or let it propagate (`throws`). If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment at the `catch`, `guard` or `??`, or in the doc comment, and the row stops firing.
  • Silent fallback default in catch AppPackage/Sources/LogsClient/LogsClient.swift:140 — `runLogFileNames` turns every thrown error into `[]` — a data error becomes a silent behavior change with no trail. Log the error or let it propagate (`throws`). If that constant is the correct answer rather than a stand-in for a value that could not be read, say so in a comment at the `catch`, `guard` or `??`, or in the doc comment, and the row stops firing.
D16 · Bus Factor · Off-boarding risk · ×1
  • Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 291 significant file(s) lose their only recent owner: AppPackage/Sources/DownloadClient/DownloadClient+ContinuedSession.swift, AppPackage/Sources/DownloadClient/DownloadClient+Manager.swift, AppPackage/Sources/PreviewSupport/PreviewIdentifiers.swift, AppPackage/Sources/DownloadClient/DownloadClient+ExecutionSupport.swift, Scripts/visual/fixtures.py, AppPackage/Sources/DownloadClient/DownloadStore.swift, AppPackage/Sources/VisualSnapshotSupport/FullContentHost.swift, AppPackage/Package.swift (+283 more). Pair on, review, or document these before any departure.
D21 · Naming Consistency · `ipbMemberId` spells `Id` where 160 names in the project spell it `ID` · ×1
  • `ipbMemberId` spells `Id` where 160 names in the project spell it `ID` AppPackage/Sources/AppTools/Defaults.swift:33 — 160 of 161 names in project AppPackage~AnalyticsClient spell the token `ID` (160 of 161; unit: names in project AppPackage~AnalyticsClient containing `ID`). Peers: AnalyticsClient.live(appID) (AppPackage/Sources/AnalyticsClient/AnalyticsClient.swift:67); InstallSignalSender.appID (AppPackage/Sources/AnalyticsClient/InstallSignalSender.swift:36); InstallSignalSender.init(appID) (AppPackage/Sources/AnalyticsClient/InstallSignalSender.swift:47); InstallSignalBody.appID (AppPackage/Sources/AnalyticsClient/InstallSignalSender.swift:217); InstallSignalBody.sessionID (AppPackage/Sources/AnalyticsClient/InstallSignalSender.swift:219). Rename to `ipbMemberID`. [rule N6]
D21 · Naming Consistency · `loadUrl` spells `Url` where 287 names in the project spell it `URL` · ×1
  • `loadUrl` spells `Url` where 287 names in the project spell it `URL` AppPackage/Sources/SettingFeature/Components/WebView.swift:83 — 287 of 288 names in project AppPackage~AnalyticsClient spell the token `URL` (287 of 288; unit: names in project AppPackage~AnalyticsClient containing `URL`). Peers: PreviewImageView.originalURL (AppPackage/Sources/AppComponents/PreviewImageView.swift:8); PreviewImageView.init(originalURL) (AppPackage/Sources/AppComponents/PreviewImageView.swift:13); LocalPreviewImageView.fileURL (AppPackage/Sources/AppComponents/PreviewImageView.swift:46); LocalPreviewImageView.init(fileURL) (AppPackage/Sources/AppComponents/PreviewImageView.swift:52); LocalPreviewThumbnailGenerator.make(fileURL) (AppPackage/Sources/AppComponents/PreviewImageView.swift:129). Rename to `loadURL`. [rule N6]
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×1
  • Projects may be oversized for their cohesion — 2 of 2 project(s) overshoot their size bounds, lowering Project Cohesion to 0.0/10. The most over is `AppPackage` (74778 LoC, 1109 module-visible types across 84 directories). Review these for cohesion — draw the boundary inside the module first (group each responsibility into its own package or directory and keep the cross-boundary members non-public), since splitting a published package moves types between packages and breaks consumers.
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
D36 · Supply-chain Provenance & Signing · REDACTED · ×1
  • REDACTED
P2 · Observability · Logging is not universal · ×1
  • Logging is not universal — Only 1/3 runnable modules use logging (modules with no entry point or server are excluded — they are libraries a runnable module hosts). Silent: `.`, `.`.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST REDACTED:6 — No static application security testing detected. For this repository's stack, add CodeQL's Swift pack (Swift/Xcode) (or `semgrep --config=auto`, which runs on any language) as a CI step. What was searched, so you can tell an absence from a miss: the 10 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P6 · Release Hygiene · Changelog looks stale/thin · ×1
  • Changelog looks stale/thin — The changelog this check read carries 1 versioned entry, against a bar of 3. Counted as either the distinct `x.y.z` versions it names (a link's target is not counted) or its version-shaped section headings (`## [1.2.0]`, `## V14.x.x`, `## Updates in 8.0.x`), whichever is the larger — so a log sectioned by minor series counts its sections, not its individual patch numbers. Entries recorded somewhere this check does not read — release notes generated at tag time from a generator config it did not recognise, or a log kept outside the repository — are not counted here, and this row is about what is re-findable in the tree rather than about how often you release.
Minor — 13 finding(s)
D10 · Test Quality · Skipped (documented) · ×8
  • Skipped (documented): theUnimplementedClientReportsAnIssueWhenSendIsCalled AppPackage/Tests/AnalyticsClientTests/AnalyticsClientGateTests.swift:44 — Skipped with a documented reason — a deferral, not lazy debt: wrapped in withKnownIssue — the body is expected to fail, so its failure is not reported
  • Skipped (documented): theUnimplementedClientReportsAnIssueWhenApplyIsCalled AppPackage/Tests/AnalyticsClientTests/AnalyticsClientGateTests.swift:51 — Skipped with a documented reason — a deferral, not lazy debt: wrapped in withKnownIssue — the body is expected to fail, so its failure is not reported
  • Skipped (documented): testANestedCountedBasisMovementIsDetectedWhileASiblingIsNot AppPackage/Tests/DownloadsFeatureTests/DownloadContinuedSessionBasisTests.swift:705 — Skipped with a documented reason — a deferral, not lazy debt: wrapped in withKnownIssue — the body is expected to fail, so its failure is not reported
  • Skipped (documented): testUnimplementedClientReportsAnIssueForEveryEndpoint AppPackage/Tests/DownloadsFeatureTests/DownloadContinuedSessionTests.swift:13 — Skipped with a documented reason — a deferral, not lazy debt: wrapped in withKnownIssue — the body is expected to fail, so its failure is not reported
  • Skipped (documented): testAnUnmatchedSchedulingReleaseReportsAnIssue AppPackage/Tests/DownloadsFeatureTests/DownloadOwnershipConvergenceTests.swift:223 — Skipped with a documented reason — a deferral, not lazy debt: wrapped in withKnownIssue — the body is expected to fail, so its failure is not reported
  • Skipped (documented): testADipNoLaterPushRepaintsIsRefused AppPackage/Tests/DownloadsFeatureTests/DownloadProgressSeriesGuardTests.swift:41 — Skipped with a documented reason — a deferral, not lazy debt: wrapped in withKnownIssue — the body is expected to fail, so its failure is not reported
  • Skipped (documented): testASecondDisplacedPushIsRefused AppPackage/Tests/DownloadsFeatureTests/DownloadProgressSeriesGuardTests.swift:50 — Skipped with a documented reason — a deferral, not lazy debt: wrapped in withKnownIssue — the body is expected to fail, so its failure is not reported
  • Skipped (documented): testADipInTheFinalPositionIsRefused AppPackage/Tests/DownloadsFeatureTests/DownloadProgressSeriesGuardTests.swift:60 — Skipped with a documented reason — a deferral, not lazy debt: wrapped in withKnownIssue — the body is expected to fail, so its failure is not reported
D12 · Dependency Hygiene · Outdated · ×5
  • Outdated: kingfisher — `kingfisher` is resolved at 8.13.0, but 8.16.0 is the newest release tagged on https://github.com/onevcat/Kingfisher within the same major. SwiftPM resolves from git tags, and a `from:` requirement admits every release below the next major — so `swift package update kingfisher` reaches this one with no change to Package.swift.
  • Outdated: swift-collections — `swift-collections` is resolved at 1.7.3, but 1.7.6 is the newest release tagged on https://github.com/apple/swift-collections within the same major. SwiftPM resolves from git tags, and a `from:` requirement admits every release below the next major — so `swift package update swift-collections` reaches this one with no change to Package.swift.
  • Outdated: swift-concurrency-extras — `swift-concurrency-extras` is resolved at 1.4.2, but 1.4.3 is the newest release tagged on https://github.com/pointfreeco/swift-concurrency-extras within the same major. SwiftPM resolves from git tags, and a `from:` requirement admits every release below the next major — so `swift package update swift-concurrency-extras` reaches this one with no change to Package.swift.
  • Outdated: swift-dependencies — `swift-dependencies` is resolved at 1.17.1, but 1.17.2 is the newest release tagged on https://github.com/pointfreeco/swift-dependencies within the same major. SwiftPM resolves from git tags, and a `from:` requirement admits every release below the next major — so `swift package update swift-dependencies` reaches this one with no change to Package.swift.
  • Outdated: swift-snapshot-testing — `swift-snapshot-testing` is resolved at 1.19.6, but 1.19.7 is the newest release tagged on https://github.com/pointfreeco/swift-snapshot-testing within the same major. SwiftPM resolves from git tags, and a `from:` requirement admits every release below the next major — so `swift package update swift-snapshot-testing` reaches this one with no change to Package.swift.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-53db92e5e0b34294a3232169bb5a453a/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-53db92e5e0b34294a3232169bb5a453a/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .82artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm .0artifacts/raw/osv-scanner.json
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 108 file(s) — `AppPackage/Sources/AppComponents/AdaptiveStack.swift`, `AppPackage/Sources/AppComponents/CategoryView.swift`, `AppPackage/Sources/AppComponents/CheckboxToggleStyle.swift`, `AppPackage/Sources/AppComponents/ChoiceCard.swift`, `AppPackage/Sources/AppComponents/FirstLaunchContinueButton.swift`, … (+103 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciesosv-scanner—osv-scanner --format json --recursive --experimental-disable-plugins transitivedependency/requirements --experimental-disable-plugins dotnet/csproj --experimental-disable-plugins dotnet/nugetcpm .0artifacts/raw/osv-scanner.json

Run 01a1dc23-5a89-7ae1-aec0-f2b0f99ce01f · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md