Public report of Cysharp/MagicOnion, published 16 November 2026. It has the same score, grades and number of
findings as the full report. The details of security findings (where they are in the code, which known
vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive reportMeasured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey →
Signed and filed in the standard's public register, 16 November 2026, 18:42 UTC · Survey ID cd_0b3af9e8742f4ae09f45735f1d2f24f8
Cysharp/MagicOnion
Measured 16 November 2026, 18:41 UTC, at code version daf8a71
Boundary Type-Coupling is not measured: Bounded contexts not declared.
Knowledge freshness is not measured: Freshness signal contradicted by repo activity.
CAI scoreWeak
CriticalWeakAdequateStrongExemplary
The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.
A medium codebase: 26,167 lines of product code in 68 projects, tests not counted · Estimated rebuild effort: about 0.7 person-years · Weakest lens: Security and Compliance, 41.8
Findings by how serious they are
91 critical404 serious199 minor
1 dimension is left out of the score. we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. It counts neither for nor against the score, and Limitations lists it with its reason.
This survey was produced by
Canine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
16 November 2026, 18:41 UTC
A measurement, not a certificate. The Code Assurance Index records a number
together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee
the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that
implements it, and today the Canine Code Analyzer is the only one that does.
The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸
72of 72 dimensions measured by tools.
653of 694 findings point to an exact file and line, so you can open each one in the code. The other 41 concern the repository as a whole, such as missing documentation.
72dimensions across 6 lenses, read from 26,167 lines of product code in 68 projects.
Cysharp/MagicOnion falls short of our standard for production, held back most by its Security and Compliance lens, the code's security and compliance. It scores 49.7 out of 100 and is rated Weak, and 55 of its 91 critical findings are security problems.
Security and Compliance, at 41.8, is the weakest lens and counts most in the score. The best first step is hashing passwords properly, worth about 7.4 points. Fixing the silenced warnings comes next, worth about 3.6 points. Raising Security and Compliance to 70 would lift the score to about 56.7.
Thirty-five pipeline tools are referenced by a changeable name, so the build pipeline can be tampered with. Seven secrets can leak from the build pipeline, and ten errors are caught and ignored, so failures can go unnoticed. Pinning each tool to an exact version, limiting each secret to its own step and handling or logging the ignored errors would close these risks. Updating the vulnerable packages would fix the three packages with a known security hole, and the five passwords or keys in the code's history and the two passwords or keys in the code need replacing, with the old ones switched off. The 13 data fields that are written but never read need removing.
The product code is 26,167 lines, about €100,000 to rebuild.
A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.
How the score is built: what each lens counts forThe lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
If Security and Compliance rose from 41.8 to 70, the lowest score rated Strong, the score would rise from 49.7 to about 56.7.
Code composition: what the lines of code are
Business logic 15%Supporting code 28%Tests 51%Code analyzers 6%
Rebuild cost: about €100,000 · Estimate
Cost to rebuild
€34,000 to €170,000, for 568 to 1,838 hours of work, about 0.7 person-years for 1 to 2 engineers
Difficulty of the problem
Standard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor
×0.7 at a score of 50. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
Size
Medium: 26,167 lines of product code
Comment lines
The estimate prices 23,931 lines. Comment lines count towards the size of 26,167 lines but aren't priced as work.
What it is not
Not a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.
How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.
Top priorities
The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.
1
Store passwords with a salted KDF — `Microsoft.AspNetCore.Identity.PasswordHasher<T>`, `Rfc2898DeriveBytes` (PBKDF2), or BCrypt/Argon2 — and compare with `CryptographicOperations.FixedTimeEquals`.
(A fast/plain hash, or a client-hashed value stored and compared verbatim, is not password storage.) Start in `samples/JwtAuthentication/JwtAuthApp.Server/Services/AccountService.cs:37`.
Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.
Where the investment is most exposed · Value at risk
This code would cost about €100,000 to build again, about 0.7 person-years of work. Its weakest lens is Security and Compliance, at 41.8 (Weak). Security and Compliance is about how well the product is protected, and how it handles personal data. Because the weakest lens counts most in the score, work on Security and Compliance also moves the score most.
Based on: the rebuild estimate · the Security and Compliance grade · how much each lens counts
What to do: Start with the Security and Compliance actions in Top priorities.
If you do one thing first · First action
Store passwords with a salted KDF — `Microsoft.AspNetCore.Identity.PasswordHasher<T>`, `Rfc2898DeriveBytes` (PBKDF2), or BCrypt/Argon2 — and compare with `CryptographicOperations.FixedTimeEquals`. Of all the actions in this report, it raises the score most for the work it takes: about 7.4 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
Architecture — bounded-context dependency graph
Each box is a bounded context (its layer projects grouped, or a project count when large); arrows show dependencies between contexts. A shared kernel is where many arrows converge.
Architecture: which parts of the code depend on which
The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.
38 modules, with 72 dependencies between them. 2 loops run through 11 of the modules, marked above the diagonal.
Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
MagicOnion.Client.SourceGenerator uses MagicOnion.Client.SourceGenerator.CodeAnalysis, so a change to MagicOnion.Client.SourceGenerator.CodeAnalysis can break MagicOnion.Client.SourceGenerator, while a change to MagicOnion.Client.SourceGenerator can't break MagicOnion.Client.SourceGenerator.CodeAnalysis.
Position
Below the diagonal: MagicOnion.Client.SourceGenerator uses a module listed above it, which is the healthy direction.
MagicOnion.Internal uses MagicOnion.Serialization, so a change to MagicOnion.Serialization can break MagicOnion.Internal, while a change to MagicOnion.Internal can't break MagicOnion.Serialization.
Position
Below the diagonal: MagicOnion.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Serialization.MemoryPack uses MagicOnion.Serialization, so a change to MagicOnion.Serialization can break MagicOnion.Serialization.MemoryPack, while a change to MagicOnion.Serialization.MemoryPack can't break MagicOnion.Serialization.
Position
Below the diagonal: MagicOnion.Serialization.MemoryPack uses a module listed above it, which is the healthy direction.
18→29 MagicOnion.Server.Diagnostics uses MagicOnion.Server.Hubs.Internalpart of a loop✕
Connections
1 pair of types, where a type in MagicOnion.Server.Diagnostics uses a type in MagicOnion.Server.Hubs.Internal.
MagicOnion.Server.Diagnostics uses MagicOnion.Server.Hubs.Internal, so a change to MagicOnion.Server.Hubs.Internal can break MagicOnion.Server.Diagnostics, while a change to MagicOnion.Server.Diagnostics can't break MagicOnion.Server.Hubs.Internal.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
18→32 MagicOnion.Server.Diagnostics uses MagicOnion.Server.Hubspart of a loop✕
Connections
1 pair of types, where a type in MagicOnion.Server.Diagnostics uses a type in MagicOnion.Server.Hubs.
MagicOnion.Server.Diagnostics uses MagicOnion.Server.Hubs, so a change to MagicOnion.Server.Hubs can break MagicOnion.Server.Diagnostics, while a change to MagicOnion.Server.Diagnostics can't break MagicOnion.Server.Hubs.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
18→34 MagicOnion.Server.Diagnostics uses MagicOnion.Serverpart of a loop✕
Connections
1 pair of types, where a type in MagicOnion.Server.Diagnostics uses a type in MagicOnion.Server.
MagicOnion.Server.Diagnostics uses MagicOnion.Server, so a change to MagicOnion.Server can break MagicOnion.Server.Diagnostics, while a change to MagicOnion.Server.Diagnostics can't break MagicOnion.Server.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
19→32 MagicOnion.Server.Filters uses MagicOnion.Server.Hubspart of a loop✕
Connections
1 pair of types, where a type in MagicOnion.Server.Filters uses a type in MagicOnion.Server.Hubs.
MagicOnion.Server.Filters uses MagicOnion.Server.Hubs, so a change to MagicOnion.Server.Hubs can break MagicOnion.Server.Filters, while a change to MagicOnion.Server.Filters can't break MagicOnion.Server.Hubs.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
19→34 MagicOnion.Server.Filters uses MagicOnion.Serverpart of a loop✕
Connections
1 pair of types, where a type in MagicOnion.Server.Filters uses a type in MagicOnion.Server.
MagicOnion.Server.Filters uses MagicOnion.Server, so a change to MagicOnion.Server can break MagicOnion.Server.Filters, while a change to MagicOnion.Server.Filters can't break MagicOnion.Server.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
docs.src.data uses docs.src.data.resources, so a change to docs.src.data.resources can break docs.src.data, while a change to docs.src.data can't break docs.src.data.resources.
Position
Below the diagonal: docs.src.data uses a module listed above it, which is the healthy direction.
MagicOnion.Client.Internal uses MagicOnion.Serialization, so a change to MagicOnion.Serialization can break MagicOnion.Client.Internal, while a change to MagicOnion.Client.Internal can't break MagicOnion.Serialization.
Position
Below the diagonal: MagicOnion.Client.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Client.Internal uses MagicOnion.Internal, so a change to MagicOnion.Internal can break MagicOnion.Client.Internal, while a change to MagicOnion.Client.Internal can't break MagicOnion.Internal.
Position
Below the diagonal: MagicOnion.Client.Internal uses a module listed above it, which is the healthy direction.
21→23 MagicOnion.Client.Internal uses MagicOnion.Clientpart of a loop✕
Connections
4 pairs of types, where a type in MagicOnion.Client.Internal uses a type in MagicOnion.Client.
MagicOnion.Client.Internal uses MagicOnion.Client, so a change to MagicOnion.Client can break MagicOnion.Client.Internal, while a change to MagicOnion.Client.Internal can't break MagicOnion.Client.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
MagicOnion.Client.SourceGenerator.CodeGen uses MagicOnion.Client.SourceGenerator.CodeAnalysis, so a change to MagicOnion.Client.SourceGenerator.CodeAnalysis can break MagicOnion.Client.SourceGenerator.CodeGen, while a change to MagicOnion.Client.SourceGenerator.CodeGen can't break MagicOnion.Client.SourceGenerator.CodeAnalysis.
Position
Below the diagonal: MagicOnion.Client.SourceGenerator.CodeGen uses a module listed above it, which is the healthy direction.
MagicOnion.Client.SourceGenerator.CodeGen uses MagicOnion.Client.SourceGenerator, so a change to MagicOnion.Client.SourceGenerator can break MagicOnion.Client.SourceGenerator.CodeGen, while a change to MagicOnion.Client.SourceGenerator.CodeGen can't break MagicOnion.Client.SourceGenerator.
Position
Below the diagonal: MagicOnion.Client.SourceGenerator.CodeGen uses a module listed above it, which is the healthy direction.
MagicOnion.Client uses MagicOnion.Serialization, so a change to MagicOnion.Serialization can break MagicOnion.Client, while a change to MagicOnion.Client can't break MagicOnion.Serialization.
Position
Below the diagonal: MagicOnion.Client uses a module listed above it, which is the healthy direction.
MagicOnion.Client uses MagicOnion.Internal, so a change to MagicOnion.Internal can break MagicOnion.Client, while a change to MagicOnion.Client can't break MagicOnion.Internal.
Position
Below the diagonal: MagicOnion.Client uses a module listed above it, which is the healthy direction.
MagicOnion.Client uses MagicOnion.Client.Internal, so a change to MagicOnion.Client.Internal can break MagicOnion.Client, while a change to MagicOnion.Client can't break MagicOnion.Client.Internal.
Position
Below the diagonal: MagicOnion.Client uses a module listed above it, which is the healthy direction.
23→24 MagicOnion.Client uses MagicOnionpart of a loop✕
Connections
2 pairs of types, where a type in MagicOnion.Client uses a type in MagicOnion.
MagicOnion uses MagicOnion.Internal, so a change to MagicOnion.Internal can break MagicOnion, while a change to MagicOnion can't break MagicOnion.Internal.
Position
Below the diagonal: MagicOnion uses a module listed above it, which is the healthy direction.
MagicOnion.Client.DynamicClient uses MagicOnion.Internal.Reflection, so a change to MagicOnion.Internal.Reflection can break MagicOnion.Client.DynamicClient, while a change to MagicOnion.Client.DynamicClient can't break MagicOnion.Internal.Reflection.
Position
Below the diagonal: MagicOnion.Client.DynamicClient uses a module listed above it, which is the healthy direction.
MagicOnion.Client.DynamicClient uses MagicOnion.Client, so a change to MagicOnion.Client can break MagicOnion.Client.DynamicClient, while a change to MagicOnion.Client.DynamicClient can't break MagicOnion.Client.
Position
Below the diagonal: MagicOnion.Client.DynamicClient uses a module listed above it, which is the healthy direction.
MagicOnion.CompilerServices uses MagicOnion, so a change to MagicOnion can break MagicOnion.CompilerServices, while a change to MagicOnion.CompilerServices can't break MagicOnion.
Position
Below the diagonal: MagicOnion.CompilerServices uses a module listed above it, which is the healthy direction.
MagicOnion.Serialization.MessagePack uses MagicOnion.Serialization, so a change to MagicOnion.Serialization can break MagicOnion.Serialization.MessagePack, while a change to MagicOnion.Serialization.MessagePack can't break MagicOnion.Serialization.
Position
Below the diagonal: MagicOnion.Serialization.MessagePack uses a module listed above it, which is the healthy direction.
MagicOnion.Serialization.MessagePack uses MagicOnion, so a change to MagicOnion can break MagicOnion.Serialization.MessagePack, while a change to MagicOnion.Serialization.MessagePack can't break MagicOnion.
Position
Below the diagonal: MagicOnion.Serialization.MessagePack uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Internal uses MagicOnion.Internal, so a change to MagicOnion.Internal can break MagicOnion.Server.Internal, while a change to MagicOnion.Server.Internal can't break MagicOnion.Internal.
Position
Below the diagonal: MagicOnion.Server.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Internal uses MagicOnion.Server.Diagnostics, so a change to MagicOnion.Server.Diagnostics can break MagicOnion.Server.Internal, while a change to MagicOnion.Server.Internal can't break MagicOnion.Server.Diagnostics.
Position
Below the diagonal: MagicOnion.Server.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Internal uses MagicOnion, so a change to MagicOnion can break MagicOnion.Server.Internal, while a change to MagicOnion.Server.Internal can't break MagicOnion.
Position
Below the diagonal: MagicOnion.Server.Internal uses a module listed above it, which is the healthy direction.
28→34 MagicOnion.Server.Internal uses MagicOnion.Serverpart of a loop✕
Connections
1 pair of types, where a type in MagicOnion.Server.Internal uses a type in MagicOnion.Server.
MagicOnion.Server.Internal uses MagicOnion.Server, so a change to MagicOnion.Server can break MagicOnion.Server.Internal, while a change to MagicOnion.Server.Internal can't break MagicOnion.Server.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
MagicOnion.Server.Hubs.Internal uses MagicOnion.Serialization, so a change to MagicOnion.Serialization can break MagicOnion.Server.Hubs.Internal, while a change to MagicOnion.Server.Hubs.Internal can't break MagicOnion.Serialization.
Position
Below the diagonal: MagicOnion.Server.Hubs.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Hubs.Internal uses MagicOnion.Internal, so a change to MagicOnion.Internal can break MagicOnion.Server.Hubs.Internal, while a change to MagicOnion.Server.Hubs.Internal can't break MagicOnion.Internal.
Position
Below the diagonal: MagicOnion.Server.Hubs.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Hubs.Internal uses MagicOnion.Server.Filters, so a change to MagicOnion.Server.Filters can break MagicOnion.Server.Hubs.Internal, while a change to MagicOnion.Server.Hubs.Internal can't break MagicOnion.Server.Filters.
Position
Below the diagonal: MagicOnion.Server.Hubs.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Hubs.Internal uses MagicOnion.Server.Internal, so a change to MagicOnion.Server.Internal can break MagicOnion.Server.Hubs.Internal, while a change to MagicOnion.Server.Hubs.Internal can't break MagicOnion.Server.Internal.
Position
Below the diagonal: MagicOnion.Server.Hubs.Internal uses a module listed above it, which is the healthy direction.
29→31 MagicOnion.Server.Hubs.Internal uses MagicOnion.Server.Features.Internalpart of a loop✕
Connections
1 pair of types, where a type in MagicOnion.Server.Hubs.Internal uses a type in MagicOnion.Server.Features.Internal.
MagicOnion.Server.Hubs.Internal uses MagicOnion.Server.Features.Internal, so a change to MagicOnion.Server.Features.Internal can break MagicOnion.Server.Hubs.Internal, while a change to MagicOnion.Server.Hubs.Internal can't break MagicOnion.Server.Features.Internal.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
29→32 MagicOnion.Server.Hubs.Internal uses MagicOnion.Server.Hubspart of a loop✕
Connections
3 pairs of types, where a type in MagicOnion.Server.Hubs.Internal uses a type in MagicOnion.Server.Hubs.
MagicOnion.Server.Hubs.Internal uses MagicOnion.Server.Hubs, so a change to MagicOnion.Server.Hubs can break MagicOnion.Server.Hubs.Internal, while a change to MagicOnion.Server.Hubs.Internal can't break MagicOnion.Server.Hubs.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
29→33 MagicOnion.Server.Hubs.Internal uses MagicOnion.Server.Binderpart of a loop✕
Connections
2 pairs of types, where a type in MagicOnion.Server.Hubs.Internal uses a type in MagicOnion.Server.Binder.
MagicOnion.Server.Hubs.Internal uses MagicOnion.Server.Binder, so a change to MagicOnion.Server.Binder can break MagicOnion.Server.Hubs.Internal, while a change to MagicOnion.Server.Hubs.Internal can't break MagicOnion.Server.Binder.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
29→34 MagicOnion.Server.Hubs.Internal uses MagicOnion.Serverpart of a loop✕
Connections
8 pairs of types, where a type in MagicOnion.Server.Hubs.Internal uses a type in MagicOnion.Server.
MagicOnion.Server.Hubs.Internal uses MagicOnion.Server, so a change to MagicOnion.Server can break MagicOnion.Server.Hubs.Internal, while a change to MagicOnion.Server.Hubs.Internal can't break MagicOnion.Server.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
MagicOnion.Server.Features uses MagicOnion.Server.Hubs.Internal, so a change to MagicOnion.Server.Hubs.Internal can break MagicOnion.Server.Features, while a change to MagicOnion.Server.Features can't break MagicOnion.Server.Hubs.Internal.
Position
Below the diagonal: MagicOnion.Server.Features uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Features.Internal uses MagicOnion.Server.Internal, so a change to MagicOnion.Server.Internal can break MagicOnion.Server.Features.Internal, while a change to MagicOnion.Server.Features.Internal can't break MagicOnion.Server.Internal.
Position
Below the diagonal: MagicOnion.Server.Features.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Features.Internal uses MagicOnion.Server.Hubs.Internal, so a change to MagicOnion.Server.Hubs.Internal can break MagicOnion.Server.Features.Internal, while a change to MagicOnion.Server.Features.Internal can't break MagicOnion.Server.Hubs.Internal.
Position
Below the diagonal: MagicOnion.Server.Features.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Hubs uses MagicOnion.Internal, so a change to MagicOnion.Internal can break MagicOnion.Server.Hubs, while a change to MagicOnion.Server.Hubs can't break MagicOnion.Internal.
Position
Below the diagonal: MagicOnion.Server.Hubs uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Hubs uses MagicOnion.Server.Filters, so a change to MagicOnion.Server.Filters can break MagicOnion.Server.Hubs, while a change to MagicOnion.Server.Hubs can't break MagicOnion.Server.Filters.
Position
Below the diagonal: MagicOnion.Server.Hubs uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Hubs uses MagicOnion, so a change to MagicOnion can break MagicOnion.Server.Hubs, while a change to MagicOnion.Server.Hubs can't break MagicOnion.
Position
Below the diagonal: MagicOnion.Server.Hubs uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Hubs uses MagicOnion.Server.Internal, so a change to MagicOnion.Server.Internal can break MagicOnion.Server.Hubs, while a change to MagicOnion.Server.Hubs can't break MagicOnion.Server.Internal.
Position
Below the diagonal: MagicOnion.Server.Hubs uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Hubs uses MagicOnion.Server.Hubs.Internal, so a change to MagicOnion.Server.Hubs.Internal can break MagicOnion.Server.Hubs, while a change to MagicOnion.Server.Hubs can't break MagicOnion.Server.Hubs.Internal.
Position
Below the diagonal: MagicOnion.Server.Hubs uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Hubs uses MagicOnion.Server.Features.Internal, so a change to MagicOnion.Server.Features.Internal can break MagicOnion.Server.Hubs, while a change to MagicOnion.Server.Hubs can't break MagicOnion.Server.Features.Internal.
Position
Below the diagonal: MagicOnion.Server.Hubs uses a module listed above it, which is the healthy direction.
32→34 MagicOnion.Server.Hubs uses MagicOnion.Serverpart of a loop✕
Connections
7 pairs of types, where a type in MagicOnion.Server.Hubs uses a type in MagicOnion.Server.
MagicOnion.Server.Hubs uses MagicOnion.Server, so a change to MagicOnion.Server can break MagicOnion.Server.Hubs, while a change to MagicOnion.Server.Hubs can't break MagicOnion.Server.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
MagicOnion.Server.Binder uses Microsoft.AspNetCore.Builder, so a change to Microsoft.AspNetCore.Builder can break MagicOnion.Server.Binder, while a change to MagicOnion.Server.Binder can't break Microsoft.AspNetCore.Builder.
Position
Below the diagonal: MagicOnion.Server.Binder uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Binder uses MagicOnion, so a change to MagicOnion can break MagicOnion.Server.Binder, while a change to MagicOnion.Server.Binder can't break MagicOnion.
Position
Below the diagonal: MagicOnion.Server.Binder uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Binder uses MagicOnion.Server.Internal, so a change to MagicOnion.Server.Internal can break MagicOnion.Server.Binder, while a change to MagicOnion.Server.Binder can't break MagicOnion.Server.Internal.
Position
Below the diagonal: MagicOnion.Server.Binder uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Binder uses MagicOnion.Server.Hubs, so a change to MagicOnion.Server.Hubs can break MagicOnion.Server.Binder, while a change to MagicOnion.Server.Binder can't break MagicOnion.Server.Hubs.
Position
Below the diagonal: MagicOnion.Server.Binder uses a module listed above it, which is the healthy direction.
33→34 MagicOnion.Server.Binder uses MagicOnion.Serverpart of a loop✕
Connections
6 pairs of types, where a type in MagicOnion.Server.Binder uses a type in MagicOnion.Server.
MagicOnion.Server.Binder uses MagicOnion.Server, so a change to MagicOnion.Server can break MagicOnion.Server.Binder, while a change to MagicOnion.Server.Binder can't break MagicOnion.Server.
Position
Above the diagonal, so it is part of a loop. Neither module can be changed, tested or released on its own until one of these dependencies is removed.
MagicOnion.Server uses MagicOnion.Serialization, so a change to MagicOnion.Serialization can break MagicOnion.Server, while a change to MagicOnion.Server can't break MagicOnion.Serialization.
Position
Below the diagonal: MagicOnion.Server uses a module listed above it, which is the healthy direction.
MagicOnion.Server uses MagicOnion.Server.Diagnostics, so a change to MagicOnion.Server.Diagnostics can break MagicOnion.Server, while a change to MagicOnion.Server can't break MagicOnion.Server.Diagnostics.
Position
Below the diagonal: MagicOnion.Server uses a module listed above it, which is the healthy direction.
MagicOnion.Server uses MagicOnion.Server.Filters, so a change to MagicOnion.Server.Filters can break MagicOnion.Server, while a change to MagicOnion.Server can't break MagicOnion.Server.Filters.
Position
Below the diagonal: MagicOnion.Server uses a module listed above it, which is the healthy direction.
MagicOnion.Server uses MagicOnion.Server.Internal, so a change to MagicOnion.Server.Internal can break MagicOnion.Server, while a change to MagicOnion.Server can't break MagicOnion.Server.Internal.
Position
Below the diagonal: MagicOnion.Server uses a module listed above it, which is the healthy direction.
MagicOnion.Server uses MagicOnion.Server.Hubs, so a change to MagicOnion.Server.Hubs can break MagicOnion.Server, while a change to MagicOnion.Server can't break MagicOnion.Server.Hubs.
Position
Below the diagonal: MagicOnion.Server uses a module listed above it, which is the healthy direction.
MagicOnion.Server uses MagicOnion.Server.Binder, so a change to MagicOnion.Server.Binder can break MagicOnion.Server, while a change to MagicOnion.Server can't break MagicOnion.Server.Binder.
Position
Below the diagonal: MagicOnion.Server uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Binder.Internal uses MagicOnion.Serialization, so a change to MagicOnion.Serialization can break MagicOnion.Server.Binder.Internal, while a change to MagicOnion.Server.Binder.Internal can't break MagicOnion.Serialization.
Position
Below the diagonal: MagicOnion.Server.Binder.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Binder.Internal uses MagicOnion.Server.Filters, so a change to MagicOnion.Server.Filters can break MagicOnion.Server.Binder.Internal, while a change to MagicOnion.Server.Binder.Internal can't break MagicOnion.Server.Filters.
Position
Below the diagonal: MagicOnion.Server.Binder.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Binder.Internal uses MagicOnion.Server.Binder, so a change to MagicOnion.Server.Binder can break MagicOnion.Server.Binder.Internal, while a change to MagicOnion.Server.Binder.Internal can't break MagicOnion.Server.Binder.
Position
Below the diagonal: MagicOnion.Server.Binder.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Binder.Internal uses MagicOnion.Server, so a change to MagicOnion.Server can break MagicOnion.Server.Binder.Internal, while a change to MagicOnion.Server.Binder.Internal can't break MagicOnion.Server.
Position
Below the diagonal: MagicOnion.Server.Binder.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Filters.Internal uses MagicOnion.Server.Filters, so a change to MagicOnion.Server.Filters can break MagicOnion.Server.Filters.Internal, while a change to MagicOnion.Server.Filters.Internal can't break MagicOnion.Server.Filters.
Position
Below the diagonal: MagicOnion.Server.Filters.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Filters.Internal uses MagicOnion.Server.Hubs, so a change to MagicOnion.Server.Hubs can break MagicOnion.Server.Filters.Internal, while a change to MagicOnion.Server.Filters.Internal can't break MagicOnion.Server.Hubs.
Position
Below the diagonal: MagicOnion.Server.Filters.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.Filters.Internal uses MagicOnion.Server, so a change to MagicOnion.Server can break MagicOnion.Server.Filters.Internal, while a change to MagicOnion.Server.Filters.Internal can't break MagicOnion.Server.
Position
Below the diagonal: MagicOnion.Server.Filters.Internal uses a module listed above it, which is the healthy direction.
MagicOnion.Server.JsonTranscoding uses MagicOnion.Serialization, so a change to MagicOnion.Serialization can break MagicOnion.Server.JsonTranscoding, while a change to MagicOnion.Server.JsonTranscoding can't break MagicOnion.Serialization.
Position
Below the diagonal: MagicOnion.Server.JsonTranscoding uses a module listed above it, which is the healthy direction.
MagicOnion.Server.JsonTranscoding uses MagicOnion, so a change to MagicOnion can break MagicOnion.Server.JsonTranscoding, while a change to MagicOnion.Server.JsonTranscoding can't break MagicOnion.
Position
Below the diagonal: MagicOnion.Server.JsonTranscoding uses a module listed above it, which is the healthy direction.
MagicOnion.Server.JsonTranscoding uses MagicOnion.Server.Binder, so a change to MagicOnion.Server.Binder can break MagicOnion.Server.JsonTranscoding, while a change to MagicOnion.Server.JsonTranscoding can't break MagicOnion.Server.Binder.
Position
Below the diagonal: MagicOnion.Server.JsonTranscoding uses a module listed above it, which is the healthy direction.
MagicOnion.Server.JsonTranscoding uses MagicOnion.Server, so a change to MagicOnion.Server can break MagicOnion.Server.JsonTranscoding, while a change to MagicOnion.Server.JsonTranscoding can't break MagicOnion.Server.
Position
Below the diagonal: MagicOnion.Server.JsonTranscoding uses a module listed above it, which is the healthy direction.
Microsoft.Extensions.DependencyInjection uses MagicOnion.Server, so a change to MagicOnion.Server can break Microsoft.Extensions.DependencyInjection, while a change to Microsoft.Extensions.DependencyInjection can't break MagicOnion.Server.
Position
Below the diagonal: Microsoft.Extensions.DependencyInjection uses a module listed above it, which is the healthy direction.
Microsoft.Extensions.DependencyInjection uses MagicOnion.Server.JsonTranscoding, so a change to MagicOnion.Server.JsonTranscoding can break Microsoft.Extensions.DependencyInjection, while a change to Microsoft.Extensions.DependencyInjection can't break MagicOnion.Server.JsonTranscoding.
Position
Below the diagonal: Microsoft.Extensions.DependencyInjection uses a module listed above it, which is the healthy direction.
At a glance — Code Health · 49.1 · Weak · gated by X1 ·
Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).
OWASP category
Findings
Severity
A05:2025 — Injection
45
High / Critical
A03:2025 — Software Supply Chain Failures
9
High / Critical
A07:2025 — Authentication Failures
8
High / Critical
Roadmap
Top priorities: Store passwords with a salted KDF — `Microsoft.AspNetCore.Identity.PasswordHasher<T>`, `Rfc2898DeriveBytes` (PBKDF2), or BCrypt/Argon2 — and compare with `CryptographicOperations.FixedTimeEquals`. (A fast/plain hash, or a client-hashed value stored and compared verbatim, is not password storage.) Start in `samples/JwtAuthentication/JwtAuthApp.Server/Services/AccountService.cs:37`; Resolve the 10 EmptyCatchBlock finding(s) in Explicit Debt — start with StreamingHubClientBase.cs (3), UnaryResult.cs (2), Program.cs; Resolve the 13 WriteOnlyPrivateField finding(s) in Explicit Debt — start with BroadcastScenario.cs (2), SystemTextJsonMessageSerializer.cs (2), HubMethodBenchmarks.cs.
Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.
Do this
Helps
Effort
Dimension
Store passwords with a salted KDF — `Microsoft.AspNetCore.Identity.PasswordHasher<T>`, `Rfc2898DeriveBytes` (PBKDF2), or BCrypt/Argon2 — and compare with `CryptographicOperations.FixedTimeEquals`. (A fast/plain hash, or a client-hashed value stored and compared verbatim, is not password storage.) Start in `samples/JwtAuthentication/JwtAuthApp.Server/Services/AccountService.cs:37`.
Every finding carries one of four grades. Three say how serious it is. The fourth says this
survey could not settle it — and it is a grade, not a gap.
Critical — 91
A definite problem that already costs you something and drags the score down: a
missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here
tends to cause failures elsewhere.
Serious — 404
Likely wrong, but not failing yet. It degrades
the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to
carry for two years either.
Minor — 199
Recorded, with no effect on how the codebase functions.
Present so the survey is complete, not because it needs doing.
Could not be resolved — 1
Something this survey could not settle
from the outside, and which could be critical or serious. Either a control was required and no
positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves
nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean
result. These are excluded from the score rather than awarded a pass, so the number on the cover neither
rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each
one is named under Limitations.
Methodology & how to trust this report
This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 72 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.
Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.
What we checked — 72 dimensions across the health lenses
Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.
How to trust any code-health report — three questions
Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 653 of 694 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.
This report answers yes to all three. That's the bar to hold any assessment to.
Tools & methods
The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.
Method
Backs
Version
Evaluator
Roslyn static analysis
Complexity, cohesion, coupling, dead code, API surface, layering
What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.
D11 Test Reliability — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. Test reliability is scored on the 2 tier(s) that produced comparable repeat runs; 1 tier(s) did not, and are excluded from the measurement rather than counted (unit: measured (0 flaky); integration: not included — too large to re-run within its budget; other: measured (0 flaky)). This is OUR limitation, not a defect in the repository.
D12 Dependency Hygiene — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares npm dependencies as well as NuGet ones — manifest: docs/package.json — and the counts on this row cover the NuGet side ONLY. This dimension reads dependency currency from `<PackageReference>` elements via `dotnet list package`; it does not read it, so the npm packages declared there were not checked for newer, deprecated or unmaintained releases. Their absence from the counts above is a gap in this analyzer's ecosystem coverage — not a finding that those dependencies are current.
D14 License Compliance — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares package.json, but the licence verdict published here was taken over its NuGet package dependencies. Nothing was read about its npm dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
D14 License Compliance — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares a Unity UPM manifest (Packages/manifest.json or a package's package.json), but the licence verdict published here was taken over its NuGet package dependencies. Nothing was read about its Upm dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
D23 Boundary Type-Coupling — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Large codebase (23,334 production LoC in the .NET projects) with no declared bounded contexts — cross-boundary type coupling is unassessed Bounded contexts cannot be inferred from a codebase that is not physically organised by them (D-321), so with none declared there are no boundaries for the coupling pass to measure across. You can widen what we reach: name this codebase's bounded contexts (≥2 module groups, e.g. per subsystem) so cross-boundary type coupling can be assessed. Declare them in `.codehealth/config.yaml` at the repository root (create it if absent), mapping each context name to the module-path or namespace prefixes that belong to it — e.g. `architecture:` → `contexts:` → `Billing: ["src/billing", "Acme.Billing"]`, `Catalog: ["src/catalog", "Acme.Catalog"]`.
D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `docs/docusaurus.config.ts`, `perf/Microbenchmark/Microbenchmark.Client/Program.cs`, `perf/SourceGeneratorPerf/SourceGeneratorPerf/Program.cs`, `src/MagicOnion.Client.SourceGenerator/CodeGen/MagicOnionInitializerGenerator.cs`, `src/MagicOnion.Client.SourceGenerator/CodeGen/MemoryPack/MemoryPackFormatterRegistrationGenerator.cs`, … (+18 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
D34 Knowledge Freshness — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. File-level freshness contradicts repo activity: 50 commits in the last 90 days, yet 82 of 104 significant files carry no living knowledge. Those two readings cannot both be true, so the per-file recency signal is treated as unreliable here and freshness is not scored for this run.
IC1 Incompleteness & stubs — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 21 further occurrence(s) are not listed individually; the score already reflects all 61.
M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 reads a prose claim (a path, a setting, a variable, a route, a version, a project, an install, a bare project name in a command) only in text identified as English: the cues that tell a claim from an absence, the past, a plan or an example are an English lexicon, and on other text they would let a false claim through. Links, image targets, fenced commands with an explicit path or a package-manager script, and env-fence variables are checked in every language. 'und' is text the identifier could not name (too short, mixed script, no function words).
M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
P10 Library API & versioning — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 24 further occurrence(s) are not listed individually; the score already reflects all 64.
P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.
PF3 Async & latency hygiene — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 7 further occurrence(s) are not listed individually; the score already reflects all 47.
X1 Async correctness — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 11 further occurrence(s) are not listed individually; the score already reflects all 51.
X2 Cancellation propagation — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 19 further occurrence(s) are not listed individually; the score already reflects all 59.
Repo exclusion declarations: 1 pattern(s) declared (.gitattributes linguist-generated/vendored, .editorconfig generated_code) excluded 0 source file(s) from code-quality scoring. Declarations are the repo's own visible statement that a tree is machine-written or vendored — auditable in any diff, honored by GitHub the same way.
Limitations & what we did not check
We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.
Per-dimension blind spots
For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.
D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
D8 Code Coverage: Coverage is measured by building and running the test suite inside our isolated image — the target repo is never modified, and nothing on your systems runs. So coverage exists only when the suite builds and runs within the inline time budget; one that needs external services, can't build, or exceeds the budget yields no coverage (D8 then degrades to not-measured, not a low score). Line coverage also says nothing about assertion quality.
D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
D11 Test Reliability: Flakiness is inferred from history/markers — we run the suite once (for coverage), not the repeated runs under varied conditions that reveal nondeterminism, so a flaky test never recorded as failing is invisible here.
D12 Dependency Hygiene: Dependency health reads manifests and lockfiles — a vulnerability in a vendored/copied dependency, or risk from how a dependency is actually used, is outside this view.
D13 Secret Scanning: Secret detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
D16 Bus Factor: Bus-factor is a time-decayed model of commit attribution (who has recently, repeatedly worked a file), not comprehension — pairing, review and reading-without-committing spread knowledge it can't see; bot commits and shared accounts still distort it.
D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
D22 Internal API Consistency: API consistency compares the call shapes of members that play the same role on the exposed C# surface: whether the API suits its callers is not measured, and surfaces in other languages are not measured.
D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
D31 IaC & Container Security: IaC scanning checks Dockerfiles/Terraform/Kubernetes against best-practice rules — it cannot see the live cloud account, runtime configuration, or drift between the committed config and what is actually deployed.
D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
ED5 Idempotency: Idempotency is read from the handler body and one hop below: a mutation is flagged only on structural double-apply evidence (a fresh-identity insert, an accumulation, a growing list, an unkeyed POST/send/charge), so a duplicate effect through a home-grown gateway two hops down, or an insert keyed on the message with no unique constraint, is not flagged but counted as not classified; a guard enforced by a database constraint or a broker's exactly-once delivery is invisible either way. It flags the at-least-once double-apply SHAPE, not a runtime proof of a duplicate effect.
M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
P4 Deployment & Rollback: Approval/branch-protection rules live in repository settings the scan cannot see — only their in-repo evidence (config files, workflows) is checked, so a control enforced purely in the host's settings reads as "not evidenced".
P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.
What it measures: How tangled the control flow is — methods with many branches are hard to test and change.
Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.
13 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was RunScenarioAsync at 34. A further 9 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being CpuModel.GetArmCpuName at 243 — they are counted neither in the figure above nor in this dimension's score. 5 files carry no cyclomatic complexity row at all for this reason — every one of their over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: perf/BenchmarkApp/PerformanceTest.Shared/ApplicationInformation.cs (CpuModel.GetArmCpuName at 243), src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs (MagicOnionJsonTranscodingGrpcMethodBinder.MapStatusCodeToHttpStatus at 18), src/MagicOnion.Client/DynamicClient/ServiceClientDefinition.cs (ServiceClientDefinition.GetRequestTypeFromMethod at 17), src/MagicOnion.Serialization.MessagePack/DynamicArgumentTupleFormatter.cs (DynamicArgumentTupleFormatter.Deserialize at 17), src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs (MethodHandlerMetadataFactory.GetRequestTypeFromMethod at 17). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.
+ 8 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 13 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with RunScenarioAsync (cyclomatic 34), DynamicStreamingHubClientBuilder.DefineMethods (cyclomatic 32), DynamicMagicOnionMethodProvider.GetGrpcMethods (cyclomatic 26). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 13 together lifts Cyclomatic Complexity from 8.1 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.
Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How hard the code is for a person to follow, beyond raw branching.
Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.
+ 11 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Bring the 2 bodies over 30 down to 30 or less in Cognitive Complexity — start with DynamicStreamingHubClientBuilder.DefineMethods (cognitive 56), DynamicMagicOnionMethodProvider.GetGrpcMethods (cognitive 43). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 2 together lifts Cognitive Complexity from 7.3 to about 8.0/10, projected with the scoring formula itself and assuming each lands exactly at 30; a cleaner split scores higher.
Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D3 · God Classes9.3 / 10Stronggated by 4 serious findings✓ Tool-verified
What it measures: Over-large classes that try to do too much ("god classes").
Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.
Resolve the 2 MethodTooLong finding(s) in God Classes — start with ApplicationInformation.cs, DynamicStreamingHubClientBuilder.cs. — One of this dimension's main actionable groups (2 warning-level).
Resolve the 1 FileTooLong finding(s) in God Classes — start with DynamicArgumentTupleConverterFactory.cs. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 TooManyMethods finding(s) in God Classes — start with StreamingHubClientBase.cs. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.
Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.
41 duplicated block group(s) detected. 10.0 % of the production lines (2,329 of 23,334) are in a reported copy. A further 63 rows report members as variants of one another; the share counts each copied line once, however many rows cite it. 10 of the 104 are in trees this repository does not ship — vendored, example/demo, project-template, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.
Edited copy of a member (9 corresponding lines) · ×4src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:143
Edited copy of a member (12 corresponding lines) · ×3src/MagicOnion.Server/Filters/Internal/FilterHelper.cs:72
+ 49 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 4 Edited copy of a member (9 corresponding lines) finding(s) in Code Duplication — start with MethodHandlerMetadata.cs, StreamingHubClient.cs, StreamingHubClientTestHelper.cs. — One of this dimension's main actionable groups (4 warning-level).
Resolve the 3 Edited copy of a member (12 corresponding lines) finding(s) in Code Duplication — start with FilterHelper.cs, StreamingContext.Duplex.cs, MagicOnionClientFactoryProvider.cs. — One of this dimension's main actionable groups (3 warning-level).
Resolve the 3 Duplicated block (9 lines × 2) finding(s) in Code Duplication — start with MethodCollector.cs, DynamicStreamingHubClientBuilder.cs, StreamingHubMessageWriter.cs. — One of this dimension's main actionable groups (3 warning-level).
Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D5 · Coupling9.9 / 10Stronggated by 1 serious finding✓ Tool-verified
What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.
Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.
Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.
Resolve the 1 Unstable project MagicOnion finding(s) in Coupling — start with MagicOnion.csproj. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether a class's methods are focused on a single responsibility.
Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.
Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.
What it measures: How much of the code is actually exercised by tests.
Method: Coverage from the analyzer's own run of the suite, computed per-file with structured exclusions for generated, trivial, and glue code. A coverage report found in the repository is never read. When the suite can't be built/run in-image, coverage is reported NOT-MEASURED (excluded from the score) with the precondition to make it measurable — never a LoC-ratio proxy folded in as if measured. Deterministic.
No test project references MagicOnion.Internalsrc/MagicOnion.Internal/MagicOnion.Internal.csproj
No test project references PerformanceTest.Sharedperf/BenchmarkApp/PerformanceTest.Shared/PerformanceTest.Shared.csproj
No test project references PerformanceTest.Clientperf/BenchmarkApp/PerformanceTest.Client/PerformanceTest.Client.csproj
No test project references PerformanceTest.Serverperf/BenchmarkApp/PerformanceTest.Server/PerformanceTest.Server.csproj
No test project references MagicOnion.Server.JsonTranscoding.Swaggersrc/MagicOnion.Server.JsonTranscoding.Swagger/MagicOnion.Server.JsonTranscoding.Swagger.csproj
+ 1 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 1 No test project references MagicOnion.Internal finding(s) in Code Coverage — start with MagicOnion.Internal.csproj. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 No test project references PerformanceTest.Shared finding(s) in Code Coverage — start with PerformanceTest.Shared.csproj. — One of this dimension's main actionable groups (1 warning-level).
Resolve the 1 No test project references PerformanceTest.Client finding(s) in Code Coverage — start with PerformanceTest.Client.csproj. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d8_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D10 · Test Quality9.9 / 10Stronggated by 6 serious findings✓ Tool-verified
What it measures: Whether the tests truly assert behaviour rather than just running the code.
Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.
Resolve the 4 No assertions finding(s) in Test Quality — start with UnaryResultNonGenericTest.cs (2), StreamingHubTest.cs (2). — One of this dimension's main actionable groups (4 warning-level).
Resolve the 2 Fixed-sleep synchronisation finding(s) in Test Quality — start with StreamingHubTest.cs (2). — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d10_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D11 · Test Reliability10.0 / 10Exemplary✓ Tool-verified
What it measures: Whether the tests pass reliably, with no flakiness.
Method: Suite re-run N times within tiered wall-clock budgets (unit to e2e); tests failing non-deterministically across runs flagged; guarded tests retried when #if guards detected.
Only 2 of 3 test tiers measured — the score covers those alone. 0 flaky across 2 measured tier(s). unit: measured (0 flaky); integration: not included — too large to re-run within its budget; other: measured (0 flaky).
What it measures: Whether dependencies are current, not deprecated, and not bloated. Known vulnerabilities are D30's.
Method: Manifest scan via dotnet list package across all projects; worst-signal-per-package deduction (capped-linear for deprecation, prerelease and outdated) per KLoC. Known-vulnerable packages are D30's and are not charged here (rubric-2026.11.2). Exhaustive.
Resolve the 11 Outdated finding(s) in Dependency Hygiene — start with REDACTED (11). — One of this dimension's main actionable groups (11 recommendation-level).
Detailed fixes: d12_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.
Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.
What it measures: Whether the licenses of third-party packages are compatible with your policy.
Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.
0 of 120 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 34 direct `PackageReference`(s), and 117 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution. ★ COVERAGE OF THIS VERDICT: it grades this repository's NuGet package dependencies and nothing else. The repository also declares package.json and a Unity UPM manifest (Packages/manifest.json or a package's package.json), and the licences of those dependency graphs were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.
What it measures: Files that change often and are also complex — the riskiest hotspots.
Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.
What it measures: Whether knowledge is concentrated in too few people (the "bus factor").
Method: Living knowledge per author via time-decayed commit attribution (6-month half-life, focus weighting) across largest source files. Deterministic, avoids blame's mechanical-refactor false positives.
21 source file(s) have their living knowledge concentrated in one author (≥90% of recent, decayed contribution). The largest is src/MagicOnion.Client/StreamingHubClientBase.cs. Counted over 104 of the 225 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.
Off-boarding risk: anonymized user #1 · ×2
What to do
Resolve the 2 Off-boarding risk finding(s) in Bus Factor. — One of this dimension's main actionable groups (2 recommendation-level).
Detailed fixes: d16_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D17 · Explicit Debt5.0 / 10Weak✓ Tool-verified
What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.
Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.
Dead code: UnaryArgRefReturnRef · ×60perf/BenchmarkApp/PerformanceTest.Shared/IPerfTestService.cs:10
+ 5 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 13 WriteOnlyPrivateField finding(s) in Explicit Debt — start with BroadcastScenario.cs (2), SystemTextJsonMessageSerializer.cs (2), HubMethodBenchmarks.cs. — One of this dimension's main actionable groups (13 issue-level).
Resolve the 10 EmptyCatchBlock finding(s) in Explicit Debt — start with StreamingHubClientBase.cs (3), UnaryResult.cs (2), Program.cs. — One of this dimension's main actionable groups (10 issue-level).
Resolve the 6 NoWarnInCsproj finding(s) in Explicit Debt — start with MagicOnion.Server.Redis.csproj (4), MagicOnion.csproj, REDACTED. — One of this dimension's main actionable groups (6 issue-level).
Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the solution is laid out in a sensible, conventional structure.
Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.
68 projects, 958 source files, 47241 hand-written lines of code (23334 production / 23907 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), 136 inter-project edges.
What it measures: Whether the project's documentation is clear, complete, and useful.
Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.
2 of 2 documentation facets pass in full. 153 document(s) read across 17 unit(s).
✓ On the Gold path — maintain.
Detailed fixes: d19_recommendation.md.
Do you agree with this assessment?
D22 · Internal API Consistency10.0 / 10Exemplary○ Nothing flagged
What it measures: Whether the internal API surface is consistent and coherent.
Method: Call-shape rules (A1-A9) over the structured code model of the intentionally exposed C# surface: members of one type, overloads of one name and the same slot across sibling types are compared, and a member that makes a caller use a different convention for the same kind of operation is flagged. Deterministic, no model. Advisory.
What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).
Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.
doc comments repeat the names · ×8src/MagicOnion.Abstractions/ServiceNameAttribute.cs:31
What to do
Resolve the 22 redundant comment finding(s) in Comment Value — start with Program.cs (6), MagicOnionSourceGeneratorVerifier.cs (4), StreamingHubClientBase.cs (2). — One of this dimension's main actionable groups (22 recommendation-level).
Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.
1 of 41 projects flagged as possibly oversized/incoherent.
Projects may be oversized for their cohesionsrc/MagicOnion.Server/MagicOnion.Server.csproj:1
✓ On the Gold path — maintain.
Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.
Do you agree with this assessment?
D27 · Navigability7.0 / 10Strong✓ Tool-verified
What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.
Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.
Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.
82 % of calls cross a namespace and 4 % go through an interface, but 69 % of collaborators are co-located — so following a call takes several hops. Baseline: medium — clean/modular boundaries expected.
Resolve the 3 Pass-through layer finding(s) in Navigability — start with MagicOnionMethodInvoker.cs (3). — One of this dimension's main actionable groups (3 recommendation-level).
Detailed fixes: d27_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.
Method: Secret scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.
5 finding(s): 0 critical, 5 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.
REDACTED
REDACTED
What to do
Resolve the 5 High secret finding(s) in Secrets (history) — start with REDACTED (5). — One of this dimension's main actionable groups (5 issue-level).
Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).
Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.
Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.
Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).
45 finding(s): 0 critical, 43 high, 2 medium, 0 low. 34 unpinned-GitHub-Actions row(s) are reported here but scored by D36 (supply-chain provenance), which measures that posture as `pinned_actions` — one pinning decision is charged once, not once per lens. semgrep hit a parse error in 35 file(s) — `docs/docusaurus.config.ts` (line 67, line 166), `perf/BenchmarkApp/PerformanceTest.Client/Program.cs` (lines 633–634, line 644), `perf/BenchmarkApp/PerformanceTest.Server/PerfGroupService.cs` (line 6), `perf/BenchmarkApp/PerformanceTest.Server/PerfTestBroadcastHub.cs` (line 6), `perf/BenchmarkApp/PerformanceTest.Server/PerfTestService.cs` (line 10), … (+30 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 20 of those file(s) — `perf/BenchmarkApp/PerformanceTest.Client/Program.cs`, `perf/BenchmarkApp/PerformanceTest.Server/PerfGroupService.cs`, `perf/BenchmarkApp/PerformanceTest.Server/PerfTestBroadcastHub.cs`, `perf/BenchmarkApp/PerformanceTest.Server/PerfTestService.cs`, `perf/BenchmarkApp/PerformanceTest.Shared/MagicOnionIsLatestAttirbute.cs`, … (+15 more) — the break is a C# primary constructor, which semgrep's grammar cannot parse and which hides the type from every rule scoped to it; those files were re-scanned from a shadow copy with the constructor's parameter list blanked (line and column preserving), which restores the type to the rules, and 0 additional row(s) came from that pass. Only the header's own parameter list is unread in them. In 7 of those file(s) — `perf/SourceGeneratorPerf/SourceGeneratorPerf/Program.cs`, `samples/ChatApp/ChatApp.Console/Program.cs`, `src/MagicOnion.Client.SourceGenerator/CodeGen/MagicOnionInitializerGenerator.cs`, `src/MagicOnion.Client.SourceGenerator/CodeGen/MemoryPack/MemoryPackFormatterRegistrationGenerator.cs`, `src/MagicOnion.Client.SourceGenerator/CodeGen/MessagePack/MessagePackFormatterResolverGenerator.cs`, … (+2 more) — the break is at a TYPE DECLARATION (a C# primary constructor semgrep's grammar cannot parse), so the loss is wider than the named lines: rules scoped to that type see no type to scope to and are blind over its whole body, while rules matching statements keep working there. Absence of a type-scoped finding in those types is not evidence of anything.
REDACTED
REDACTED
REDACTED
REDACTED
REDACTED
+ 2 more group(s) — more in Appendix A; the complete list is findings.md.
What to do
Resolve the 6 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (3), REDACTED (2), REDACTED. — One of this dimension's main actionable groups (6 issue-level).
No action in Static Analysis (SAST) — all 20 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (20 issue-level, 0 of them charged here).
No action in Static Analysis (SAST) — all 14 REDACTED finding(s) are reported here at file:line but scored by D36 (supply-chain provenance), so none is charged to this dimension. — One of this dimension's main actionable groups (14 issue-level, 0 of them charged here).
Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.
Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
Resolve the 3 High CVE finding(s) in Dependency Vulnerabilities — start with REDACTED (2). — One of this dimension's main actionable groups (3 issue-level).
Resolve the 2 Medium CVE finding(s) in Dependency Vulnerabilities — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 warning-level).
Detailed fixes: d30_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.
Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.
Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.
Resolve the 1 Change coupling finding(s) in Change Coupling — start with Program.cs. — One of this dimension's main actionable groups (1 warning-level).
Detailed fixes: d35_recommendation.md · top locations in Appendix A, every location in findings.md.
What it measures: Whether the build pipeline provides supply-chain integrity — generated provenance/attestation, signed artifacts (cosign/sigstore), an SBOM, and pinned build actions. Presence of the configuration, not a runtime guarantee.
Method: Supply-chain provenance/signing read deterministically from CI/build config (.github/workflows, .gitlab-ci.yml, azure-pipelines, Jenkinsfile, .circleci) + the release surface: four signals — generated provenance/attestation (SLSA/in-toto/actions-attest), artifact signing (cosign/sigstore/gitsign), an SBOM (syft/sbom-action/*.spdx.json/*.cdx.json), and SHA-pinned build actions — scored 10·present/denom. NotApplicable without a build pipeline. Detects configuration presence, not runtime enforcement.
What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.
Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.
What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.
Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.
0 end-of-life runtime(s) and 0 end-of-life framework(s), read from 41 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.
Other · Architecture — Whether any singleton service captures a scoped/transient dependency — a silent lifetime/threading bug.
Method: Roslyn scan: DI registrations parsed from AddSingleton/Scoped/Transient; each singleton checked for captured shorter-lifetime dependencies. Exhaustive, deterministic.
Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.
Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.
Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.
Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.
Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.
`MagicOnionManagedGroupProvider` is a singleton (one shared instance) but mutates instance state outside any lock (groups; e.g. `groups` at line 28). — src/MagicOnion.Server/Hubs/Internal/MagicOnionManagedGroupProvider.cs:5
`ServerBroadcastMetricsContext` is not registered, but the singleton `PerfGroupService` creates it and keeps it in `metricsContext`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (isRunning, targetFps, startTimestamp, elapsed; e.g. `isRunning` at line 27). — perf/BenchmarkApp/PerformanceTest.Server/ServerBroadcastMetricsContext.cs:3
`HardwarePerformanceReporter` is not registered, but the singleton `ProfileService` creates it and keeps it in `hardwarehardwarePerformanceReporter`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (running; e.g. `running` at line 33). — perf/BenchmarkApp/PerformanceTest.Shared/Reporting/HardwarePerformanceReporter.cs:6
`MagicOnionTypeInfo` is not registered, but `KnownTypes` creates it and keeps it in the static `System_Void`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (fullName, fullNameOpenType; e.g. `fullName` at line 44). — src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MagicOnionTypeInfo.cs:6
`ObjectPool` is not registered, but the singleton `StreamingHubPayloadPool` creates it and keeps it in `pool`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (item1, item2, item3, item4; e.g. `item1` at line 25). — src/MagicOnion.Internal/StreamingHubPayloadPool.BuiltIn.cs:8
`DynamicArgumentTupleFormatter` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (isRegistered; e.g. `isRegistered` at line 16). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:10
`MagicOnionServerInternalLogger` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (logger; e.g. `logger` at line 16). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — src/MagicOnion.Server/MagicOnionServerInternalLogger.cs:6
What to do
Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
A `static` field is one slot for the whole process, however its type is created: back it with a thread-safe type (ConcurrentDictionary, Interlocked), take a lock around every write, or move it into a registered singleton that does.
Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).
Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.
The namespaces MagicOnion ↔ MagicOnion.Client ↔ MagicOnion.Client.Internal depend on each other. The lightest dependency in the cycle is MagicOnion → MagicOnion.Client (MagicOnion.UnaryResult → MagicOnion.Client.IResponseContext, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/MagicOnion.Abstractions/UnaryResult.cs:2
The namespaces MagicOnion.Server ↔ MagicOnion.Server.Binder ↔ MagicOnion.Server.Diagnostics ↔ MagicOnion.Server.Features.Internal ↔ MagicOnion.Server.Filters ↔ MagicOnion.Server.Hubs ↔ MagicOnion.Server.Hubs.Internal ↔ MagicOnion.Server.Internal depend on each other. The lightest dependency in the cycle is MagicOnion.Server → MagicOnion.Server.Hubs (MagicOnion.Server.ThroughFilter → MagicOnion.Server.Hubs.StreamingHubContext, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — src/MagicOnion.Server/FromServiceFilterAttribute.cs:1
What to do
Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.
Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.
Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.
Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.
Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').
Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.
Do you agree with this assessment?
AX8 · Test isolation10.0 / 10Exemplary✓ Tool-verified
Other · Architecture — Whether production projects stay free of references to test projects — tests may depend on production, never the reverse.
Method: Csproj graph: each production project checked for references to test projects (identified by test-framework presence, not name). Zero violations is clean. Deterministic.
Other · Security — Whether access is authorized by default — a framework authorization attribute/decorator or policy, or imperative guard methods (throw-on-violation) called from handlers.
Method: Roslyn scan: [Authorize] usage and authorization policies, plus imperative throw-on-violation guard methods detected via syntax. Deterministic.
Other · Readiness — Whether retry-prone mutations (command handlers and message or event consumers) are idempotent, so an at-least-once redelivery or a client retry does not apply the effect twice.
Method: Roslyn (any mutation, ungated): each persistent write of a command handler or message/event consumer is idempotent when a guard is visible (an exists/dedup read that gates an exit, upsert, idempotency-key/inbox used in a condition or store call, versioned or fixed-value write, dedup envelope or pipeline), at risk only on positive double-apply evidence (a fresh-identity insert, an accumulation on a loaded and saved object, a growing member list, an unkeyed POST/SMTP send/Stripe charge), and otherwise not classified. Deterministic, no model; not scored when more than half are not classified. Advisory.
Coverage: Population: retry-prone mutations — command handlers (CQRS write side) + message/event consumers (IConsumer/I*EventHandler) — that mutate persistent state; runs on any repo with mutations, not only event-driven ones. Every mutation is classified exhaustively and deterministically: guarded, at risk on positive evidence, or not classified; the score is over the classified ones and is withheld when they are fewer than half.
Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.
Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.
A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×10) — perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:45, perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:48, perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:51, …
What to do
Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.
Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.
`CreatePropagationTokenCore` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:28
`ResponseTrailersCore` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:72
`WriteOptionsCore` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:74
`AuthContextCore` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:75
The branch `if (!type.GetInterfaces().Any(x => x.IsGenericType && (x.GetGenericTypeDefinition() == typeof(IService<>) || x.GetGenericTypeDefinition() == typeof(IStreamingHub<,>))))` throws `InvalidOperationException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. — src/MagicOnion.Server/Binder/IMagicOnionGrpcMethodProvider.cs:42
The first 2 statements of the `if` and of the `else` are identical, so they run on both paths regardless of the condition. Lift them above the `if` — leaving them duplicated inside makes the branches read as though they handled this differently. — src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:120
The branch `if (!typeof(IMagicOnionServiceFilter).IsAssignableFrom(type) && !typeof(IStreamingHubFilter).IsAssignableFrom(type))` throws `ArgumentException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. — src/MagicOnion.Server/FromServiceFilterAttribute.cs:24
A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×33) — src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MagicOnionTypeInfo.cs:106, src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MagicOnionTypeInfo.cs:109, src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MethodCollector.cs:136, …
What to do
Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.
Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.
What to do
Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.
Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.
No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
`docs/docs/streaminghub/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape. — docs/docs/streaminghub/fundamentals.md:8
`docs/docs/streaminghub/group-backplane.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape. — docs/docs/streaminghub/group-backplane.md:7
`docs/docs/unary/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape. — docs/docs/unary/fundamentals.md:6
`docs/i18n/ja/docusaurus-plugin-content-docs/current/streaminghub/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape. — docs/i18n/ja/docusaurus-plugin-content-docs/current/streaminghub/fundamentals.md:8
`docs/i18n/ja/docusaurus-plugin-content-docs/current/streaminghub/group-backplane.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape. — docs/i18n/ja/docusaurus-plugin-content-docs/current/streaminghub/group-backplane.md:7
`docs/i18n/ja/docusaurus-plugin-content-docs/current/unary/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape. — docs/i18n/ja/docusaurus-plugin-content-docs/current/unary/fundamentals.md:6
`docs/i18n/ko/docusaurus-plugin-content-docs/current/streaminghub/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape. — docs/i18n/ko/docusaurus-plugin-content-docs/current/streaminghub/fundamentals.md:8
`docs/i18n/ko/docusaurus-plugin-content-docs/current/streaminghub/group-backplane.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape. — docs/i18n/ko/docusaurus-plugin-content-docs/current/streaminghub/group-backplane.md:7
`docs/i18n/ko/docusaurus-plugin-content-docs/current/unary/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape. — docs/i18n/ko/docusaurus-plugin-content-docs/current/unary/fundamentals.md:5
What to do
Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
Update docs/docs/streaminghub/fundamentals.md so it draws the parts the code has today: add PerformanceTest.Shared, JwtAuthApp.Shared.
Update docs/docs/streaminghub/group-backplane.md so it draws the parts the code has today: add PerformanceTest.Shared, JwtAuthApp.Shared.
Update docs/docs/unary/fundamentals.md so it draws the parts the code has today: add PerformanceTest.Shared, JwtAuthApp.Shared.
Update docs/i18n/ja/docusaurus-plugin-content-docs/current/streaminghub/fundamentals.md so it draws the parts the code has today: add PerformanceTest.Shared, JwtAuthApp.Shared.
Update docs/i18n/ja/docusaurus-plugin-content-docs/current/streaminghub/group-backplane.md so it draws the parts the code has today: add PerformanceTest.Shared, JwtAuthApp.Shared.
Update docs/i18n/ja/docusaurus-plugin-content-docs/current/unary/fundamentals.md so it draws the parts the code has today: add PerformanceTest.Shared, JwtAuthApp.Shared.
Update docs/i18n/ko/docusaurus-plugin-content-docs/current/streaminghub/fundamentals.md so it draws the parts the code has today: add PerformanceTest.Shared, JwtAuthApp.Shared.
Update docs/i18n/ko/docusaurus-plugin-content-docs/current/streaminghub/group-backplane.md so it draws the parts the code has today: add PerformanceTest.Shared, JwtAuthApp.Shared.
Update docs/i18n/ko/docusaurus-plugin-content-docs/current/unary/fundamentals.md so it draws the parts the code has today: add PerformanceTest.Shared, JwtAuthApp.Shared.
Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.
Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.
Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.
Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.
Readiness · Readiness — Whether an automated pipeline builds and tests every change.
Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.
Do you agree with this assessment?
P10 · Library API & versioning8.5 / 10Strong✓ Tool-verified
Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.
Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language's code model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.
21 public types in `MagicOnion.Internal` are marked as implementation by their own namespace, folder or name: `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:6, `Internal`), `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:6, `Internal`), `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:6, `Internal`), `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:40, `Internal`), `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:40, `Internal`), `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:40, `Internal`), `IAsyncGrpcCallWrapper` (src/MagicOnion.Abstractions/Internal/IAsyncGrpcCallWrapper.cs:5, `Internal`), `IAsyncGrpcCallWrapper` (src/MagicOnion.Abstractions/Internal/IAsyncGrpcCallWrapper.cs:5, `Internal`), and 13 more. While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — src/MagicOnion.Abstractions/Internal/Box.cs:6
12 public types in `MagicOnion.Client.Internal` are marked as implementation by their own namespace, folder or name: `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:10, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:10, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:10, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:10, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:29, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:29, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:29, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:29, `Internal`), and 4 more. While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:10
2 public types in `MagicOnion.Server.Binder.Internal` are marked as implementation by their own namespace, folder or name: `MagicOnionGrpcMethodHandler` (src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:18, `Internal`), `MagicOnionGrpcMethodHandler` (src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:18, `Internal`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:18
2 public types in `MagicOnion.Server.Hubs.Internal` are marked as implementation by their own namespace, folder or name: `StreamingHubHandlerOptions` (src/MagicOnion.Server/Hubs/Internal/StreamingHubHandler.cs:62, `Internal`), `StreamingHubHandlerOptions` (src/MagicOnion.Server/Hubs/Internal/StreamingHubHandler.cs:62, `Internal`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — src/MagicOnion.Server/Hubs/Internal/StreamingHubHandler.cs:62
8 public types in `MagicOnion.Server.Internal` are marked as implementation by their own namespace, folder or name: `MethodHandlerMetadata` (src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:9, `Internal`), `MethodHandlerMetadata` (src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:9, `Internal`), `StreamingHubMethodHandlerMetadata` (src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:90, `Internal`), `StreamingHubMethodHandlerMetadata` (src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:90, `Internal`), `DuplicateKeyException` (src/MagicOnion.Server/Internal/UniqueHashDictionary.cs:6, `Internal`), `DuplicateKeyException` (src/MagicOnion.Server/Internal/UniqueHashDictionary.cs:6, `Internal`), `UniqueHashDictionary` (src/MagicOnion.Server/Internal/UniqueHashDictionary.cs:21, `Internal`), `UniqueHashDictionary` (src/MagicOnion.Server/Internal/UniqueHashDictionary.cs:21, `Internal`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers. — src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:9
`MagicOnion.Client.DynamicClient.DynamicNotSupportedMagicOnionClientFactoryProvider` (src/MagicOnion.Client/DynamicClient/DynamicMagicOnionClientFactoryProvider.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/DynamicClient/DynamicMagicOnionClientFactoryProvider.cs:5
`MagicOnion.Client.DynamicClient.DynamicNotSupportedMagicOnionClientFactoryProvider` (src/MagicOnion.Client/DynamicClient/DynamicMagicOnionClientFactoryProvider.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/DynamicClient/DynamicMagicOnionClientFactoryProvider.cs:5
`MagicOnion.Client.DynamicClient.DynamicNotSupportedStreamingHubClientFactoryProvider` (src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientFactoryProvider.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientFactoryProvider.cs:5
`MagicOnion.Client.DynamicClient.DynamicNotSupportedStreamingHubClientFactoryProvider` (src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientFactoryProvider.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientFactoryProvider.cs:5
`MagicOnion.Client.IMagicOnionAwareGrpcChannel` (src/MagicOnion.Client/IMagicOnionAwareGrpcChannel.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/IMagicOnionAwareGrpcChannel.cs:5
`MagicOnion.Client.IMagicOnionAwareGrpcChannel` (src/MagicOnion.Client/IMagicOnionAwareGrpcChannel.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/IMagicOnionAwareGrpcChannel.cs:5
`MagicOnion.Client.MagicOnionClientFactoryProvider` (src/MagicOnion.Client/MagicOnionClientFactoryProvider.cs:10) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/MagicOnionClientFactoryProvider.cs:10
`MagicOnion.Client.MagicOnionClientFactoryProvider` (src/MagicOnion.Client/MagicOnionClientFactoryProvider.cs:10) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/MagicOnionClientFactoryProvider.cs:10
`MagicOnion.Client.RequestContext` (src/MagicOnion.Client/RequestContext.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/RequestContext.cs:5
`MagicOnion.Client.RequestContext` (src/MagicOnion.Client/RequestContext.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/RequestContext.cs:5
`MagicOnion.Client.StreamingHubClientFactoryProvider` (src/MagicOnion.Client/StreamingHubClientFactoryProvider.cs:10) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/StreamingHubClientFactoryProvider.cs:10
`MagicOnion.Client.StreamingHubClientFactoryProvider` (src/MagicOnion.Client/StreamingHubClientFactoryProvider.cs:10) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Client/StreamingHubClientFactoryProvider.cs:10
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:10) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:10
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:35) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:35
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:74) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:74
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:115) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:115
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:158) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:158
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:203) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:203
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:250) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:250
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:299) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:299
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:350) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:350
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:403) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:403
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:458) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:458
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:515) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:515
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:574) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:574
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:635) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:635
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:698) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:698
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:35) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `PerformanceTest.Client`, `PerformanceTest.Server`, `PerformanceTest.Shared`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:35
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:74) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `PerformanceTest.Client`, `PerformanceTest.Server`, `PerformanceTest.Shared`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:74
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:115) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `PerformanceTest.Client`, `PerformanceTest.Server`, `PerformanceTest.Shared`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:115
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:158) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `PerformanceTest.Client`, `PerformanceTest.Server`, `PerformanceTest.Shared`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:158
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:203) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `PerformanceTest.Client`, `PerformanceTest.Server`, `PerformanceTest.Shared`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:203
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:250) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `PerformanceTest.Client`, `PerformanceTest.Server`, `PerformanceTest.Shared`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:250
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:299) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `PerformanceTest.Client`, `PerformanceTest.Server`, `PerformanceTest.Shared`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:299
`MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:350) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `PerformanceTest.Client`, `PerformanceTest.Server`, `PerformanceTest.Shared`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such. — src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:350
What to do
Hide `MagicOnion.Internal` (`Box`, `Box`, `Box`, `Box`, `Box`, `Box`, `IAsyncGrpcCallWrapper`, `IAsyncGrpcCallWrapper`, and 13 more) (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
Hide `MagicOnion.Client.Internal` (`RawMethodInvoker`, `RawMethodInvoker`, `RawMethodInvoker`, `RawMethodInvoker`, `RawMethodInvoker`, `RawMethodInvoker`, `RawMethodInvoker`, `RawMethodInvoker`, and 4 more) (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
Hide `MagicOnion.Server.Binder.Internal` (`MagicOnionGrpcMethodHandler`, `MagicOnionGrpcMethodHandler`) (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
Hide `MagicOnion.Server.Hubs.Internal` (`StreamingHubHandlerOptions`, `StreamingHubHandlerOptions`) (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
Hide `MagicOnion.Server.Internal` (`MethodHandlerMetadata`, `MethodHandlerMetadata`, `StreamingHubMethodHandlerMetadata`, `StreamingHubMethodHandlerMetadata`, `DuplicateKeyException`, `DuplicateKeyException`, `UniqueHashDictionary`, `UniqueHashDictionary`) (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): its own namespace, folder or name already says it is implementation, and hidden it can change without breaking a consumer.
Make `MagicOnion.Client.DynamicClient.DynamicNotSupportedMagicOnionClientFactoryProvider` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Client.DynamicClient.DynamicNotSupportedMagicOnionClientFactoryProvider` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Client.DynamicClient.DynamicNotSupportedStreamingHubClientFactoryProvider` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Client.DynamicClient.DynamicNotSupportedStreamingHubClientFactoryProvider` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Client.IMagicOnionAwareGrpcChannel` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Client.IMagicOnionAwareGrpcChannel` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Client.MagicOnionClientFactoryProvider` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Client.MagicOnionClientFactoryProvider` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Client.RequestContext` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Client.RequestContext` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Client.StreamingHubClientFactoryProvider` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Client.StreamingHubClientFactoryProvider` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.DynamicArgumentTupleFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.UnsafeDirectBlitArrayFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.UnsafeDirectBlitFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.UnsafeDirectBlitArrayFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.UnsafeDirectBlitFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.UnsafeDirectBlitArrayFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.UnsafeDirectBlitFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.UnsafeDirectBlitArrayFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Serialization.MessagePack.UnsafeDirectBlitFormatter` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Server.JsonTranscoding.MagicOnionJsonTranscodingGrpcMethodBinder` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Server.JsonTranscoding.MagicOnionJsonTranscodingGrpcMethodBinder` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Server.JsonTranscoding.MagicOnionJsonTranscodingServerCallContext` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `MagicOnion.Server.JsonTranscoding.MagicOnionJsonTranscodingServerCallContext` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Microsoft.AspNetCore.Builder.MagicOnionServiceEndpointConventionBuilder` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Make `Microsoft.AspNetCore.Builder.MagicOnionServiceEndpointConventionBuilder` internal (C#: `internal`, with `[InternalsVisibleTo]` for the sibling assemblies and tests that need them): only the library itself uses it and nothing on its public API exposes it, so hiding it costs consumers nothing and lets it change freely.
Do you agree with this assessment?
P2 · Observability7.5 / 10Strong✓ Tool-verified
Readiness · Readiness — Whether the code is diagnosable in production — structured logging, tracing/metrics, health checks.
Only 5/10 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 10, 5 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 23 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:23
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 24 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:24
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 25 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:25
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 26 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:26
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 27 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:27
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 28 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:28
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 29 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:29
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 31 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:31
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 32 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:32
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 33 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:33
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 35 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:35
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 36 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:36
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 37 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:37
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 38 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:38
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 39 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:39
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 40 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:40
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 41 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:41
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 42 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:42
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 43 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:43
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 44 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:44
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 45 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:45
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 46 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:46
`perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 48 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters. — perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:48
What to do
Extend structured logging across the projects you operate, and give the library ones a diagnostics seam instead — an `EventSource`/`ActivitySource` the host can subscribe to, or an optional logger on your options object — rather than taking a logging dependency on your consumers' behalf.
Replace `Console.Write…` in service code with the project's injected `ILogger<T>` (message templates with named properties), so delivery outcomes and failures reach the log pipeline with a level and a category.
Add a health-check endpoint (AddHealthChecks/MapHealthChecks) so orchestrators and load balancers can probe liveness/readiness.
Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).
Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.
`.github/dependabot.yaml` schedules updates, but no `package-ecosystem` entry covers `nuget`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entry to the `updates:` list. — .github/dependabot.yaml:3
What to do
Dependabot is configured but does not watch `nuget` — add that `package-ecosystem` entry to .github/dependabot.yml so those dependencies get the same automatic update and advisory pressure as the ones it already covers.
Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
Readiness · Readiness — Whether releases are automated and safely reversible (probes, rolling updates, approval gates) — from manifests/pipeline files, not the live environment.
Method: Filesystem scan: deployment manifests/IaC (K8s YAML, Helm, Terraform) for rolling updates, probes, approval gates, migration hooks. Exhaustive, deterministic.
Readiness · Readiness — Whether outbound HTTP calls are wrapped in resilience (retry/timeout/circuit-breaker) so a failing dependency doesn't cascade.
Method: Source scan: outbound HTTP clients and what bounds them — resilience handlers (Polly, AddStandardResilienceHandler) on .NET; on Go, the JVM, Python, JavaScript/TypeScript, Ruby, PHP, Rust, Elixir, Swift, Dart and Erlang, a timeout, deadline, retry or breaker beside each call, or a process-wide client default (a framework-wide deadline such as Drupal core's, Laravel's or actix's awc counts). Exhaustive, deterministic.
`new HttpClient()` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default). — perf/BenchmarkApp/PerformanceTest.Shared/Reporting/DatadogMetricsRecorder.cs:46
What to do
Add `AddStandardResilienceHandler()` (or a Polly policy and an explicit timeout) to each client registration flagged here, so a flaky dependency can't take the app down.
Readiness · Performance — Whether the code protects its performance with benchmarks — a benchmark suite, allocation/memory measurement, and (ideally) a CI gate. Presence is credited as a bonus, never a deduction.
Method: Repo + source scan: BenchmarkDotNet referenced (csproj/source), [Benchmark]/[MemoryDiagnoser] attribute counts, and a benchmark step in CI; off .NET, the same ladder over Go testing.B, Rust criterion/#[bench]/divan, JMH/kotlinx-benchmark, pytest-benchmark/asv/pyperf, tinybench/mitata/vitest bench/benchmark.js and Swift package-benchmark — scored as a bonus ladder (absence is neutral, never a deduction). Deterministic, presence detection.
A BenchmarkDotNet suite exists but no [MemoryDiagnoser] — allocations (the main way hot code pressures the GC) aren't being measured.
What to do
Add [MemoryDiagnoser] to the benchmarks so allocation regressions are visible, not just time.
Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.
Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.
7 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
`.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×3) — perf/Microbenchmark/Microbenchmark.Client/HubMethodBenchmarks.cs:43, perf/Microbenchmark/Microbenchmark.Client/HubReceiverBroadcastBenchmarks.cs:21, src/MagicOnion.Server/Binder/MagicOnionUnaryMethod.cs:84
`Received.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one). (×4) — perf/Microbenchmark/Microbenchmark.Client/HubReceiverBroadcastBenchmarks.cs:42, perf/Microbenchmark/Microbenchmark.Client/HubReceiverBroadcastBenchmarks.cs:49, perf/Microbenchmark/Microbenchmark.Client/HubReceiverBroadcastBenchmarks.cs:56, …
Only 43/81 awaits in library code use ConfigureAwait(false). A library that captures the caller's context can stall or deadlock its host — the classic way a dependency drags an app down.
`await InterceptInvokeHelper.InvokeWithFilter(requestContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:68
`await ConnectAsync<TStreamingHub, TReceiver>(channel.CreateCallInvoker(), receiver,...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Client/StreamingHubClient.cs:31
`await context.Request.BodyReader.CopyToAsync(memStream)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:63
`await unaryMethodHandler(handle.Instance, request, serverCallContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:70
`await WriteErrorResponseAsync(context, ex)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:79
`await serviceActivator.ReleaseAsync(handle)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:85
`await JsonSerializer.SerializeAsync(context.Response.Body, new { Code = (int)status...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:101
`await JsonSerializer.SerializeAsync(context.Response.Body, new { Code = (int)Status...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:206
`await wrappedBody(serviceContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. (×4) — src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:87, src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:163, src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:234, …
`await autoDisposeGroupProvider.GetOrAddAsync($"{prefix}/{groupName}", streamingCont...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/HubGroupRepository.cs:32
`await autoDisposeGroupProvider.RemoveAsync(item, streamingContext.ContextId)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/HubGroupRepository.cs:41
`await @lock.WaitAsync()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. (×2) — src/MagicOnion.Server/Hubs/Internal/MagicOnionManagedGroupProvider.cs:21, src/MagicOnion.Server/Hubs/Internal/MagicOnionManagedGroupProvider.cs:53
`await underlyingGroup.AddAsync(contextId, client)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/Internal/MagicOnionManagedGroupProvider.cs:31
`await underlyingGroup.RemoveAsync(contextId)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/Internal/MagicOnionManagedGroupProvider.cs:60
`await runningTimer.WaitForNextTickAsync()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/Internal/StreamingHubHeartbeatManager.cs:219
`await OnConnecting()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:115
`await HandleMessageAsync()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:116
`await CleanupSafeAsync(static hub => hub.OnDisconnected(), this)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:158
`await CleanupSafeAsync(static hub => hub.Group.DisposeAsync(), this)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:159
`await action(hub)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:171
`await Context.CallContext.WriteResponseHeadersAsync(ResponseHeaders)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:188
`await writer.WriteAsync(StreamingHubPayloadPool.Shared.RentOrCreate(MarkerResponseB...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:192
`await OnConnected()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:201
`await reader.MoveNext(ct)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:208
`await ProcessMessageAsync(payload, ct)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:212
`await foreach (… in requests.Reader.ReadAllAsync(default))` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:226
`await handler.MethodBody.Invoke(hubContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`. — src/MagicOnion.Server/Hubs/StreamingHub.cs:249
What to do
Make the call chain async end-to-end and await it — never block on a Task with .Wait()/.GetAwaiter().GetResult().
In library code, append .ConfigureAwait(false) to every await (or set <ConfigureAwait>false</ConfigureAwait> / use the analyzer CA2007) so the library never captures the host's context.
Other · Security — Transport security, security headers, secure cookies, input validation, middleware order and crypto hygiene (presence, not runtime).
Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.
`userInfo.Password == password` checks a password against the stored one in plaintext, so the store holds the password itself and whoever reads it holds every account. Store a salted KDF hash (PBKDF2/scrypt/Argon2/bcrypt) and verify by deriving again. — samples/JwtAuthentication/JwtAuthApp.Server/Services/AccountService.cs:37
`RemoteCertificateValidationCallback` is assigned a callback that returns `true` unconditionally, so every TLS peer certificate is accepted — including one an attacker presents. Chain, expiry, revocation and hostname are all skipped, so an attacker on the network path can present any certificate and read or rewrite the traffic — the connection is encrypted to the attacker, not to the intended host. Delete the override and let the platform validate. If a specific self-signed or internally-issued certificate genuinely has to be trusted, pin THAT one — compare the presented certificate's public key or thumbprint against the expected value and return `false` for everything else — and scope it to the single handler that talks to that host rather than to the whole process. If the override exists only to get past a development certificate, gate it on a build configuration or an explicit opt-in setting so it cannot ship. — perf/BenchmarkApp/PerformanceTest.Client/Program.cs:607
`RequireHttpsMetadata = false` allows the OIDC discovery doc to be fetched over plain HTTP. Safe for loopback-only fetches (Aspire / on-host); risky for any other path. — samples/JwtAuthentication/JwtAuthApp.Server/Program.cs:40
`ValidateAudience`, `ValidateIssuer` are all set to `false`, which means a token minted for a DIFFERENT relying party is accepted here. Any other service that trusts the same issuer can have its tokens replayed against this one, which is precisely what the `Audience` value exists to prevent. — samples/JwtAuthentication/JwtAuthApp.Server/Program.cs:35
None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves. (×4) — perf/BenchmarkApp/PerformanceTest.Server/Program.cs:12, samples/ChatApp/ChatApp.Server/Program.cs:6, samples/JsonTranscoding/JsonTranscodingSample.Server/Program.cs:3, …
No ModelState/[ApiController]/FluentValidation signal — inbound payloads reach handlers unvalidated. (−2.0 on this card.)
What to do
Store passwords with a salted KDF — `Microsoft.AspNetCore.Identity.PasswordHasher<T>`, `Rfc2898DeriveBytes` (PBKDF2), or BCrypt/Argon2 — and compare with `CryptographicOperations.FixedTimeEquals`. (A fast/plain hash, or a client-hashed value stored and compared verbatim, is not password storage.) Start in `samples/JwtAuthentication/JwtAuthApp.Server/Services/AccountService.cs:37`.
Stop accepting every TLS certificate: remove the always-true validation callback so the platform verifies the chain, hostname and expiry. If one self-signed certificate must be trusted, pin it by public key or thumbprint on the single handler that needs it and reject all others — never process-wide.
Set RequireHttpsMetadata = true in prod (or pin MetadataAddress to a localhost URL the API can hit directly).
Re-enable token validation — `ValidateAudience` is set to `false`. If it was switched off because the expected value was wrong or absent, supply that value instead (`ValidAudiences`/`ValidIssuers`, or `IssuerSigningKeys`/`IssuerSigningKeyResolver` for the signature) rather than skipping the check: a disabled check accepts every token, not just the one that was failing.
Add security response headers (Content-Security-Policy first, then Strict-Transport-Security, X-Content-Type-Options and a frame policy) — defense in depth, even when a reverse proxy could set them.
Validate inbound models (ModelState/[ApiController]/FluentValidation) to reduce injection and bad-data risk.
Do you agree with this assessment?
X1 · Async correctness3.3 / 10Weak✓ Tool-verified
Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.
Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.
`StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin. (×40) — perf/BenchmarkApp/PerformanceTest.Client/Program.cs:125, perf/BenchmarkApp/PerformanceTest.Client/Program.cs:126, perf/BenchmarkApp/PerformanceTest.Client/Program.cs:128, …
What to do
Blocking `StreamWriter.WriteLine` inside an `async` method
Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.
Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.
Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.
Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).
Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.
Only 23/78 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
No CancellationToken parameter — this work can't be stopped early once started. (×36) — perf/BenchmarkApp/PerformanceTest.Client/BroadcastScenario.cs:18, perf/BenchmarkApp/PerformanceTest.Client/BroadcastScenario.cs:51, perf/BenchmarkApp/PerformanceTest.Client/Program.cs:428, …
Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one. — perf/BenchmarkApp/PerformanceTest.Client/Program.cs:17
No CancellationToken parameter — the body observes an ambient token instead (a field or a context object), so the work does stop on cancellation, but a caller cannot cancel this call independently of the owner that created that token. (×2) — perf/BenchmarkApp/PerformanceTest.Server/PerfTestService.cs:86, samples/JwtAuthentication/JwtAuthApp.Server/Hubs/TimerHub.cs:22
What to do
Thread a CancellationToken through async methods so work stops promptly on cancellation.
Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.
Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements (or a repository exception type deriving from it) controlled by an `if` — directly or through the `using`, `lock` or `try` that wraps the throw — whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`); in the `else` branch, for a conjunct of the admitting condition that is FALSE of a non-null `p`. Range guards are read for bounds that leave nothing and for a `p > C.Count` bound whose index then reaches `C[p]`, `C.RemoveAt(p)` or a method of the same type that indexes with it. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a `when` guard is free of side effects — a guard that increments a counter or assigns while deciding whether its arm matches applies that change during PATTERN MATCHING, on an arm that may not be selected, and skips it entirely when a short-circuit to its left answers first.
Method: Roslyn syntax: `when` guards on case labels and switch-expression arms, read for a mutation (`++`/`--`/assignment) sitting in a position the guard's own `&&`/`||`/`??`/`?:`/`?.` can skip. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a method that TAKES a lock or semaphore and gives it back from a flag-guarded `finally` returns the value that flag implies — reporting success while the guard hands the primitive back admits a second caller the exclusion was there to keep out, and reporting failure while the guard keeps it leaves nothing to ever give it back. Also whether a `finally` that gives the primitive back unconditionally can run in a state where the method does not hold it: after a timed wait whose result was discarded, after an acquire inside the `try` that can fail, after the body already released it, or never, because a `return` left between the acquire and the `try`.
Method: Roslyn syntax: `try` statements whose `finally` releases a synchronisation primitive under a bare local-bool guard, where the method also TOOK that same primitive before the `try`, checked for a `return` of a bool literal whose value disagrees with the flag state the method's own straight-line assignments put it in. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.
Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether a value the caller is invited to supply is the value the type actually uses — a constructor parameter stored in a private field that nothing ever reads while the default it was given is spelled out a second time at the site that should have read it, a keyed lookup that falls back to a different setting than the one its key names while the same type falls back to the matching one for that same key, or a culture-sensitive parse given no format provider by a type that feeds its own settable culture to the same kind of parse elsewhere, or a number an entry point writes to standard output under the host's culture while the same entry point formats with the invariant culture elsewhere. Either way, every caller who supplies a value silently gets something else.
Method: Roslyn syntax: private instance fields of a non-partial type assigned in a constructor from one of its own parameters with a `??` fallback, checked for whether anything in the type body reads the field and whether that same fallback expression is spelled out again outside the constructor; and `??` fallbacks onto a member access from a lookup call carrying exactly one string literal, grouped by that key across the type and checked for a fallback member whose folded name disagrees with the key while a sibling site for the same key agrees with it. On a repository with no .NET source the first two arms read JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `#x`, `private` or `private` parameter-property instance field filled in the constructor from a parameter (or one member of one) through `??`/`||` or a parameter default, never read anywhere in the file by name, whose constructed default is spelled again in the class body; and `lookup("key") ?? s.member` grouped by key per class, or per module outside every class. The culture arm has no JavaScript counterpart: its parses take no locale. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.
Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.
Do you agree with this assessment?
X28 · Index access outside its own emptiness guard3.5 / 10Weak✓ Tool-verified
Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.
Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.
This guard tests `sortedData` for emptiness and then indexes it where the test says it is empty: `sortedData[0]` is reached only when `sortedData.Count == 0` holds the empty case, and `sortedData[0]` indexes position 0 of nothing and throws. Either the guard is load-bearing, in which case this access crashes, or `sortedData` cannot be empty here and the guard is dead. Move the access to the branch the test protects, or leave the method on the empty side. — perf/BenchmarkApp/PerformanceTest.Shared/Reporting/OutlinerHelper.cs:37
What to do
Each finding names the index access that escapes the guard and the line of the correctly bracketed access beside it. Compare the two: they differ only in where one parenthesis sits. Move it so the emptiness test brackets every access to that symbol — and if the value provably cannot be empty at this point, delete the test rather than leave a condition that guards one access and not its neighbour.
Do you agree with this assessment?
X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.
Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.
Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.
An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. (×9) — perf/BenchmarkApp/PerformanceTest.Client/Program.cs:269, perf/BenchmarkApp/PerformanceTest.Client/ServerStreamingScenario.cs:61, perf/BenchmarkApp/PerformanceTest.Server/PerfTestService.cs:168, …
An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else). — src/MagicOnion.Client/Internal/StreamingHubClientHeartbeatManager.cs:202
What to do
Swallowed exception (empty catch)
Do you agree with this assessment?
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged
Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.
Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.
Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.
Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.
Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it. — samples/ChatApp/ChatApp.Server/ChatService.cs:25
Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.
Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.
20/23 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
~3.4 `!` suppressions per 1k syntax nodes — 440 suppression(s) across the 130067 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.
What to do
Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.
Do you agree with this assessment?
Reference — by lens
The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.
Unscored — 2 check(s) recorded observations but carry no score
These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.
X10 Duplicated predicate — 3 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
X7 Silent fallback defaults — 2 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 1 control(s) we could not find positive evidence for
These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.
P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 43 check(s) not relevant to this codebase
These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.
AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
AX7 Slice cohesion — not applicable — not a vertical-slice architecture
AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
AXR1 Runtime accessibility — docker build failed (exit 1) — 8 | COPY ["ChatApp.Shared/ChatApp.Shared.csproj", "ChatApp.Shared/"] 9 | RUN dotnet restore "ChatApp.Server/ChatApp.Server.csproj" -------------------- ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref ee63ab71-22a5-4f70-a0ba-6ef1316a8a4e::mdt9csyli789tq45bwrnbqz9e: "/ChatApp.Server/ChatApp.Server.csproj": not found; likely cause (the repository): a file the Dockerfile copies (`ChatApp.Server/ChatApp.Server.csproj`) is not in the repository's build context (it may be produced by a build step outside the Dockerfile, or excluded by .dockerignore); runtime evidence skipped The cause is in the repository, not in our sandbox: a file the Dockerfile copies (`ChatApp.Server/ChatApp.Server.csproj`) is not in the repository's build context (it may be produced by a build step outside the Dockerfile, or excluded by .dockerignore). Nothing here says the surface is inaccessible, only that it was never rendered.
C1 Data Protection — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C3 Audit Trail — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C4 Data Retention — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
C5 Data-Subject Rights — No personal data detected in the analyzed source — no PII-typed entity/column names (Email, FirstName, DateOfBirth, …), no ASP.NET Identity / user-account model, and no stored user credentials. GDPR data-protection controls are therefore N/A here. If this is intentional, record the no-PII posture in an ADR; if the app does process personal data, name those fields conventionally so this dimension activates.
D20 ADR Quality — N/A — ADRs are expected on deployable products with a user-facing host, not consumed libraries; no ADR log is required here.
D21 Naming Consistency — D21 withholds its sibling role token rows: 1 candidate(s) found and not reported.
D23 Boundary Type-Coupling — Cross-context type coupling could not be assessed — this codebase's bounded contexts are neither declared nor inferable.
D25 ADR Conformance — no ADRs to check
D32 Data Compliance (PII/GDPR) — 23 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
D34 Knowledge Freshness — knowledge concentrated in recent work — freshness signal contradicted by repo activity
D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (3 value object(s))
ED1 Event-Driven — not scored — this repository shows only 1 of the 3 signals this lens looks for (1 event handler(s))
ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
P12 CI test-gate honesty — Reported, not scored — and nothing was matched here. The coverage check applies to any stack, and the automatic-re-run check to any GitHub-Actions workflow, but the checks for excluded tests, skipped tests and sleep-based synchronisation currently recognise only some ecosystems' test-runner idioms, so on a repository built with another stack the zeros below mean 'not checked', not 'clean'.
P8 Schema migrations — no EF Core usage detected
P9 Domain vs controller coverage — coverage data present for 5 file(s), but no domain-layer files were identified: no covered file's path contains any of the markers this check keys on (/domain/, /aggregates/, /valueobjects/, /domainmodel/, .domain/, /entities/), which are matched case-insensitively anywhere in the path. With no domain partition there is nothing to compare the web/controller layer against — if this repository keeps its business rules under a folder named none of those, that naming is what the check cannot see, not the domain logic.
PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
SC1 Supply-chain hygiene — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X13 Undrained process stream — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X24 Document value interpolated into markup unescaped — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X26 Unsynchronised callback handoff — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X32 Type resolved by simple name across every loaded assembly — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
Appendix A — Findings (grouped)
The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.
WriteOnlyPrivateField perf/BenchmarkApp/PerformanceTest.Client/BroadcastScenario.cs:13— private int connectionId — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField perf/BenchmarkApp/PerformanceTest.Client/BroadcastScenario.cs:14— private long begin — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField perf/Microbenchmark/Microbenchmark.Client/HubMethodBenchmarks.cs:11— private Task responseTask — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField samples/JwtAuthentication/JwtAuthApp.Server/Hubs/TimerHub.cs:20— private IGroup<ITimerHubReceiver> _group — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/MagicOnion.Client/StreamingHubClientBase.cs:150— private Task? writerTask — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/MagicOnion.Server.JsonTranscoding/SystemTextJsonMessageSerializer.cs:12— private string[] dynamicArgumentTupleParameterNames — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField src/MagicOnion.Server.JsonTranscoding/SystemTextJsonMessageSerializer.cs:13— private bool serializeAsKeyedObject — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField tests/MagicOnion.Client.SourceGenerator.Tests/Collector/SerializationInfoCollectorTest.cs:7— private ITestOutputHelper testOutputHelper — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField tests/MagicOnion.Server.Redis.Tests/RedisGroupFunctionalTest.cs:18— private TemporaryRedisServerFixture redisServer — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField tests/MagicOnion.Server.Tests/ArgumentPatternTest.cs:159— private ITestOutputHelper logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField tests/MagicOnion.Server.Tests/InterfaceInheritanceTest.cs:32— private ITestOutputHelper logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField tests/MagicOnion.Server.Tests/ReturnStatusTest.cs:73— private ITestOutputHelper logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
WriteOnlyPrivateField tests/MagicOnion.Server.Tests/StreamingHubTest.cs:132— private ITestOutputHelper logger — assigned 1 time(s), read never — this field is written and never read anywhere its type can be reached from, so the state it keeps answers no question: every assignment to it computes a value that nothing observes, on every instance, for the lifetime of each one. It reads as a flag the code branches on, and nothing branches on it. Delete the field and its assignments — or, if the value was MEANT to be consulted, the missing read is the defect this row is pointing at, and the branch that should have depended on it is not there.
EmptyCatchBlock perf/BenchmarkApp/PerformanceTest.Client/Program.cs:269— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock perf/BenchmarkApp/PerformanceTest.Client/ServerStreamingScenario.cs:61— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock perf/BenchmarkApp/PerformanceTest.Server/PerfTestService.cs:168— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/MagicOnion.Abstractions/UnaryResult.cs:155— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/MagicOnion.Abstractions/UnaryResult.cs:272— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/MagicOnion.Client/Internal/StreamingHubClientHeartbeatManager.cs:202— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/MagicOnion.Client/StreamingHubClientBase.cs:524— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/MagicOnion.Client/StreamingHubClientBase.cs:634— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/MagicOnion.Client/StreamingHubClientBase.cs:701— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
EmptyCatchBlock src/MagicOnion.Server/Hubs/Internal/StreamingHubHeartbeatManager.cs:241— empty catch block — the error is discarded with nothing recorded, so a failure here leaves no trace anywhere. Record it through whatever this codebase already uses to report problems, or let it propagate. Where swallowing one specific failure really is correct — as it often is on a teardown/dispose path where throwing would mask the original failure — catch exactly that exception type and write down WHY in a comment on the catch. Both are needed: a comment on a catch-all still swallows every failure nobody anticipated, and a note that only restates the swallow ("ignored", "do nothing") is read as no explanation at all.
NoWarnInCsproj src/MagicOnion/MagicOnion.csproj:16— CS2008 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj src/MagicOnion.Server.Redis/MagicOnion.Server.Redis.csproj:9— 1701 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj src/MagicOnion.Server.Redis/MagicOnion.Server.Redis.csproj:9— 1702 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj src/MagicOnion.Server.Redis/MagicOnion.Server.Redis.csproj:9— 1705 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj src/MagicOnion.Server.Redis/MagicOnion.Server.Redis.csproj:9— 1591 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
NoWarnInCsproj REDACTED:8— CS1591 — this project generates an XML documentation file as a build output, so its documentation is something it PUBLISHES to whoever consumes the assembly, and this entry switches off a rule whose only job is to report that documentation missing or malformed. The two decisions sit in the same file and the quiet one wins: the documentation this project ships has holes exactly where the rule would have pointed, no build says so, and the people who meet the gap are downstream — in their editor, at the moment they are trying to use the member. Write the documentation the rule is asking for and drop the code from the list; where only some elements genuinely cannot carry it, narrow the suppression to those sites and give each one its reason, so the rest of the API stays covered. If the documentation was never meant to be consumed, the honest fix is the other line — stop generating the file, so the project no longer publishes something it is choosing not to check.
FileScopedPragmaDisable samples/JwtAuthentication/JwtAuthApp.Server/Services/GreeterService.cs:11— #pragma warning disable CS1998 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable tests/MagicOnion.Integration.Tests/ClientFilterTest.cs:1— #pragma warning disable CS1998 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable tests/MagicOnion.Server.InternalTesting/MagicOnionApplicationFactory.cs:11— #pragma warning disable CS1998 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable tests/MagicOnion.Server.Tests/StreamingHubBroadcastTest/BroadcastGroupTestHub.cs:1— #pragma warning disable CS1998 — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
FileScopedPragmaDisable tests/MagicOnion.Serialization.MessagePack.Tests/UnsafeDirectBlitResolverTest.cs:3— #pragma warning disable CS0618 // Type or member is obsolete — the disable has no matching restore anywhere in this file, so it does not end with the construct that needed it: it runs to the end of the file and silences the rule for everything written below, including code added years later that nobody weighed against it. Close it with the matching restore directive immediately after the construct it covers — that alone turns a standing exemption into a scoped one — or fix the cause and drop the directive entirely.
Namespace dependency cycle src/MagicOnion.Abstractions/UnaryResult.cs:2— The namespaces MagicOnion ↔ MagicOnion.Client ↔ MagicOnion.Client.Internal depend on each other. The lightest dependency in the cycle is MagicOnion → MagicOnion.Client (MagicOnion.UnaryResult → MagicOnion.Client.IResponseContext, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
Namespace dependency cycle src/MagicOnion.Server/FromServiceFilterAttribute.cs:1— The namespaces MagicOnion.Server ↔ MagicOnion.Server.Binder ↔ MagicOnion.Server.Diagnostics ↔ MagicOnion.Server.Features.Internal ↔ MagicOnion.Server.Filters ↔ MagicOnion.Server.Hubs ↔ MagicOnion.Server.Hubs.Internal ↔ MagicOnion.Server.Internal depend on each other. The lightest dependency in the cycle is MagicOnion.Server → MagicOnion.Server.Hubs (MagicOnion.Server.ThroughFilter → MagicOnion.Server.Hubs.StreamingHubContext, 1 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
S1 · Web-Security Posture· Password hashing without a KDF · ×1
Password hashing without a KDF samples/JwtAuthentication/JwtAuthApp.Server/Services/AccountService.cs:37— `userInfo.Password == password` checks a password against the stored one in plaintext, so the store holds the password itself and whoever reads it holds every account. Store a salted KDF hash (PBKDF2/scrypt/Argon2/bcrypt) and verify by deriving again.
TLS certificate validation disabled perf/BenchmarkApp/PerformanceTest.Client/Program.cs:607— `RemoteCertificateValidationCallback` is assigned a callback that returns `true` unconditionally, so every TLS peer certificate is accepted — including one an attacker presents. Chain, expiry, revocation and hostname are all skipped, so an attacker on the network path can present any certificate and read or rewrite the traffic — the connection is encrypted to the attacker, not to the intended host. Delete the override and let the platform validate. If a specific self-signed or internally-issued certificate genuinely has to be trusted, pin THAT one — compare the presented certificate's public key or thumbprint against the expected value and return `false` for everything else — and scope it to the single handler that talks to that host rather than to the whole process. If the override exists only to get past a development certificate, gate it on a build configuration or an explicit opt-in setting so it cannot ship.
Dead code: UnaryArgRefReturnRef perf/BenchmarkApp/PerformanceTest.Shared/IPerfTestService.cs:10— Method UnaryArgRefReturnRef — Roslyn's SymbolFinder walked every project the solution loads, including PerformanceTest.Client, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: UnaryArgDynamicArgumentTupleReturnRef perf/BenchmarkApp/PerformanceTest.Shared/IPerfTestService.cs:11— Method UnaryArgDynamicArgumentTupleReturnRef — Roslyn's SymbolFinder walked every project the solution loads, including PerformanceTest.Client, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: LeaveGroupAsync perf/BenchmarkApp/PerformanceTest.Shared/IPerTestBroadcastHub.cs:9— Method LeaveGroupAsync — Roslyn's SymbolFinder walked every project the solution loads, including PerformanceTest.Client, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: AddJwtSecurityScheme samples/JsonTranscoding/JsonTranscodingSample.Server/SwaggerJwtExtention.cs:8— Method AddJwtSecurityScheme — Roslyn's SymbolFinder walked every project the solution loads, including JsonTranscodingSample.Server, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: SayHelloAsync samples/JsonTranscoding/JsonTranscodingSample.Shared/IMyFirstService.cs:17— Method SayHelloAsync — Roslyn's SymbolFinder walked every project the solution loads, including JsonTranscodingSample.Shared, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: RegisterUserAsync samples/JsonTranscoding/JsonTranscodingSample.Shared/IMyFirstService.cs:24— Method RegisterUserAsync — Roslyn's SymbolFinder walked every project the solution loads, including JsonTranscodingSample.Shared, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: RegisterUserWithRoleAsync samples/JsonTranscoding/JsonTranscodingSample.Shared/IMyFirstService.cs:32— Method RegisterUserWithRoleAsync — Roslyn's SymbolFinder walked every project the solution loads, including JsonTranscodingSample.Shared, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ThrowWithReturnStatusCodeAsync samples/JsonTranscoding/JsonTranscodingSample.Shared/IMyFirstService.cs:46— Method ThrowWithReturnStatusCodeAsync — Roslyn's SymbolFinder walked every project the solution loads, including JsonTranscodingSample.Shared, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ServerAsync samples/JwtAuthentication/JwtAuthApp.Shared/IGreeterService.cs:12— Method ServerAsync — Roslyn's SymbolFinder walked every project the solution loads, including JwtAuthApp.Shared, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ClientAsync samples/JwtAuthentication/JwtAuthApp.Shared/IGreeterService.cs:13— Method ClientAsync — Roslyn's SymbolFinder walked every project the solution loads, including JwtAuthApp.Shared, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DuplexAsync samples/JwtAuthentication/JwtAuthApp.Shared/IGreeterService.cs:14— Method DuplexAsync — Roslyn's SymbolFinder walked every project the solution loads, including JwtAuthApp.Shared, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: AppendLiteral src/MagicOnion.Client.SourceGenerator/Helpers/StringBuilderExtensions.cs:26— Method AppendLiteral — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Client.SourceGenerator, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: AppendFormatted src/MagicOnion.Client.SourceGenerator/Helpers/StringBuilderExtensions.cs:31— Method AppendFormatted — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Client.SourceGenerator, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: UnknownObject tests/MagicOnion.Client.NativeAot.Tests/ResolverTest.cs:150— NamedType UnknownObject — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Client.NativeAot.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: UnknownEnumValue tests/MagicOnion.Client.NativeAot.Tests/ResolverTest.cs:152— NamedType UnknownEnumValue — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Client.NativeAot.Tests, and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DoAsync tests/MagicOnion.Client.Tests/DynamicClient/SameInterfaceNameTest.cs:79— Method DoAsync — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Client.Tests(net8.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: DoAsync tests/MagicOnion.Client.Tests/DynamicClient/SameInterfaceNameTest.cs:95— Method DoAsync — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Client.Tests(net8.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ManyParameterReturnValueType tests/MagicOnion.Client.Tests/UnaryTest.cs:557— Method ManyParameterReturnValueType — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Client.Tests(net8.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: AMethod tests/MagicOnion.Client.Tests/UnaryTest.cs:572— Method AMethod — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Client.Tests(net8.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: AMethod tests/MagicOnion.Client.Tests/UnaryTest.cs:587— Method AMethod — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Client.Tests(net8.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: LoggingFilter tests/MagicOnion.Integration.Tests/ClientFilterTest.cs:149— NamedType LoggingFilter — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Integration.Tests(net8.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: ResponseHandlingFilter tests/MagicOnion.Integration.Tests/ClientFilterTest.cs:165— NamedType ResponseHandlingFilter — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Integration.Tests(net8.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: MockRequestFilter tests/MagicOnion.Integration.Tests/ClientFilterTest.cs:181— NamedType MockRequestFilter — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Integration.Tests(net8.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: MethodReturnWithoutValue tests/MagicOnion.Integration.Tests/SerializerStreamingHubTest.cs:116— Method MethodReturnWithoutValue — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Integration.Tests(net8.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Dead code: MethodReturnWithoutValue tests/MagicOnion.Serialization.MemoryPack.Tests/MemoryPackSerializerStreamingHubTest.cs:221— Method MethodReturnWithoutValue — Roslyn's SymbolFinder walked every project the solution loads, including MagicOnion.Serialization.MemoryPack.Tests(net8.0), and found no reference to it. That walk cannot see three kinds of caller, so check them before removing it: code outside the solution file (a solution is a curated list, not the repository — a sibling test tree with its own .sln is invisible), a call resolved by reflection or dependency injection from the symbol's name, and any project the workspace could not load. This is 'no caller found by this walk', not a verdict that the symbol is unused.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:125— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:126— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:128— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:129— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:130— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:131— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:132— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:133— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:134— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:135— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:136— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:137— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:138— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:139— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:140— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:141— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:142— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:143— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:144— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:145— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:146— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:147— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:148— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:149— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
Blocking `StreamWriter.WriteLine` inside an `async` method perf/BenchmarkApp/PerformanceTest.Client/Program.cs:150— `StreamWriter.WriteLine` blocks the thread on I/O while `StreamWriter.WriteLineAsync` exists to wait without one — inside a method that is already `async`, await the twin.
X2 · Cancellation propagation· Async method without CancellationToken · ×36
Async method without CancellationToken: PrepareAsync perf/BenchmarkApp/PerformanceTest.Client/BroadcastScenario.cs:18— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CompleteAsync perf/BenchmarkApp/PerformanceTest.Client/BroadcastScenario.cs:51— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PutClientHardwareMetricsAsync perf/BenchmarkApp/PerformanceTest.Client/Program.cs:428— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PutClientBenchmarkMetricsAsync perf/BenchmarkApp/PerformanceTest.Client/Program.cs:472— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CompleteAsync perf/BenchmarkApp/PerformanceTest.Client/ServerStreamingScenario.cs:54— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PrepareAsync perf/BenchmarkApp/PerformanceTest.Client/StreamingHubLargePayloadScenario.cs:16— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CompleteAsync perf/BenchmarkApp/PerformanceTest.Client/StreamingHubLargePayloadScenario.cs:34— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PrepareAsync perf/BenchmarkApp/PerformanceTest.Client/StreamingHubScenario.cs:10— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CompleteAsync perf/BenchmarkApp/PerformanceTest.Client/StreamingHubScenario.cs:27— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PrepareAsync perf/BenchmarkApp/PerformanceTest.Client/StreamingHubScenario.cs:38— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CompleteAsync perf/BenchmarkApp/PerformanceTest.Client/StreamingHubScenario.cs:54— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PrepareAsync perf/BenchmarkApp/PerformanceTest.Client/StreamingHubScenario.cs:65— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CompleteAsync perf/BenchmarkApp/PerformanceTest.Client/StreamingHubScenario.cs:81— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PrepareAsync perf/BenchmarkApp/PerformanceTest.Client/StreamingHubScenario.cs:92— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: CompleteAsync perf/BenchmarkApp/PerformanceTest.Client/StreamingHubScenario.cs:108— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: SendAsync perf/BenchmarkApp/PerformanceTest.Shared/Reporting/DatadogMetricsRecorder.cs:141— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ServerStreamingAsync perf/BenchmarkApp/PerformanceTest.Server/PerfTestService.cs:63— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PutServerHardwareMetricsAsync perf/BenchmarkApp/PerformanceTest.Server/ProfileService.cs:40— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: PutServerBroadcastMetricsAsync perf/BenchmarkApp/PerformanceTest.Server/ProfileService.cs:91— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ValueTask_Parameter_Zero_NoReturn perf/Microbenchmark/Microbenchmark.Client/HubMethodBenchmarks.cs:54— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Parameter_Zero_Return_ValueType perf/Microbenchmark/Microbenchmark.Client/HubMethodBenchmarks.cs:60— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Parameter_Many_Return_ValueType perf/Microbenchmark/Microbenchmark.Client/HubMethodBenchmarks.cs:66— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Parameter_Zero_Return_RefType perf/Microbenchmark/Microbenchmark.Client/HubMethodBenchmarks.cs:72— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: Parameter_Many_Return_RefType perf/Microbenchmark/Microbenchmark.Client/HubMethodBenchmarks.cs:78— No CancellationToken parameter — this work can't be stopped early once started.
Async method without CancellationToken: ReadRequestRawAsync perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:89— No CancellationToken parameter — this work can't be stopped early once started.
Awaits without ConfigureAwait(false) — Only 43/81 awaits in library code use ConfigureAwait(false). A library that captures the caller's context can stall or deadlock its host — the classic way a dependency drags an app down.
Awaits without ConfigureAwait(false) src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:68— `await InterceptInvokeHelper.InvokeWithFilter(requestContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Client/StreamingHubClient.cs:31— `await ConnectAsync<TStreamingHub, TReceiver>(channel.CreateCallInvoker(), receiver,...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:63— `await context.Request.BodyReader.CopyToAsync(memStream)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:70— `await unaryMethodHandler(handle.Instance, request, serverCallContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:79— `await WriteErrorResponseAsync(context, ex)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:85— `await serviceActivator.ReleaseAsync(handle)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:101— `await JsonSerializer.SerializeAsync(context.Response.Body, new { Code = (int)status...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingGrpcMethodBinder.cs:206— `await JsonSerializer.SerializeAsync(context.Response.Body, new { Code = (int)Status...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:87— `await wrappedBody(serviceContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:163— `await wrappedBody(serviceContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:234— `await wrappedBody(serviceContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:298— `await wrappedBody(serviceContext)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/HubGroupRepository.cs:32— `await autoDisposeGroupProvider.GetOrAddAsync($"{prefix}/{groupName}", streamingCont...` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/HubGroupRepository.cs:41— `await autoDisposeGroupProvider.RemoveAsync(item, streamingContext.ContextId)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/Internal/MagicOnionManagedGroupProvider.cs:21— `await @lock.WaitAsync()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/Internal/MagicOnionManagedGroupProvider.cs:31— `await underlyingGroup.AddAsync(contextId, client)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/Internal/MagicOnionManagedGroupProvider.cs:53— `await @lock.WaitAsync()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/Internal/MagicOnionManagedGroupProvider.cs:60— `await underlyingGroup.RemoveAsync(contextId)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/Internal/StreamingHubHeartbeatManager.cs:219— `await runningTimer.WaitForNextTickAsync()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/StreamingHub.cs:115— `await OnConnecting()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/StreamingHub.cs:116— `await HandleMessageAsync()` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/StreamingHub.cs:158— `await CleanupSafeAsync(static hub => hub.OnDisconnected(), this)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/StreamingHub.cs:159— `await CleanupSafeAsync(static hub => hub.Group.DisposeAsync(), this)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
Awaits without ConfigureAwait(false) src/MagicOnion.Server/Hubs/StreamingHub.cs:171— `await action(hub)` resumes on the caller's captured context. In library code that context belongs to the host application, so a host that blocks on this call (or runs on a UI thread) can stall or deadlock — append `.ConfigureAwait(false)`.
DeadPreprocessorBranch perf/BenchmarkApp/PerformanceTest.Shared/ApplicationInformation.cs:33— #if RELEASE — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch perf/Microbenchmark/Microbenchmark.Client/Program.cs:8— #if FALSE — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch tests/MagicOnion.Server.Tests/MagicOnionEngineTest.cs:1— #if FALSE — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Client/DynamicClient/DynamicClientAssemblyHolder.cs:7— #if ENABLE_SAVE_ASSEMBLY — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Client/DynamicClient/DynamicClientAssemblyHolder.cs:24— #if ENABLE_SAVE_ASSEMBLY — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:13— #if ENABLE_SAVE_ASSEMBLY — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:30— #if ENABLE_SAVE_ASSEMBLY — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:41— #if ENABLE_SAVE_ASSEMBLY — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Internal/Reflection/DynamicAssembly.cs:9— #if ENABLE_SAVE_ASSEMBLY — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Internal/Reflection/DynamicAssembly.cs:18— #if ENABLE_SAVE_ASSEMBLY — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Internal/Reflection/DynamicAssembly.cs:29— #if ENABLE_SAVE_ASSEMBLY — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Internal/Reflection/DynamicAssembly.cs:70— #if ENABLE_SAVE_ASSEMBLY — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Internal/StreamingHubPayload.cs:11— #if STREAMINGHUBPAYLOAD_TRACK_LOCATION — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Internal/StreamingHubPayload.cs:49— #if STREAMINGHUBPAYLOAD_TRACK_LOCATION — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch src/MagicOnion.Internal/StreamingHubPayload.cs:61— #if STREAMINGHUBPAYLOAD_TRACK_LOCATION — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
DeadPreprocessorBranch tests/MagicOnion.Client.SourceGenerator.Tests/Verifiers/MagicOnionSourceGeneratorVerifier.cs:99— #if WRITE_EXPECTED — no definition of that symbol was found anywhere this analysis looks: not in a <DefineConstants> in any project file, props or targets under any condition, not on a build script's command line, not in a #define, and not in a project-template manifest; nor is it one the compiler or SDK defines itself. On that evidence the condition is decided the same way in every configuration this repository can build, and the code on the dead side of it never compiles — including the part a reader will assume is what ships. Either define the symbol in the configuration that is supposed to have it, or delete the branch and keep the behaviour you are actually shipping. If some other mechanism binds it, that mechanism is outside the list above and this row is a gap in what we read, not a fact about your code.
Unfinished stub — throws NotImplementedException perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:45— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:48— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:51— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:54— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException samples/ChatApp/ChatApp.Server/ChatHub.cs:70— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException samples/ChatApp/ChatApp.Server/ChatService.cs:18— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:28— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:72— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:74— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:75— A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
Swallowed exception (empty catch) perf/BenchmarkApp/PerformanceTest.Client/Program.cs:269— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) perf/BenchmarkApp/PerformanceTest.Client/ServerStreamingScenario.cs:61— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) perf/BenchmarkApp/PerformanceTest.Server/PerfTestService.cs:168— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/MagicOnion.Abstractions/UnaryResult.cs:155— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/MagicOnion.Abstractions/UnaryResult.cs:272— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/MagicOnion.Client/Internal/StreamingHubClientHeartbeatManager.cs:202— An empty catch block silently discards the error — failures vanish with no log and no rethrow. On a teardown path letting it propagate is not an option (throwing out of `Dispose()` masks the failure already in flight and abandons the rest of the cleanup), so make the swallow deliberate instead: record it through whatever this codebase already uses to report problems — or, if one specific failure truly cannot matter, catch exactly that exception type and say why in a comment on the catch (a comment on a catch-all still swallows everything else).
Swallowed exception (empty catch) src/MagicOnion.Client/StreamingHubClientBase.cs:524— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/MagicOnion.Client/StreamingHubClientBase.cs:634— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/MagicOnion.Client/StreamingHubClientBase.cs:701— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Swallowed exception (empty catch) src/MagicOnion.Server/Hubs/Internal/StreamingHubHeartbeatManager.cs:241— An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Sync-over-async blocking — 7 blocking call(s) on async work (.Wait()/.GetAwaiter().GetResult()) — these waste a thread and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking perf/Microbenchmark/Microbenchmark.Client/HubMethodBenchmarks.cs:43— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking perf/Microbenchmark/Microbenchmark.Client/HubReceiverBroadcastBenchmarks.cs:21— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking perf/Microbenchmark/Microbenchmark.Client/HubReceiverBroadcastBenchmarks.cs:42— `Received.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking perf/Microbenchmark/Microbenchmark.Client/HubReceiverBroadcastBenchmarks.cs:49— `Received.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking perf/Microbenchmark/Microbenchmark.Client/HubReceiverBroadcastBenchmarks.cs:56— `Received.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking perf/Microbenchmark/Microbenchmark.Client/HubReceiverBroadcastBenchmarks.cs:63— `Received.Wait()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
Sync-over-async blocking src/MagicOnion.Server/Binder/MagicOnionUnaryMethod.cs:84— `.GetAwaiter().GetResult()` blocks this thread until the async work completes — it wastes a thread-pool thread for as long as the work runs and can deadlock wherever a synchronization context is in play (a UI thread, or a caller that has one).
HackComment perf/BenchmarkApp/PerformanceTest.Server/KestrelHelperExtensions.cs:17— // HACK: h3 requires Listen on AnyIP, otherwise ALPN exception occurs for localhost. — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/MagicOnion.Internal/Reflection/DynamicAssembly.cs:38— // HACK: Allow access to `internal` classes from dynamically generated assembly. — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/MagicOnion.Server/Filters/Internal/InvokeHelper.cs:24— // HACK: If the app is running on .NET Core 2.2 or earlier, the runtime hides dynamic method in the stack trace. — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/MagicOnion.Server/Filters/Internal/InvokeHelper.cs:47— // HACK: If the app is running on .NET Core 3.0 or later, the runtime hides `AggressiveInlining` method in the stack trace. (If the app is running on .NET Framework 4.x, This hack does not affect.) — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
HackComment src/MagicOnion.Server/Hubs/StreamingHub.cs:42— // HACK: If the ID of the message is `-1`, the client will ignore the message. — a workaround marked in source: record what it is compensating for and what would allow its removal (the upstream fix, the API it is waiting on, the invariant it restores), so the next reader can judge whether it is still needed rather than rediscovering why it is there.
Stateful shared instance: ServerBroadcastMetricsContext perf/BenchmarkApp/PerformanceTest.Server/ServerBroadcastMetricsContext.cs:3— `ServerBroadcastMetricsContext` is not registered, but the singleton `PerfGroupService` creates it and keeps it in `metricsContext`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (isRunning, targetFps, startTimestamp, elapsed; e.g. `isRunning` at line 27).
Stateful shared instance: HardwarePerformanceReporter perf/BenchmarkApp/PerformanceTest.Shared/Reporting/HardwarePerformanceReporter.cs:6— `HardwarePerformanceReporter` is not registered, but the singleton `ProfileService` creates it and keeps it in `hardwarehardwarePerformanceReporter`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (running; e.g. `running` at line 33).
Stateful shared instance: MagicOnionTypeInfo src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MagicOnionTypeInfo.cs:6— `MagicOnionTypeInfo` is not registered, but `KnownTypes` creates it and keeps it in the static `System_Void`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (fullName, fullNameOpenType; e.g. `fullName` at line 44).
Stateful shared instance: ObjectPool src/MagicOnion.Internal/StreamingHubPayloadPool.BuiltIn.cs:8— `ObjectPool` is not registered, but the singleton `StreamingHubPayloadPool` creates it and keeps it in `pool`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (item1, item2, item3, item4; e.g. `item1` at line 25).
No assertions: Ctor_Default tests/MagicOnion.Abstractions.Tests/UnaryResultNonGenericTest.cs:7— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Ctor_RawValue tests/MagicOnion.Abstractions.Tests/UnaryResultNonGenericTest.cs:14— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: ValueTask_Forget_NoReturnValue tests/MagicOnion.Integration.Tests/StreamingHubTest.cs:316— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
No assertions: Filter tests/MagicOnion.Server.Tests/StreamingHubTest.cs:485— This method's body runs code, and no assertion call was recognised in it. Recognised by name: Assert*, *Should*/ShouldBe*, Verify, Expect, Throws, Record, Received/DidNotReceive, MustHaveHappened/MustNotHaveHappened, EnsureSuccessStatusCode and *AndEnsure*, in the test body and in the helpers it calls in the test and test-support code (a helper there that throws when its check fails counts as an assertion) — so verification routed through a callback object whose members hold the assertions, or through a harness in production code that fails by throwing, is not visible to this check and is not counted here. Read it as 'no assertion this check knows how to see', and if that is right, add one.
TodoComment src/MagicOnion.Client.SourceGenerator/MagicOnionClientSourceGenerator.Parser.cs:18— // TODO: ReportDiagnostic — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/MagicOnion.Client.SourceGenerator/MagicOnionClientSourceGenerator.cs:23— // TODO: ReportDiagnostic — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/MagicOnion.Client.SourceGenerator/MagicOnionClientSourceGenerator.cs:26— // TODO: ReportDiagnostic — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
TodoComment src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodBinder.cs:78— // TODO: Currently, MagicOnion expects TRawRequest/TRawResponse to be raw-byte array (`StreamingHubPayload`). — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
BarePragmaDisable src/MagicOnion.Internal/GrpcMethodHelper.cs:88— #pragma warning disable CS8602 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable src/MagicOnion.Internal/GrpcMethodHelper.cs:112— #pragma warning disable CS8602 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable tests/MagicOnion.Abstractions.Tests/UnaryResultNonGenericTest.cs:45— #pragma warning disable CS8604 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
BarePragmaDisable tests/MagicOnion.Abstractions.Tests/UnaryResultNonGenericTest.cs:67— #pragma warning disable CS8604 — the disable is closed again below, so its scope is not the problem; what it records is no reason: there is nothing on the directive line, and no ordinary comment attached to it either side. A suppression is a decision somebody made, and without the reason the next reader cannot tell a considered exception from an unexamined one, so it is never revisited and it outlives the code it was written for. Put the reason on the directive line — what makes this site legitimately different — or fix what the rule is pointing at and delete the pair. A rationale in the member's documentation comment does not clear this row and is not meant to: it explains the member to its callers, and the next person to touch the suppression is not reading it for that.
D4 · Code Duplication· Edited copy of a member (9 corresponding lines) · ×4
Edited copy of a member (9 corresponding lines) src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:143— src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:143-151 | src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:169-177 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) src/MagicOnion.Client/StreamingHubClient.cs:11— src/MagicOnion.Client/StreamingHubClient.cs:11-19 | src/MagicOnion.Client/StreamingHubClient.cs:30-38 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:174— perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:174-182 | perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:185-193 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (9 corresponding lines) perf/BenchmarkApp/PerformanceTest.Client/StreamingHubScenario.cs:44— perf/BenchmarkApp/PerformanceTest.Client/StreamingHubScenario.cs:44-52 | perf/BenchmarkApp/PerformanceTest.Client/UnaryScenario.cs:45-53 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Unfinished stub — throws NotImplementedException src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:28— `CreatePropagationTokenCore` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:72— `ResponseTrailersCore` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:74— `WriteOptionsCore` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
Unfinished stub — throws NotImplementedException src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingServerCallContext.cs:75— `AuthContextCore` is a shipped property whose accessors only throw NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
D4 · Code Duplication· Edited copy of a member (12 corresponding lines) · ×3
Edited copy of a member (12 corresponding lines) src/MagicOnion.Server/Filters/Internal/FilterHelper.cs:72— src/MagicOnion.Server/Filters/Internal/FilterHelper.cs:72-83 | src/MagicOnion.Server/Filters/Internal/FilterHelper.cs:86-97 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) src/MagicOnion.Server/StreamingContext.Duplex.cs:38— src/MagicOnion.Server/StreamingContext.Duplex.cs:38-50 | src/MagicOnion.Server/StreamingContext.Client.cs:26-37 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (12 corresponding lines) src/MagicOnion.Client/MagicOnionClientFactoryProvider.cs:57— src/MagicOnion.Client/MagicOnionClientFactoryProvider.cs:57-68 | src/MagicOnion.Client/StreamingHubClientFactoryProvider.cs:59-70 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (9 lines × 2) src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MethodCollector.cs:48— src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MethodCollector.cs:48-56 | src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MethodCollector.cs:73-81 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MethodCollector.cs:48` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:443— src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:443-451 | src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:466-474 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:443` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 2) src/MagicOnion.Internal/StreamingHubMessageWriter.cs:73— src/MagicOnion.Internal/StreamingHubMessageWriter.cs:73-81 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:88-96 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (14 lines × 2) src/MagicOnion.Internal/GrpcMethodHelper.cs:86— src/MagicOnion.Internal/GrpcMethodHelper.cs:86-99 | src/MagicOnion.Internal/GrpcMethodHelper.cs:110-123 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Internal/GrpcMethodHelper.cs:86` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 2) src/MagicOnion.Internal/StreamingHubMessageWriter.cs:247— src/MagicOnion.Internal/StreamingHubMessageWriter.cs:247-260 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:268-281 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (14 lines × 2) perf/BenchmarkApp/PerformanceTest.Client/Program.cs:445— perf/BenchmarkApp/PerformanceTest.Client/Program.cs:445-458 | perf/BenchmarkApp/PerformanceTest.Client/Program.cs:487-500 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) src/MagicOnion.Internal/StreamingHubMessageWriter.cs:223— src/MagicOnion.Internal/StreamingHubMessageWriter.cs:223-228 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:289-294 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:127— src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:127-132 | src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:211-216 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (6 lines × 2) src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationFormatterNameMapper.cs:80— src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationFormatterNameMapper.cs:80-85 | src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationFormatterNameMapper.cs:238-243 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationFormatterNameMapper.cs:80` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
AX2 · Stateful singletons· Process-global static state · ×2
Process-global static state: DynamicArgumentTupleFormatter src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:10— `DynamicArgumentTupleFormatter` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (isRegistered; e.g. `isRegistered` at line 16). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
Process-global static state: MagicOnionServerInternalLogger src/MagicOnion.Server/MagicOnionServerInternalLogger.cs:6— `MagicOnionServerInternalLogger` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (logger; e.g. `logger` at line 16). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
D10 · Test Quality· Fixed-sleep synchronisation · ×2
Fixed-sleep synchronisation: Cancel_While_WritingStream tests/MagicOnion.Client.Tests/StreamingHubTest.cs:685— This test starts a background task and then orders itself against it with `Task.Delay(100)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
Fixed-sleep synchronisation: ContinuationBlocking tests/MagicOnion.Integration.Tests/StreamingHubTest.cs:428— This test starts a background task and then orders itself against it with `Task.Delay(1000)` — a fixed wait, not a signal that the work is done. Whether it passes depends on how loaded the machine is, which is why a test written this way is green on a developer's box and random in CI. Wait for the event itself instead: the process's own exit or output, a completion handle, or a condition polled to a timeout.
MethodTooLong: CpuModel.GetArmCpuName perf/BenchmarkApp/PerformanceTest.Shared/ApplicationInformation.cs:326— MethodTooLong — GetArmCpuName runs 245 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 145 over it, 2.45× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
MethodTooLong: DynamicStreamingHubClientBuilder.DefineMethods src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:198— MethodTooLong — DefineMethods runs 197 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 97 over it, 1.97× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication· Members sharing a duplicated core (14 members, 50+ identical tokens) · ×2
Members sharing a duplicated core (14 members, 50+ identical tokens) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:58— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:58-94 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:119-159 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:187-231 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:262-310 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:344-396 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:433-489 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:529-589 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:632-696 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:742-810 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:859-931 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:983-1059 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1114-1194 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1252-1336 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1397-1485 — These 14 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 14 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 14 times.
Members sharing a duplicated core (14 members, 50+ identical tokens) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:97— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:97-114 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:162-182 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:234-257 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:313-339 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:399-428 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:492-524 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:592-627 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:699-737 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:813-854 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:934-978 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1062-1109 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1197-1247 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1339-1392 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1488-1544 — These 14 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 14 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 14 times.
D4 · Code Duplication· Edited copy of a member (21 corresponding lines) · ×2
Edited copy of a member (21 corresponding lines) src/MagicOnion.Client/StreamingHubClientBase.cs:551— src/MagicOnion.Client/StreamingHubClientBase.cs:551-571 | src/MagicOnion.Client/StreamingHubClientBase.cs:574-594 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (21 corresponding lines) src/MagicOnion.Shared/MetadataExtensions.cs:13— src/MagicOnion.Shared/MetadataExtensions.cs:13-33 | src/MagicOnion.Shared/MetadataExtensions.cs:39-59 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (4 corresponding lines) · ×2
Edited copy of a member (4 corresponding lines) src/MagicOnion.Server/FromServiceFilterAttribute.cs:31— src/MagicOnion.Server/FromServiceFilterAttribute.cs:31-34 | src/MagicOnion.Server/FromTypeFilterAttribute.cs:33-36 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Edited copy of a member (4 corresponding lines) src/MagicOnion.Server/FromServiceFilterAttribute.cs:37— src/MagicOnion.Server/FromServiceFilterAttribute.cs:37-40 | src/MagicOnion.Server/FromTypeFilterAttribute.cs:39-42 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (8 lines × 2) src/MagicOnion.Internal/StreamingHubClientMessageReader.cs:93— src/MagicOnion.Internal/StreamingHubClientMessageReader.cs:93-100 | src/MagicOnion.Internal/StreamingHubClientMessageReader.cs:107-114 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (8 lines × 2) src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationFormatterNameMapper.cs:40— src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationFormatterNameMapper.cs:40-47 | src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationFormatterNameMapper.cs:204-211 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationFormatterNameMapper.cs:40` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (10 lines × 2) src/MagicOnion.Internal/StreamingHubMessageWriter.cs:103— src/MagicOnion.Internal/StreamingHubMessageWriter.cs:103-112 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:137-146 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10 lines × 2) src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:116— src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:116-125 | src/MagicOnion.Internal/BroadcasterHelper.cs:48-58 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:116` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (9 lines × 13) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:163— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:163-171 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:235-243 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:314-322 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:400-408 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:493-501 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:593-601 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:700-708 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:814-822 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:935-943 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1063-1071 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1198-1206 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1340-1348 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1489-1497 — all 13 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:163` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `DynamicArgumentTuple<T1, T2, T3>` in one and `DynamicArgumentTuple<T1, T2, T3, T4>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:244` calls `WritePropertyName`, `Serialize` and `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:172` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (9 lines × 13) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:123— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:123-131 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:192-200 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:268-276 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:351-359 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:441-449 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:538-546 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:642-650 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:753-761 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:871-879 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:996-1004 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1128-1136 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1267-1275 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1413-1421 — all 13 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:123` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:202` calls `Read` and `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:132` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 14) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:98— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:98-104 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:163-169 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:235-241 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:314-320 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:400-406 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:493-499 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:593-599 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:700-706 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:814-820 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:935-941 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1063-1069 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1198-1204 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1340-1346 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1489-1495 — all 14 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:98` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `DynamicArgumentTuple<T1, T2>` in one and `DynamicArgumentTuple<T1, T2, T3>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:170` calls `WritePropertyName`, `Serialize` and `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:105` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 14) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:61— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:61-67 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:123-129 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:192-198 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:268-274 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:351-357 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:441-447 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:538-544 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:642-648 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:753-759 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:871-877 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:996-1002 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1128-1134 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1267-1273 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1413-1419 — all 14 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:61` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:131` calls `Read` and `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:68` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 2) src/MagicOnion.Internal/MagicOnionMarshallers.cs:63— src/MagicOnion.Internal/MagicOnionMarshallers.cs:63-67 | src/MagicOnion.Serialization.MessagePack/MessagePackMagicOnionSerializerProvider.cs:59-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
Duplicated block (5 lines × 2) src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:125— src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:125-129 | src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:268-272 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:125` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Unfinished branch — throws a "not implemented" exception src/MagicOnion.Server/Binder/IMagicOnionGrpcMethodProvider.cs:42— The branch `if (!type.GetInterfaces().Any(x => x.IsGenericType && (x.GetGenericTypeDefinition() == typeof(IService<>) || x.GetGenericTypeDefinition() == typeof(IStreamingHub<,>))))` throws `InvalidOperationException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
Unfinished branch — throws a "not implemented" exception src/MagicOnion.Server/FromServiceFilterAttribute.cs:24— The branch `if (!typeof(IMagicOnionServiceFilter).IsAssignableFrom(type) && !typeof(IStreamingHubFilter).IsAssignableFrom(type))` throws `ArgumentException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
Stateful singleton: MagicOnionManagedGroupProvider src/MagicOnion.Server/Hubs/Internal/MagicOnionManagedGroupProvider.cs:5— `MagicOnionManagedGroupProvider` is a singleton (one shared instance) but mutates instance state outside any lock (groups; e.g. `groups` at line 28).
RunScenarioAsync (cyclomatic 34) perf/BenchmarkApp/PerformanceTest.Client/Program.cs:185— RunScenarioAsync has cyclomatic complexity 34 (threshold 15). Of this number, 33 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
DynamicStreamingHubClientBuilder.DefineMethods (cyclomatic 32) src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:198— DynamicStreamingHubClientBuilder.DefineMethods has cyclomatic complexity 32 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DynamicMagicOnionMethodProvider.GetGrpcMethods (cyclomatic 26) src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:20— DynamicMagicOnionMethodProvider.GetGrpcMethods has cyclomatic complexity 26 (threshold 15). Of this number, 25 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DynamicArgumentTupleConverter.Read (cyclomatic 22) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1396— DynamicArgumentTupleConverter.Read has cyclomatic complexity 22 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
DynamicArgumentTupleConverter.Read (cyclomatic 21) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1251— DynamicArgumentTupleConverter.Read has cyclomatic complexity 21 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
DynamicArgumentTupleConverter.Read (cyclomatic 20) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1113— DynamicArgumentTupleConverter.Read has cyclomatic complexity 20 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
MagicOnionTypeInfo.Create (cyclomatic 19) src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MagicOnionTypeInfo.cs:128— MagicOnionTypeInfo.Create has cyclomatic complexity 19 (threshold 15). To reduce it, name the conditions: bind each compound test to a well-named local or a small predicate function, so the body reads as a sequence of named decisions rather than a chain of operators.
DynamicArgumentTupleConverter.Read (cyclomatic 19) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:982— DynamicArgumentTupleConverter.Read has cyclomatic complexity 19 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
StaticStreamingHubClientGenerator.EmitHubMethods (cyclomatic 18) src/MagicOnion.Client.SourceGenerator/CodeGen/StaticStreamingHubClientGenerator.cs:234— StaticStreamingHubClientGenerator.EmitHubMethods has cyclomatic complexity 18 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DynamicArgumentTupleConverter.Read (cyclomatic 18) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:858— DynamicArgumentTupleConverter.Read has cyclomatic complexity 18 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
DynamicMagicOnionMethodProvider.GetStreamingHubMethods (cyclomatic 18) src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:161— DynamicMagicOnionMethodProvider.GetStreamingHubMethods has cyclomatic complexity 18 (threshold 15). Of this number, 17 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
DynamicArgumentTupleConverter.Read (cyclomatic 17) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:741— DynamicArgumentTupleConverter.Read has cyclomatic complexity 17 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
DynamicArgumentTupleConverter.Read (cyclomatic 16) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:631— DynamicArgumentTupleConverter.Read has cyclomatic complexity 16 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
DynamicStreamingHubClientBuilder.DefineMethods (cognitive 56) src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:198— DynamicStreamingHubClientBuilder.DefineMethods has cognitive complexity 56 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DynamicMagicOnionMethodProvider.GetGrpcMethods (cognitive 43) src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:20— DynamicMagicOnionMethodProvider.GetGrpcMethods has cognitive complexity 43 (threshold 15). Of this number, 42 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DynamicClientBuilder.EmitServiceMethods (cognitive 27) src/MagicOnion.Client/DynamicClient/DynamicClientBuilder.cs:145— DynamicClientBuilder.EmitServiceMethods has cognitive complexity 27 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MethodCollector.GetStreamingHubs (cognitive 26) src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MethodCollector.cs:20— MethodCollector.GetStreamingHubs has cognitive complexity 26 (threshold 15). None of this is in the body itself: all 26 points belong to one function literal inside it that branches (line 23). The decisions are inside the literal, which nothing outside this body can call, review or test on its own, so splitting the enclosing body is not the move available here. To reduce it, lift the literal's work into a named function or method at the enclosing scope and have the literal call it, then reduce whichever part then reads as the largest.
StaticStreamingHubClientGenerator.EmitHubMethods (cognitive 25) src/MagicOnion.Client.SourceGenerator/CodeGen/StaticStreamingHubClientGenerator.cs:234— StaticStreamingHubClientGenerator.EmitHubMethods has cognitive complexity 25 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
UnitTestRunner.RunTestInCoroutine (cognitive 25) src/MagicOnion.Client.Unity/Assets/Scripts/RuntimeUnitTestToolkit/UnitTestRunner.cs:223— UnitTestRunner.RunTestInCoroutine has cognitive complexity 25 (threshold 15). Of this number, 24 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
GrpcChannelProviderMonitor.DrawChannels (cognitive 24) src/MagicOnion.Client.Unity/Assets/Scripts/MagicOnion.Client.Unity/Editor/GrpcChannelProviderMonitor.cs:50— GrpcChannelProviderMonitor.DrawChannels has cognitive complexity 24 (threshold 15). Of this number, 22 points are the body's own statements and 2 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
DynamicMagicOnionMethodProvider.GetStreamingHubMethods (cognitive 22) src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:161— DynamicMagicOnionMethodProvider.GetStreamingHubMethods has cognitive complexity 22 (threshold 15). Of this number, 21 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
CpuModel.GetLinuxModelName (cognitive 21) perf/BenchmarkApp/PerformanceTest.Shared/ApplicationInformation.cs:159— CpuModel.GetLinuxModelName has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MagicOnionServiceMethodInfo.GetMethodTypeAndResponseTypeFromMethod (cognitive 21) src/MagicOnion.Client/DynamicClient/ServiceClientDefinition.cs:95— MagicOnionServiceMethodInfo.GetMethodTypeAndResponseTypeFromMethod has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity· Main (cognitive 20) · ×1
Main (cognitive 20) perf/BenchmarkApp/PerformanceTest.Client/Program.cs:17— Main has cognitive complexity 20 (threshold 15). To reduce it, break up the iteration: give each loop body a named function, and split a multi-phase loop into one function per phase so no single body carries the whole pipeline.
DynamicStreamingHubClientBuilder.DefineMethodsFireAndForget (cognitive 20) src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:592— DynamicStreamingHubClientBuilder.DefineMethodsFireAndForget has cognitive complexity 20 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
StreamingHubClientBase.StartSubscribe (cognitive 20) src/MagicOnion.Client/StreamingHubClientBase.cs:288— StreamingHubClientBase.StartSubscribe has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
SerializationInfoCollector.Collect (cognitive 19) src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationInfoCollector.cs:61— SerializationInfoCollector.Collect has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
StreamingHubClientBase.CleanupAsync (cognitive 17) src/MagicOnion.Client/StreamingHubClientBase.cs:688— StreamingHubClientBase.CleanupAsync has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
MagicOnionTypeInfo.CreateFromSymbol (cognitive 16) src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MagicOnionTypeInfo.cs:177— MagicOnionTypeInfo.CreateFromSymbol has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
FileTooLong: MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs— FileTooLong — 1181 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 681 over it, 2.36× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
TooManyMethods: StreamingHubClientBase src/MagicOnion.Client/StreamingHubClientBase.cs— TooManyMethods — 343 significant lines (blank, comment-only and punctuation-only lines excluded), 41 methods. The bar is 30 methods; this is 11 over it, 1.37× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
Change coupling: Program.cs ↔ PerfTestService.cs perf/BenchmarkApp/PerformanceTest.Client/Program.cs:1— `perf/BenchmarkApp/PerformanceTest.Client/Program.cs` and `perf/BenchmarkApp/PerformanceTest.Server/PerfTestService.cs` change together 60% of the time (9 of the 15 commits that touched whichever of the two files changed less often, counting a file under its earlier names as well — a repo-wide or module-wide sweep is evidence about the sweep rather than about any pair inside it and is left out of BOTH sides of this ratio, while a dependency bump, a formatter/rename sweep, or a commit whose edit to one of the two files was a tool directive such as //go:generate or whitespace only is left out of the shared count ONLY, so the two sides are not taken over identical commit sets). They sit in different directories, but in this ecosystem the namespace is declared in the FILE, not by the folder — so the two may well share one namespace and reference each other with no import for this pass to see. Read the pair before acting: if one derives from or overrides the other, the dependency is explicit in the type declaration and the co-change is definitional; if one registers itself into the other through a hook or an initialiser, the missing dependency is DELIBERATE and the thing to add is a comment saying so; if they simply belong together, co-locate them; if none of these holds, the coupling is hidden and worth breaking. You can check this without leaving the row: of the 9 shared commits counted here, the most recent 3 are `cb66153f` chore: Server Broadcast by fps; `abbc07bc` chore: Stop Benchmark ServerStreaming by initial request timeout [ski…; `94d34e16` chore: Benchmark ServerStreaming Scenario — run `git show` on any of them.
D4 · Code Duplication· Members sharing a duplicated core (6 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (6 members, 50+ identical tokens) src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:67— src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:67-74 | src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:77-85 | src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:88-97 | src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:100-110 | src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:113-124 | src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:127-139 — These 6 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 6 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 6 times.
D4 · Code Duplication· Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
Members sharing a duplicated core (5 members, 50+ identical tokens) src/MagicOnion.Internal/StreamingHubMessageWriter.cs:72— src/MagicOnion.Internal/StreamingHubMessageWriter.cs:72-81 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:87-96 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:102-112 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:119-129 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:136-146 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication· Edited copies of one member (3 members, 22+ corresponding lines) · ×1
Edited copies of one member (3 members, 22+ corresponding lines) src/MagicOnion.Client/DynamicClient/ServiceClientDefinition.cs:214— src/MagicOnion.Client/DynamicClient/ServiceClientDefinition.cs:214-236 | src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:236-257 | src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:301-323 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 22 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 56+ corresponding lines) · ×1
Edited copies of one member (3 members, 56+ corresponding lines) src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:55— src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:55-116 | src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:131-186 | src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:201-259 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 56 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (29 corresponding lines) · ×1
Edited copy of a member (29 corresponding lines) src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:85— src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:85-113 | src/MagicOnion.Client/DynamicClient/ServiceClientDefinition.cs:176-206 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (26 corresponding lines) · ×1
Edited copy of a member (26 corresponding lines) src/MagicOnion.Server/Filters/Internal/FilterHelper.cs:13— src/MagicOnion.Server/Filters/Internal/FilterHelper.cs:13-38 | src/MagicOnion.Server/Filters/Internal/FilterHelper.cs:44-69 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (11 corresponding lines) · ×1
Edited copy of a member (11 corresponding lines) src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationFormatterNameMapper.cs:68— src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationFormatterNameMapper.cs:68-78 | src/MagicOnion.Client.SourceGenerator/CodeAnalysis/SerializationFormatterNameMapper.cs:226-236 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (18 corresponding lines) · ×1
Edited copy of a member (18 corresponding lines) src/MagicOnion.Server/Binder/MagicOnionStreamingHubMethod.cs:40— src/MagicOnion.Server/Binder/MagicOnionStreamingHubMethod.cs:40-57 | src/MagicOnion.Server/Binder/MagicOnionStreamingHubMethod.cs:122-148 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copy of a member (19 corresponding lines) · ×1
Edited copy of a member (19 corresponding lines) src/MagicOnion.Client/Internal/StreamingHubClientHeartbeatManager.cs:132— src/MagicOnion.Client/Internal/StreamingHubClientHeartbeatManager.cs:132-155 | src/MagicOnion.Client/Internal/StreamingHubClientHeartbeatManager.cs:157-175 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 6+ corresponding lines) · ×1
Edited copies of one member (4 members, 6+ corresponding lines) src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodBinder.cs:37— src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodBinder.cs:37-42 | src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodBinder.cs:47-52 | src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodBinder.cs:57-62 | src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodBinder.cs:67-72 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (63 corresponding lines) · ×1
Edited copy of a member (63 corresponding lines) src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:125— src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:125-187 | src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:268-345 — These two members are one piece of code written twice and then edited apart: 63 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 1+ corresponding lines) · ×1
Edited copies of one member (3 members, 1+ corresponding lines) src/MagicOnion.Server/Hubs/Internal/MagicOnionRemoteSerializer.cs:67— src/MagicOnion.Server/Hubs/Internal/MagicOnionRemoteSerializer.cs:67-67 | src/MagicOnion.Server/Hubs/Internal/MagicOnionRemoteSerializer.cs:69-69 | src/MagicOnion.Server/Hubs/Internal/MagicOnionRemoteSerializer.cs:71-71 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 1 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (8 corresponding lines) · ×1
Edited copy of a member (8 corresponding lines) src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:22— src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:22-31 | src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:104-111 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 7+ corresponding lines) · ×1
Edited copies of one member (3 members, 7+ corresponding lines) src/MagicOnion.Server/Binder/MagicOnionClientStreamingMethod.cs:36— src/MagicOnion.Server/Binder/MagicOnionClientStreamingMethod.cs:36-42 | src/MagicOnion.Server/Binder/MagicOnionDuplexStreamingMethod.cs:36-42 | src/MagicOnion.Server/Binder/MagicOnionServerStreamingMethod.cs:35-41 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
Duplicated block (44 lines × 2) src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:521— src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:521-564 | src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:624-667 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:521` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (23 lines × 2) src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:164— src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:164-186 | src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:237-259 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:164` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (17 lines × 2) src/MagicOnion.Client/StreamingHubClientBase.cs:552— src/MagicOnion.Client/StreamingHubClientBase.cs:552-568 | src/MagicOnion.Client/StreamingHubClientBase.cs:575-591 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
Duplicated block (16 lines × 3) src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:170— src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:170-185 | src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:243-258 | src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:326-341 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:170` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (14 lines × 14) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:67— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:67-80 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:131-144 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:202-215 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:280-293 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:365-378 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:457-470 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:556-569 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:662-675 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:775-788 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:895-908 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1022-1035 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1156-1169 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1297-1310 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1445-1458 — all 14 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:67` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (15 lines × 2) src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:246— src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:246-260 | src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:295-309 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:246` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:245` calls `Where` and `src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:294` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (10 lines × 4) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1048— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1048-1057 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1183-1192 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1325-1334 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1474-1483 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1048` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (11 lines × 3) src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:87— src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:87-97 | src/MagicOnion.Client/DynamicClient/ServiceClientDefinition.cs:178-188 | src/MagicOnion.Internal/BroadcasterHelper.cs:21-31 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:87` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (12 lines × 2) src/MagicOnion.Client.SourceGenerator/Internal/FNV1A32.cs:14— src/MagicOnion.Client.SourceGenerator/Internal/FNV1A32.cs:14-25 | src/MagicOnion.Internal/FNV1A32.cs:14-25 — before extracting anything, compare `src/MagicOnion.Client.SourceGenerator/Internal/FNV1A32.cs` and `src/MagicOnion.Internal/FNV1A32.cs` as WHOLE FILES: 83% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 1 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (10–11 lines × 2) src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:36— src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:36-45 | src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:174-184 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:36` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Duplicated block (9 lines × 12) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:246— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:246-254 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:327-335 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:415-423 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:510-518 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:612-620 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:721-729 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:837-845 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:960-968 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1090-1098 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1227-1235 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1371-1379 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1522-1530 — all 12 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:246` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `DynamicArgumentTuple<T1, T2, T3, T4>` in one and `DynamicArgumentTuple<T1, T2, T3, T4, T5>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:336` calls `Serialize` and `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:255` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 8) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:530— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:530-537 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:633-640 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:743-750 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:860-867 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:984-991 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1115-1122 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1253-1260 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1398-1405 — all 8 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:641` calls `default` and `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:538` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 9) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:450— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:450-457 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:547-554 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:651-658 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:762-769 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:880-887 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1005-1012 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1137-1144 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1276-1283 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1422-1429 — all 9 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:556` calls `Read` and `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:458` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 9) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:503— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:503-509 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:603-609 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:710-716 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:824-830 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:945-951 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1073-1079 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1208-1214 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1350-1356 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1499-1505 — all 9 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `DynamicArgumentTuple<T1, T2, T3, T4, T5, T6, T7>` in one and `DynamicArgumentTuple<T1, T2, T3, T4, T5, T6, T7, T8>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:610` calls `WritePropertyName`, `Serialize` and `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:510` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (8 lines × 5) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:888— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:888-895 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1013-1020 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1145-1152 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1284-1291 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1430-1437 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1022` calls `Read` and `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:896` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (7 lines × 5) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:953— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:953-959 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1081-1087 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1216-1222 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1358-1364 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1507-1513 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `DynamicArgumentTuple<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11>` in one and `DynamicArgumentTuple<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1088` calls `WritePropertyName`, `Serialize` and `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:960` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 6) src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:68— src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:68-72 | src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:78-82 | src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:89-93 | src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:101-105 | src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:114-118 | src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:128-132 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Client/Internal/InterceptInvokeHelper.cs:68` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
Duplicated block (6 lines × 6) src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:846— src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:846-851 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:969-974 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1099-1104 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1236-1241 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1380-1385 | src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:1531-1536 — all 6 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `value` to `DynamicArgumentTuple<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10>` in one and `DynamicArgumentTuple<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11>` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:975` calls `Serialize` and `src/MagicOnion.Server.JsonTranscoding/DynamicArgumentTupleConverterFactory.cs:852` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (6 lines × 5) src/MagicOnion.Internal/StreamingHubMessageWriter.cs:72— src/MagicOnion.Internal/StreamingHubMessageWriter.cs:72-77 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:87-92 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:102-107 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:119-125 | src/MagicOnion.Internal/StreamingHubMessageWriter.cs:136-141 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `src/MagicOnion.Internal/StreamingHubMessageWriter.cs:72` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `src/MagicOnion.Internal/StreamingHubMessageWriter.cs:108` calls `VerifyResultAndAdvance`, `TryWrite`, `Slice` and `src/MagicOnion.Internal/StreamingHubMessageWriter.cs:78` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
Duplicated block (5 lines × 3) src/MagicOnion.Internal/BroadcasterHelper.cs:10— src/MagicOnion.Internal/BroadcasterHelper.cs:10-16 | src/MagicOnion.Internal/MagicOnionMarshallers.cs:63-67 | src/MagicOnion.Serialization.MessagePack/MessagePackMagicOnionSerializerProvider.cs:59-63 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere all 3 call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made 3 times.
D4 · Code Duplication· Edited copy of a member (23 corresponding lines) · ×1
Edited copy of a member (23 corresponding lines) perf/BenchmarkApp/PerformanceTest.Client/Program.cs:302— perf/BenchmarkApp/PerformanceTest.Client/Program.cs:302-324 | perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:22-49 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (3 members, 20+ corresponding lines) · ×1
Edited copies of one member (3 members, 20+ corresponding lines) perf/BenchmarkApp/PerformanceTest.Client/Program.cs:443— perf/BenchmarkApp/PerformanceTest.Client/Program.cs:443-463 | perf/BenchmarkApp/PerformanceTest.Client/Program.cs:485-504 | perf/BenchmarkApp/PerformanceTest.Server/ProfileService.cs:105-125 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (10 corresponding lines) · ×1
Edited copy of a member (10 corresponding lines) perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:150— perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:150-159 | perf/Microbenchmark/Microbenchmark.Client/StreamingHubClientTestHelper.cs:162-171 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication· Edited copies of one member (4 members, 9+ corresponding lines) · ×1
Edited copies of one member (4 members, 9+ corresponding lines) perf/BenchmarkApp/PerformanceTest.Client/StreamingHubLargePayloadScenario.cs:22— perf/BenchmarkApp/PerformanceTest.Client/StreamingHubLargePayloadScenario.cs:22-32 | perf/BenchmarkApp/PerformanceTest.Client/StreamingHubScenario.cs:17-25 | perf/BenchmarkApp/PerformanceTest.Client/UnaryLargePayloadScenario.cs:23-33 | perf/BenchmarkApp/PerformanceTest.Client/UnaryScenario.cs:17-25 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication· Edited copy of a member (36 corresponding lines) · ×1
Edited copy of a member (36 corresponding lines) perf/BenchmarkApp/PerformanceTest.Client/Program.cs:429— perf/BenchmarkApp/PerformanceTest.Client/Program.cs:429-464 | perf/BenchmarkApp/PerformanceTest.Server/ProfileService.cs:41-86 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
Duplicated block (18 lines × 2) perf/BenchmarkApp/PerformanceTest.Server/PerfTestControlService.cs:13— perf/BenchmarkApp/PerformanceTest.Server/PerfTestControlService.cs:13-30 | perf/BenchmarkApp/PerformanceTest.Server/PerfTestService.cs:14-31 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
Duplicated block (11 lines × 2) perf/BenchmarkApp/PerformanceTest.Server/ServerBroadcastMetricsContext.cs:97— perf/BenchmarkApp/PerformanceTest.Server/ServerBroadcastMetricsContext.cs:97-107 | perf/BenchmarkApp/PerformanceTest.Server/ServerBroadcastMetricsContext.cs:123-133 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `perf/BenchmarkApp/PerformanceTest.Server/ServerBroadcastMetricsContext.cs:97` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
Unstable project MagicOnion src/MagicOnion/MagicOnion.csproj:1— MagicOnion has instability 0.33 with 4 dependents.
D8 · Code Coverage· No test project references MagicOnion.Internal · ×1
No test project references MagicOnion.Internal src/MagicOnion.Internal/MagicOnion.Internal.csproj— No test project in this repository references MagicOnion.Internal (20 production source file(s)), so `dotnet test` never loads it and no coverage tool can measure it — its code is absent from the 100.0% above rather than counted at zero. This is the whole assembly, not a gap within one: add a test project that references it (or a ProjectReference from an existing suite) and its coverage starts being measured.
D8 · Code Coverage· No test project references PerformanceTest.Shared · ×1
No test project references PerformanceTest.Shared perf/BenchmarkApp/PerformanceTest.Shared/PerformanceTest.Shared.csproj— No test project in this repository references PerformanceTest.Shared (15 production source file(s)), so `dotnet test` never loads it and no coverage tool can measure it — its code is absent from the 100.0% above rather than counted at zero. This is the whole assembly, not a gap within one: add a test project that references it (or a ProjectReference from an existing suite) and its coverage starts being measured.
D8 · Code Coverage· No test project references PerformanceTest.Client · ×1
No test project references PerformanceTest.Client perf/BenchmarkApp/PerformanceTest.Client/PerformanceTest.Client.csproj— No test project in this repository references PerformanceTest.Client (11 production source file(s)), so `dotnet test` never loads it and no coverage tool can measure it — its code is absent from the 100.0% above rather than counted at zero. This is the whole assembly, not a gap within one: add a test project that references it (or a ProjectReference from an existing suite) and its coverage starts being measured.
D8 · Code Coverage· No test project references PerformanceTest.Server · ×1
No test project references PerformanceTest.Server perf/BenchmarkApp/PerformanceTest.Server/PerformanceTest.Server.csproj— No test project in this repository references PerformanceTest.Server (10 production source file(s)), so `dotnet test` never loads it and no coverage tool can measure it — its code is absent from the 100.0% above rather than counted at zero. This is the whole assembly, not a gap within one: add a test project that references it (or a ProjectReference from an existing suite) and its coverage starts being measured.
D8 · Code Coverage· No test project references MagicOnion.Server.JsonTranscoding.Swagger · ×1
No test project references MagicOnion.Server.JsonTranscoding.Swagger src/MagicOnion.Server.JsonTranscoding.Swagger/MagicOnion.Server.JsonTranscoding.Swagger.csproj— No test project in this repository references MagicOnion.Server.JsonTranscoding.Swagger (7 production source file(s)), so `dotnet test` never loads it and no coverage tool can measure it — its code is absent from the 100.0% above rather than counted at zero. This is the whole assembly, not a gap within one: add a test project that references it (or a ProjectReference from an existing suite) and its coverage starts being measured.
D8 · Code Coverage· No test project references SourceGeneratorPerf · ×1
No test project references SourceGeneratorPerf perf/SourceGeneratorPerf/SourceGeneratorPerf/SourceGeneratorPerf.csproj— No test project in this repository references SourceGeneratorPerf (2 production source file(s)), so `dotnet test` never loads it and no coverage tool can measure it — its code is absent from the 100.0% above rather than counted at zero. This is the whole assembly, not a gap within one: add a test project that references it (or a ProjectReference from an existing suite) and its coverage starts being measured.
IC1 · Incompleteness & stubs· Both branches open with the same statements · ×1
Both branches open with the same statements — the condition does not decide them src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs:120— The first 2 statements of the `if` and of the `else` are identical, so they run on both paths regardless of the condition. Lift them above the `if` — leaving them duplicated inside makes the branches read as though they handled this differently.
Outbound HTTP without resilience perf/BenchmarkApp/PerformanceTest.Shared/Reporting/DatadogMetricsRecorder.cs:46— `new HttpClient()` builds an outbound HTTP client and nothing bounds it: no timeout is set on it and no retry or resilience policy wraps its calls in the type that owns it. A slow or failing dependency will hold this service's request, thread or connection — and cascade — until the call gives up on its own (100 s for HttpClient's default).
Token validation disabled samples/JwtAuthentication/JwtAuthApp.Server/Program.cs:35— `ValidateAudience`, `ValidateIssuer` are all set to `false`, which means a token minted for a DIFFERENT relying party is accepted here. Any other service that trusts the same issuer can have its tokens replayed against this one, which is precisely what the `Audience` value exists to prevent.
X2 · Cancellation propagation· Async local function without CancellationToken · ×1
Async local function without CancellationToken: Main perf/BenchmarkApp/PerformanceTest.Client/Program.cs:17— Neither takes a CancellationToken nor reads the one of the function it sits in, while it calls something that takes one — this work can't be stopped early once started. Take the token, or pass on the enclosing one.
X28 · Index access outside its own emptiness guard· Index access outside its own emptiness guard · ×1
Index access outside its own emptiness guard perf/BenchmarkApp/PerformanceTest.Shared/Reporting/OutlinerHelper.cs:37— This guard tests `sortedData` for emptiness and then indexes it where the test says it is empty: `sortedData[0]` is reached only when `sortedData.Count == 0` holds the empty case, and `sortedData[0]` indexes position 0 of nothing and throws. Either the guard is load-bearing, in which case this access crashes, or `sortedData` cannot be empty here and the guard is dead. Move the access to the branch the test protects, or leave the method on the empty side.
Minor — 168 finding(s)
P10 · Library API & versioning· Public type used only inside its own library · ×35
Public type used only inside its own library src/MagicOnion.Client/DynamicClient/DynamicMagicOnionClientFactoryProvider.cs:5— `MagicOnion.Client.DynamicClient.DynamicNotSupportedMagicOnionClientFactoryProvider` (src/MagicOnion.Client/DynamicClient/DynamicMagicOnionClientFactoryProvider.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Client/DynamicClient/DynamicMagicOnionClientFactoryProvider.cs:5— `MagicOnion.Client.DynamicClient.DynamicNotSupportedMagicOnionClientFactoryProvider` (src/MagicOnion.Client/DynamicClient/DynamicMagicOnionClientFactoryProvider.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientFactoryProvider.cs:5— `MagicOnion.Client.DynamicClient.DynamicNotSupportedStreamingHubClientFactoryProvider` (src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientFactoryProvider.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientFactoryProvider.cs:5— `MagicOnion.Client.DynamicClient.DynamicNotSupportedStreamingHubClientFactoryProvider` (src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientFactoryProvider.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Client/IMagicOnionAwareGrpcChannel.cs:5— `MagicOnion.Client.IMagicOnionAwareGrpcChannel` (src/MagicOnion.Client/IMagicOnionAwareGrpcChannel.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Client/IMagicOnionAwareGrpcChannel.cs:5— `MagicOnion.Client.IMagicOnionAwareGrpcChannel` (src/MagicOnion.Client/IMagicOnionAwareGrpcChannel.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Client/MagicOnionClientFactoryProvider.cs:10— `MagicOnion.Client.MagicOnionClientFactoryProvider` (src/MagicOnion.Client/MagicOnionClientFactoryProvider.cs:10) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Client/MagicOnionClientFactoryProvider.cs:10— `MagicOnion.Client.MagicOnionClientFactoryProvider` (src/MagicOnion.Client/MagicOnionClientFactoryProvider.cs:10) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Client/RequestContext.cs:5— `MagicOnion.Client.RequestContext` (src/MagicOnion.Client/RequestContext.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Client/RequestContext.cs:5— `MagicOnion.Client.RequestContext` (src/MagicOnion.Client/RequestContext.cs:5) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Client/StreamingHubClientFactoryProvider.cs:10— `MagicOnion.Client.StreamingHubClientFactoryProvider` (src/MagicOnion.Client/StreamingHubClientFactoryProvider.cs:10) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion`, `MagicOnion.Client.Tests(net8.0)`, `MagicOnion.Integration.Tests(net8.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`, `MagicOnion.Serialization.MessagePack.Tests(net8.0)`, `MagicOnion.Server.Redis.Tests(net8.0)`, `MagicOnion.Server.Tests(net8.0)`, `Microbenchmark.Client`, `SourceGeneratorPerf`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Client/StreamingHubClientFactoryProvider.cs:10— `MagicOnion.Client.StreamingHubClientFactoryProvider` (src/MagicOnion.Client/StreamingHubClientFactoryProvider.cs:10) is public, and the library's own code uses it, but no other project in this repository uses it (read: `ChatApp.Console`, `JwtAuthApp.Client`, `MagicOnion.Client.NativeAot.Tests`, `MagicOnion.Client.SourceGenerator.Tests`, `MagicOnion.Client.Tests(net10.0)`, `MagicOnion.Integration.Tests(net10.0)`, `MagicOnion.Serialization.MemoryPack.Tests(net10.0)`, `MagicOnion.Serialization.MessagePack.Tests(net10.0)`, `MagicOnion.Server.Redis.Tests(net10.0)`, `MagicOnion.Server.Tests(net10.0)`, `PerformanceTest.Client`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:10— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:10) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:35— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:35) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:74— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:74) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:115— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:115) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:158— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:158) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:203— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:203) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:250— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:250) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:299— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:299) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:350— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:350) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:403— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:403) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:458— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:458) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:515— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:515) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Public type used only inside its own library src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:574— `MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter` (src/MagicOnion.Serialization.MemoryPack/DynamicArgumentTupleMemoryPackFormatter.cs:574) is public, and the library's own code uses it, but no other project in this repository uses it (read: `MagicOnion.Serialization.MemoryPack.Tests(net8.0)`) and no public member of the library exposes it. Consumers outside this repository are not visible here; if they rely on it, it is API and should be documented as such.
Commented-out code src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MagicOnionTypeInfo.cs:106— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MagicOnionTypeInfo.cs:109— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client.SourceGenerator/CodeAnalysis/MethodCollector.cs:136— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicClientBuilder.cs:109— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicClientBuilder.cs:113— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicClientBuilder.cs:126— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicClientBuilder.cs:130— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicClientBuilder.cs:259— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:154— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:163— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:261— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:276— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:311— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:312— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:317— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:341— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:359— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:381— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:396— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:411— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:412— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:413— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:414— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:416— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
Commented-out code src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:420— A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
+ 8 more in this group — see findings.md.
P2 · Observability· Console output used as the logging channel · ×23
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:23— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 23 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:24— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 24 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:25— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 25 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:26— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 26 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:27— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 27 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:28— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 28 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:29— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 29 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:31— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 31 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:32— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 32 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:33— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 33 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:35— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 35 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:36— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 36 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:37— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 37 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:38— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 38 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:39— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 39 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:40— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 40 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:41— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 41 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:42— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 42 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:43— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 43 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:44— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 44 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:45— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 45 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:46— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 46 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
Console output used as the logging channel perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs:48— `perf/BenchmarkApp/PerformanceTest.Server/StartupService.cs` reports through `Console.Write…` at line 48 although other files in its project log through a logger. Console lines carry no level, category or structured properties and never reach the log pipeline or its exporters.
redundant comment perf/BenchmarkApp/PerformanceTest.Client/Program.cs:68— "Create a control channel" repeats the code it sits on: 3 of its 3 words (create, control, channel) are already in `using var channelControl = config.CreateChannel();`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment perf/BenchmarkApp/PerformanceTest.Client/Program.cs:507— "Remove Outliner by IQR" repeats the code it sits on: 3 of its 3 words (remove, outliner, iqr) are already in `private static IReadOnlyList<PerformanceResult> RemoveOutlinerByIQR(IReadOnlyList<PerformanceResult> data)`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment perf/BenchmarkApp/PerformanceTest.Client/Program.cs:514— "get outliner for rps" repeats the code it sits on: 3 of its 3 words (get, outliner, rps) are already in `var lowerBoundRps = OutlinerHelper.GetLowerBound(rps);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment perf/BenchmarkApp/PerformanceTest.Client/Program.cs:518— "get outliner for mean" repeats the code it sits on: 3 of its 3 words (get, outliner, mean) are already in `var lowerBoundMean = OutlinerHelper.GetLowerBound(mean);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment perf/BenchmarkApp/PerformanceTest.Server/Program.cs:35— "Add services to the container." is ASP.NET Core project template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment perf/BenchmarkApp/PerformanceTest.Server/Program.cs:52— "Configure the HTTP request pipeline." is ASP.NET Core project template text, left in place. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment perf/BenchmarkApp/PerformanceTest.Shared/Reporting/MetricsTagCache.cs:37— "put to hot-cache if cache hit is above threshold" repeats the code it sits on: 4 of its 5 words (hot, cache, hit, threshold) are already in `if (isCacheHit && cacheHitCount >= hotEntryThresholds)`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment src/MagicOnion.Client.SourceGenerator/MagicOnionClientSourceGenerator.Parser.cs:22— "Type[] typesContainedInTargetAssembly" repeats the code it sits on: 5 of its 5 words (type, types, contained, target, assembly) are already in `foreach (var typeContainedInTargetAssembly in attr.ConstructorArguments[0].Values) // Type[] typesContainedInTargetAssem …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment src/MagicOnion.Client/DynamicClient/DynamicClientBuilder.cs:122— "private {ServiceName}Client(MagicOnionClientOptions options, ClientCore clientCore) {" repeats the code it sits on: 7 of its 8 words (private, service, client, magic, onion, options, core) are already in `ctx.ServiceClientConstructorForClone = ctx.ServiceClientType.DefineConstructor(MethodAttributes.Private, CallingConventi …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:68— "Create FireAndForgetType first as nested type." repeats the code it sits on: 5 of its 6 words (create, fire, forget, type, nested) are already in `var typeBuilderEx = typeBuilder.DefineNestedType($"FireAndForgetClient", TypeAttributes.NestedPrivate, typeof(object), n …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment src/MagicOnion.Client/Internal/StreamingHubClientHeartbeatManager.cs:86— "Writes a ClientHeartbeat to the writer queue." repeats the code it sits on: 4 of its 5 words (writes, client, heartbeat, writer) are already in `_ = writer.TryWrite(BuildClientHeartbeatMessage(sequence));`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment src/MagicOnion.Client/StreamingHubClientBase.cs:217— "Check message version of StreamingHub." repeats the code it sits on: 5 of its 5 words (check, message, version, streaming, hub) are already in `if (messageVersion != null && messageVersion.Value != StreamingHubVersionHeaderValue)`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment src/MagicOnion.Client/StreamingHubClientBase.cs:228— "Set up the Heartbeat Manager" repeats the code it sits on: 3 of its 3 words (set, heartbeat, manager) are already in `heartbeatManager = new StreamingHubClientHeartbeatManager(`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment src/MagicOnion.Server/Extensions/MagicOnionServicesExtensions.cs:54— "MagicOnion: Metrics" repeats the code it sits on: 3 of its 3 words (magic, onion, metrics) are already in `services.TryAddSingleton<MagicOnionMetrics>();`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment src/MagicOnion.Server/Extensions/MagicOnionServicesExtensions.cs:57— "MagicOnion: Options" repeats the code it sits on: 3 of its 3 words (magic, onion, options) are already in `services.AddOptions<MagicOnionOptions>(configName)`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment tests/MagicOnion.Client.SourceGenerator.Tests/RunTest.cs:39— 8 comments in this file only repeat the code they sit on (lines 39, 70, 105, 147, 234, 275, 319, 358), for example "Run generator and update compilation". Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment tests/MagicOnion.Client.SourceGenerator.Tests/Verifiers/MagicOnionSourceGeneratorVerifier.cs:71— "MagicOnion.Serialization.MemoryPack" repeats the code it sits on: 5 of its 5 words (magic, onion, serialization, memory, pack) are already in `test.TestState.AdditionalReferences.Add(typeof(MagicOnion.Serialization.MemoryPack.DynamicArgumentTupleFormatter).Assemb …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment tests/MagicOnion.Client.SourceGenerator.Tests/Verifiers/MagicOnionSourceGeneratorVerifier.cs:108— "MagicOnion.Client" repeats the code it sits on: 3 of its 3 words (magic, onion, client) are already in `this.TestState.AdditionalReferences.Add(typeof(MagicOnion.Client.MagicOnionClient).Assembly);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment tests/MagicOnion.Client.SourceGenerator.Tests/Verifiers/MagicOnionSourceGeneratorVerifier.cs:112— "MagicOnion.Serialization.MessagePack" repeats the code it sits on: 5 of its 5 words (magic, onion, serialization, message, pack) are already in `this.TestState.AdditionalReferences.Add(typeof(MagicOnion.Serialization.MessagePack.MessagePackMagicOnionSerializerProvi …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment tests/MagicOnion.Client.SourceGenerator.Tests/Verifiers/MagicOnionSourceGeneratorVerifier.cs:120— "Grpc.Net.Client" repeats the code it sits on: 3 of its 3 words (grpc, net, client) are already in `this.TestState.AdditionalReferences.Add(typeof(Grpc.Net.Client.GrpcChannel).Assembly);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment tests/MagicOnion.Server.Tests/Filter/FilterHelperTest.cs:497— "IMagicOnionFilterFactory<MagicOnionFilterAttribute>" repeats the code it sits on: 4 of its 5 words (magic, onion, filter, factory) are already in `var filterDesc = new MagicOnionServiceFilterDescriptor(new TestServiceFilterLegacyFactory()); /* IMagicOnionFilterFactor …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
redundant comment tests/MagicOnion.Server.Tests/Filter/MagicOnionFilterDescriptorExtensionsTest.cs:86— "`MagicOnionFilterFromTypeFactoryFactory` is internal type" repeats the code it sits on: 5 of its 6 words (magic, onion, filter, type, factory) are already in `var filter = Assert.IsType<MagicOnionFilterDescriptor<IStreamingHubFilter>.MagicOnionFilterFromTypeFactoryFactory>(filte …`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
Outdated: Microsoft.SourceLink.GitHub REDACTED:27— Microsoft.SourceLink.GitHub 8.0.0 → 11.0.100 available (referenced by PerformanceTest.Client).
Outdated: Microsoft.AspNetCore.Authentication.JwtBearer REDACTED:57— Microsoft.AspNetCore.Authentication.JwtBearer 8.0.11 → 11.0.0 available (referenced by JsonTranscodingSample.Server).
Outdated: Microsoft.Bcl.TimeProvider REDACTED:23— Microsoft.Bcl.TimeProvider 8.0.1 → 11.0.0 available (referenced by MagicOnion.Client).
Outdated: System.Threading.Channels REDACTED:36— System.Threading.Channels 8.0.0 → 11.0.0 available (referenced by MagicOnion.Client).
Outdated: Swashbuckle.AspNetCore REDACTED:33— Swashbuckle.AspNetCore 7.0.0 → 11.0.1 available (referenced by MagicOnion.Server.JsonTranscoding.Swagger).
Outdated: coverlet.collector REDACTED:40— coverlet.collector 3.1.2 → 10.1.1 available (referenced by MagicOnion.Abstractions.Tests).
Outdated: xunit.v3 REDACTED:49— xunit.v3 1.0.0 → 4.0.3 available (referenced by MagicOnion.Abstractions.Tests).
Outdated: Microsoft.Extensions.TimeProvider.Testing REDACTED:43— Microsoft.Extensions.TimeProvider.Testing 8.0.0 → 11.0.0 available (referenced by MagicOnion.Client.Tests).
Outdated: Microsoft.AspNetCore.Mvc.Testing REDACTED:41— Microsoft.AspNetCore.Mvc.Testing 8.0.0 → 11.0.0 available (referenced by MagicOnion.Integration.Tests).
Outdated: Microsoft.Extensions.Diagnostics.Testing REDACTED:42— Microsoft.Extensions.Diagnostics.Testing 8.0.0 → 11.0.0 available (referenced by MagicOnion.Server.InternalTesting).
Outdated: System.Text.Json REDACTED:35— System.Text.Json 8.0.5 → 11.0.0 available (referenced by MagicOnion.Server.JsonTranscoding.Tests).
M2 · Architecture documentation· Architecture diagram out of date · ×9
Architecture diagram out of date docs/docs/streaminghub/fundamentals.md:8— `docs/docs/streaminghub/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape.
Architecture diagram out of date docs/docs/streaminghub/group-backplane.md:7— `docs/docs/streaminghub/group-backplane.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape.
Architecture diagram out of date docs/docs/unary/fundamentals.md:6— `docs/docs/unary/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape.
Architecture diagram out of date docs/i18n/ja/docusaurus-plugin-content-docs/current/streaminghub/fundamentals.md:8— `docs/i18n/ja/docusaurus-plugin-content-docs/current/streaminghub/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape.
Architecture diagram out of date docs/i18n/ja/docusaurus-plugin-content-docs/current/streaminghub/group-backplane.md:7— `docs/i18n/ja/docusaurus-plugin-content-docs/current/streaminghub/group-backplane.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape.
Architecture diagram out of date docs/i18n/ja/docusaurus-plugin-content-docs/current/unary/fundamentals.md:6— `docs/i18n/ja/docusaurus-plugin-content-docs/current/unary/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape.
Architecture diagram out of date docs/i18n/ko/docusaurus-plugin-content-docs/current/streaminghub/fundamentals.md:8— `docs/i18n/ko/docusaurus-plugin-content-docs/current/streaminghub/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape.
Architecture diagram out of date docs/i18n/ko/docusaurus-plugin-content-docs/current/streaminghub/group-backplane.md:7— `docs/i18n/ko/docusaurus-plugin-content-docs/current/streaminghub/group-backplane.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape.
Architecture diagram out of date docs/i18n/ko/docusaurus-plugin-content-docs/current/unary/fundamentals.md:5— `docs/i18n/ko/docusaurus-plugin-content-docs/current/unary/fundamentals.md` draws the system's parts, and the drawing no longer matches the code: it leaves out `PerformanceTest.Shared`, `JwtAuthApp.Shared`, which the repository has beside the units it does draw. A diagram of a system that no longer exists misleads the reader it was drawn for, so it is not credited as documenting the shape.
P10 · Library API & versioning· Implementation type on the public API · ×5
Implementation type on the public API src/MagicOnion.Abstractions/Internal/Box.cs:6— 21 public types in `MagicOnion.Internal` are marked as implementation by their own namespace, folder or name: `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:6, `Internal`), `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:6, `Internal`), `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:6, `Internal`), `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:40, `Internal`), `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:40, `Internal`), `Box` (src/MagicOnion.Abstractions/Internal/Box.cs:40, `Internal`), `IAsyncGrpcCallWrapper` (src/MagicOnion.Abstractions/Internal/IAsyncGrpcCallWrapper.cs:5, `Internal`), `IAsyncGrpcCallWrapper` (src/MagicOnion.Abstractions/Internal/IAsyncGrpcCallWrapper.cs:5, `Internal`), and 13 more. While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
Implementation type on the public API src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:10— 12 public types in `MagicOnion.Client.Internal` are marked as implementation by their own namespace, folder or name: `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:10, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:10, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:10, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:10, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:29, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:29, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:29, `Internal`), `RawMethodInvoker` (src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:29, `Internal`), and 4 more. While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
Implementation type on the public API src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:18— 2 public types in `MagicOnion.Server.Binder.Internal` are marked as implementation by their own namespace, folder or name: `MagicOnionGrpcMethodHandler` (src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:18, `Internal`), `MagicOnionGrpcMethodHandler` (src/MagicOnion.Server/Binder/Internal/MagicOnionGrpcMethodHandler.cs:18, `Internal`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
Implementation type on the public API src/MagicOnion.Server/Hubs/Internal/StreamingHubHandler.cs:62— 2 public types in `MagicOnion.Server.Hubs.Internal` are marked as implementation by their own namespace, folder or name: `StreamingHubHandlerOptions` (src/MagicOnion.Server/Hubs/Internal/StreamingHubHandler.cs:62, `Internal`), `StreamingHubHandlerOptions` (src/MagicOnion.Server/Hubs/Internal/StreamingHubHandler.cs:62, `Internal`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
Implementation type on the public API src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:9— 8 public types in `MagicOnion.Server.Internal` are marked as implementation by their own namespace, folder or name: `MethodHandlerMetadata` (src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:9, `Internal`), `MethodHandlerMetadata` (src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:9, `Internal`), `StreamingHubMethodHandlerMetadata` (src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:90, `Internal`), `StreamingHubMethodHandlerMetadata` (src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs:90, `Internal`), `DuplicateKeyException` (src/MagicOnion.Server/Internal/UniqueHashDictionary.cs:6, `Internal`), `DuplicateKeyException` (src/MagicOnion.Server/Internal/UniqueHashDictionary.cs:6, `Internal`), `UniqueHashDictionary` (src/MagicOnion.Server/Internal/UniqueHashDictionary.cs:21, `Internal`), `UniqueHashDictionary` (src/MagicOnion.Server/Internal/UniqueHashDictionary.cs:21, `Internal`). While they are public, every consumer of the library can bind to them, so changing them is a breaking change for those consumers.
No security response headers detected — None of the 11 security response headers the OWASP Secure Headers Project recommends (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, X-Frame-Options, …) is configured — defense in depth, even when a reverse proxy could set them. (−2.0 on this card.)
No security response headers detected perf/BenchmarkApp/PerformanceTest.Server/Program.cs:12— This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves.
No security response headers detected samples/ChatApp/ChatApp.Server/Program.cs:6— This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves.
No security response headers detected samples/JsonTranscoding/JsonTranscodingSample.Server/Program.cs:3— This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves.
No security response headers detected samples/JwtAuthentication/JwtAuthApp.Server/Program.cs:10— This web host's pipeline is composed here and adds no security response header (Content-Security-Policy, Strict-Transport-Security, X-Content-Type-Options, a frame policy) to what it serves.
Pass-through layer src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:98— AsyncServerStreamingCallWrapper: all 3 public methods forward their arguments unchanged to inner and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call inner directly, or give the layer a job.
Pass-through layer src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:123— AsyncClientStreamingCallWrapper: all 3 public methods forward their arguments unchanged to inner and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call inner directly, or give the layer a job.
Pass-through layer src/MagicOnion.Client/Internal/MagicOnionMethodInvoker.cs:152— AsyncDuplexStreamingCallWrapper: all 3 public methods forward their arguments unchanged to inner and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call inner directly, or give the layer a job.
Duplicated predicate src/MagicOnion.Server/FromServiceFilterAttribute.cs:21— `!typeof(IMagicOnionServiceFilter).IsAssignableFrom(type) && !typeof(IStreamingHubFilter).IsAssignableFrom(type)` appears character-identically in 2 files — src/MagicOnion.Server/FromServiceFilterAttribute.cs, src/MagicOnion.Server/FromTypeFilterAttribute.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs:93— `methodInfo.IsSpecialName && (methodInfo.Name.StartsWith("set_") || methodInfo.Name.StartsWith("get_"))` appears character-identically in 4 files — src/MagicOnion.Client/DynamicClient/DynamicStreamingHubClientBuilder.cs, src/MagicOnion.Client/DynamicClient/ServiceClientDefinition.cs, src/MagicOnion.Internal/BroadcasterHelper.cs, src/MagicOnion.Server/Binder/Internal/DynamicMagicOnionMethodProvider.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Duplicated predicate src/MagicOnion.Internal/BroadcasterHelper.cs:14— `x.Name.StartsWith("DynamicArgumentTuple") && !x.Name.Contains("Formatter")` appears character-identically in 3 files — src/MagicOnion.Internal/BroadcasterHelper.cs, src/MagicOnion.Internal/MagicOnionMarshallers.cs, src/MagicOnion.Serialization.MessagePack/MessagePackMagicOnionSerializerProvider.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
Off-boarding risk: anonymized user #1 — If anonymized user #1 becomes unavailable, 12 significant file(s) lose their only recent owner: src/MagicOnion.Client/StreamingHubClientBase.cs, src/MagicOnion.Server/Internal/MethodHandlerMetadata.cs, src/MagicOnion.Server/Hubs/StreamingHub.cs, src/MagicOnion.Server/Binder/MagicOnionStreamingHubMethod.cs, src/MagicOnion.Server/Hubs/Internal/StreamingHubHeartbeatManager.cs, src/MagicOnion.Server/Binder/MagicOnionUnaryMethod.cs, src/MagicOnion.Server/Internal/QueuedResponseWriter.cs, src/MagicOnion.Server/MagicOnionOptions.cs (+4 more). Pair on, review, or document these before any departure.
Off-boarding risk: anonymized user #2 — If anonymized user #2 becomes unavailable, 9 significant file(s) lose their only recent owner: perf/BenchmarkApp/PerformanceTest.Client/Program.cs, perf/BenchmarkApp/PerformanceTest.Shared/ApplicationInformation.cs, perf/BenchmarkApp/PerformanceTest.Shared/Reporting/DatadogMetricsRecorder.cs, perf/BenchmarkApp/PerformanceTest.Server/PerfTestService.cs, perf/BenchmarkApp/PerformanceTest.Server/ProfileService.cs, perf/BenchmarkApp/PerformanceTest.Server/ServerBroadcastMetricsContext.cs, perf/BenchmarkApp/PerformanceTest.Client/PerformanceTestRunningContext.cs, perf/BenchmarkApp/PerformanceTest.Shared/Reporting/HardwarePerformanceReporter.cs (+1 more). Pair on, review, or document these before any departure.
D26 · Project Cohesion· Projects may be oversized for their cohesion · ×1
Projects may be oversized for their cohesion src/MagicOnion.Server/MagicOnion.Server.csproj:1— `MagicOnion.Server(net8.0)` overshoots its size bounds (6261 LoC, 60 public types across 12 namespaces). 1 of 41 project(s) overshoot their size bounds, lowering Project Cohesion to 9.7/10. Review these for cohesion — draw the boundary inside the assembly first (group each responsibility into its own namespace/folder and keep the cross-boundary members internal), since splitting a published assembly moves types between packages and breaks consumers.
D28 · Secrets (history)· Rotate the exposed credentials · ×1
No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
Logging is not universal — Only 5/10 service-like projects use logging (pure contract/DTO projects are excluded — they have nothing to log). Of those 10, 5 ship a process this repository operates; the rest are libraries their consumer hosts, where the logging decision belongs to the host.
P3 · Security & performance tooling· Dependabot does not watch nuget · ×1
Dependabot does not watch nuget .github/dependabot.yaml:3— `.github/dependabot.yaml` schedules updates, but no `package-ecosystem` entry covers `nuget`, which this tree depends on — so those dependencies get no update pull requests and no advisory pressure, however complete the dep-scan credit looks. Add the missing entry to the `updates:` list.
Benchmarks don't track allocations — A BenchmarkDotNet suite exists but no [MemoryDiagnoser] — allocations (the main way hot code pressures the GC) aren't being measured.
OIDC metadata fetched over HTTP samples/JwtAuthentication/JwtAuthApp.Server/Program.cs:40— `RequireHttpsMetadata = false` allows the OIDC discovery doc to be fetched over plain HTTP. Safe for loopback-only fetches (Aspire / on-host); risky for any other path.
S1 · Web-Security Posture· No inbound model validation detected · ×1
No inbound model validation detected — No ModelState/[ApiController]/FluentValidation signal — inbound payloads reach handlers unvalidated. (−2.0 on this card.)
X2 · Cancellation propagation· Not all async methods take a CancellationToken · ×1
Not all async methods take a CancellationToken — Only 23/78 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
Interpolated log message defeats structured logging samples/ChatApp/ChatApp.Server/ChatService.cs:25— Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
Nullable reference types not enabled everywhere — 20/23 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
Null-forgiving operator (`!`) suppressions override nullable warnings — ~3.4 `!` suppressions per 1k syntax nodes — 440 suppression(s) across the 130067 syntax node(s) in code where nullable warnings are ENABLED, which is the only code a `!` can suppress anything in (a `!` under `#nullable disable` is inert and is not counted, and its file's nodes are not in the denominator). Each one tells the compiler to trust you about null, suppressing the very safety NRTs provide. Many are correct: each is a claim the checker could not verify, and it is wrong only where the value can in fact be missing, so review the densest places first.
Silent fallback default on parse failure samples/JwtAuthentication/JwtAuthApp.Server/Services/AccountService.cs:60— `GetCurrentUserNameAsync` returns `CurrentUserResponse.Anonymous` when `int.TryParse(userPrincipal.Claims.FirstOrDefault(x => x.Type == ClaimTypes.NameI…` is false, with no log or throw — a malformed value silently becomes that default. Log the input or fail validation. If that constant is the correct answer to the test rather than a stand-in for a value that could not be read, this is not a silent default: say so in a comment on the member and the row stops firing.
Silent fallback default in catch src/MagicOnion.Server/Internal/MagicOnionServicesDiscoverer.cs:83— `GetTypesFromAssemblies` swallows `ReflectionTypeLoadException` into `return Array.Empty<Type>();` — a data error becomes a silent behavior change with no trail. Log the failure or let validation throw.
doc comments repeat the names src/MagicOnion.Abstractions/ServiceNameAttribute.cs:31— 0 of 3 documented parameters and 1 of 50 summaries in `MagicOnion.Abstractions(netstandard2.0)` only repeat the member or parameter name (e.g. "Initializes a new instance of with the specified service name." for `ServiceNameAttribute`). Delete the restating tags, or add what the name does not say.
doc comments repeat the names src/MagicOnion.Internal/ServiceNameHelper.cs:12— 1 of 25 documented parameters and 2 of 77 summaries in `MagicOnion.Client(netstandard2.0)` only repeat the member or parameter name (e.g. "The service interface type (e.g., IMyService)." for `serviceInterfaceType`). 21 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
doc comments repeat the names src/MagicOnion.Serialization.MessagePack/MessagePackMagicOnionSerializerProvider.cs:37— 0 of 1 documented parameters and 0 of 3 summaries in `MagicOnion.Serialization.MessagePack(netstandard2.0)` only repeat the member or parameter name (e.g. "" for `enableFallback`). 1 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
doc comments repeat the names src/MagicOnion.Server/Filters/MagicOnionFilterDescriptor.cs:5— 0 of 94 documented parameters and 4 of 98 summaries in `MagicOnion.Server(net8.0)` only repeat the member or parameter name (e.g. "A descriptor of MagicOnion filter." for `MagicOnionFilterDescriptor`). 20 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
doc comments repeat the names src/MagicOnion.Server.JsonTranscoding/MagicOnionJsonTranscodingBuilderExtensions.cs:13— 0 of 2 documented parameters and 0 of 4 summaries in `MagicOnion.Server.JsonTranscoding(net8.0)` only repeat the member or parameter name (e.g. "" for `builder`). 2 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
doc comments repeat the names src/MagicOnion.Server.JsonTranscoding.Swagger/MagicOnionServerJsonTranscodingSwaggerBuilderExtension.cs:17— 0 of 1 documented parameters and 0 of 1 summaries in `MagicOnion.Server.JsonTranscoding.Swagger(net8.0)` only repeat the member or parameter name (e.g. "" for `services`). 1 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
doc comments repeat the names perf/BenchmarkApp/PerformanceTest.Client/Program.cs:424— 0 of 16 documented parameters and 0 of 21 summaries in `PerformanceTest.Client` only repeat the member or parameter name (e.g. "" for `recorder`). 16 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
doc comments repeat the names perf/BenchmarkApp/PerformanceTest.Server/ProfileService.cs:37— 0 of 3 documented parameters and 0 of 2 summaries in `PerformanceTest.Server` only repeat the member or parameter name (e.g. "" for `recorder`). 3 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.
semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 23 file(s) — `docs/docusaurus.config.ts`, `perf/Microbenchmark/Microbenchmark.Client/Program.cs`, `perf/SourceGeneratorPerf/SourceGeneratorPerf/Program.cs`, `src/MagicOnion.Client.SourceGenerator/CodeGen/MagicOnionInitializerGenerator.cs`, `src/MagicOnion.Client.SourceGenerator/CodeGen/MemoryPack/MemoryPackFormatterRegistrationGenerator.cs`, … (+18 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.
disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
Run 01a1e5a9-c24e-7306-94ee-4397dc590f45 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.
Appendix C — Personal-data map
Every field, property and record parameter whose name is conventional personal data — 8 field(s) across 1 category, each with an exact repo-relative file:line. This is the data inventory a compliance review starts from — right-to-erasure, retention, minimisation. Detected by NAME, from the C# syntax tree, with a deliberately specific identifier classifier — the same one the C1–C5 compliance cards use to decide whether personal data is present, so CardDefinition or FileName don't trip. Two caveats stated rather than glossed: those cards additionally require corroboration (a persistence/account signal, or two distinct PII categories) that this inventory deliberately does not, so it lists more than they gate on; and D32 Data Compliance shares nothing with it — that dimension is a separate semgrep ruleset for personal data leaking into logs, URLs and browser storage, and a clean D32 result says nothing about this list. Informational — it feeds no score.
Issues: 91 · Warnings: 404 · Recommendations: 168 · Info: 31 — Appendix A · all findings · full markdown report.
Generated by the Canine Code Analyzer: deterministic code-health analysis. 16-11-2026 @ 18:41 UTC.
Downloadable artifacts
Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.