Public report of 526077247/ETPro, published 17 November 2026. It has the same score, grades and number of findings as the full report. The details of security findings (where they are in the code, which known vulnerabilities and which passwords or keys were found) are left out, so nobody can use them against the project.
Public
Executive report Measured under the Code Assurance Index, an open standard for code quality, using its published scoring rules (rubric version 2026.11.4). Assert signed this survey and filed it in the standard's public register, where anyone can look it up by its survey ID. Check this survey → Signed and filed in the standard's public register, 17 November 2026, 19:46 UTC · Survey ID cd_7df7b33601d1484a8d44f91822f3c860

526077247/ETPro

Measured 17 November 2026, 19:45 UTC, at code version 6a19e7f

First survey, so nothing to compare with yet Code coverage: not measured

Code coverage is not measured: The repo's test suite did not build.

CAI score 36.4out of 100 Weak
CriticalWeakAdequateStrongExemplary

The score is built from these lenses. Each lens grades one area of the code, such as how easy it is to change or how well it is protected. The weakest lens counts most, so one weak area pulls the score down instead of being averaged away.

A medium codebase: 60,899 lines of product code in 15 projects, tests not counted · Estimated rebuild effort: about 1.0 person-years · Weakest lens: Production Readiness, 23.3

Findings by how serious they are

56 critical 523 serious 109 minor

7 dimensions are left out of the score. For each one, we either couldn't measure it in this code, or found no evidence of the safeguard we look for, such as a tested backup restore. They count neither for nor against the score, and Limitations lists each one with its reason.

This survey was produced by

Assert small markCanine Code Analyzer
Producer
Canine Development
Analyzer
Canine Code Analyzer engine 1.0.0
Measured
17 November 2026, 19:45 UTC

A measurement, not a certificate. The Code Assurance Index records a number together with the evidence it was worked out from, so anyone can recalculate it, but it doesn't certify or guarantee the code. The standard was written by Canine Development, which also builds the Canine Code Analyzer. It is open to any tool that implements it, and today the Canine Code Analyzer is the only one that does.

The score is deterministic, which means the same code always gets the same score. We work it out with tools that follow published rules, and an AI model never decides it, so anyone who applies the same rules to the same code gets the same number. How it is done is explained under Methodology ▸

61of 61 dimensions measured by tools.
677of 688 findings point to an exact file and line, so you can open each one in the code. The other 11 concern the repository as a whole, such as missing documentation.
61dimensions across 6 lenses, read from 60,899 lines of product code in 15 projects.
Chapters

Executive summary

526077247/ETPro falls short of our standard for production, in part because we found no working pipeline that builds or tests changes to the code. It scores 36.4 out of 100 and is rated Weak, and 43 of its 56 critical findings are leaked passwords or keys.

Production Readiness, at 23.3, is the weakest lens and counts most in the score. The best first step is encrypting the sensitive stored data and keeping its keys in a vault, worth about 6.4 points. Adding an automated build and test pipeline would lift Production Readiness itself, worth about 6.0 points. Raising Production Readiness to 70 would lift the score to about 47.8.

Forty-three passwords or keys are open to anyone who can read the repository. Replacing each exposed password or key would close this risk. The ten sets of compiler warnings switched off in projects need turning back on in the build file.

The product code is 60,899 lines, about €150,000 to rebuild.

A lens is capped at Adequate while one of its dimensions scores below 4 out of 10, however well the rest of the lens does. That way a serious problem in one place always shows in the lens's rating.

How the score is built: what each lens counts for The lenses don't count equally. The weakest lens counts most, the next weakest a little less, and so on, so a weak area pulls the score down instead of being averaged away. In the bar below, each part's width shows how much that lens counts and its colour shows its rating. Improving the widest part moves the score most, and as that lens improves, it counts for less, because another lens becomes the weakest.
Production Readiness 23.3 · counts for 46%Security and Compliance 33.9 · counts for 25%Code Health 54.5 · counts for 14%Maturity 55.0 · counts for 8%Architecture 67.7 · counts for 4%Performance 100.0 · counts for 2%

If Production Readiness rose from 23.3 to 70, the lowest score rated Strong, the score would rise from 36.4 to about 47.8.

Code composition: what the lines of code are
Business logic 43%Supporting code 53%Tests 2%Code analyzers 2%
Rebuild cost: about €150,000 · Estimate
Cost to rebuild€49,000 to €250,000, for 818 to 2,666 hours of work, about 1.0 person-years for 1 to 2 engineers
Difficulty of the problemStandard, judged from the kind of software and how it is built. Code that solves a harder problem, such as payments or medical bookings, costs more per line to write.
Quality factor×0.7 at a score of 36. Better code takes more work to write, so the factor is ×1.0 at a score of 70, lower below it and higher above it.
SizeMedium: 60,899 lines of product code
Comment linesThe estimate prices 55,190 lines. Comment lines count towards the size of 60,899 lines but aren't priced as work.
What it is notNot a quotation: nobody has offered to build it for that. Not a valuation: it says nothing about what the business is worth. Not a certified figure: no professional has signed it as one.

How the estimate is made: We price the hours a team would need to write this code again, at €60 to €95 an hour. Declarations and boilerplate are priced at a fast rate and logic at a slower one, and the logic is then multiplied by the difficulty of the problem and by the quality factor. The estimate can be about 30% off either way, and it moves most with the hourly rate and the difficulty.

Top priorities

The three actions that raise the score most for the work they take. The full ranked list is in the Roadmap.

1
Encrypt sensitive data at rest (ASP.NET Core Data Protection / column encryption) and manage keys in a vault.
Skip if delegated to infra (Postgres TDE, KMS, etc.).
Raises the score by about 6.4 points · Medium effort · Data Protection
2
Add a CI workflow that builds and runs the test suite on every push/PR.
Raises the score by about 6.0 points · Medium effort · CI/CD gates
3
Stamp a semantic version (csproj <Version> or GitVersion/MinVer) and follow semver for breaking changes.
Raises the score by about 6.0 points · Medium effort · Library API & versioning

Diagnosis: what the measurements show together

Each conclusion below combines several dimensions into one point that no single dimension shows, and lists the measurements it rests on.

Where the investment is most exposed · Value at risk
This code would cost about €150,000 to build again, about 1.0 person-years of work. Its weakest lens is Production Readiness, at 23.3 (Critical). Production Readiness is about whether the product is ready to run in production and to change without breaking. Because the weakest lens counts most in the score, work on Production Readiness also moves the score most.
Based on: the rebuild estimate · the Production Readiness grade · how much each lens counts
What to do: Start with the Production Readiness actions in Top priorities.
If you do one thing first · First action
Encrypt sensitive data at rest (ASP.NET Core Data Protection / column encryption) and manage keys in a vault. Of all the actions in this report, it raises the score most for the work it takes: about 6.4 points for medium effort. The next survey will show the change in the score.
Based on: the ranked actions in Top priorities, by score gain and effort
What hard-to-read code costs each year · Cost
Four dimensions measure how easy the code is to work in: two measure how tangled its logic is, one how much of it is copied, and one how well each part sticks to a single job. In this codebase they average 6.9 out of 10. Code at that level is slower to change than clean code, and we estimate the extra work at 3% to 6% on every change. The history of the code shows how much it changes: about 618 lines over the last 90 days, which is about 2,506 lines a year. At that pace, the extra work comes to an estimated 0.2 to 1.1 engineer-days a year, and it grows as more code changes.
How this is estimated: The number of changed lines is measured from the history of the code. The rest rests on two assumptions of our own: code scoring 8 out of 10 or more adds no extra work, and each point below 8 adds 2.5% to 5.6% to every change, never less than 2% to 5% and never more than 40% to 60% in all; and an engineer changes 150 to 400 lines in a day. The result is a range for planning, not a measurement.
Based on: Cyclomatic Complexity · Cognitive Complexity · Code Duplication · Cohesion (LCOM4) · the code's change history
What to do: Start with the files listed under Churn × Complexity Hotspots, which change often and are hard to read, because that is where the extra work is paid most often.

Architecture — bounded-context dependency graph

Each box is a bounded context (its layer projects grouped, or a project count when large); arrows show dependencies between contexts. A shared kernel is where many arrows converge.

arch FileServer FileServer App App ctx:Robot Robot Hotfix · Model App->ctx:Robot Server.App Server.App ctx:Server Server Hotfix · Model Server.App->ctx:Server Tools.App Tools.App ctx:ThirdParty ThirdParty ETTask · ShareLib · UnityEngine Tools.App->ctx:ThirdParty protobuf-net protobuf-net ctx:Robot->ctx:ThirdParty ctx:Server->ctx:ThirdParty ctx:Unity Unity Runtime · ShaderLibrary ctx:Unity->ctx:ThirdParty

Architecture: which parts of the code depend on which

The code is divided into modules, groups of code that each handle one part of the product, and a module depends on another when it uses code from it. The table lists the modules both down the side and across the top, in an order where each module should only use modules listed above it. A number in a cell means the module on that row uses the module in that column, and it counts the pairs of building blocks (types) that connect them. The one thing to look for is a mark above the diagonal line. It means two or more modules use each other in a loop (a dependency cycle), so none of them can be changed, tested or released on its own.

13 modules, with 9 dependencies between them. 2 loops run through 4 of the modules, marked above the diagonal.

Which modules use which. The module on each row uses the module in each column, and the number counts the pairs of types that connect them. A cell above the diagonal is part of a loop.
uses →1 ET.Analyzer2 ETFileServer3 UnityEditor.Rendering.Universal4 UnityEngine5 UnityEngine.Experimental.Rendering.LWRP6 UnityEngine.Experimental.Rendering.Universal.LibTessDotNet7 UnityEngine.Rendering.LWRP8 ET.EventType9 UnityEngine.Rendering.Universal.Internal10 ET11 UnityEngine.Rendering.Universal12 (global)13 UnityEngine.Experimental.Rendering.Universal
1 ET.Analyzer
2 ETFileServer
3 UnityEditor.Rendering.Universal
4 UnityEngine
5 UnityEngine.Experimental.Rendering.LWRP
6 UnityEngine.Experimental.Rendering.Universal.LibTessDotNet
7 UnityEngine.Rendering.LWRP
8 ET.EventType15
9 UnityEngine.Rendering.Universal.Internal83
10 ET443
11 UnityEngine.Rendering.Universal15
12 (global)1
13 UnityEngine.Experimental.Rendering.Universal3326
Uses a module listed above itPart of a loopThe module itself
1 ET.Analyzer2 ETFileServer3 UnityEditor.Rendering.Universal4 UnityEngine5 UnityEngine.Experimental.Rendering.LWRP6 UnityEngine.Experimental.Rendering.Universal.LibTessDotNet7 UnityEngine.Rendering.LWRP8 ET.EventType9 UnityEngine.Rendering.Universal.Internal10 ET11 UnityEngine.Rendering.Universal12 (global)13 UnityEngine.Experimental.Rendering.UniversalET.Analyzer1ETFileServer2UnityEditor.Rendering.Universal3UnityEngine4UnityEngine.Experimental.Rendering.LWRP5UnityEngine.Experimental.Rendering.Universal.LibTessDotNet6UnityEngine.Rendering.LWRP7ET.EventType8UnityEngine.Rendering.Universal.Internal9ET10UnityEngine.Rendering.Universal11(global)12UnityEngine.Experimental.Rendering.Universal1315834431513326

At a glance — Code Health · 54.5 · Adequate · gated by X5 ·

At a glance — Architecture · 67.7 · Adequate · gated by D26, AX2 ·

At a glance — Maturity · 55.0 · Adequate · gated by M2 ·

At a glance — Readiness · 23.3 · Critical · gated by P1, P3, P10 ·

At a glance — Security · 33.9 · Weak · gated by D28, C1 ·

At a glance — Performance · 100.0 · Exemplary ·

Security & Compliance — OWASP Top-10 mapping

Findings mapped to OWASP categories; the specific CVEs/secrets are in the Security dimension cards below and findings.md (redacted only on the public version of this report).

OWASP categoryFindingsSeverity
A07:2025 — Authentication Failures44High / Critical
A05:2025 — Injection6Medium

Roadmap

Top priorities: Encrypt sensitive data at rest (ASP.NET Core Data Protection / column encryption) and manage keys in a vault. Skip if delegated to infra (Postgres TDE, KMS, etc.); Add a CI workflow that builds and runs the test suite on every push/PR; Stamp a semantic version (csproj <Version> or GitVersion/MinVer) and follow semver for breaking changes.

Ranked by impact ÷ effort. "Helps" is the estimated gain on the 0–100 health score.

Do thisHelpsEffortDimension
Encrypt sensitive data at rest (ASP.NET Core Data Protection / column encryption) and manage keys in a vault. Skip if delegated to infra (Postgres TDE, KMS, etc.).+6.4 ptsMediumData Protection
Add a CI workflow that builds and runs the test suite on every push/PR.+6.0 ptsMediumCI/CD gates
Stamp a semantic version (csproj <Version> or GitVersion/MinVer) and follow semver for breaking changes.+6.0 ptsMediumLibrary API & versioning
Run what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.+6.0 ptsMediumSecurity & performance tooling
Resolve the 1 No ADRs found finding(s) in ADR Quality — start with Robot.App.csproj.+1.9 ptsLowADR Quality
Resolve the 28 REDACTED finding(s) in Secrets (history) — start with REDACTED (28).+3.5 ptsMediumSecrets (history)
Resolve the 11 End-of-life runtime finding(s) in Platform End-of-Life — start with Robot.App.csproj, Robot.Hotfix.csproj, Robot.Model.csproj.+2.2 ptsMediumPlatform End-of-Life
Resolve the 15 High secret finding(s) in Secrets (history) — start with REDACTED (13), REDACTED, REDACTED.+1.9 ptsMediumSecrets (history)

File quality

Per-file score 0–10 — a quality signature. Of 122 files carrying findings, judged against the Production bar: 0% slop · 65% mixed · 35% near-clean.

FileScoreBandWorst signal
REDACTED4.4MixedSecrets (history): High secret: REDACTED
REDACTED4.4MixedSecrets (history): REDACTED: REDACTED
REDACTED5.0MixedStatic Analysis (SAST): Medium: REDACTED
Tools/Analyzer/Analyzer.csproj5.3MixedExplicit Debt: NoWarnInCsproj
Unity/Unity.RenderPipelines.Universal.Runtime.csproj5.9MixedExplicit Debt: NoWarnInCsproj
Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs6.0MixedExplicit Debt: TodoComment
Tools/App/Apps/ExcelExporter/ExcelExporter.cs6.0MixedExplicit Debt: CommentedOutCode
Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs6.0MixedExplicit Debt: TodoComment
ThirdParty/UnityEngine/UnityEngine.csproj6.4MixedPlatform End-of-Life: End-of-life runtime: .NET net6.0
ThirdParty/ETTask/ETTask.csproj6.4MixedPlatform End-of-Life: End-of-life runtime: .NET net6.0
ThirdParty/ShareLib/ShareLib.csproj6.4MixedPlatform End-of-Life: End-of-life runtime: .NET net6.0
Unity/Unity.RenderPipeline.Universal.ShaderLibrary.csproj6.4MixedExplicit Debt: NoWarnInCsproj
Unity/Codes/Model/Module/Message/MessagePackHelper.cs6.4MixedExplicit Debt: CommentedOutCode
Unity/Codes/Model/Core/Object/EventSystem.cs6.6MixedCognitive Complexity: EventSystem.Add (cognitive 17)
Server/Hotfix/Module/Router/RouterServiceInnerComponentSystem.cs6.7MixedExplicit Debt: TodoComment
Server/Hotfix/Demo/Actor_TransferHandler.cs6.9MixedExplicit Debt: CommentedOutCode
REDACTED6.9MixedStatic Analysis (SAST): Medium: REDACTED
Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs7.0MixedCyclomatic Complexity: AOITriggerSystem.IsInTrigger (cyclomatic 72)
Server/Model/Generate/Message/InnerMessage.cs7.0MixedCode Duplication: Duplicated block (26 lines × 2)
ThirdParty/UnityEngine/Quaternion.cs7.0MixedCode Duplication: Near-duplicate member pair (27 shared lines)

How the grades work

Every finding carries one of four grades. Three say how serious it is. The fourth says this survey could not settle it — and it is a grade, not a gap.

Critical — 56

A definite problem that already costs you something and drags the score down: a missing authorisation check, a dependency with a known exploit, a build that does not reproduce. Failure here tends to cause failures elsewhere.

Serious — 523

Likely wrong, but not failing yet. It degrades the codebase over a longer horizon and can cause failures elsewhere — not urgent this week, not something to carry for two years either.

Minor — 109

Recorded, with no effect on how the codebase functions. Present so the survey is complete, not because it needs doing.

Could not be resolved — 7

Something this survey could not settle from the outside, and which could be critical or serious. Either a control was required and no positive evidence of it exists in the repository — a backup job that nothing shows was ever restored from proves nothing about restores — or our own analysis could not run over that part of the tree. This is not a clean result. These are excluded from the score rather than awarded a pass, so the number on the cover neither rewards nor penalises them: if you act on this survey without resolving them, you carry that risk yourself. Each one is named under Limitations.

Methodology & how to trust this report

This survey is a deep, periodic assessment — run each sprint, monthly, or quarterly, taking the time to go wider and deeper than a quick check and surfacing in one coherent report what you'd otherwise piece together from a dozen separate tools. It scores deterministically: the same commit yields the same score, every run. All 61 evaluated dimensions are computed by tools and static analysis; no language model sets or judges any of them. Overall confidence is 0.9, the weighted average across measured dimensions.

Every figure here is one of two kinds, and we label which: ✓ Measured — a deterministic fact (LoC, complexity, coverage); ~ Modeled — an estimate from a stated model (cost, effort, value-at-risk), always a range with its assumptions, never a precise fact. We never present a modelled estimate as if it were measured. Perfect or absent scores carry their provenance too (ADR-0011): ✓ Tool-verified means the property itself was measured across the surface; ○ Nothing flagged means the probes came back clean — a claim bounded by what a repository can show; ⊘ Not evidenced means a working control (a tested restore, an automated rollback) showed no positive evidence — absence of evidence is not evidence of a control, so it's excluded from the score rather than awarded a spurious 10.

What we checked — 61 dimensions across the health lenses
D1D2D3D4D5D6D10D13D14D15D17D18D19D20D23D24D26D27D28D29D30D34D35D43D44AX10AX2AX3AX4AX5AX6C1GD1IC1M1M2M3M4P1P10P3P6PF3S1X1X12X13X16X18X2X20X23X24X26X27X28X29X3X30X4X5

Each chip is a dimension scored from real signals across architecture, testing, dependencies, security & compliance, documentation, git-history and code quality — in one coherent pass. A surface report typically covers a handful.

How to trust any code-health report — three questions
  1. Can you open the finding? Real findings cite a repo-relative file and line you can open at the cited line — never an absolute scratch path. Here, 677 of 688 do; the remainder are repo-wide signals — a dimension-level measurement, not a single line. (Every path in this report is repo-relative by construction: paths are normalized at the producer and the report is rejected if any rooted path leaks through.)
  2. Is there a tool behind the number? Every score below names the method that produced it: Roslyn, git or a scanner, not a narrative.
  3. Does re-running give the same result? Run it again on the same commit and the score — and this report, byte for byte — is identical. A report whose numbers move between runs is describing the run, not the code.

This report answers yes to all three. That's the bar to hold any assessment to.

Tools & methods

The actual versions used this run (captured at analysis time) — re-run on the same commit for the identical score.

MethodBacksVersionEvaluator
Roslyn static analysisComplexity, cohesion, coupling, dead code, API surface, layering5.3.0✓ deterministic
Native secret scannerHardcoded secrets / credentials1.0.0✓ deterministic
Canine Code Analyzer duplication detector (in-process)Code duplication1.0.0✓ deterministic
Coverage (coverlet / dotnet-coverage)Line & branch coverage10.0.400✓ deterministic
NuGet / dotnetOutdated, vulnerable & deprecated dependencies10.0.400✓ deterministic
git / LibGit2SharpChurn hotspots, knowledge concentration, history2.43.0 · 0.31.0✓ deterministic
gitleaks · semgrep · trivySecrets in history, SAST, CVEs, IaC & container, PII / GDPR1.86.0 · 0.69.3✓ deterministic

Every finding is locatable in findings.md. Run 01a1eb0b-169a-70fb-8ace-7be0262446e7.

The exact command behind every deep-scan dimension — tool, version, invocation and retained raw output — is in Appendix B — Reproduction & audit trail.

Run transparency — what happened this run

What ran differently this time — a tool absent, degraded, or that fell back to an estimate. Named openly, not folded silently into the scores. A degraded run also records its exact cause in diagnostics.md.

  • D12 Dependency Hygiene — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `dotnet list package` did not return usable output (restore or query failed); no outdated/vulnerable/deprecated data to assess. The tool said: /usr/share/dotnet/sdk/10.0.400/NuGet.targets(521,5): error MSB3202: The project file "Unity/Unity.Model.csproj" was not found. [Client-Server.sln].
  • D14 License Compliance — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This repository declares a Unity UPM manifest (Packages/manifest.json or a package's package.json), but the licence verdict published here was taken over its NuGet package dependencies. Nothing was read about its Upm dependencies' licensing in either direction, and a clean score on this card must not be read as covering them.
  • D16 Bus Factor — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. Single-maintainer repository — bus factor is not applicable (58 contributor(s) across 1889 commit(s) sampled, automation and bot accounts excluded). One of them holds 87% of the history; the other 57 hold 0.2% each on average, below the 5% at which there is somebody to hand the work to. That is a single maintainer with drive-by contributors, not a team whose knowledge has concentrated — so the bus factor is not applicable and there is nothing here for the owner to act on.
  • D17 Explicit Debt — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The C# workspace loaded this repository's projects but reported a load failure, and the dead-code reference search is unreliable over a graph that did not load cleanly, so it was skipped. The other debt markers on this row were read; dead symbols were not, and their absence from the score is not a finding that the code has none. First load diagnostic: Failure: Project file not found: 'Unity/Unity.Model.csproj'.
  • D18 Solution Shape — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. The build did not finish within its budget on this run; structural metrics are reported, build/warning status is unknown.
  • D19 Documentation Quality — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. This kind did not reach the 95 % precision gate in three adjudicated runs (docs/plans/deterministic-engine/adjudication/D19-sample3-v3.md), so by the pre-registered fallback it publishes no row until a re-measurement shows it does. The candidates are counted here, not reported as findings, and the score does not include them.
  • D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D21 Naming Consistency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. PREREGISTRATION version 20's fallback (adjudication D21-sample3-v3): this rule kind was adjudicated below the 95 % precision gate, so its candidates are counted here and not published, and the score covers only the acronym-spelling and awaitable-suffix rules. The kind returns as rows only after it shows a measured precision; this says nothing about whether these names are consistent.
  • D22 Internal API Consistency — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The loaded project set declares no packable project and no `.Contracts` project, so there is no intentionally-exposed surface for API consistency to be judged over.
  • D24 Comment Value — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D24 compares a comment's words with the identifiers, literals and constructs of the code it annotates, using English function-word and rationale lexicons. Comments in another script or language were left unread rather than counted as clean.
  • D28 Secrets (history) — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. D28's config-credential rule (WD-SECRET-0002) parses each committed `.json` config as a document and reads credential-named values; `Tools/FileServer/hosting.json` did not parse (JSON5, a template, several concatenated documents), so a credential bound there is UNMEASURED by that rule. gitleaks still scanned the same files as text.
  • D30 Dependency Vulnerabilities — measured, with a gap in what it reached — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. The solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan. 2 of 3 declared ecosystem(s) (npm,osv) WERE scanned and every vulnerability they reported is included in this result; nuget was not, so this dimension's score covers less than the dependency surface this repository declares, and nothing here is evidence that nuget is free of known-vulnerable dependencies.
  • D32 Data Compliance (PII/GDPR) — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. `Unity/Assets/Editor/BuildEditor/BuildEditor.cs`, `Unity/Assets/Editor/BuildEditor/BuildHelper.cs`, `Unity/Assets/Editor/BuildEditor/ETBuildSettings.cs`, `Unity/Assets/ThirdParty/Mongo/MongoDB.Bson/TargetFramework.cs`, `Unity/Assets/ThirdParty/protobuf-net/GlobalSuppressions.cs`, … (+8 more) produced a parse error, so every rule in this engine's `gdpr.yml` was absent there. That absence is NOT a clean result: these rules detect personal data crossing a boundary into a log sink, a URL or browser storage, and a file that was never parsed cannot report any of the three. The rest of the tree analysed normally and its rows above stand; only these files are unaccounted for. You can widen what we reach: fix the syntax error (or exclude the file deliberately) and re-scan to cover it.
  • ED5 Idempotency — not measured this run — We could not measure this here. That is a gap on our side — a collector, parser or image we have not built yet — and it is neither a defect in this repository nor evidence that the check would have passed. Idempotency could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository. Engine failure: ArgumentException: Syntax node is not within syntax tree.
  • IC1 Incompleteness & stubs — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. 100 further occurrence(s) are not listed individually; the score already reflects all 140.
  • M4 Documentation accuracy — measured, with a gap in what it reached — We measured this, but not all of it. What we did not reach is a gap on our side — a collector, parser or image we have not built yet — so the numbers on that dimension cover less than the repository, and the part left out is not evidence that it would have passed. M4 checks only the claim kinds adjudicated at or above 95 % precision: links and versions (PREREGISTRATION version 9), and artefact counts an order of magnitude off. Paths, command arguments, installs, environment variables, settings, projects, packages, routes, cd targets, infrastructure products and removed modules are read but not checked, and none of them is reported or counted.
  • P5 DR & Backup — not measured this run — This is a true statement about the repository that carries nothing for its owner to act on, so it is reported here rather than as a defect in their code. No backup/snapshot/replication config, RTO/RPO or restore-procedure documentation was found — and no production persistence was detected either (no data-access packages, no data-store services, no database resources), so there is nothing in this repository whose loss a DR control would recover. If this system's data lives in a platform or ops repo we can't see, that's where the DR evidence belongs.

Repo exclusion declarations (.gitattributes linguist-generated/vendored, .editorconfig generated_code): none declared — every source file was scored.

Limitations & what we did not check

We assess the repository exactly as committed, and only the repository. By design we do not reach outside the source tree: the live cloud account, the running CI/CD pipeline, the host's branch-protection and approval rules, the production configuration, or a restore actually exercised against a backup are all out of scope. That boundary is a feature, not a gap — a repo-relative, deterministic scan re-runs identically on any commit and every finding opens at a real file and line, where a live audit can neither be reproduced nor traced. The visible consequence is that controls which leave no in-repo evidence are reported as "not evidenced" and excluded from the score rather than awarded a number a static scan cannot justify.

Per-dimension blind spots

For each dimension that was measured, what a static, repo-only scan structurally cannot see — the honest edge of the measurement, not a failure of it.

  • D1 Cyclomatic Complexity: Cyclomatic complexity counts branches statically — it cannot tell an essential decision tree from accidental tangle, nor see complexity that lives in data or configuration (large switch-case token tables, DSL lexers/parsers, data-as-code rule tables) rather than control flow: a tokenizer's many single-character cases read as high complexity though each branch is trivial.
  • D2 Cognitive Complexity: Cognitive-complexity heuristics approximate how hard code is to follow; genuine domain difficulty and well-named intent that eases reading are not captured.
  • D3 God Classes: "God class" is sized by members and responsibilities visible in the type — a deliberately broad facade over a coherent subsystem can read the same as an accidental grab-bag. For front-end JS the file-length check is cohesion-aware (a single-responsibility module — one class/IIFE — earns a 3× threshold), but cohesion is approximated from top-level declarations, not true dependency structure.
  • D4 Code Duplication: Duplication is token-similarity — an in-process token-stream comparison over sliding windows, with type-aware normalization — so it finds copy-paste, not semantic duplication expressed differently. Committed machine-written code (scaffolded migrations, designer/codegen output, protobuf/OpenAPI stubs, model snapshots) is EXCLUDED — its repetition is the tool's, not the team's — so the score reflects hand-written duplication only.
  • D5 Coupling: Coupling is measured between projects/assemblies — runtime coupling through DI, reflection, messaging or shared databases is invisible to a static reference graph.
  • D6 Cohesion (LCOM4): LCOM4 cohesion is syntactic — it infers connectivity from which methods touch which fields/methods by name, not from real runtime behaviour or intent.
  • D10 Test Quality: Assertion density is structural — it cannot tell a meaningful behavioural assertion from a trivial one, only that an assertion is present.
  • D13 REDACTED Scanning: REDACTED detection is signature- and entropy-based on the current tree — a secret that does not match a known pattern, or one already rotated, will not be flagged (a clean scan is "nothing matched", not "no secrets exist").
  • D14 License Compliance: License compatibility is checked against declared package metadata and a policy — mislabelled or missing license metadata, and obligations that depend on how you distribute, are not resolved here.
  • D15 Churn × Complexity Hotspots: Churn hotspots come from git history — a freshly imported or squashed repository has no churn signal, and recent rewrites can mask a historically risky file.
  • D17 Explicit Debt: Acknowledged-debt signals (TODO/FIXME, suppressions, dead code) are textual — undocumented debt that nobody marked, and debt that lives in design rather than annotations, is invisible. Committed machine-written code (scaffolded migrations, designer/codegen output, generated stubs) is excluded — it is never the team's dead code to delete.
  • D18 Solution Shape: Build integrity reflects whether the solution compiled in this environment — a build that needs a private feed, a specific SDK, or a generated file absent from the repo can read as broken when it is merely unreproducible here.
  • D19 Documentation Quality: Documentation quality publishes two things only: a runnable or packaged unit with no example, and a multi-project root README that maps none of its parts. It does not judge clarity, and its other checks (overview, licence, boilerplate, structure, empty sections, XML-doc coverage) are withheld after adjudication: their candidates are counted in the card's gaps, not shown as rows. A false statement in a document is M4's; units are .NET projects only.
  • D20 ADR Quality: ADR quality checks the structure of the decision records present: it cannot know about decisions made and never recorded, and it does not judge how well a record argues its case. Records in a language the section lexicon does not cover are not evaluated.
  • D23 Boundary Type-Coupling: Boundary leakage is detected from type references across detected contexts — leaks that flow through primitives, serialization or shared infrastructure may not surface as a typed reference.
  • D24 Comment Value: Comment value is measured as redundancy only: a comment that repeats its code's words is found, but a paraphrase in other words, a vague comment, or one the code contradicts is not, and whether a comment is valuable is not claimed. Comments in other scripts or languages, and outside C#, are not judged.
  • D26 Project Cohesion: Project focus is sized from members/namespaces per project — a project that is broad by deliberate design reads the same as one that has sprawled.
  • D27 Navigability: Indirection/navigability is structural — it measures hops to follow a call, not whether that indirection buys real flexibility or just ceremony.
  • D28 Secrets (history): Secret-history scanning sweeps the git log for known patterns — a secret that predates the available history, or never matched a signature, is not found (clean means "nothing matched in the history we can see").
  • D29 Static Analysis (SAST): SAST findings are pattern-based (semgrep) — it finds classes of bug it has rules for; logic flaws, auth/authorization gaps and issues needing runtime context are out of reach (and clean means "no rule matched").
  • D30 Dependency Vulnerabilities: CVE matching depends on accurate package/version metadata and on the advisory databases — a vulnerability with no published advisory, or in code not declared as a dependency, is not seen. Coverage needs a RESOLVED graph: an unpinned requirements.txt, or a pom without a resolved build, yields partial coverage rather than a clean verdict. An ecosystem the analyzer cannot scan is reported as unmeasured, never as clean.
  • D34 Knowledge Freshness: Freshness is decayed commit RECENCY, not comprehension — code read often but rarely committed reads as orphaned, and stable code that genuinely needs no changes is penalised the same as forgotten code; bot/squash commits distort it like the bus factor.
  • D35 Change Coupling: Change coupling is co-change in COMMITS — files split across separate commits, or coupled only through a shared config/build step, read as uncoupled, and a sweeping commit (rename/format) is excluded so it doesn't couple everything. It shows that files change together, not WHY: a high coupling can be a healthy cohesive pair as readily as a hidden leak.
  • D43 Malicious Dependencies: Only packages some vulnerability database has already NAMED as malicious are seen — a compromise published in the last hours, or never reported at all, is invisible here, and this dimension reading 10 is not evidence that a dependency is trustworthy. There is no typosquat or dependency-confusion analysis: a package nobody has reported is simply absent from the feeds. Coverage is the dependency scan's: an ecosystem that could not be scanned is disclosed as unmeasured, never as clean.
  • D44 Platform End-of-Life: The support table is FROZEN, so it goes out of date by losing RECALL: a release that ended support after the table was written is missed until the table is refreshed, and this dimension reading 10 is not evidence that a platform is current. Only platforms the repository DECLARES in a place this pass reads are seen — a runtime named only in a Dockerfile (D31's subject), in a CI workflow (D29's), or in a file this pass does not parse (go.mod, a Gemfile ruby directive) is invisible here, which is why a repository declaring none of them abstains rather than scoring. Only frameworks with a PUBLISHED support policy are tracked: React, Flask and Express publish none, so their age cannot be judged and their absence from a report is not a statement that they are supported.
  • AX10 Code composition: Role is inferred from namespace/folder convention, not semantics — a domain concept living in a folder named "Services" reads as application, and the split is lines-of-code, not business value. The business-logic-share score is a SOFT, FLOORED signal: it contributes to the Architecture lens but is floored at the Critical gate, so an infrastructure-heavy design (a gateway, an ETL, a driver) is legitimately low without being nuked to zero.
  • M4 Documentation accuracy: Documentation accuracy checks links, versions and artefact counts against the tree: other claims (paths, commands, settings, routes) are read but not checked, and it cannot run the onboarding or measure how long a real new joiner takes.
  • P6 Release Hygiene: Rollback/observability controls are inferred from repo artefacts (pipelines, dashboards-as-code) — controls configured in external tooling, with no in-repo trace, cannot be credited.

Dimensions

D1 · Cyclomatic Complexity6.5 / 10Adequate✓ Tool-verified

What it measures: How tangled the control flow is — methods with many branches are hard to test and change.

Method: Cyclomatic complexity per method (1 + decision points), computed exhaustively across production source; test projects separated by convention. Deterministic.

Maturity: Documented → Verified → Prevented · effective 6.5 / 10 · rule-coverage 100% · ceiling Prevented

23 method(s) exceeded the cyclomatic complexity threshold of 15; the worst was AOITriggerSystem.IsInTrigger at 72. A further 3 method(s) were over the threshold but excluded as flat dispatchers (a long switch/match over independent cases: many branches, almost no nesting), the largest being Matrix4x4.Equals at 16 — they are counted neither in the figure above nor in this dimension's score. 1 file carries no cyclomatic complexity row at all for this reason — every one of its over-threshold methods was excluded, so the exclusion is disclosed nowhere in the file itself: ThirdParty/UnityEngine/Matrix4x4.cs (Matrix4x4.Equals at 16). They are named here because the per-file figures other dimensions report are taken BEFORE this exclusion, so such a file can show a high maximum complexity elsewhere in this report and nothing here, with nothing to reconcile the two.

OBBComponentSystem.IsRayInTrigger (cyclomatic 65) · ×2Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:246
AOITriggerSystem.IsInTrigger (cyclomatic 72)Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1302
AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe (cyclomatic 62)Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:872
AOITriggerSystem.AfterColliderChangeBroadcastToOther (cyclomatic 60)Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1088
AOITriggerSystem.AfterTriggerChangeBroadcastToMe (cyclomatic 51)Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:661

+ 17 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 23 bodies over 15 down to 15 or less in Cyclomatic Complexity — start with AOITriggerSystem.IsInTrigger (cyclomatic 72), OBBComponentSystem.IsRayInTrigger (cyclomatic 65), OBBComponentSystem.IsRayInTrigger (cyclomatic 65). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 23 together lifts Cyclomatic Complexity from 6.5 to about 10.0/10, projected with the scoring formula itself and assuming each lands exactly at 15.

Detailed fixes: d1_recommendation.md · top locations in Appendix A, every location in findings.md.

D2 · Cognitive Complexity5.4 / 10Adequate✓ Tool-verified

What it measures: How hard the code is for a person to follow, beyond raw branching.

Method: Cognitive complexity per method (Sonar-style nesting-penalized score), computed exhaustively over production code, excluding test projects. Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.4 / 10 · rule-coverage 100% · ceiling Prevented

49 method(s) exceeded the cognitive complexity threshold of 15; the worst was AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe at 133.

OBBComponentSystem.IsRayInTrigger (cognitive 92) · ×2Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:246
AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe (cognitive 133)Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:872
AOITriggerSystem.AfterColliderChangeBroadcastToOther (cognitive 133)Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1088
AOITriggerSystem.AfterTriggerChangeBroadcastToMe (cognitive 117)Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:661
AOITriggerSystem.IsInTrigger (cognitive 94)Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1302

+ 43 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Bring the 8 bodies over 60 down to 60 or less in Cognitive Complexity — start with AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe (cognitive 133), AOITriggerSystem.AfterColliderChangeBroadcastToOther (cognitive 133), AOITriggerSystem.AfterTriggerChangeBroadcastToMe (cognitive 117). — This score is capped by its worst body, so a finding fixed alone moves it by almost nothing — the next one down takes its place. Refactoring these 8 together lifts Cognitive Complexity from 5.4 to about 6.4/10, projected with the scoring formula itself and assuming each lands exactly at 60; a cleaner split scores higher.

Detailed fixes: d2_recommendation.md · top locations in Appendix A, every location in findings.md.

D3 · God Classes9.8 / 10Stronggated by 6 serious findings✓ Tool-verified

What it measures: Over-large classes that try to do too much ("god classes").

Method: God-class detection by line and method-count thresholds per logical type (partial classes unified), filtered for generated code and registration/contract false positives. Deterministic.

Maturity: Documented → Verified → Prevented · effective 9.8 / 10 · rule-coverage 100% · ceiling Prevented

6 god class(es) detected.

MethodTooLong: AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe · ×3Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:872
FileTooLong: Trigger/AOITriggerSystem.csUnity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs
ClassTooLong: ExcelExporterTools/App/Apps/ExcelExporter/ExcelExporter.cs
TooManyMethods: EntityUnity/Codes/Model/Core/Object/Entity.cs

What to do

  1. Resolve the 3 MethodTooLong finding(s) in God Classes — start with AOITriggerSystem.cs (3). — One of this dimension's main actionable groups (3 warning-level).
  2. Resolve the 1 FileTooLong finding(s) in God Classes — start with AOITriggerSystem.cs. — One of this dimension's main actionable groups (1 warning-level).
  3. Resolve the 1 ClassTooLong finding(s) in God Classes — start with ExcelExporter.cs. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d3_recommendation.md · top locations in Appendix A, every location in findings.md.

D4 · Code Duplication5.5 / 10Adequate✓ Tool-verified

What it measures: How much of the production code is copy-pasted: the share of production lines inside a reported copy (every copy of a duplicated block or of an edited member, each line once), 10 at none and 0 at a quarter of the lines.

Method: Code duplication via token-stream sliding windows with type-aware normalization (locals masked, type names preserved), scored on the share of production lines inside a reported copy (each line once; 10 at none, 0 at a quarter). Deterministic.

Maturity: Documented → Verified → Prevented · effective 5.5 / 10 · rule-coverage 100% · ceiling Verified

146 duplicated block group(s) detected. 11.2 % of the production lines (6,628 of 59,071) are in a reported copy. A further 182 rows report members as variants of one another; the share counts each copied line once, however many rows cite it. 145 of the 328 are in trees this repository does not ship — vendored, example/demo, project-template, fixture and benchmark code — and are ranked below the shipped groups rather than excluded from them: the duplication there is real and is still counted in this dimension's score. The dimensions that publish a production-file census leave those trees out of theirs, so this count is deliberately drawn over the wider population.

Edited copy of a member (7 corresponding lines) · ×14Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:99
Edited copy of a member (10 corresponding lines) · ×12Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:14
Duplicated block (8 lines × 2) · ×10Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:931
Duplicated block (6 lines × 2) · ×9Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:338
Duplicated block (7 lines × 2) · ×9Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:572

+ 125 more group(s) — more in Appendix A; the complete list is findings.md.

What to do

  1. Resolve the 14 Edited copy of a member (7 corresponding lines) finding(s) in Code Duplication — start with Vector3.cs (7), Matrix4x4.cs (2), Vector2.cs (2). — One of this dimension's main actionable groups (14 warning-level).
  2. Resolve the 12 Edited copy of a member (10 corresponding lines) finding(s) in Code Duplication — start with NetInnerComponentSystem.cs (3), NetKcpComponentSystem.cs (2), Vector2.cs (2). — One of this dimension's main actionable groups (12 warning-level).
  3. Resolve the 10 Duplicated block (8 lines × 2) finding(s) in Code Duplication — start with AOITriggerSystem.cs (2), AOIUnitComponentSystem.cs (2), Quaternion.cs (2). — One of this dimension's main actionable groups (10 warning-level).

Detailed fixes: d4_recommendation.md · top locations in Appendix A, every location in findings.md.

D5 · Coupling8.4 / 10Strong✓ Tool-verified

What it measures: Whether volatile projects sit underneath others that depend on them (so their churn ripples upward), and whether project dependencies form cycles. A widely-depended-on but stable shared/kernel project is healthy, not penalised.

Method: Dependency cycles via elementary-DFS over real .csproj references, plus Martin instability (afferent/efferent) per project. Exhaustive over the reference graph, deterministic.

Coverage: Exhaustive · type-level: afferent/efferent coupling + cycles computed over every production type — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 8.4 / 10 · rule-coverage 100% · ceiling Prevented

15 projects, 0 dependency cycle(s), 0 unstable depended-on project(s).

Off the main sequence: UnityEngine · ×3ThirdParty/UnityEngine/UnityEngine.csproj:1

What to do

  1. Resolve the 3 Off the main sequence finding(s) in Coupling — start with UnityEngine.csproj, ETTask.csproj, ShareLib.csproj. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d5_recommendation.md · top locations in Appendix A, every location in findings.md.

D6 · Cohesion (LCOM4)10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether a class's methods are focused on a single responsibility.

Method: LCOM4 cohesion per production class with at least two methods: connected components of methods sharing state or calls, computed syntactically. Deterministic, not a proxy.

Coverage: Exhaustive · type-level: LCOM4 cohesion computed over every production class — the population is all types, not a name convention.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 35 classes have LCOM4 above 3.

✓ On the Gold path — maintain.

Detailed fixes: d6_recommendation.md.

D10 · Test Quality10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether the tests truly assert behaviour rather than just running the code.

Method: Per-test assertions, skips, and mock references analyzed via Roslyn; structured skip-reason tags (BUG:/ENV:) separate documented deferrals from debt. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

0 skipped, 0 zero-assertion, no mocking-framework packages referenced (hand-written doubles or no mocking) across 23 tests.

✓ On the Gold path — maintain.

Detailed fixes: d10_recommendation.md.

D13 · REDACTED Scanning10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any secrets (keys, tokens, passwords) have leaked into the code.

Method: In-process native secret scanner (entropy plus signature patterns) across all tracked files; no external tool. A clean result is a measured 10, not no-data zero. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Prevented

REDACTED scan ran and found no leaked secrets.

✓ On the Gold path — maintain.

Detailed fixes: d13_recommendation.md.

D14 · License Compliance10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether the licenses of third-party packages are compatible with your policy.

Method: Third-party package licenses resolved from declared package metadata and checked against the configured policy (allow/deny/copyleft). Deterministic; clean = no incompatible license found at metadata depth.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

0 of 212 packages use a banned license. ★ DEPTH: this repository's MSBuild projects declare 16 direct `PackageReference`(s), and 196 further package(s) were reached beyond them by closing the graph over nuget.org's own nuspec dependency graph — so a banned licence pulled in only by a dependency's OWN dependencies is inside this verdict. A package whose licence nuget.org could not be asked for is not graded, and version ranges are taken at their lower bound, so this is the closure as that graph states it rather than a restored consumer's exact resolution. ★ COVERAGE OF THIS VERDICT: it grades this repository's NuGet package dependencies and nothing else. The repository also declares a Unity UPM manifest (Packages/manifest.json or a package's package.json), and the licences of those dependencies were NOT read by this pass — a gap in this engine's coverage, not a statement about them. So this result says the graded closure carries no banned licence; it does NOT say this repository's licensing is clear.

✓ On the Gold path — maintain.

Detailed fixes: d14_recommendation.md.

D15 · Churn × Complexity Hotspots10.0 / 10Exemplary✓ Tool-verified

What it measures: Files that change often and are also complex — the riskiest hotspots.

Method: Per production file churn times cyclomatic complexity over a rolling window, computed from git and Roslyn/JS/Razor analysis. Exhaustive, deterministic per commit date.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No churn × complexity hotspots in the window.

✓ On the Gold path — maintain.

Detailed fixes: d15_recommendation.md.

D17 · Explicit Debt9.6 / 10Adequategated by 10 critical findings✓ Tool-verified

What it measures: Acknowledged debt left in the code — TODOs, dead code, suppressed warnings.

Method: Roslyn syntactic debt markers (suppressions/TODO/FIXME/HACK/empty-catch/commented-code/Obsolete) plus SymbolFinder dead-code analysis; weighted-debt-per-KLoC density deducted 2.0x per unit. Deterministic, exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.6 / 10 · rule-coverage 100% · ceiling Prevented

26 deducted debt markers + unmeasured dead symbols across 59071 LoC in the .NET projects (0.2/KLoC) → score 9.6. Dead code not measured: the solution did not load cleanly, so the reference search was skipped.

NoWarnInCsproj · ×10Unity/Unity.RenderPipeline.Universal.ShaderLibrary.csproj:32
CommentedOutCode · ×13Server/Hotfix/Demo/Actor_TransferHandler.cs:18
TodoComment · ×3Server/Hotfix/Module/Router/RouterServiceInnerComponentSystem.cs:130

What to do

  1. Resolve the 10 NoWarnInCsproj finding(s) in Explicit Debt — start with Analyzer.csproj (6), Unity.RenderPipeline.Universal.ShaderLibrary.csproj (2), Unity.RenderPipelines.Universal.Runtime.csproj (2). — One of this dimension's main actionable groups (10 issue-level).
  2. Resolve the 13 CommentedOutCode finding(s) in Explicit Debt — start with MessagePackHelper.cs (8), Actor_TransferHandler.cs (3), C2M_ReloadHandler.cs. — One of this dimension's main actionable groups (13 warning-level).
  3. Resolve the 3 TodoComment finding(s) in Explicit Debt — start with RouterServiceInnerComponentSystem.cs, AOIUnitComponentSystem.cs, Physics.cs. — One of this dimension's main actionable groups (3 warning-level).

Detailed fixes: d17_recommendation.md · top locations in Appendix A, every location in findings.md.

D18 · Solution Shape10.0 / 10Stronggated by 1 serious finding✓ Tool-verified

What it measures: Whether the solution is laid out in a sensible, conventional structure.

Method: Solution structure: project count, decomposition, shell-project detection, build success (confirmed failures cap the score); traced to actual .sln files and binaries. Deterministic.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

14 projects, 999 source files, 59071 hand-written lines of code (59071 production / 0 test — the split is derived per file: test is what its project, its own path, or a compile-guarded region marks as test, and a file carrying no test signal counts as production), 14 inter-project edges (build status unknown — did not finish).

Solution references 13 projects that do not existClient-Server.sln

What to do

  1. Resolve the 1 Solution references 13 projects that do not exist finding(s) in Solution Shape — start with Client-Server.sln. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d18_recommendation.md · top locations in Appendix A, every location in findings.md.

D19 · Documentation Quality6.7 / 10Adequate✓ Tool-verified

What it measures: Whether the project's documentation is clear, complete, and useful.

Method: Every README, docs/ document and root guide parsed by its markup and measured in Unicode letters. Published: a runnable or packaged .NET project whose README (or a document it links, or a root guide) shows no example, and a root README naming none of three or more projects. Overview, licence, boilerplate, wall-of-text, empty-section and XML-doc rows are measured and withheld (counted in gaps) after adjudication. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 6.7 / 10 · rule-coverage 100% · ceiling Documented

1 of 2 documentation facets pass in full; short on: F2 example. 11 document(s) read across 21 unit(s).

Documentation: no build, run or usage example · ×2Unity/Packages/com.code-philosophy.hybridclr/README.md:1

What to do

  1. Resolve the 2 Documentation finding(s) in Documentation Quality — start with README.md (2). — One of this dimension's main actionable groups (2 recommendation-level).

Detailed fixes: d19_recommendation.md · top locations in Appendix A, every location in findings.md.

D20 · ADR Quality0.0 / 10Critical✓ Tool-verified

What it measures: Whether architecture decisions are recorded well (context, decision, consequences).

Method: Every ADR read by its section structure: nine located rules (a missing Decision, Context or Consequences section, a stale status, two records deciding the same question, a dangling supersede link, a number-only title, a single option, no named cost, no status where the log uses one, no enforcement field where the log adopted one), each a fixed deduction from 10; the score is the mean over evaluated records. Deterministic, no model. Advisory.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

No architecture decision records were found.

No ADRs foundRobot/App/Robot.App.csproj:4

What to do

  1. Resolve the 1 No ADRs found finding(s) in ADR Quality — start with Robot.App.csproj. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d20_recommendation.md · top locations in Appendix A, every location in findings.md.

D23 · Boundary Type-Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether domain types (IDs, enums, value objects) leak across bounded-context boundaries.

Method: Cross-context domain-type leakage via Roslyn structural classification (strongly-typed IDs / value objects) over every public surface. Exhaustive, deterministic, type-level aggregate-boundary check.

Coverage: Bounded contexts derived from NAMESPACE prefix (or graph-inferred where available); cross-boundary domain-type leakage then checked exhaustively over every public member of every type.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Verified

No domain types leak across context boundaries (5 contexts). Contexts: Robot, Server, ThirdParty, Tools, Unity.

✓ On the Gold path — maintain.

Detailed fixes: d23_recommendation.md.

D24 · Comment Value9.0 5.8 / 10Adequate✓ Tool-verified

What it measures: Whether comments are worth it — explaining WHY (valuable) rather than WHAT (redundant).

Method: Every inline C# comment compared word by word with the identifiers, literals and constructs of the code it annotates (taken from the syntax); a comment whose words that code already contains is redundant, as are closing-brace labels and generator template text. Comments giving a reason or a reference are kept; other scripts and languages are not judged. Deterministic, exhaustive, advisory.

Maturity: Documented → Verified → Prevented · effective 5.8 / 10 · rule-coverage 64% · ceiling Documented

8 of 813 judged comments only repeat the code they sit on (1.0 %). 571 comment(s) in another language or script were not judged.

redundant comment · ×8Unity/Codes/Model/Core/Object/EventSystem.cs:266
doc comments repeat the names · ×4Server/Hotfix/Module/AOI/Ghost/GhostComponentSystem.cs:43

What to do

  1. Resolve the 8 redundant comment finding(s) in Comment Value — start with EventSystem.cs (2), ScriptableRenderer.cs (2), DeferredLights.cs. — One of this dimension's main actionable groups (8 recommendation-level).

Detailed fixes: d24_recommendation.md · top locations in Appendix A, every location in findings.md.

D26 · Project Cohesion2.5 / 10Critical✓ Tool-verified

What it measures: Whether each project is a focused, coherent unit rather than an oversized grab-bag.

Method: Project size overshoot penalties (LoC / public-type count / namespace count, 2-of-3 flag) weighted by log magnitude. Exhaustive across projects, deterministic.

Maturity: Documented → Verified → Prevented · effective 2.5 / 10 · rule-coverage 100% · ceiling Documented

6 of 15 projects flagged as possibly oversized/incoherent.

Projects may be oversized for their cohesion · ×6Robot/Model/Robot.Model.csproj:1

What to do

  1. Resolve the 6 Projects may be oversized for their cohesion finding(s) in Project Cohesion — start with Robot.Model.csproj, Server.Model.csproj, Unity.RenderPipelines.Universal.Runtime.csproj. — One of this dimension's main actionable groups (6 recommendation-level).

Detailed fixes: d26_recommendation.md · top locations in Appendix A, every location in findings.md.

D27 · Navigability9.2 / 10Exemplary✓ Tool-verified

What it measures: How far you must trace to follow a call — low indirection and co-located slices read easier.

Method: Call indirection (interface hops, cross-namespace calls, slice-locality scaled) over a sampled set of method invocations, size-aware baseline. Sampled; confidence discounted by symbol-resolution gaps. C# also names each pass-through layer (a class whose every public method only forwards its own parameters to one collaborator) as a located finding; the score is not affected.

Coverage: Slice locality from the first namespace segments, SAMPLED (≤400 methods) — not exhaustive.

Maturity: Documented → Verified → Prevented · effective 9.2 / 10 · rule-coverage 100% · ceiling Documented

52 % of calls cross a namespace and 3 % go through an interface, but 95 % of collaborators are co-located — so a call's collaborators sit together and tracing stays easy. Baseline: large — vertical-slice locality expected.

Pass-through layerUnity/Assets/Mono/Core/Log/NLogger.cs:6

✓ On the Gold path — maintain.

Detailed fixes: d27_recommendation.md · top locations in Appendix A, every location in findings.md.

D28 · Secrets (history)0.0 / 10Critical✓ Tool-verified

What it measures: Whether any secrets were ever committed — scanned across the full git history, not just now.

Method: REDACTED scan via TWO gitleaks detect passes in an isolated checkout — the full git history, then a second --no-git pass over the working tree as it stands — merged and de-duplicated by (rule, file, line); each match flagged High. Both invocations are recorded in the audit trail. Exhaustive; when the tool is absent, or when its output cannot be parsed into the expected shape, the dimension is WITHHELD as an explicit measurement gap on our side — unscored and excluded from the lens, never a hedged middling score.

Maturity: Documented → Verified → Prevented · effective 0.0 / 10 · rule-coverage 100% · ceiling Documented

43 finding(s): 0 critical, 43 high, 0 medium, 0 low. Remediation for historically-committed secrets is credential rotation — they remain in history regardless of later deletion.

REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 28 REDACTED finding(s) in Secrets (history) — start with REDACTED (28). — One of this dimension's main actionable groups (28 issue-level).
  2. Resolve the 15 High secret finding(s) in Secrets (history) — start with REDACTED (13), REDACTED, REDACTED. — One of this dimension's main actionable groups (15 issue-level).
  3. Resolve the 1 Rotate the exposed credentials finding(s) in Secrets (history). — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d28_recommendation.md · top locations in Appendix A, every location in findings.md.

D29 · Static Analysis (SAST)7.3 / 10Strong✓ Tool-verified

What it measures: Real static-analysis (SAST) findings — likely security bugs in the code, any language.

Method: Polyglot static analysis via semgrep across the repo using the pinned, image-baked p/security-audit + p/owasp-top-ten rulesets (no scan-time registry fetch); severity rules (ERROR/WARNING/INFO) map to a full-band severity-weighted score. Exhaustive, deterministic; degrades on parse failure.

Coverage: semgrep pattern rules over all files — exhaustive for the rule set, blind to classes of bug without a rule (clean = no rule matched).

Maturity: Documented → Verified → Prevented · effective 7.3 / 10 · rule-coverage 100% · ceiling Documented

6 finding(s): 0 critical, 0 high, 6 medium, 0 low. semgrep hit a parse error in 15 file(s) — `Libs/Kcp/ikcp.h`, `Libs/RecastDll/make_ios.sh` (line 8, line 10), `Unity/Assets/Editor/BuildEditor/BuildEditor.cs` (lines 44–46, line 47, line 186), `Unity/Assets/Editor/BuildEditor/BuildHelper.cs` (line 84), `Unity/Assets/Editor/BuildEditor/ETBuildSettings.cs` (lines 9–10), … (+10 more) — so no absence of findings in the named regions is evidence of anything; rows reported elsewhere in those files are real. Fix the syntax error (or exclude the file deliberately) and re-scan to cover them. In 1 of those file(s) — `Unity/Assets/ThirdParty/protobuf-net/Serializers/TypeSerializer.cs` — the break is at a TYPE DECLARATION (a C# primary constructor semgrep's grammar cannot parse), so the loss is wider than the named lines: rules scoped to that type see no type to scope to and are blind over its whole body, while rules matching statements keep working there. Absence of a type-scoped finding in those types is not evidence of anything.

REDACTED
REDACTED
REDACTED

What to do

  1. Resolve the 3 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED (2), REDACTED. — One of this dimension's main actionable groups (3 warning-level).
  2. Resolve the 2 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED, REDACTED. — One of this dimension's main actionable groups (2 warning-level).
  3. Resolve the 1 REDACTED finding(s) in Static Analysis (SAST) — start with REDACTED. — One of this dimension's main actionable groups (1 warning-level).

Detailed fixes: d29_recommendation.md · top locations in Appendix A, every location in findings.md.

D30 · Dependency Vulnerabilities10.0 / 10Exemplary○ Nothing flagged

What it measures: Whether any dependency has a known published vulnerability (CVE), direct or transitive, in ANY ecosystem the repository declares — Dart pub, Elixir and Erlang via Hex, Go modules, Java and Kotlin via Maven/Gradle, JavaScript/npm, .NET/NuGet, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift.

Method: Dependency-CVE scan across every ecosystem the repository declares, scored ONCE. Three sources are unioned and deduplicated by advisory identity (rule id + alias closure, CVE<->GHSA) scoped to package+version, keeping the worst severity: `osv-scanner --recursive` over osv.dev for Dart pub, Elixir/Hex (and Erlang, whose `rebar.lock` syft first converts to a CycloneDX SBOM the scanner reads, with rows attributed back to the lock), Go, Java and Kotlin via Maven/Gradle (and Scala, whose sbt build's pinned direct declarations are written into a CycloneDX SBOM the scanner reads, with rows attributed back to the build file), npm, PHP/Composer, Python/PyPI, RubyGems, Rust/Cargo and Swift; `trivy fs --scanners vuln` for npm lockfiles; and `dotnet list package --vulnerable --include-transitive` for NuGet (with per-advisory collapse of the project x target-framework fan-out), plus a DECLARED-dependency arm that resolves a published gem's gemspec against rubygems.org where no Gemfile.lock is committed. `SeverityScore(c,h,m,l, normalizer 8.0)`. NotApplicable only when NO ecosystem is readable; if any applicable ecosystem could not be scanned the findings are REPORTED and the score is withheld. Supersedes the npm and OSV arms, retired 2026-09-05. Advisory since rubric-2026.11.2 (CAI decision 0006): every row is a match against a vulnerability database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No known-vulnerable dependencies in the 2 ecosystem(s) that were scanned (npm,osv). Partial dependency scan: 2 of 3 declared ecosystem(s) were scanned (npm,osv), and the findings above are real and complete for them. nuget was not scanned (nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan), so this is not the whole dependency surface and the result is reported at reduced confidence.

✓ On the Gold path — maintain.

Detailed fixes: d30_recommendation.md.

D34 · Knowledge Freshness7.4 / 10Adequategated by 1 critical finding✓ Tool-verified

What it measures: Whether anyone still has living knowledge of each file, or it has been orphaned — last understood long ago by someone now gone quiet. The sibling of the bus factor: D16 asks who owns it, D34 asks whether anyone still knows it.

Method: File orphaning as total living-knowledge decay below one focused-commit's worth within a year, computed per-file from the D16 decay model. Exhaustive, deterministic over fixed history.

Maturity: Documented → Verified → Prevented · effective 7.4 / 10 · rule-coverage 100% · ceiling Documented

31 of 117 significant source file(s) are orphaned — their living knowledge has decayed to nothing, so no one currently understands them. The largest is Tools/App/Apps/ExcelExporter/ExcelExporter.cs. Counted over 117 of the 254 production source files in this repository: the rest are under the ~2,400-byte size floor this dimension measures over.

Orphaned knowledgeTools/App/Apps/ExcelExporter/ExcelExporter.cs:1
Orphaned file · ×30REDACTED:1
Further orphaned files (smaller)

What to do

  1. Resolve the 30 Orphaned file finding(s) in Knowledge Freshness — start with StartSceneConfig.cs (2), REDACTED, OuterMessage.cs. — One of this dimension's main actionable groups (30 recommendation-level).
  2. Resolve the 1 Orphaned knowledge finding(s) in Knowledge Freshness — start with ExcelExporter.cs. — One of this dimension's main actionable groups (1 issue-level).
  3. Resolve the 1 Further orphaned files (smaller) finding(s) in Knowledge Freshness. — One of this dimension's main actionable groups (1 recommendation-level).

Detailed fixes: d34_recommendation.md · top locations in Appendix A, every location in findings.md.

D35 · Change Coupling10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether files that change together actually belong together — pairs that repeatedly co-change in git history despite having no explicit code dependency, surfacing the hidden/logical coupling (and boundaries in the wrong place) a static scan can't see.

Method: Pairwise co-occurrence over the per-commit file sets in git history (production source only — tests and generated dropped): Degree-of-Coupling = shared ÷ min individual revisions, reported above noise floors (each file ≥10 revisions, ≥5 shared commits, ≥50% strength); sweeping commits excluded. Deterministic over fixed history.

Coverage: Population: PRODUCTION source files only — test and generated files are dropped before pairing, so a class co-changing with its own test (trivially ~100%) can't drown the real production↔production coupling. Pairs ranked by Degree-of-Coupling. A non-source file is never a coupling PARTICIPANT either: documentation, schemas, config and data files are dropped with the rest, so a code↔docs pair — a command and the reference page that restates it — is not reported however strongly the two co-change; nor is coupling that runs THROUGH a build step or config file.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No strong hidden change-coupling between production files.

✓ On the Gold path — maintain.

Detailed fixes: d35_recommendation.md.

D43 · Malicious Dependencies10.0 / 10Exemplary✓ Tool-verified

What it measures: Whether any dependency the repository declares is published as MALICIOUS rather than merely vulnerable — a package that is an attacker's work, in any ecosystem osv-scanner reads. Reported apart from D30 because the answer is binary: there is no safe version to upgrade to, and the fix is to remove the package and rotate every credential it could have read.

Method: The same dependency scan D30 reads, partitioned on the scanner's own classification rather than rescanned: a row is MALICIOUS when its id is in the `MAL-` space (the ossf/malicious-packages feed) OR its `database_specific.cwe_ids` carries `CWE-506` ("Embedded Malicious Code"). Both channels are structural; the summary text is deliberately NOT read, because a malicious-package record whose summary says only "Critical severity vulnerability" is a real shape ([GHSA redacted]) and a text matcher misses it. Scored BINARY: any surviving row is 0, whatever its severity and however many CVEs sit beside it — a hostile dependency is not a quantity. Applicability and degradation are D30's: NotApplicable only when no ecosystem is readable, and an unscannable ecosystem degrades rather than reading clean. Advisory since rubric-2026.11.2 (CAI decision 0006): the malicious-package feed is a database that changes daily, so the reading is shown and never moves a scored dimension, lens or the headline.

Maturity: Documented → Verified → Prevented · effective 10.0 / 10 · rule-coverage 100% · ceiling Documented

No dependency in any ecosystem this repository declares is published as malicious.

✓ On the Gold path — maintain.

Detailed fixes: d43_recommendation.md.

D44 · Platform End-of-Life6.0 / 10Adequate✓ Tool-verified

What it measures: Whether anyone still ships security patches for the platform this repository RUNS ON — the runtime it pins and the framework majors its own constraints hold it to. Separate from D12 because the question differs: a current Django on an end-of-life Python is perfectly up to date and completely unsupported, and the fix is a migration rather than a version bump. What the repository says it merely SUPPORTS is never charged.

Method: End-of-life PLATFORM read from the repository's own declarations and graded against a FROZEN, dated table of vendor support dates — no network, no feed, no API, so this dimension answers identically inside a closed scan fence. Two subjects: a RUNTIME the project pins (a single or all-end-of-life TargetFramework, a .nvmrc or .python-version, a requires-python CAP) and a FRAMEWORK major a dependency constraint cannot move off (a caret, tilde or exact version; `vue@^2.7.16` pins Vue 2). A FLOOR is deliberately never charged — `requires-python = ">=3.8"` states what a package SUPPORTS, not what it runs on — and a multi-target project is charged only when EVERY target is out of support. Runtime 4.0/product capped 8.0, framework 1.5 capped 4.5. The table is safe to freeze because a statement about support that ended in the past cannot become false: it loses recall as it ages, never precision, and a test asserts every entry predates the freeze date. Disjoint from D31 (a container image's OS layer) and D29 (the toolchain a CI workflow installs). Abstains when the repository declares no platform this pass reads — never scores it clean.

Maturity: Documented → Verified → Prevented · effective 6.0 / 10 · rule-coverage 100% · ceiling Documented

1 end-of-life runtime(s) and 0 end-of-life framework(s), read from 15 platform declaration(s) and 0 dependency declaration(s). This dimension reads what the repository says about ITSELF — a pinned target framework, a version file, a capped requires-python, a Rust toolchain pin, a framework major a constraint cannot move off. A FLOOR is deliberately never charged: `requires-python = ">=3.8"` states what the package SUPPORTS, not what it runs on, and a well-maintained library declares exactly that while running its own CI on a current release. The end-of-life facts are FROZEN and dated, so this dimension needs no network and answers identically inside a closed scan fence; as the table ages it loses recall and never precision, because a statement about support that ended in the past cannot become false. The OS layer of a container image is D31's question and the toolchain a CI workflow installs is D29's; this row is neither.

End-of-life runtime: .NET net6.0 · ×11Robot/App/Robot.App.csproj:5

What to do

  1. Resolve the 11 End-of-life runtime finding(s) in Platform End-of-Life — start with Robot.App.csproj, Robot.Hotfix.csproj, Robot.Model.csproj. — One of this dimension's main actionable groups (11 warning-level).

Detailed fixes: d44_recommendation.md · top locations in Appendix A, every location in findings.md.

Frontend & cross-cutting dimensions

R = React/JS · M = Maturity · P = Readiness.

AX10 · Code composition9.3 / 10Exemplary✓ Tool-verified

Other · Architecture — How the codebase splits by code ROLE — domain, application, infrastructure, test, generated. The significance map behind the knowledge/coupling weighting, and a DDD signal in its own right: a thin domain core under fat infrastructure is the anemic-domain smell, quantified. How each file's role is decided, because the split is only as good as that: a generated name or a build-output tree makes it Generated, a test project makes it Test, and otherwise the file's NAMESPACE and PATH words are matched against fixed vocabularies in a fixed ORDER — domain, then infrastructure, then application — so a file whose words hit two layers is counted under the earlier one. A production file matching none of them counts as application, so that share reads 'application or unclassified' rather than a measured application layer. Roles come from naming convention, never from what the code does.

Method: Roslyn line-count by code ROLE: every source file classified Domain/Application/Infrastructure/Test/Generated by namespace + path convention (the shared CodeRoleClassifier), then significant lines summed per role. Deterministic; the advisory score is the business-logic (domain+application) share of production code.

Coverage: Population: ALL source files, each bucketed into ONE of five roles (Domain/Application/Infrastructure/Test/Generated) by namespace + path convention — a file whose layer isn't named in the convention falls to Application (the neutral default), and the split is line-count, not semantic depth or business value.

AX2 · Stateful singletons1.0 / 10Critical✓ Tool-verified

Other · Architecture — Whether singleton services avoid mutable shared instance state that concurrent callers would race on.

Method: Roslyn scan: singleton field mutations unguarded by lock or Interlocked, per type; syntax-based guard detection. Deterministic, traceable per field.

  • `FormulaStringFx` keeps one instance of itself in the static `Instances`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (formulaNodeList; e.g. `formulaNodeList` at line 140). — Unity/Codes/Model/Module/Battle/Combat/FormulaStringFx.cs:8
  • `EventSystem` keeps one instance of itself in the static `instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (allTypes, typeSystems, allEvents, assemblies, allEntities, loaders; e.g. `allTypes` at line 96). — Unity/Codes/Model/Core/Object/EventSystem.cs:51
  • `IdGenerater` keeps one instance of itself in the static `Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (epoch2020, epochThisYear, value, lastInstanceIdTime, instanceIdValue, lastIdTime; e.g. `epoch2020` at line 190). — Unity/Codes/Model/Core/Object/IdGenerater.cs:142
  • `ObjectPool` keeps one instance of itself in the static `Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (pool; e.g. `pool` at line 54). — Unity/Codes/Model/Core/Object/ObjectPool.cs:6
  • `MonoPool` keeps one instance of itself in the static `Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (pool; e.g. `pool` at line 38). — Unity/Assets/Mono/Core/MonoPool.cs:6
  • `TimeInfo` keeps one instance of itself in the static `Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (timeZone, dt, FrameTime; e.g. `timeZone` at line 19). — Unity/Assets/Mono/Core/TimeInfo.cs:5
  • `DeferredShaderData` keeps one instance of itself in the static `m_Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (m_PreTiles, m_Buffers, m_BufferCount, m_FrameIndex, m_CachedBufferIndex, m_BufferInfos; e.g. `m_PreTiles` at line 52). — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/DeferredShaderData.cs:8
  • `UniversalAdditionalCameraData` keeps one instance of itself in the static `s_DefaultAdditionalCameraData`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (m_RenderShadows, m_RequiresDepthTextureOption, m_RequiresOpaqueTextureOption, m_CameraType, m_Cameras, m_RendererIndex; e.g. `m_RenderShadows` at line 319). — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalAdditionalCameraData.cs:243
  • `XRSystem` is not registered, but `UniversalRenderPipeline` creates it and keeps it in the static `m_XRSystem`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (occlusionMeshMaterial, mirrorViewMaterial, framePasses, display, testRenderTexture; e.g. `occlusionMeshMaterial` at line 54). — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/XR/XRSystem.cs:13
  • `ShaderData` keeps one instance of itself in the static `m_Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (m_LightDataBuffer, m_LightIndicesBuffer, m_ShadowDataBuffer, m_ShadowIndicesBuffer; e.g. `m_LightDataBuffer` at line 32). — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/ShaderData.cs:6
  • `TypeSystems` is not registered, but the singleton `EventSystem` creates it and keeps it in `typeSystems`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (typeSystemsMap; e.g. `typeSystemsMap` at line 24). — Unity/Codes/Model/Core/Object/EventSystem.cs:10
  • `XRPass` is not registered, but the singleton `XRSystem` creates it and keeps it in `emptyPass`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (customMirrorView, views, cullingPassId, cullingParams, occlusionMeshCombinedHashCode, occlusionMeshCombined; e.g. `customMirrorView` at line 127). — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/XR/XRPass.cs:67
  • `DllHelper` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (assemblyLoadContext; e.g. `assemblyLoadContext` at line 15). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Server/Model/Base/DllHelper.cs:7
  • `Game` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (scene, frameFinishTask; e.g. `scene` at line 23). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Codes/Model/Core/Entity/Game.cs:6
  • `NumericType` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (map; e.g. `map` at line 25). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Codes/Model/Module/Numeric/NumericType.cs:4
  • `KChannel` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (KcpPtrChannels; e.g. `KcpPtrChannels` at line 50). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Assets/Mono/Module/Network/KChannel.cs:16
  • `SceneChangeHelper` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (waitCreateMyUnit; e.g. `waitCreateMyUnit` at line 40). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Codes/Hotfix/Demo/Scene/SceneChangeHelper.cs:3
  • `Kcp` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (KcpOutput, KcpLog; e.g. `KcpOutput` at line 192). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Assets/ThirdParty/ShareLib/Kcp/Kcp.cs:12
  • `ExcelExporter` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (tables, packages, IsCheck, template, configAssemblies; e.g. `tables` at line 110). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Tools/App/Apps/ChapterExporter/ChapterExporter.cs:18
  • `InnerProto2CS` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (msgOpcode, maxOldOuterOpcode, oldOuterOpcode; e.g. `msgOpcode` at line 35). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — REDACTED:24
  • `ETTask` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (queue; e.g. `queue` at line 40). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Assets/ThirdParty/ETTask/ETTask.cs:9
  • `ETTask` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (queue; e.g. `queue` at line 186). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Assets/ThirdParty/ETTask/ETTask.cs:165
  • `Light2DManager` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_SortingLayers; e.g. `s_SortingLayers` at line 109). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/2D/Light2DManager.cs:9
  • `Light2DLookupTexture` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_PointLightLookupTexture, s_FalloffLookupTexture; e.g. `s_PointLightLookupTexture` at line 13). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/2D/Passes/Utility/Light2DLookupTexture.cs:5
  • `RendererLighting` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_RenderTextureFormatToUse, s_HasSetupRenderTextureFormatToUse; e.g. `s_RenderTextureFormatToUse` at line 75). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/2D/Passes/Utility/RendererLighting.cs:7
  • `ShadowCasterGroup2DManager` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_ShadowCasterGroups; e.g. `s_ShadowCasterGroups` at line 77). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/2D/Shadows/ShadowCasterGroup2DManager.cs:7
  • `Pooled` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_stack; e.g. `_stack` at line 126). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/External/LibTessDotNet/MeshUtils.cs:116
  • `ScriptableRenderer` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (m_ActiveColorAttachments, m_ActiveDepthAttachment, m_UseOptimizedStoreActions, m_ActiveColorStoreActions, m_ActiveDepthStoreAction; e.g. `m_ActiveColorAttachments` at line 374). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/Deprecated.cs:63
  • `UniversalRenderPipeline` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (m_ShadowBiasData; e.g. `m_ShadowBiasData` at line 932). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalRenderPipelineCore.cs:356
  • `Profiling` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_HashSamplerCache; e.g. `s_HashSamplerCache` at line 48). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalRenderPipeline.cs:30
  • `RenderingUtils` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_FullscreenMesh, s_ErrorMaterial, m_RenderTextureFormatSupport, m_GraphicsFormatSupport; e.g. `s_FullscreenMesh` at line 39). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/RenderingUtils.cs:12
  • `SceneViewDrawMode` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (sceneViewHaveValidateFunction; e.g. `sceneViewHaveValidateFunction` at line 40). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/SceneViewDrawMode.cs:7

What to do

  • Keep singletons stateless or back their state with thread-safe types (Concurrent*/Immutable*); otherwise concurrent callers race.
  • A `static` field is one slot for the whole process, however its type is created: back it with a thread-safe type (ConcurrentDictionary, Interlocked), take a lock around every write, or move it into a registered singleton that does.
AX3 · Project dependency cycles10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the project-reference graph is acyclic (cycles block independent build/deploy and signal eroding boundaries).

Method: Project reference cycles via elementary-DFS over real .csproj references, using the engine shared with D5/D7; cyclic versus acyclic. Exhaustive, deterministic.

  • The namespaces ET ↔ ET.EventType depend on each other. The lightest dependency in the cycle is ET → ET.EventType (ET.INumericWatcher → ET.EventType.NumbericChange, 3 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — Unity/Codes/Model/Module/Numeric/INumericWatcher.cs:3
  • The namespaces UnityEngine.Rendering.Universal ↔ UnityEngine.Rendering.Universal.Internal depend on each other. The lightest dependency in the cycle is UnityEngine.Rendering.Universal → UnityEngine.Rendering.Universal.Internal (UnityEngine.Rendering.Universal.ForwardRenderer → UnityEngine.Rendering.Universal.Internal.AdditionalLightsShadowCasterPass, 15 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/ForwardRenderer.cs:1

What to do

  • Break namespace cycles inside a project by moving the shared type to a namespace both sides can use, or by inverting the back edge behind an interface.
AX4 · Dependency direction10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether dependencies point inward (Domain ← Application ← Infrastructure/Web) — the clean-architecture dependency rule, checked across the project graph.

Method: Layer violations by name-segment inference (Domain/Core to Application to Infrastructure/Web) over the project-reference graph. Exhaustive over all projects, deterministic.

AX5 · Architecture & structure10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether the codebase has a recognisable, scale-appropriate structure (a named architectural style, or modular enough for its size) rather than being an ad-hoc ball of mud.

Method: Roslyn plus csproj analysis: architecture style detection (DDD, clean, vertical-slice, CQRS) and structure fitness for repo size. Deterministic.

AX6 · Interface segregation10.0 / 10Exemplary✓ Tool-verified

Other · Architecture — Whether interfaces stay focused rather than fat — the Interface-Segregation principle (SOLID 'I').

Method: Roslyn scan: public interface declared-member counts (accessors fold into their property/event); fat-interface threshold (over 15 declared members) flagged per type. Each finding also reports the distinct-OPERATION count — members counted by name, so an overload group counts once — which decides whether it states the caller-side ISP harm or the implementer-side burden of an overload set. TypeScript: exported interfaces that declare behaviour, counted over their REQUIRED operations (method signatures and function-typed properties with no `?`, once per signature) — data-shape interfaces and ambient .d.ts declarations are outside the population; JavaScript declares no interfaces and is not applicable. Deterministic, type-level.

C1 · Data Protection0.0 / 10Critical✓ Tool-verified

Other · Security — Whether sensitive data is encrypted at rest and in transit and keys are vaulted.

Method: Roslyn plus filesystem scan: encryption presence (EF ColumnEncryption, key-vault references, HTTPS enforcement) and key-derivation KDF detection. Deterministic.

  • No data-protection or encryption usage (ASP.NET Data Protection, AES, column encryption, PBKDF2) was found — sensitive data at rest may be unprotected. If TDE/KMS/vault is delegated to infrastructure, ignore.

What to do

  • Encrypt sensitive data at rest (ASP.NET Core Data Protection / column encryption) and manage keys in a vault. Skip if delegated to infra (Postgres TDE, KMS, etc.).
  • Enforce HTTPS (UseHttpsRedirection / RequireHttpsMetadata) so data in transit is always encrypted.
GD1 · Unfinished & placeholder code10.0 / 10Exemplary✓ Tool-verified

Other · Code Health — Unreviewed-generation residue: shipped members still throwing NotImplementedException, and placeholder string literals left in non-test, non-generated code. Scored as a quality signature, never as a claim about authorship.

Method: Roslyn syntax scan: NotImplementedException throws and placeholder string literals in non-test, non-generated shipped code. Deterministic, code-shape signature.

  • A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface. (×4) — Unity/Assets/Mono/Module/NetworkTCP/WService.cs:125, Unity/Assets/Mono/Module/Network/Circularbuffer.cs:265, Unity/Assets/Mono/Module/Network/Circularbuffer.cs:270, …

What to do

  • Finish or delete NotImplementedException stubs and replace placeholder literals before shipping.
IC1 · Incompleteness & stubs7.2 / 10Strong✓ Tool-verified

Other · Code Health — Unfinished work detected by code SHAPE, not keywords: members that only throw a "not implemented" exception, methods that take inputs and return a constant, async methods that never await, dead `if (false)` / `#if false` branches, and skeleton types most of whose members are holes. A real, objective slice of technical debt.

Method: Roslyn syntax scan: incompleteness by code shape (constant-returning methods, async-never-await, #if false branches, guards that return what the code already falls through to, tests an earlier guard already decided, comparisons against NaN, skeleton types), not keyword-gated. Deterministic, code-shape heuristic.

  • `Add` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. (×2) — Server/Hotfix/Demo/Unit/UnitComponentSystem.cs:20, Unity/Codes/Hotfix/Demo/Unit/UnitComponent.cs:21
  • `Flush` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — Unity/Assets/Mono/Module/Network/Circularbuffer.cs:265
  • `Get` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface. — Unity/Assets/Mono/Module/NetworkTCP/WService.cs:125
  • `Stop` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it. — Unity/Codes/Hotfix/Module/Message/NetThreadComponentSystem.cs:43
  • The branch `if (viewId >= views.Count)` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. (×2) — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/XR/XRPass.cs:167, Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/XR/XRPass.cs:175
  • The branch `if (displayList.Count > 1)` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/XR/XRSystem.cs:233
  • A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers). (×32) — Server/Hotfix/Demo/Actor_TransferHandler.cs:12, Server/Hotfix/Demo/Actor_TransferHandler.cs:15, Server/Hotfix/Demo/Actor_TransferHandler.cs:18, …

What to do

  • Finish or delete the unfinished stubs (NotImplementedException / empty / constant-returning bodies) — they are dead surface that looks live.
  • Clear the softer debt: remove commented-out code and dead branches, re-enable or delete skipped tests, and replace blanket warning suppressions with targeted ones.
M1 · Documentation (README)6.0 / 10Adequate✓ Tool-verified

Maturity · Maturity — Whether the repository and its projects have a README, and whether it is substantive.

Method: Filesystem scan: README presence, word count, and headings for depth; git history for staleness. Exhaustive across root and project dirs, deterministic.

What to do

  • Add a build/run (quick start) section to the root README — the first thing a newcomer needs.
  • Explain in the README how to run the tests. Add a section called Testing to the README in the repository's top folder, saying how to run the test suite.
M2 · Architecture documentation0.0 / 10Critical✓ Tool-verified

Maturity · Maturity — Whether key decisions (ADRs) and the high-level shape (C4/diagrams) are written down.

Method: Filesystem scan: ADR folder/naming conventions or content, plus Mermaid/PlantUML/C4/architecture.md discovery. Exhaustive, deterministic.

  • No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
  • No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.

What to do

  • Record your significant design decisions. Write one short document per decision, giving its date, the situation, the decision and its consequences, and keep them together with your other design documents. A docs/adr folder with each file named by number and title is the easiest place to find them.
  • Add a C4 context/container diagram (Structurizr, PlantUML or Mermaid) or an architecture.md overview.
M3 · Folder & project structure10.0 / 10Exemplary✓ Tool-verified

Maturity · Maturity — Whether the repository is organised deliberately: production code and tests are set apart in a way its ecosystem or the repository itself declares.

Method: Filesystem scan: src/test folder separation and namespace-prefix consistency (majority RootNamespace agreement). Exhaustive across projects, deterministic.

M4 · Documentation accuracy10.0 / 10Exemplary○ Nothing flagged

Maturity · Maturity — Whether the project's current-state documentation describes the code that exists.

Method: Every current-state document's checkable claims looked up in the tree (links, versions, and artefact counts an order of magnitude off), plus two README checks: an advertised infrastructure product with no footprint, and a module the CHANGELOG records as removed. Deterministic, no model. Advisory.

P1 · CI/CD gates0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether an automated pipeline builds and tests every change.

Method: Filesystem scan: CI workflow files (.github/workflows, .gitlab-ci.yml, etc.) for build and test stages. Exhaustive, deterministic.

  • No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.

What to do

  • Add a CI workflow that builds and runs the test suite on every push/PR.
P10 · Library API & versioning0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — For a library: a deliberate (small) public API surface and explicit semantic versioning so consumers can depend on it safely.

Method: Roslyn scan: public API surface area and semantic-versioning markers (SemVer attributes, changelog entries) for libraries; off .NET, a library is the ecosystem's publication act (an npm package that is not private and names an entry point, a PyPI distribution with a build system, a Rust library crate, a Maven/Gradle module that publishes, a Go module with no package main, a gemspec, a Composer library, a SwiftPM library product, a pub.dev or Hex package), its surface is the share of types the language's code model records as public (Rust, Swift, Java, Kotlin, Go, Dart; not measured where the model records no type visibility or, as in TypeScript, only module-level export), and its version is read from the manifest, a semver CHANGELOG, release tooling or semver git tags. Exhaustive, deterministic.

  • No explicit version was found by any of the six routes this check reads: a `<Version>` or `<VersionPrefix>` property; a `GitVersion` or `MinVer` reference; the split Arcade spelling (`<MajorVersion>` AND `<MinorVersion>` together); a hand-written `[assembly: AssemblyVersion]` in source, with `bin/` and `obj/` excluded so the SDK's generated AssemblyInfo cannot satisfy it; or a version handed to MSBuild by the pipeline, as `-p:Version=` / `-p:PackageVersion=` on a `dotnet build` or `dotnet pack` line. Only project files, first-party source and CI files are read, so a version computed somewhere none of those can see is invisible here. A published library needs explicit semantic versioning so consumers can reason about breaking changes.

What to do

  • Stamp a semantic version (csproj <Version> or GitVersion/MinVer) and follow semver for breaking changes.
P3 · Security & performance tooling0.0 / 10Critical✓ Tool-verified

Readiness · Readiness — Whether SAST, secret/dependency scanning and performance benchmarking are wired in (presence, not runtime).

Method: Filesystem scan: SAST configuration, dependency-update automation, secret scanning, and a benchmark harness or benchmark step — in this repository's own ecosystem. Exhaustive, deterministic.

  • No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
  • `ThirdParty/ShareLib/ShareLib.csproj` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`. — ThirdParty/ShareLib/ShareLib.csproj:64

What to do

  • Run what this repository's stack ships: CodeQL's csharp pack, or a .NET security analyzer package — or `semgrep --config=auto`, which runs on any language — locally for now, since there is no CI pipeline here yet, and as a step of the first workflow you add so a security regression fails the build instead of landing.
  • Enable Dependabot/Renovate or a dependency-review gate.
  • Add gitleaks/trufflehog in CI to block PRs that introduce committed secrets.
P6 · Release Hygiene5.0 / 10Adequate✓ Tool-verified

Readiness · Readiness — Whether releases are traceable — a maintained changelog and explicit version stamping.

Method: Filesystem scan: changelog file presence and version tags in csproj or git tags. Exhaustive, deterministic.

PF3 · Async & latency hygiene10.0 / 10Exemplary✓ Tool-verified

Readiness · Performance — Whether asynchronous code stays responsive — it avoids sync-over-async blocking (a .NET .Wait()/.GetAwaiter().GetResult(), a time.sleep or blocking HTTP call inside a Python coroutine, a *Sync call inside an async JavaScript function, block_on inside a Rust async fn, runBlocking inside a Kotlin suspend function, block() inside a Reactor publisher) that stalls a thread or event loop and risks deadlock, and, where the code is a reusable library on .NET, awaits with ConfigureAwait(false) so it never captures and stalls its caller's context.

Method: Production-source scan: sync-over-async blocking counted everywhere — .Wait()/.GetAwaiter().GetResult() in .NET; off .NET, read from each language's code model, a blocking call inside an async function (Python, TS/JS, Rust, Kotlin, Swift, Dart) or inside a Java method returning a Reactor Mono/Flux or a Scala method returning a Future or effect — and, for a .NET library with ≥5 awaits, the share of awaits using ConfigureAwait(false). Deterministic, syntax/text detection.

S1 · Cryptographic Hygiene8.0 / 10Strong✓ Tool-verified

Other · Security — Cryptographic hygiene (weak hash/cipher, password key-derivation). This codebase has no web surface, so transport/header/cookie/CSRF controls are N/A and only crypto is scored.

Method: Roslyn plus filesystem scan: HSTS/security headers, secure cookies, input validation, middleware order, weak crypto (MD5/SHA1/DES); HTTPS-metadata context-aware. On a repository with no .NET source it reads JavaScript/TypeScript, Dart, Ruby, Scala, Rust or Elixir source itself (test, vendored, generated and minified paths not) for the arms that hold whether or not the code serves HTTP: a weak hash or cipher, key material fixed in the source, a TLS client that accepts any certificate, and (JavaScript/TypeScript, Ruby, Scala, Rust and Elixir) an obsolete TLS version; the server controls are not assessed there, and a Dart, Ruby, Scala, Rust or Elixir repository that serves no HTTP of its own is N/A on them. Deterministic.

  • MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses. — Unity/Assets/Mono/Core/Helper/MD5Helper.cs:13

What to do

  • Review each MD5/SHA1 use by what it protects: replace it with SHA-256+ (or a KDF for passwords) where the digest is security-relevant, and switch it to a non-cryptographic hash (`System.IO.Hashing.XxHash64`/`Crc32`) where it only derives an identifier such as a cache key or a mutex name.
X1 · Async correctness6.2 / 10Adequate✓ Tool-verified

Other · Code Health — Whether the code avoids sync-over-async (deadlock-prone blocking on tasks) and async void.

Method: Roslyn syntax scan: async methods scanned for .Wait()/.GetAwaiter().GetResult() and async-void outside event handlers. Deterministic, hard fact per invocation.

  • `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin. (×6) — Server/Model/Config/ConfigLoader.cs:14, Server/Model/Config/ConfigLoader.cs:16, Server/Model/Config/ConfigLoader.cs:17, …
  • `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained. — Unity/Assets/Mono/Core/Helper/ProcessHelper.cs:48
  • `StreamReader.ReadToEnd` blocks the thread on I/O while `StreamReader.ReadToEndAsync` exists to wait without one — inside a method that is already `async`, await the twin. — Unity/Assets/Mono/Core/Helper/ProcessHelper.cs:52
  • `Task.WaitAll` blocks this thread until the tasks complete — sync-over-async: it can deadlock under a synchronization context and it parks a thread for as long as the work runs. `await Task.WhenAll(…)` instead. — Tools/App/Apps/ExcelExporter/ExcelExporter.cs:236

What to do

  • Blocking `File.ReadAllBytes` inside an `async` method
X12 · Unreachable branch10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether any branch is dead by construction — a switch arm whose label can never equal a case-normalised subject, or an `else if` whose predicate the arm above has already swallowed.

Method: Roslyn syntax + semantics: switch labels compared against the subject's own case normaliser, and if/else-if chains checked for a literal an earlier arm's containment test already swallows. Deterministic, provable per finding. Advisory.

X13 · Undrained process stream10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a child process that has BOTH standard streams redirected drains both — reading one to the end while the other is never read deadlocks once the child fills the unread pipe.

Method: Roslyn syntax + semantics: ProcessStartInfo launches with both streams redirected, checked for a drain of each stream across the enclosing type. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `spawn` imported from `child_process` whose stdout and stderr are both pipes (no options, no `stdio`, or `stdio` of `'pipe'`), bound to a local that never leaves its scope, where exactly one of the two streams is read, the other never, and the child’s `close`/`exit` (or the read stream’s end) is awaited; a shell redirect in the call’s arguments or a `kill` of the child suppresses it. The same rule reads Python’s `subprocess.Popen`, Dart’s `Process.start`, Ruby’s `Open3.popen3`, and Scala’s JDK process starts (`new ProcessBuilder(…).start()` with no `redirectErrorStream`/`redirectError`/`redirectOutput`/`inheritIO`, `Runtime.getRuntime.exec`) where one of `getInputStream`/`getErrorStream` is read and the other never while `waitFor()` is called or the read stream is read to its end. Deterministic, provable per finding. Advisory.

X16 · Unfloored truncation loop10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a loop that shortens a string until it fits a length budget has a floor — one with none grinds the value down to the empty string, or past it into a negative-length `Substring`.

Method: Roslyn syntax + semantics: while/do loops whose body's only effect on a string is to drop its last character, checked for whether anything — a direct comparison on the length, a body guard, a break — bounds that length below. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `while`/`do` loop whose body’s one assignment to a value is `x = x.slice(0, -1)` or `x = x.slice|substring|substr(0, x.length - 1)`, driven by a condition that reads `x.length` only as a term of a larger expression — never compared directly, never tested for truthiness, and with no other read of `x` — and whose body has no `break`, `return`, `throw` or `if` naming `x`. Deterministic, provable per finding. Advisory.

X18 · Disposal-pattern correctness7.6 / 10Strong✓ Tool-verified

Other · Code Health — Whether a type's disposal matches what it OWNS — releasing what it created, leaving alone what it was handed, and not declaring a finalizer for state that has nothing unmanaged to finalize.

Method: Roslyn syntax + semantics: every assignment to a disposable field is read to decide whether the type CREATED the value or was handed it, and the type's disposal is checked against that answer — an injected interface it disposes, a value it constructed and never releases, a finalizer on a type holding nothing unmanaged, and a disposable local whose every reference is a plain member read. A value handed to a container that disposes its contents (a parent control's `Controls` collection, a component `IContainer`) is released by that container and is not reported; generated code is out of population. On a repository with no .NET source the same ownership questions are read in JavaScript/TypeScript off the engine’s own token stream (test, vendored, generated and minified paths not): a class declaring `dispose()`, `[Symbol.dispose]()` or `[Symbol.asyncDispose]()` that disposes a field it was handed through a constructor parameter typed as a repository interface or resolved by a dependency-injection container; that assigns a field only ever from `new X(…)` of a disposable class and neither releases it anywhere in the class nor names it in its disposal member or a method that member calls, nor hands it to anything else; and a `const`/`let` local built from literals only whose every reference opens a statement operating on a non-release member of it. A class is disposable when every repository declaration of its name declares or inherits a disposal member, or when it is a documented library disposable (`vscode` EventEmitter, CancellationTokenSource and Disposable; three.js geometries, materials, textures, render targets, renderers, controls and composers). The finalizer arm has no JavaScript counterpart: a class cannot declare one. Dart is read for the owned-and-never-released arm: a Flutter `State` (or a class declaring `dispose()`/`close()`) whose library-private field is written only with direct creations of a framework controller, `FocusNode`, `StreamController` or periodic `Timer` (or a `.listen(…)` into a field declared `StreamSubscription`), which nothing in the class or its library releases (`dispose`/`close`/`cancel`) and which is never handed on except as a named argument. Ruby is read for the owned-and-never-released arm and the abandoned-local arm: a class declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose instance variable is written only with a blockless core descriptor creation (`File.open`/`new`, `Tempfile`, `Dir.open`, `IO.popen`, the `socket` and `openssl` socket classes) that no method of the class closes and that is never handed on (passed, returned, stored, exposed by `attr_reader`, delegated) — a class whose superclass or mixin lies outside the repository is not judged — and a blockless creation read through and dropped (`File.open(path).read`) or held in a local that is never closed, returned, passed or stored (a `&:read` block-pass, an `autoclose: false` borrow and a `fileno` hand-over are not abandonment). PHP is read for the same two arms: a class (not a trait, and not one using a trait) declaring an instance `close`, `dispose`, `shutdown`, `stop`, `disconnect` or `terminate` whose `private` property (or a `final` class's `protected` one) is written only with a direct core `fopen`, `tmpfile`, `popen`, `proc_open`, `fsockopen`, `stream_socket_client`/`server` or `opendir` that nothing in the class closes (`fclose`, `pclose`, `closedir`, `unset`, a reset to `null`) and that is never handed on, and a handle held in a function's local, or read through as the argument of a reader, that is never closed, returned, passed, captured or stored; a `php://` stream, `curl_init`, `SplFileObject`, `PDO` and a function the repository declares under the core name are not read. Deterministic, provable per finding. Advisory.

  • `md5` is a `MD5`, which implements `IDisposable`, and it is created here (line 13). Every use of it in `FileMD5` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var md5 = …;`), which releases it at the end of the scope on every path including a throw. — Unity/Assets/Mono/Core/Helper/MD5Helper.cs:13
  • `TChannel` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `recvBuffer` itself (line 18), which makes that instance its own. But `recvBuffer` is named in none of the methods the disposal search covered: `Dispose` (line 95) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`recvBuffer?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — Unity/Assets/Mono/Module/NetworkTCP/TChannel.cs:18
  • `TChannel` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `sendBuffer` itself (line 19), which makes that instance its own. But `sendBuffer` is named in none of the methods the disposal search covered: `Dispose` (line 95) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`sendBuffer?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree. — Unity/Assets/Mono/Module/NetworkTCP/TChannel.cs:19
  • `unit` is a `Unit`, which implements `IDisposable`, and it is created here (line 17). Every use of it in `Run` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var unit = …;`), which releases it at the end of the scope on every path including a throw. — Unity/Codes/Hotfix/Demo/Unit/M2C_CreateUnitsHandler.cs:17

What to do

  • Each finding names the value and the span that decides who owns it — the `new` that created it, or the constructor parameter that handed it over. Confirm ownership from that span, then make the disposal match it: release what this type created, leave what it was injected with to whoever created THAT, and drop a finalizer whose type holds nothing unmanaged to release.
X2 · Cancellation propagation6.5 / 10Adequate✓ Tool-verified

Other · Code Health — Whether async methods accept a CancellationToken so work can be cancelled (adoption curve).

Method: Roslyn scan: every async method (excluding framework-fixed overrides/Blazor handlers) checked for CancellationToken parameter presence. Deterministic, adoption percentage. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same question: every named async function that itself makes a request an AbortSignal can cancel (global `fetch`, axios and its file-local instances, ky, ofetch) counts, and it is compliant when its parameters or body name a signal or it hands one of its own parameters to the request as options; signatures a framework fixes (JSX event handlers, route and lifecycle exports, request-first handlers, `override`, `'use server'` modules, TanStack `mutationFn`) are exempt unless they take a signal. Deterministic, adoption percentage.

  • Only 14/34 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
  • No CancellationToken parameter — this work can't be stopped early once started. (×16) — Unity/Assets/Mono/Core/Helper/ProcessHelper.cs:48, Server/Hotfix/Module/DB/DBComponentSystem.cs:32, Server/Hotfix/Module/DB/DBComponentSystem.cs:42, …
  • No CancellationToken parameter — the body observes an ambient token instead (a field or a context object), so the work does stop on cancellation, but a caller cannot cancel this call independently of the owner that created that token. (×4) — Unity/Assets/Mono/Module/NetworkTCP/WChannel.cs:72, Unity/Assets/Mono/Module/NetworkTCP/WChannel.cs:102, Unity/Assets/Mono/Module/NetworkTCP/WChannel.cs:151, …

What to do

  • Thread a CancellationToken through async methods so work stops promptly on cancellation.
X20 · Mistyped argument guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether an argument guard throws the exception its own condition describes — a guard that rejects a value for being EMPTY and reports it as `ArgumentNullException` tells the caller a parameter was null when it provably was not.

Method: Roslyn syntax: `throw new ArgumentNullException(nameof(p))` statements (or a repository exception type deriving from it) controlled by an `if` — directly or through the `using`, `lock` or `try` that wraps the throw — whose condition is read for a test that is true of a NON-null `p` — an emptiness test that dereferences it (`p.Count == 0`, `!p.Any()`) or a BCL predicate documented true of the empty value (`string.IsNullOrEmpty(p)`); in the `else` branch, for a conjunct of the admitting condition that is FALSE of a non-null `p`. Range guards are read for bounds that leave nothing and for a `p > C.Count` bound whose index then reaches `C[p]`, `C.RemoveAt(p)` or a method of the same type that indexes with it. Deterministic, provable per finding. Advisory.

X23 · Unguarded diagnostic materialisation10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether the work a diagnostic log line costs is paid only when that line is wanted — C# evaluates a call's arguments BEFORE the call, so a trace/debug message joined or projected out of a collection is built in full on every pass, and then discarded by a sink the shipped configuration leaves switched off.

Method: Roslyn syntax: log calls at a diagnostic level (a `Log`-prefixed method naming Trace/Debug/Verbose, or a bare `Debug`/`Trace`/`Verbose` on a receiver named for a logger), whose argument list is read for a call whose cost scales with a sequence — a LINQ operator, a materialisation, `string.Join`, a serializer — with no enclosing level check or conditional-compilation region. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `debug`/`trace`/`verbose` call on a receiver named for a logger, or a `log`-prefixed method naming the level, whose argument calls an array operator (`map`/`filter`/`reduce`/`sort`/…), `Array.from`, `Object.keys/values/entries`, `JSON.stringify`/`util.inspect` over anything but a literal, or an array `join` — outside any arrow or function passed as an argument, which the logger calls only when the level is on — with no enclosing `if`, `&&` or `?:` whose condition names a level, a level string, or the `NODE_ENV`/`__DEV__`/`DEV` build switch. Deterministic, provable per finding. Advisory.

X24 · Document value interpolated into markup unescaped10.0 / 10Exemplary○ Nothing flagged

Other · Security — Whether text read out of the document being converted is escaped before it is written into generated markup — a value the document's author chose, interpolated into an attribute the surrounding literal delimits, can close that attribute and open another.

Method: Roslyn semantic model over the whole compilation: a string-typed `Value`/`InnerText`/`InnerXml`/`Text` member declared inside `DocumentFormat.OpenXml` or `System.Xml` is a taint SOURCE, propagated through assignments, returns, arguments, tuple elements and string composition to its transitive closure, then read at interpolated-string holes that sit in a markup position the surrounding literal itself delimits. Escaper/encoder calls and enclosing validator conditions cut the flow. Flow- and container-insensitive by construction. A second arm needs no provenance at all and reports a type that CONTRADICTS ITSELF — the same expression escaped at one delimited markup hole and interpolated raw at another hole in the same markup position of the same type, which the type's own escaping proves is a defect without knowing where the value came from. On a repository with no .NET source it reads JavaScript/TypeScript off the token stream with the same rule: a DOM read of raw document text (`getAttribute`, `textContent`, `innerText`, `nodeValue`) is the source, propagated through local bindings and string composition, and judged at template-literal and concatenation holes in the same two delimited markup positions; escapers and validating conditions cut it, and documentation-site, test, vendored and minified scripts are not read. Deterministic, provable per finding. Advisory.

X26 · Unsynchronised callback handoff3.5 / 10Weak✓ Tool-verified

Other · Code Health — Whether a value handed from a callback to the body that waits on it crosses on something built to be crossed — a `Queue<T>`/`List<T>`/`Dictionary<K,V>` written inside an event handler and read back outside it is mutated by two flows at once, and the semaphore or completion source beside it orders how MANY items exist while leaving the collection's own head, tail and backing array unprotected.

Method: Roslyn syntax: method, accessor, local-function and lambda bodies that declare BOTH a non-thread-safe generic collection (`Queue`/`Stack`/`List`/`Dictionary`/`HashSet`/`Sorted*`/`LinkedList`) and a synchronisation primitive (`SemaphoreSlim`/`TaskCompletionSource`/`ManualResetEvent(Slim)`/`AutoResetEvent`/`CountdownEvent`) as locals, then read for a `+=`-registered lambda that raises that primitive while the body outside every lambda waits on it — and, in that scope, a mutating call on the collection inside the lambda paired with a mention of it outside. Any `lock` in the scope abstains it. On a repository with no .NET source the same handoff is read in Java off the engine’s own token stream (test source sets, vendored and demonstration paths not): an `ArrayList`/`LinkedList`/`ArrayDeque`/`PriorityQueue`/`Hash*`/`LinkedHash*`/`Tree*` local and a `CountDownLatch`/`Semaphore`/`CompletableFuture` local, a lambda or anonymous class that raises the primitive and mutates the collection, and a wait outside it; any `synchronized` or `lock()` abstains the body. Because each of those primitives orders what the callback wrote before raising it, only a touch that provably overlaps the callback is convicted: one after the registration and before the next wait, or one in a loop registered-before, waiting on every pass and not declaring the collection. Deterministic, provable per finding. Advisory.

  • `TService.idChannels` is a `Dictionary<…>` that a `SocketAsyncEventArgs.Completed +=` callback writes (`Add` on line 75) and `Dispose` reads (line 131). The runtime runs that callback on a thread the rest of the type does not own — a pool or I/O thread for a watcher, timer or process event, the completing thread for a continuation, the cancelling thread for a token registration, the pool for a `Progress<T>` made without a UI context — while `Dispose` runs on whichever thread calls it. `Dictionary<…>` allows many readers or one writer, never both: a read that meets the write sees a torn resize, an enumeration throws `InvalidOperationException`, and two writes lose or duplicate entries. Take one `lock` over the write and every read of `idChannels`, use a `System.Collections.Concurrent` collection, or marshal the callback onto the reader's synchronisation context. — Unity/Assets/Mono/Module/NetworkTCP/TService.cs:75

What to do

  • Hand values between a callback and the body waiting on it through a type built to be crossed — `System.Collections.Concurrent.ConcurrentQueue<T>` drops in beside the existing signal, and `System.Threading.Channels.Channel<T>` replaces the signal as well — or take a `lock` over every access to the shared collection on both sides. A counting semaphore beside it orders how MANY items exist and takes no exclusion over the collection's own internal state.
X27 · Collection changed while being enumerated10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a `foreach` leaves the collection it is walking alone — a body that adds to or removes from the very collection the loop is enumerating invalidates the enumerator it is holding, so the next `MoveNext` throws `InvalidOperationException` and the remaining items are never seen.

Method: Roslyn syntax + semantics: `foreach` statements whose body calls a structural mutator (`Add`/`Remove`/`Clear`/`Insert`/…) on the very expression the loop is enumerating. Two arms. ARM A — the source is a concrete fragile BCL collection, or a live `Keys`/`Values` view over one, and the mutator resolves to that same collection's own member; concurrent and immutable collections and arrays are outside the population by construction, since their enumerators survive a structural change. ARM B — the source is an argument-less accessor CALL on a receiver whose body is in source: the accessor must return a stored field VERBATIM and a sibling member must structurally change that same field, both read off the implementations rather than from the members' names. A mutation the loop provably exits immediately after (`break`/`return`/`throw`/`goto`), or one written inside a nested loop or a lambda, is counted and never reported. Deterministic, provable per finding. Advisory.

X28 · Index access outside its own emptiness guard10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a condition that tests a value for emptiness indexes that same value only where the test holds — an `||` written one parenthesis too far to the left leaves an index access outside the guard beside it, so the empty case the guard exists to anticipate reaches the index and throws.

Method: Roslyn syntax only, no semantic model: the OUTERMOST `&&`/`||` of every boolean condition, read for a symbol the condition tests for emptiness (`string.IsNullOrEmpty`/`IsNullOrWhiteSpace`, a `Length`/`Count` comparison against a literal, `Any()`, a `Length`/`Count` pattern, or a comparison against `""`) and ALSO indexes. Each `symbol[...]` access is placed by a boolean-reachability walk from the access up to the outermost connective: an access is COVERED when some enclosing step has it in the right operand and the left operand, under the truth value that step forces, proves the symbol non-empty — a recursion over `&&`/`||` whose true- and false-directions are asymmetric. A finding needs BOTH an uncovered access and a covered one on the same symbol in the same condition, which is the agreeing twin that separates a misplaced parenthesis from an unrelated length test. Bare index accesses with no emptiness test in the condition are neither counted nor reported; a non-identifier receiver and a lambda nested inside the condition are outside the population. Deterministic, provable per finding. Advisory.

X29 · Per-element action decided by a fixed element10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a decision taken once per element is taken ABOUT that element — a test inside a counted loop that reads a fixed subscript of the very collection its guarded statement indexes by the loop variable applies element zero's answer to all of them, so the elements that differ from it are all handled wrongly, and in the same direction.

Method: Roslyn syntax only, no semantic model: every `for` statement declaring exactly ONE loop variable, and every `if` inside its body that is not under a nested loop or a lambda. A site enters the population when the `if`’s condition never mentions the loop variable while the statement it guards indexes some collection by that variable ALONE (`c[i]`; `c[i + 1]` and `c[i, j]` are outside it). A finding additionally needs the AGREEING TWIN at the same-collection grain: the condition must read THAT SAME collection at a subscript that does not move — written into the condition, or reached through a local declared BEFORE the loop, so an alias bound inside the body is not followed. Both collection expressions must be simple identifiers. On a repository with no .NET source the same rule reads JavaScript/TypeScript off the engine’s own token stream (tests included, bundles and vendored paths not): a `for (let|var|const x = …; …; …)` with one declarator and a braced body, an alias followed only when it is declared before the loop in a block that encloses it and never assigned inside the loop. Deterministic, provable per finding. Advisory.

X3 · Exception handling7.6 / 10Strong✓ Tool-verified

Other · Code Health — Whether exceptions are handled rather than silently swallowed or rethrown with lost stack traces.

Method: Roslyn syntax scan: every catch clause counted; empty catches and bare rethrows flagged. Population is all catch clauses, not estimated. Deterministic, hard fact.

  • An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/RenderingUtils.cs:94

What to do

  • Swallowed exception (empty catch)
X30 · Support guard that admits what it rejects10.0 / 10Exemplary○ Nothing flagged

Other · Code Health — Whether a guard written as a NEGATED `||` says what its author meant — `!(a || b || x != k)` is `!a && !b && x == k` by De Morgan, so a bail-out that mixes capabilities the code needs with a fault it refuses turns inside out: it fires only where the capabilities are ABSENT, and lets every value the fault term names walk straight into the body that cannot handle it.

Method: Roslyn syntax only, no semantic model: every logical-not whose operand is a parenthesised `||` chain of two or more disjuncts, flattened (a left-nested `a || b || c` read once would see `(a || b)` as one disjunct). A site enters the population on that shape alone. A finding additionally needs the disjuncts to DISAGREE in polarity: at least one bare boolean read — an identifier or member access, never an invocation, which is a predicate rather than a capability flag — and at least one `x != <constant>`, the only form that negates into an exact-value pin (`== null` negates into a looser requirement and is outside the fault set). Consistently-polarised disjunctions, all-fault or all-capability, are counted and never reported; a negated `&&` is outside the population entirely. No same-receiver gate: it was measured to cost a real defect and remove no false positive. Deterministic, provable per finding. Advisory.

X4 · Structured logging5.5 / 10Adequate✓ Tool-verified

Other · Code Health — Whether log calls use message templates (queryable) rather than interpolated strings.

Method: Roslyn syntax scan: every log call-site counted; interpolated-string first-argument violations flagged. Population is all log calls, not estimated. On a repository with no .NET source it reads JavaScript/TypeScript off the engine’s own token stream (test, vendored and minified paths not) with the same rule: a `trace`/`debug`/`info`/`warn`/`error`/`fatal`/`verbose`/`silly`/`http`/`log` call on a receiver named for a logger, in a package whose own or an enclosing `package.json` declares a logger that carries values as fields (pino, pino-http, nestjs-pino, Fastify, winston, bunyan, tslog, LogTape, roarr), whose first deciding argument is a template literal with substitutions; an object-literal fields argument is stepped over, a plain string message clears the call. Python is read the same way: a `debug`/`info`/`warning`/`error`/`exception`/`critical`/`log` call on a logger in a file that imports the standard library’s `logging` or structlog (loguru, which formats at the call, is not judged), whose message is a whole f-string with a non-constant field; a `%`-formatted, `.format()`-ed or concatenated message is not convicted, as in C#. PHP is read the same way: a PSR-3 level call (`emergency`…`debug`, `log`) on a logger (`$logger`, `$this->logger`, Laravel’s `Log::`, `logger()`, `\Drupal::logger()`) in a package whose `composer.json` requires a PSR-3 logger or a framework that hands one out (psr/log, Monolog, Laravel, Symfony, Drupal, CakePHP), or a file that imports one, whose message is a double-quoted string interpolating a variable; a single-quoted message clears the call, and `sprintf` or `.` concatenation is not convicted, as in C#. Dart is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on Sentry’s structured logger (`Sentry.logger`) whose message is a whole string literal interpolating a value (`$name`, `${…}`); the `Sentry.logger.fmt` template API clears the call. Dart that logs only through loggers with one message and no fields (package:logging, package:logger, talker, dart:developer) is not applicable rather than a reach gap. Ruby is read the same way: a `trace`/`debug`/`info`/`warn`/`error`/`fatal` call on the console gem’s `Console` (declared by a Gemfile, gemspec or Gemfile.lock, or required) or, where SemanticLogger, Ougai or dry-logger is declared or required, on a receiver named for a logger (`logger`, `@logger`, `Rails.logger`, `log`), whose first deciding argument is, as the whole argument, a double-quoted string interpolating a non-constant value (`#{…}`, `#@ivar`); a plain literal clears the call, keyword arguments are the fields, and a block, `%`-format or `+` concatenation is not convicted. Ruby that logs only through the standard Logger (Rails.logger) is not applicable rather than a reach gap. Deterministic.

  • Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it. (×6) — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/ScriptableRendererData.cs:135, Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalAdditionalCameraData.cs:454, Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/Data/UniversalRenderPipelineAsset.cs:323, …

What to do

  • Interpolated log message defeats structured logging
X5 · Nullable reference types2.7 / 10Weak✓ Tool-verified

Other · Code Health — Whether nullable reference types are enabled and not undermined by heavy `!` suppression.

Method: Roslyn compiler-options scan: NullableContextOptions per project; null-forgiving (!) suppression density per 1k syntax nodes. Deterministic, adoption plus suppression penalty.

  • This method contradicts itself about `s`: line 29 assigns it with `as AIConfigCategory`, which hands back null rather than throwing when the value is not a `AIConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(AIConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/AIConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as AttributeConfigCategory`, which hands back null rather than throwing when the value is not a `AttributeConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(AttributeConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/AttributeConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as BuffActionControlConfigCategory`, which hands back null rather than throwing when the value is not a `BuffActionControlConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(BuffActionControlConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/BuffActionControlConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as BuffAttrConfigCategory`, which hands back null rather than throwing when the value is not a `BuffAttrConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(BuffAttrConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/BuffAttrConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as BuffBleedConfigCategory`, which hands back null rather than throwing when the value is not a `BuffBleedConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(BuffBleedConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/BuffBleedConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as BuffChantConfigCategory`, which hands back null rather than throwing when the value is not a `BuffChantConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(BuffChantConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/BuffChantConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as BuffConfigCategory`, which hands back null rather than throwing when the value is not a `BuffConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(BuffConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/BuffConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as EffectConfigCategory`, which hands back null rather than throwing when the value is not a `EffectConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(EffectConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/EffectConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as FormulaConfigCategory`, which hands back null rather than throwing when the value is not a `FormulaConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(FormulaConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/FormulaConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as GuidanceConfigCategory`, which hands back null rather than throwing when the value is not a `GuidanceConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(GuidanceConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/GuidanceConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as MapSceneConfigCategory`, which hands back null rather than throwing when the value is not a `MapSceneConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(MapSceneConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/MapSceneConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as SkillConfigCategory`, which hands back null rather than throwing when the value is not a `SkillConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(SkillConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/SkillConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as SkillJudgeConfigCategory`, which hands back null rather than throwing when the value is not a `SkillJudgeConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(SkillJudgeConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/SkillJudgeConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as SkillStepConfigCategory`, which hands back null rather than throwing when the value is not a `SkillStepConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(SkillStepConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/SkillStepConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as StartMachineConfigCategory`, which hands back null rather than throwing when the value is not a `StartMachineConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(StartMachineConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/StartMachineConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as StartProcessConfigCategory`, which hands back null rather than throwing when the value is not a `StartProcessConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(StartProcessConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/StartProcessConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as StartSceneConfigCategory`, which hands back null rather than throwing when the value is not a `StartSceneConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(StartSceneConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/StartSceneConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as StartZoneConfigCategory`, which hands back null rather than throwing when the value is not a `StartZoneConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(StartZoneConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/StartZoneConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as UIRouterConfigCategory`, which hands back null rather than throwing when the value is not a `UIRouterConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(UIRouterConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/UIRouterConfig.cs:30
  • This method contradicts itself about `s`: line 29 assigns it with `as UnitConfigCategory`, which hands back null rather than throwing when the value is not a `UnitConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(UnitConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Model/Generate/Config/UnitConfig.cs:30
  • This method contradicts itself about `component`: line 931 assigns it with `as T`, which hands back null rather than throwing when the value is not a `T`, but line 932 then dereferences it directly as `component.Id` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `component` once before the first use and handle the null case, or cast with `(T)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Model/Core/Object/Entity.cs:932
  • This method contradicts itself about `iLoadSystem`: line 509 assigns it with `as ILoadSystem`, which hands back null rather than throwing when the value is not a `ILoadSystem`, but line 512 then dereferences it directly as `iLoadSystem.Run` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `iLoadSystem` once before the first use and handle the null case, or cast with `(ILoadSystem)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Model/Core/Object/EventSystem.cs:512
  • This method contradicts itself about `iUpdateSystem`: line 577 assigns it with `as IUpdateSystem`, which hands back null rather than throwing when the value is not a `IUpdateSystem`, but line 580 then dereferences it directly as `iUpdateSystem.Run` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `iUpdateSystem` once before the first use and handle the null case, or cast with `(IUpdateSystem)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Model/Core/Object/EventSystem.cs:580
  • This method contradicts itself about `iLateUpdateSystem`: line 618 assigns it with `as ILateUpdateSystem`, which hands back null rather than throwing when the value is not a `ILateUpdateSystem`, but line 621 then dereferences it directly as `iLateUpdateSystem.Run` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `iLateUpdateSystem` once before the first use and handle the null case, or cast with `(ILateUpdateSystem)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Model/Core/Object/EventSystem.cs:621
  • This method contradicts itself about `timerAttribute`: line 176 assigns it with `as TimerAttribute`, which hands back null rather than throwing when the value is not a `TimerAttribute`, but line 177 then dereferences it directly as `timerAttribute.Type` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `timerAttribute` once before the first use and handle the null case, or cast with `(TimerAttribute)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Model/Core/Timer/TimerComponent.cs:177
  • This method contradicts itself about `tcs`: line 202 assigns it with `as ETTask<bool>`, which hands back null rather than throwing when the value is not a `ETTask<bool>`, but line 204 then dereferences it directly as `tcs.SetResult` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `tcs` once before the first use and handle the null case, or cast with `(ETTask<bool>)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Model/Core/Timer/TimerComponent.cs:204
  • This method contradicts itself about `responseTypeAttribute`: line 60 assigns it with `as ResponseTypeAttribute`, which hands back null rather than throwing when the value is not a `ResponseTypeAttribute`, but line 61 then dereferences it directly as `responseTypeAttribute.Type` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `responseTypeAttribute` once before the first use and handle the null case, or cast with `(ResponseTypeAttribute)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Model/Module/Message/OpcodeTypeComponent.cs:61
  • This method contradicts itself about `response`: line 134 assigns it with `as M2M_UnitAreaTransferResponse`, which hands back null rather than throwing when the value is not a `M2M_UnitAreaTransferResponse`, but line 135 then dereferences it directly as `response.NewInstanceId` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `response` once before the first use and handle the null case, or cast with `(M2M_UnitAreaTransferResponse)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Server/Hotfix/Demo/Transfer/TransferHelper.cs:135
  • This method contradicts itself about `args`: line 9 assigns it with `as EventType.ChangePosition`, which hands back null rather than throwing when the value is not a `EventType.ChangePosition`, but line 10 then dereferences it directly as `args.Unit` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `args` once before the first use and handle the null case, or cast with `(EventType.ChangePosition)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Hotfix/Module/AOI/Event/ChangePosition_MoveAOIUnit.cs:10
  • This method contradicts itself about `args`: line 9 assigns it with `as EventType.ChangePosition`, which hands back null rather than throwing when the value is not a `EventType.ChangePosition`, but line 12 then dereferences it directly as `args.Unit` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `args` once before the first use and handle the null case, or cast with `(EventType.ChangePosition)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Hotfix/Module/AOI/Event/ChangeRotation_TurnAOIUnit.cs:12
  • This method contradicts itself about `buff`: line 252 writes `buff?.Dispose`, which says `buff` can be null, but line 249 then dereferences it directly as `buff.ConfigId` with no null test between them and no guard around it. If the `?.` is right, that dereference throws NullReferenceException on the input it was written for; if `buff` truly cannot be null here, the `?.` is misleading. Settle it one way — test `buff` once before the first use and handle the null case, or drop the `?.` — rather than leaving the two readings side by side. — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:249
  • This method contradicts itself about `args`: line 7 assigns it with `as EventType.ChangePosition`, which hands back null rather than throwing when the value is not a `EventType.ChangePosition`, but line 8 then dereferences it directly as `args.Unit` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `args` once before the first use and handle the null case, or cast with `(EventType.ChangePosition)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/Event/ChangePosition_NotifyMoveBuffWatcher.cs:8
  • This method contradicts itself about `response`: line 17 assigns it with `as M2C_TestRobotCase`, which hands back null rather than throwing when the value is not a `M2C_TestRobotCase`, but line 18 then dereferences it directly as `response.N` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `response` once before the first use and handle the null case, or cast with `(M2C_TestRobotCase)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Robot/Hotfix/Robot/Case/RobotCase_FirstCase.cs:18
  • This method contradicts itself about `g2CEnterMap`: line 13 assigns it with `as G2C_EnterMap`, which hands back null rather than throwing when the value is not a `G2C_EnterMap`, but line 14 then dereferences it directly as `g2CEnterMap.MyId` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `g2CEnterMap` once before the first use and handle the null case, or cast with `(G2C_EnterMap)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Hotfix/Demo/Login/EnterMapHelper.cs:14
  • This method contradicts itself about `response`: line 28 assigns it with `as G2C_Ping`, which hands back null rather than throwing when the value is not a `G2C_Ping`, but line 38 then dereferences it directly as `response.Time` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `response` once before the first use and handle the null case, or cast with `(G2C_Ping)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Codes/Hotfix/Module/Ping/PingComponentSystem.cs:38
  • This method contradicts itself about `final`: line 687 assigns it with `as IMerge`, which hands back null rather than throwing when the value is not a `IMerge`, but line 700 then dereferences it directly as `final.Merge` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `final` once before the first use and handle the null case, or cast with `(IMerge)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Tools/App/Apps/ExcelExporter/ExcelExporter.cs:700
  • This method contradicts itself about `resources`: line 73 assigns it with `as UniversalRenderPipelineEditorResources`, which hands back null rather than throwing when the value is not a `UniversalRenderPipelineEditorResources`, but line 74 then dereferences it directly as `resources.materials` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `resources` once before the first use and handle the null case, or cast with `(UniversalRenderPipelineEditorResources)` so the failure is reported where it happens — rather than leaving the two readings side by side. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/Data/UniversalRenderPipelineEditorResources.cs:74
  • This method contradicts itself about `cameraStack`: line 433 tests it for null before doing anything with it — the author's own statement that null is an input this code expects — but that `if` scopes only the block beneath it, and line 537 then dereferences `cameraStack` as `cameraStack.Count` AFTER the block has closed, where the guard no longer applies. A null `cameraStack` skips the guarded body and reaches that line anyway, throwing NullReferenceException on exactly the input the guard was written for. If the dereference belongs to the guarded work, move it inside the block; if `cameraStack` truly cannot be null by then, the guard above is misleading and should go. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalRenderPipeline.cs:537
  • This method contradicts itself about `light`: line 938 tests it for null before doing anything with it — the author's own statement that null is an input this code expects — but that `if` scopes only the block beneath it, and line 944 then dereferences `light` as `light.shadowBias` AFTER the block has closed, where the guard no longer applies. A null `light` skips the guarded body and reaches that line anyway, throwing NullReferenceException on exactly the input the guard was written for. If the dereference belongs to the guarded work, move it inside the block; if `light` truly cannot be null by then, the guard above is misleading and should go. — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalRenderPipeline.cs:944
  • 1/12 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.

What to do

  • Where a method uses `?.` on a symbol and then dereferences it directly, settle the question once: test it before the first use and handle null, or drop the `?.`.
  • Where a method null-tests a symbol and then uses it after the guarded block closes, move the trailing work inside the block — the guard skips its body on null, it does not stop the method.
  • Enable <Nullable>enable</Nullable> across all projects and resolve warnings rather than suppressing with `!`.

Reference — by lens

The score is the rank-weighted fold of these lenses (worst-heaviest), each including its meta-dimensions; a lens with a Critical contributor is capped at Fair (its band reads "gated by …") and is never the strongest area however high its average.

LensScoreRatingImpact
Code Health54.5Adequate — gated by X5Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Architecture67.7Adequate — gated by D26, AX2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Maturity55.0Adequate — gated by M2Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Readiness23.3Critical — gated by P1, P3, P10Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Security33.9Weak — gated by D28, C1Capped at Fair by a Critical contributor — resolve it before relying on this lens.
Performance100.0ExemplaryStrongest area.
Unscored — 2 check(s) recorded observations but carry no score

These checks ran and found something, but they do not carry a score — either by design (an advisory check reports evidence rather than grading it) or because they could not be scored here. They are excluded from the score for that reason, not because there was nothing to see.

  • SC1 Supply-chain hygiene — 8 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
  • X10 Duplicated predicate — 10 observation(s) recorded · Advisory — this card reports evidence and never carries a score.
Not evidenced — 5 control(s) we could not find positive evidence for

These checks grade a working control, and the repository shows no evidence of one. That is deliberately not scored as a zero: a repository cannot show an ops runbook, a database TTL or an infrastructure-side audit log, so absence of evidence here is not evidence the control is missing. It is also not a statement that the check is irrelevant to this codebase — the thing it grades applies; we just could not see it. Excluded from the score either way.

  • C3 Audit Trail — Repo shows no audit-logging mechanism (IAuditable, an immutable audit log, an EF SaveChanges interceptor) for sensitive changes — absence of evidence is not evidence of a working control. Record an audit trail in code (or document where it lives) so this dimension can be scored.
  • C4 Data Retention — Repo shows no data-retention / TTL / cleanup mechanism for personal data — absence of evidence is not evidence of a working control. Define retention periods and a purge/cleanup job (or TTL) in code, or document where retention is enforced, so this dimension can be scored.
  • C5 Data-Subject Rights — Repo shows no corroborated data-subject-rights mechanism (erasure / export-portability / consent) tied to a subject id or GDPR vocabulary — absence of evidence is not evidence of a working control. Implement erasure, data export/portability and consent tracking over the subject's records.
  • P4 Deployment & Rollback — not evidenced — no deploy/rollback/approval signal in the repo; absence of evidence is not evidence of a manual release
  • P5 DR & Backup — not evidenced — repo shows no backup/RTO/RPO controls; absence of evidence is not evidence of a working control
Not included — 51 check(s) not relevant to this codebase

These checks had nothing to measure here (no tests, no git history, the codebase is small, or the architecture style doesn't apply), so they're omitted above rather than scored low.

  • AC1 Text alternatives — No web markup found — accessibility is not applicable to this repository.
  • AC2 Forms & labels — No web markup found — accessibility is not applicable to this repository.
  • AC3 Page structure — No web markup found — accessibility is not applicable to this repository.
  • AC4 Keyboard semantics — No web markup found — accessibility is not applicable to this repository.
  • AC5 ARIA correctness — No web markup found — accessibility is not applicable to this repository.
  • AC6 Visual & motion safety — No web markup found — accessibility is not applicable to this repository.
  • AX1 Captive dependencies — no DI registrations detected
  • AX7 Slice cohesion — not applicable — not a vertical-slice architecture
  • AX8 Test isolation — no test/production split to check
  • AX9 CQS / query purity — no CQRS query handlers detected — query purity is not applicable to this codebase
  • AXB2 Runtime readiness — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • AXR1 Runtime accessibility — This repository has no user interface to render — no markup (HTML, Razor, JSX, Vue, Svelte or server templates), no UI framework dependency, no UI component source and no native UI project — so WCAG's runtime success criteria have nothing to apply to here. Not applicable: this is neither a gap in the scan nor a finding about your code.
  • AXS1 Runtime exposed surface — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • C2 Access Controls — No access-control surface detected in the analyzed source — no web/app surface to authorize (no HTTP API or web-UI project) and no authorization code at all (no [Authorize]/policies, no imperative guard methods). Access control is therefore N/A here — this is a library/CLI, which is authorized by its CALLER, not by itself. If this codebase grows request handlers, the dimension reactivates and a default-deny posture is expected then.
  • D11 Test Reliability — No test suite was found to re-run, so reliability couldn't be assessed. Two searches produced that zero and both came back empty: the classifier that reads the loaded workspace recognised no suite it could run, and a walk of the source on disk — which covers the JS/TS `*.test.*` and `*.spec.*` conventions and probes for a Pester suite — found no test source in any other ecosystem either. Neither search reaches a suite that is missing from the loaded workspace and carries no name either walk recognises, so this is 'no suite found by those two searches', not a verdict that the repository has none.
  • D12 Dependency Hygiene — Dependency hygiene not measured
  • D16 Bus Factor — single-maintainer repository — bus factor is not applicable
  • D21 Naming Consistency — D21 withholds its case and prefix conventions rows: 13 candidate(s) found and not reported.
  • D22 Internal API Consistency — No intentionally-exposed public API to evaluate for consistency.
  • D25 ADR Conformance — no ADRs to check
  • D31 IaC & Container Security — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.
  • D32 Data Compliance (PII/GDPR) — 13 file(s) were not parsed by semgrep — the PII/GDPR ruleset never ran over them
  • D36 Supply-chain Provenance & Signing — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.
  • D37 Vulnerability-disclosure Policy — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.
  • D40 Network Egress Confinement — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.
  • D41 Kernel & Syscall Confinement — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.
  • D42 Runtime Threat Enforcement — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.
  • D7 Architectural Integrity — no checkable ADRs and no dependency cycles — architectural integrity not assessed
  • D8 Code Coverage — Coverage NOT MEASURED: this repository did not build in our analyzer environment (a C#/MSBuild compiler error), so no coverage could be collected. It is excluded from the score rather than counted as a near-zero defect. We did not read WHERE the failing diagnostic is, so this does not claim the fault is in your test code — a repository written for an older SDK band can compile for you and not for us. Run `dotnet build` on this commit; if it succeeds, the gap is ours. Committing the Cobertura/OpenCover/lcov report your CI already produces also lets us measure real coverage without building anything.
  • DM1 Domain Modelling — not scored — this repository shows only 1 of the 3 signals this lens looks for (28 domain event(s); its domain events are published by services or handlers — no domain entity raises one)
  • ED1 Event-Driven — not scored — this repository shows none of the 3 signals this lens looks for
  • ED5 Idempotency — Idempotency could not be assessed in this run — the check did not complete, so it is not scored. This is a gap in the analyzer, not a finding about this repository.
  • ES1 Event Sourcing — not scored — this repository shows none of the 3 signals this lens looks for
  • P12 CI test-gate honesty — no CI workflow found
  • P2 Observability — This repo is a library, not a deployed service — it has no process to operate, so production observability (structured logging, tracing/metrics, health checks) is N/A. A library may log via an injected ILogger, but the absence of operational telemetry is not a defect here. If it grows a host (web API, worker), the dimension reactivates.
  • P7 Outbound HTTP resilience — not applicable — this isn't a service/API/worker
  • P8 Schema migrations — no EF Core usage detected
  • P9 Domain vs controller coverage — coverage not measured: this check compares the coverage of the analyzer's own test run across the domain and web layers, and that run measured none here — Test coverage (D8) says why
  • PF1 Benchmark discipline — Not applicable: no benchmark suite was found by the two searches this check runs — a BenchmarkDotNet package reference in any project file (loaded, or on disk), and a script whose name contains `benchmark` that this repository's CI runs. Neither can see a suite in another ecosystem's idiom, so this is not a verdict that the repository has none. Benchmarks are credited as a bonus, so their absence is neither scored nor deducted, and nothing is asked of a repository that has none.
  • PF2 Allocation hygiene — Not scored: this check counted allocation-aware idioms (Span, pools, stackalloc) per line, which describes what kind of code a repository is rather than whether it has an allocation problem, so it was withdrawn. Nothing here is a finding about your code.
  • X14 Bypassable address classification — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X15 Unvalidated length from an untrusted reader — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X17 Uncapped recursion over a caller-supplied document — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X19 Unrestored process-global state — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X21 Side-effecting pattern guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X22 Contradicted release guard — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X25 Inert configuration knob — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X32 Type resolved by simple name across every loaded assembly — not applicable — the code was read and holds no site of this kind, so there is nothing for this check to judge
  • X6 Hand-rolled structured-format parsing — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X7 Silent fallback defaults — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.
  • X9 Subsumed condition operand — Advisory — this card reports evidence and never carries a score, so there is nothing missing here.

Appendix A — Findings (grouped)

The findings behind the scores, grouped by severity, then by dimension and kind. The high-severity issues are enumerated in full below; items per group are capped at 25 with any overflow stated explicitly per group, never silently truncated. The complete machine-readable list of every finding (all severities) is the companion findings.md in this report's bundle.

Critical — 56 finding(s)
D28 · Secrets (history) · REDACTED · ×28
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • + 3 more in this group — see findings.md.
D28 · Secrets (history) · High secret · ×15
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D17 · Explicit Debt · NoWarnInCsproj · ×10
  • NoWarnInCsproj Unity/Unity.RenderPipeline.Universal.ShaderLibrary.csproj:32 — 0169 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj Unity/Unity.RenderPipelines.Universal.Runtime.csproj:32 — 0169 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj Unity/Unity.RenderPipeline.Universal.ShaderLibrary.csproj:32 — 0649 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj Unity/Unity.RenderPipelines.Universal.Runtime.csproj:32 — 0649 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj Tools/Analyzer/Analyzer.csproj:12 — 1701 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj Tools/Analyzer/Analyzer.csproj:17 — 1701 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj Tools/Analyzer/Analyzer.csproj:12 — 1702 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj Tools/Analyzer/Analyzer.csproj:17 — 1702 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj Tools/Analyzer/Analyzer.csproj:12 — RS2008 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
  • NoWarnInCsproj Tools/Analyzer/Analyzer.csproj:17 — RS2008 — this warning is switched off for the WHOLE project, in every file it builds, including code written years from now: nothing at the call site records that the rule was ever silenced, so the next reader has no reason to look here. Fix what the rule is reporting and drop the code from the list, or — if some occurrences really are legitimate — narrow the suppression to those sites and give each one its reason, so the rule keeps protecting the rest of the project.
AX3 · Project dependency cycles · Namespace dependency cycle · ×2
  • Namespace dependency cycle Unity/Codes/Model/Module/Numeric/INumericWatcher.cs:3 — The namespaces ET ↔ ET.EventType depend on each other. The lightest dependency in the cycle is ET → ET.EventType (ET.INumericWatcher → ET.EventType.NumbericChange, 3 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
  • Namespace dependency cycle Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/ForwardRenderer.cs:1 — The namespaces UnityEngine.Rendering.Universal ↔ UnityEngine.Rendering.Universal.Internal depend on each other. The lightest dependency in the cycle is UnityEngine.Rendering.Universal → UnityEngine.Rendering.Universal.Internal (UnityEngine.Rendering.Universal.ForwardRenderer → UnityEngine.Rendering.Universal.Internal.AdditionalLightsShadowCasterPass, 15 type pair(s)); cut that one first, e.g. by moving the shared type to a namespace both can use or inverting it behind an interface.
D34 · Knowledge Freshness · Orphaned knowledge · ×1
  • Orphaned knowledge Tools/App/Apps/ExcelExporter/ExcelExporter.cs:1 — No living knowledge remains for this large file — its last meaningful change has decayed away; if it breaks, no one currently understands it. Schedule a read-through / add characterisation tests before it bites.
Serious — 523 finding(s)
X5 · Nullable reference types · Symbol treated as nullable, then dereferenced unguarded · ×37
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/AIConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as AIConfigCategory`, which hands back null rather than throwing when the value is not a `AIConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(AIConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/AttributeConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as AttributeConfigCategory`, which hands back null rather than throwing when the value is not a `AttributeConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(AttributeConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/BuffActionControlConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as BuffActionControlConfigCategory`, which hands back null rather than throwing when the value is not a `BuffActionControlConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(BuffActionControlConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/BuffAttrConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as BuffAttrConfigCategory`, which hands back null rather than throwing when the value is not a `BuffAttrConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(BuffAttrConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/BuffBleedConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as BuffBleedConfigCategory`, which hands back null rather than throwing when the value is not a `BuffBleedConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(BuffBleedConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/BuffChantConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as BuffChantConfigCategory`, which hands back null rather than throwing when the value is not a `BuffChantConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(BuffChantConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/BuffConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as BuffConfigCategory`, which hands back null rather than throwing when the value is not a `BuffConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(BuffConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/EffectConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as EffectConfigCategory`, which hands back null rather than throwing when the value is not a `EffectConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(EffectConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/FormulaConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as FormulaConfigCategory`, which hands back null rather than throwing when the value is not a `FormulaConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(FormulaConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/GuidanceConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as GuidanceConfigCategory`, which hands back null rather than throwing when the value is not a `GuidanceConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(GuidanceConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/MapSceneConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as MapSceneConfigCategory`, which hands back null rather than throwing when the value is not a `MapSceneConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(MapSceneConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/SkillConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as SkillConfigCategory`, which hands back null rather than throwing when the value is not a `SkillConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(SkillConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/SkillJudgeConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as SkillJudgeConfigCategory`, which hands back null rather than throwing when the value is not a `SkillJudgeConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(SkillJudgeConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/SkillStepConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as SkillStepConfigCategory`, which hands back null rather than throwing when the value is not a `SkillStepConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(SkillStepConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/StartMachineConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as StartMachineConfigCategory`, which hands back null rather than throwing when the value is not a `StartMachineConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(StartMachineConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/StartProcessConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as StartProcessConfigCategory`, which hands back null rather than throwing when the value is not a `StartProcessConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(StartProcessConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/StartSceneConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as StartSceneConfigCategory`, which hands back null rather than throwing when the value is not a `StartSceneConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(StartSceneConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/StartZoneConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as StartZoneConfigCategory`, which hands back null rather than throwing when the value is not a `StartZoneConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(StartZoneConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/UIRouterConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as UIRouterConfigCategory`, which hands back null rather than throwing when the value is not a `UIRouterConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(UIRouterConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Server/Model/Generate/Config/UnitConfig.cs:30 — This method contradicts itself about `s`: line 29 assigns it with `as UnitConfigCategory`, which hands back null rather than throwing when the value is not a `UnitConfigCategory`, but line 30 then dereferences it directly as `s.list` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `s` once before the first use and handle the null case, or cast with `(UnitConfigCategory)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Unity/Codes/Model/Core/Object/Entity.cs:932 — This method contradicts itself about `component`: line 931 assigns it with `as T`, which hands back null rather than throwing when the value is not a `T`, but line 932 then dereferences it directly as `component.Id` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `component` once before the first use and handle the null case, or cast with `(T)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Unity/Codes/Model/Core/Object/EventSystem.cs:512 — This method contradicts itself about `iLoadSystem`: line 509 assigns it with `as ILoadSystem`, which hands back null rather than throwing when the value is not a `ILoadSystem`, but line 512 then dereferences it directly as `iLoadSystem.Run` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `iLoadSystem` once before the first use and handle the null case, or cast with `(ILoadSystem)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Unity/Codes/Model/Core/Object/EventSystem.cs:580 — This method contradicts itself about `iUpdateSystem`: line 577 assigns it with `as IUpdateSystem`, which hands back null rather than throwing when the value is not a `IUpdateSystem`, but line 580 then dereferences it directly as `iUpdateSystem.Run` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `iUpdateSystem` once before the first use and handle the null case, or cast with `(IUpdateSystem)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Unity/Codes/Model/Core/Object/EventSystem.cs:621 — This method contradicts itself about `iLateUpdateSystem`: line 618 assigns it with `as ILateUpdateSystem`, which hands back null rather than throwing when the value is not a `ILateUpdateSystem`, but line 621 then dereferences it directly as `iLateUpdateSystem.Run` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `iLateUpdateSystem` once before the first use and handle the null case, or cast with `(ILateUpdateSystem)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • Symbol treated as nullable, then dereferenced unguarded Unity/Codes/Model/Core/Timer/TimerComponent.cs:177 — This method contradicts itself about `timerAttribute`: line 176 assigns it with `as TimerAttribute`, which hands back null rather than throwing when the value is not a `TimerAttribute`, but line 177 then dereferences it directly as `timerAttribute.Type` with no null test between them and no guard around it. If the `as` is right, that dereference throws NullReferenceException on the input it was written for — and the NullReferenceException names neither the cast nor the type that failed. Settle it one way — test `timerAttribute` once before the first use and handle the null case, or cast with `(TimerAttribute)` so the failure is reported where it happens — rather than leaving the two readings side by side.
  • + 12 more in this group — see findings.md.
AX2 · Stateful singletons · Process-global static state · ×20
  • Process-global static state: DllHelper Server/Model/Base/DllHelper.cs:7 — `DllHelper` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (assemblyLoadContext; e.g. `assemblyLoadContext` at line 15). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: Game Unity/Codes/Model/Core/Entity/Game.cs:6 — `Game` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (scene, frameFinishTask; e.g. `scene` at line 23). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: NumericType Unity/Codes/Model/Module/Numeric/NumericType.cs:4 — `NumericType` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (map; e.g. `map` at line 25). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: KChannel Unity/Assets/Mono/Module/Network/KChannel.cs:16 — `KChannel` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (KcpPtrChannels; e.g. `KcpPtrChannels` at line 50). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: SceneChangeHelper Unity/Codes/Hotfix/Demo/Scene/SceneChangeHelper.cs:3 — `SceneChangeHelper` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (waitCreateMyUnit; e.g. `waitCreateMyUnit` at line 40). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: Kcp Unity/Assets/ThirdParty/ShareLib/Kcp/Kcp.cs:12 — `Kcp` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (KcpOutput, KcpLog; e.g. `KcpOutput` at line 192). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: ExcelExporter Tools/App/Apps/ChapterExporter/ChapterExporter.cs:18 — `ExcelExporter` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (tables, packages, IsCheck, template, configAssemblies; e.g. `tables` at line 110). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: InnerProto2CS REDACTED:24 — `InnerProto2CS` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (msgOpcode, maxOldOuterOpcode, oldOuterOpcode; e.g. `msgOpcode` at line 35). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: ETTask Unity/Assets/ThirdParty/ETTask/ETTask.cs:9 — `ETTask` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (queue; e.g. `queue` at line 40). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: ETTask Unity/Assets/ThirdParty/ETTask/ETTask.cs:165 — `ETTask` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (queue; e.g. `queue` at line 186). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: Light2DManager Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/2D/Light2DManager.cs:9 — `Light2DManager` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_SortingLayers; e.g. `s_SortingLayers` at line 109). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: Light2DLookupTexture Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/2D/Passes/Utility/Light2DLookupTexture.cs:5 — `Light2DLookupTexture` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_PointLightLookupTexture, s_FalloffLookupTexture; e.g. `s_PointLightLookupTexture` at line 13). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: RendererLighting Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/2D/Passes/Utility/RendererLighting.cs:7 — `RendererLighting` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_RenderTextureFormatToUse, s_HasSetupRenderTextureFormatToUse; e.g. `s_RenderTextureFormatToUse` at line 75). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: ShadowCasterGroup2DManager Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/2D/Shadows/ShadowCasterGroup2DManager.cs:7 — `ShadowCasterGroup2DManager` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_ShadowCasterGroups; e.g. `s_ShadowCasterGroups` at line 77). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: Pooled Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/External/LibTessDotNet/MeshUtils.cs:116 — `Pooled` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (_stack; e.g. `_stack` at line 126). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: ScriptableRenderer Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/Deprecated.cs:63 — `ScriptableRenderer` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (m_ActiveColorAttachments, m_ActiveDepthAttachment, m_UseOptimizedStoreActions, m_ActiveColorStoreActions, m_ActiveDepthStoreAction; e.g. `m_ActiveColorAttachments` at line 374). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: UniversalRenderPipeline Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalRenderPipelineCore.cs:356 — `UniversalRenderPipeline` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (m_ShadowBiasData; e.g. `m_ShadowBiasData` at line 932). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: Profiling Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalRenderPipeline.cs:30 — `Profiling` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_HashSamplerCache; e.g. `s_HashSamplerCache` at line 48). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: RenderingUtils Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/RenderingUtils.cs:12 — `RenderingUtils` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (s_FullscreenMesh, s_ErrorMaterial, m_RenderTextureFormatSupport, m_GraphicsFormatSupport; e.g. `s_FullscreenMesh` at line 39). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
  • Process-global static state: SceneViewDrawMode Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/SceneViewDrawMode.cs:7 — `SceneViewDrawMode` keeps mutable `static` state — one slot for the whole process, shared by every thread that reaches the type however its instances are created — and mutates it outside any lock (sceneViewHaveValidateFunction; e.g. `sceneViewHaveValidateFunction` at line 40). Concurrent callers lose updates, and a collection that is not built for concurrent writers can corrupt.
X2 · Cancellation propagation · Async method without CancellationToken · ×16
  • Async method without CancellationToken: WaitExitAsync Unity/Assets/Mono/Core/Helper/ProcessHelper.cs:48 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Query Server/Hotfix/Module/DB/DBComponentSystem.cs:32 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Query Server/Hotfix/Module/DB/DBComponentSystem.cs:42 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Query Server/Hotfix/Module/DB/DBComponentSystem.cs:53 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Query Server/Hotfix/Module/DB/DBComponentSystem.cs:64 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: QueryJson Server/Hotfix/Module/DB/DBComponentSystem.cs:89 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: QueryJson Server/Hotfix/Module/DB/DBComponentSystem.cs:99 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: InsertBatch Server/Hotfix/Module/DB/DBComponentSystem.cs:113 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Save Server/Hotfix/Module/DB/DBComponentSystem.cs:130 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Save Server/Hotfix/Module/DB/DBComponentSystem.cs:150 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Save Server/Hotfix/Module/DB/DBComponentSystem.cs:170 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Remove Server/Hotfix/Module/DB/DBComponentSystem.cs:209 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Remove Server/Hotfix/Module/DB/DBComponentSystem.cs:219 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Remove Server/Hotfix/Module/DB/DBComponentSystem.cs:229 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: Remove Server/Hotfix/Module/DB/DBComponentSystem.cs:239 — No CancellationToken parameter — this work can't be stopped early once started.
  • Async method without CancellationToken: LoadAsync Unity/Codes/Hotfix/Module/Config/ConfigComponentSystem.cs:63 — No CancellationToken parameter — this work can't be stopped early once started.
D4 · Code Duplication · Edited copy of a member (7 corresponding lines) · ×14
  • Edited copy of a member (7 corresponding lines) Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:99 — Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:99-110 | Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:115-121 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:115 — Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:115-121 | Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:99-110 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:1215 — ThirdParty/UnityEngine/Matrix4x4.cs:1215-1227 | ThirdParty/UnityEngine/Matrix4x4.cs:1230-1240 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:1253 — ThirdParty/UnityEngine/Matrix4x4.cs:1253-1265 | ThirdParty/UnityEngine/Matrix4x4.cs:1268-1278 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:193 — ThirdParty/UnityEngine/Vector3.cs:193-199 | ThirdParty/UnityEngine/Vector3.cs:202-209 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) ThirdParty/UnityEngine/Vector2.cs:327 — ThirdParty/UnityEngine/Vector2.cs:327-333 | ThirdParty/UnityEngine/Vector3.cs:568-574 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) ThirdParty/UnityEngine/Vector2.cs:318 — ThirdParty/UnityEngine/Vector2.cs:318-324 | ThirdParty/UnityEngine/Vector3.cs:559-565 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:385 — ThirdParty/UnityEngine/Vector3.cs:385-391 | ThirdParty/UnityEngine/Vector4.cs:371-378 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:417 — ThirdParty/UnityEngine/Vector3.cs:417-423 | ThirdParty/UnityEngine/Vector4.cs:407-414 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:449 — ThirdParty/UnityEngine/Vector3.cs:449-455 | ThirdParty/UnityEngine/Vector4.cs:443-450 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:596 — ThirdParty/UnityEngine/Vector3.cs:596-602 | ThirdParty/UnityEngine/Vector4.cs:505-512 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:614 — ThirdParty/UnityEngine/Vector3.cs:614-620 | ThirdParty/UnityEngine/Vector4.cs:525-532 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:641 — ThirdParty/UnityEngine/Vector3.cs:641-647 | ThirdParty/UnityEngine/Vector4.cs:555-562 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (7 corresponding lines) Tools/App/Apps/AreaExporter/AreaExporter.cs:56 — Tools/App/Apps/AreaExporter/AreaExporter.cs:56-62 | Tools/App/Apps/AttrExporter/AttrExporter.cs:115-121 — These two members are one piece of code written twice and then edited apart: 7 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D17 · Explicit Debt · CommentedOutCode · ×13
  • CommentedOutCode Server/Hotfix/Demo/Actor_TransferHandler.cs:18 — 7 consecutive commented-code lines
  • CommentedOutCode Server/Hotfix/Demo/Actor_TransferHandler.cs:27 — 3 consecutive commented-code lines
  • CommentedOutCode Server/Hotfix/Demo/Actor_TransferHandler.cs:32 — 3 consecutive commented-code lines
  • CommentedOutCode Unity/Codes/Model/Module/Message/MessagePackHelper.cs:10 — 3 consecutive commented-code lines
  • CommentedOutCode Unity/Codes/Model/Module/Message/MessagePackHelper.cs:14 — 3 consecutive commented-code lines
  • CommentedOutCode Server/Hotfix/Handler/C2M_ReloadHandler.cs:11 — 13 consecutive commented-code lines
  • CommentedOutCode Tools/App/Apps/ExcelExporter/ExcelExporter.cs:224 — 4 consecutive commented-code lines
  • CommentedOutCode Unity/Codes/Model/Module/Message/MessagePackHelper.cs:24 — 4 consecutive commented-code lines
  • CommentedOutCode Unity/Codes/Model/Module/Message/MessagePackHelper.cs:29 — 4 consecutive commented-code lines
  • CommentedOutCode Unity/Codes/Model/Module/Message/MessagePackHelper.cs:34 — 4 consecutive commented-code lines
  • CommentedOutCode Unity/Codes/Model/Module/Message/MessagePackHelper.cs:39 — 4 consecutive commented-code lines
  • CommentedOutCode Unity/Codes/Model/Module/Message/MessagePackHelper.cs:44 — 4 consecutive commented-code lines
  • CommentedOutCode Unity/Codes/Model/Module/Message/MessagePackHelper.cs:18 — 5 consecutive commented-code lines
AX2 · Stateful singletons · Stateful shared instance · ×12
  • Stateful shared instance: FormulaStringFx Unity/Codes/Model/Module/Battle/Combat/FormulaStringFx.cs:8 — `FormulaStringFx` keeps one instance of itself in the static `Instances`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (formulaNodeList; e.g. `formulaNodeList` at line 140).
  • Stateful shared instance: EventSystem Unity/Codes/Model/Core/Object/EventSystem.cs:51 — `EventSystem` keeps one instance of itself in the static `instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (allTypes, typeSystems, allEvents, assemblies, allEntities, loaders; e.g. `allTypes` at line 96).
  • Stateful shared instance: IdGenerater Unity/Codes/Model/Core/Object/IdGenerater.cs:142 — `IdGenerater` keeps one instance of itself in the static `Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (epoch2020, epochThisYear, value, lastInstanceIdTime, instanceIdValue, lastIdTime; e.g. `epoch2020` at line 190).
  • Stateful shared instance: ObjectPool Unity/Codes/Model/Core/Object/ObjectPool.cs:6 — `ObjectPool` keeps one instance of itself in the static `Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (pool; e.g. `pool` at line 54).
  • Stateful shared instance: MonoPool Unity/Assets/Mono/Core/MonoPool.cs:6 — `MonoPool` keeps one instance of itself in the static `Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (pool; e.g. `pool` at line 38).
  • Stateful shared instance: TimeInfo Unity/Assets/Mono/Core/TimeInfo.cs:5 — `TimeInfo` keeps one instance of itself in the static `Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (timeZone, dt, FrameTime; e.g. `timeZone` at line 19).
  • Stateful shared instance: DeferredShaderData Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/DeferredShaderData.cs:8 — `DeferredShaderData` keeps one instance of itself in the static `m_Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (m_PreTiles, m_Buffers, m_BufferCount, m_FrameIndex, m_CachedBufferIndex, m_BufferInfos; e.g. `m_PreTiles` at line 52).
  • Stateful shared instance: UniversalAdditionalCameraData Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalAdditionalCameraData.cs:243 — `UniversalAdditionalCameraData` keeps one instance of itself in the static `s_DefaultAdditionalCameraData`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (m_RenderShadows, m_RequiresDepthTextureOption, m_RequiresOpaqueTextureOption, m_CameraType, m_Cameras, m_RendererIndex; e.g. `m_RenderShadows` at line 319).
  • Stateful shared instance: XRSystem Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/XR/XRSystem.cs:13 — `XRSystem` is not registered, but `UniversalRenderPipeline` creates it and keeps it in the static `m_XRSystem`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (occlusionMeshMaterial, mirrorViewMaterial, framePasses, display, testRenderTexture; e.g. `occlusionMeshMaterial` at line 54).
  • Stateful shared instance: ShaderData Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/ShaderData.cs:6 — `ShaderData` keeps one instance of itself in the static `m_Instance`, so that one instance serves the whole process and is shared by every thread that reaches it — and it mutates instance state outside any lock (m_LightDataBuffer, m_LightIndicesBuffer, m_ShadowDataBuffer, m_ShadowIndicesBuffer; e.g. `m_LightDataBuffer` at line 32).
  • Stateful shared instance: TypeSystems Unity/Codes/Model/Core/Object/EventSystem.cs:10 — `TypeSystems` is not registered, but the singleton `EventSystem` creates it and keeps it in `typeSystems`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (typeSystemsMap; e.g. `typeSystemsMap` at line 24).
  • Stateful shared instance: XRPass Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/XR/XRPass.cs:67 — `XRPass` is not registered, but the singleton `XRSystem` creates it and keeps it in `emptyPass`, so one instance outlives every request and is shared by every caller that reaches it — and it mutates instance state outside any lock (customMirrorView, views, cullingPassId, cullingParams, occlusionMeshCombinedHashCode, occlusionMeshCombined; e.g. `customMirrorView` at line 127).
D4 · Code Duplication · Edited copy of a member (10 corresponding lines) · ×12
  • Edited copy of a member (10 corresponding lines) Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:14 — Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:14-23 | Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:31-41 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) Unity/Codes/Model/Core/Object/ObjectPool.cs:48 — Unity/Codes/Model/Core/Object/ObjectPool.cs:48-57 | Unity/Assets/Mono/Core/MonoPool.cs:32-41 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:58 — Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:58-67 | Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:54-63 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:54 — Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:54-63 | Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:58-67 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:70 — Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:70-79 | Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:66-75 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:66 — Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:66-75 | Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:70-79 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Collider/SkillColliderComponentSystem.cs:9 — Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Collider/SkillColliderComponentSystem.cs:9-18 | Unity/Codes/Hotfix/Module/Message/SessionAcceptTimeoutComponentSystem.cs:9-18 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) Unity/Codes/Hotfix/Module/Message/SessionAcceptTimeoutComponentSystem.cs:9 — Unity/Codes/Hotfix/Module/Message/SessionAcceptTimeoutComponentSystem.cs:9-18 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Collider/SkillColliderComponentSystem.cs:9-18 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:120 — ThirdParty/UnityEngine/Quaternion.cs:120-129 | ThirdParty/UnityEngine/Quaternion.cs:142-151 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) ThirdParty/UnityEngine/Vector2.cs:236 — ThirdParty/UnityEngine/Vector2.cs:236-247 | ThirdParty/UnityEngine/Vector2.cs:250-259 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) Server/Hotfix/Demo/Battle/Event/M2M_DamageHandler.cs:7 — Server/Hotfix/Demo/Battle/Event/M2M_DamageHandler.cs:7-18 | Unity/Codes/Hotfix/Demo/Battle/M2C_DamageHandler.cs:7-16 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (10 corresponding lines) ThirdParty/UnityEngine/Vector2.cs:157 — ThirdParty/UnityEngine/Vector2.cs:157-166 | ThirdParty/UnityEngine/Vector2.cs:169-181 — These two members are one piece of code written twice and then edited apart: 10 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D44 · Platform End-of-Life · End-of-life runtime · ×11
  • End-of-life runtime: .NET net6.0 Robot/App/Robot.App.csproj:5 — Robot/App/Robot.App.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
  • End-of-life runtime: .NET net6.0 Robot/Hotfix/Robot.Hotfix.csproj:4 — Robot/Hotfix/Robot.Hotfix.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
  • End-of-life runtime: .NET net6.0 Robot/Model/Robot.Model.csproj:4 — Robot/Model/Robot.Model.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
  • End-of-life runtime: .NET net6.0 Server/App/Server.App.csproj:5 — Server/App/Server.App.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
  • End-of-life runtime: .NET net6.0 Server/Hotfix/Server.Hotfix.csproj:3 — Server/Hotfix/Server.Hotfix.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
  • End-of-life runtime: .NET net6.0 Server/Model/Server.Model.csproj:3 — Server/Model/Server.Model.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
  • End-of-life runtime: .NET net6.0 ThirdParty/ETTask/ETTask.csproj:4 — ThirdParty/ETTask/ETTask.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
  • End-of-life runtime: .NET net6.0 ThirdParty/ShareLib/ShareLib.csproj:4 — ThirdParty/ShareLib/ShareLib.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
  • End-of-life runtime: .NET net6.0 ThirdParty/UnityEngine/UnityEngine.csproj:4 — ThirdParty/UnityEngine/UnityEngine.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
  • End-of-life runtime: .NET net6.0 Tools/App/Tools.App.csproj:5 — Tools/App/Tools.App.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
  • End-of-life runtime: .NET net6.0 Tools/FileServer/FileServer.csproj:4 — Tools/FileServer/FileServer.csproj declares .NET net6.0 as this project's target framework, and .NET 6 LTS, support ended 2024-11-12. An unsupported runtime receives no security patches, so every vulnerability disclosed in it since 2024-11-12 is present and unfixable without moving off it. This is a migration rather than an upgrade: there is no newer release of a runtime that has ended.
D4 · Code Duplication · Duplicated block (8 lines × 2) · ×10
  • Duplicated block (8 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:931 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:931-938 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:972-979 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:931` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:65 — Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:65-72 | Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:79-86 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:65` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (8 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:13 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:13-20 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:31-38 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8 lines × 2) Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:13 — Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:13-21 | Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:48-55 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:13` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (8 lines × 2) Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:30 — Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:30-38 | Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:63-70 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:30` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (8 lines × 2) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffBleedComponentSystem.cs:60 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffBleedComponentSystem.cs:60-67 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Event/OnSkillTrigger_OnSkillTrigger.cs:92-100 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffBleedComponentSystem.cs:60` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (8 lines × 2) Tools/App/Apps/ChapterExporter/ChapterExporter.cs:95 — Tools/App/Apps/ChapterExporter/ChapterExporter.cs:95-102 | Tools/App/Apps/ExcelExporter/ExcelExporter.cs:548-555 — `Tools/App/Apps/ChapterExporter/ChapterExporter.cs` and `Tools/App/Apps/ExcelExporter/ExcelExporter.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 4 separate duplicated blocks between them, totalling at least 80 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `Tools/App/Apps/ChapterExporter/ChapterExporter.cs:95` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (8 lines × 2) ThirdParty/UnityEngine/Quaternion.cs:472 — ThirdParty/UnityEngine/Quaternion.cs:472-479 | ThirdParty/UnityEngine/Quaternion.cs:515-522 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ThirdParty/UnityEngine/Quaternion.cs:472` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `matrix` to `Matrix4x4` in one and `ref Matrix4x4` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (8 lines × 2) ThirdParty/UnityEngine/Quaternion.cs:483 — ThirdParty/UnityEngine/Quaternion.cs:483-490 | ThirdParty/UnityEngine/Quaternion.cs:524-531 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ThirdParty/UnityEngine/Quaternion.cs:483` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `matrix` to `Matrix4x4` in one and `ref Matrix4x4` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (8 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:1182 — ThirdParty/UnityEngine/Matrix4x4.cs:1182-1189 | ThirdParty/UnityEngine/Matrix4x4.cs:1200-1207 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `matrix` to `Matrix4x4` in one and `ref Matrix4x4` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (6 lines × 2) · ×9
  • Duplicated block (6 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:338 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:338-343 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1106-1111 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:327 — Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:327-332 | Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:168-173 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (6 lines × 2) Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:71 — Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:71-76 | Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:113-118 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:71` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:85 — Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:85-90 | Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:99-104 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:85` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (6 lines × 2) Server/Hotfix/Demo/Unit/UnitFactory.cs:130 — Server/Hotfix/Demo/Unit/UnitFactory.cs:130-135 | Unity/Codes/Hotfix/Demo/Unit/UnitFactory.cs:123-128 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (6 lines × 2) ThirdParty/UnityEngine/Quaternion.cs:494 — ThirdParty/UnityEngine/Quaternion.cs:494-499 | ThirdParty/UnityEngine/Quaternion.cs:535-540 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `matrix` to `Matrix4x4` in one and `ref Matrix4x4` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (6 lines × 2) ThirdParty/UnityEngine/Vector3.cs:299 — ThirdParty/UnityEngine/Vector3.cs:299-304 | ThirdParty/UnityEngine/Vector3.cs:317-322 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ThirdParty/UnityEngine/Vector3.cs:317` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (6 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:1216 — ThirdParty/UnityEngine/Matrix4x4.cs:1216-1221 | ThirdParty/UnityEngine/Matrix4x4.cs:1231-1236 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `matrix` to `Matrix4x4` in one and `ref Matrix4x4` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (6 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:1254 — ThirdParty/UnityEngine/Matrix4x4.cs:1254-1259 | ThirdParty/UnityEngine/Matrix4x4.cs:1269-1274 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `direction` to `Vector3` in one and `ref Vector3` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (7 lines × 2) · ×9
  • Duplicated block (7 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:572 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:572-578 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:626-632 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:572` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SkillStepComponentSystem.cs:38 — Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SkillStepComponentSystem.cs:38-44 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SkillStepComponentSystem.cs:70-76 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SkillStepComponentSystem.cs:38` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) Unity/Codes/Hotfix/Module/Recast/PathfindingComponentSystem.cs:85 — Unity/Codes/Hotfix/Module/Recast/PathfindingComponentSystem.cs:85-91 | Unity/Codes/Hotfix/Module/Recast/PathfindingComponentSystem.cs:137-143 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/Recast/PathfindingComponentSystem.cs:85` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
  • Duplicated block (7 lines × 2) Server/Hotfix/Module/DB/DBComponentSystem.cs:91 — Server/Hotfix/Module/DB/DBComponentSystem.cs:91-97 | Server/Hotfix/Module/DB/DBComponentSystem.cs:101-107 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (7 lines × 2) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SpellComponentSystem.cs:180 — Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SpellComponentSystem.cs:180-186 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SpellComponentSystem.cs:207-213 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SpellComponentSystem.cs:180` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:51 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:51-57 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:106-113 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:51` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (7 lines × 2) ThirdParty/UnityEngine/Vector3.cs:179 — ThirdParty/UnityEngine/Vector3.cs:179-185 | ThirdParty/UnityEngine/Vector4.cs:171-177 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Read the line range as the matched WINDOW rather than a finished unit: at `ThirdParty/UnityEngine/Vector3.cs:179` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `result` to `out Vector3` in one and `out Vector4` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (7 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:701 — ThirdParty/UnityEngine/Matrix4x4.cs:701-707 | ThirdParty/UnityEngine/Matrix4x4.cs:717-723 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (7 lines × 2) ThirdParty/UnityEngine/Vector4.cs:265 — ThirdParty/UnityEngine/Vector4.cs:265-271 | ThirdParty/UnityEngine/Vector4.cs:285-291 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ThirdParty/UnityEngine/Vector4.cs:285` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The `return` at the foot of the matched lines is the enclosing body's own terminal exit, not an early one: it moves with them unchanged, and each site calls the extracted unit from the position that `return` occupied — no decision has to be handed back and re-acted on.
D4 · Code Duplication · Duplicated block (11 lines × 2) · ×8
  • Duplicated block (11 lines × 2) Server/Hotfix/Module/DB/DBComponentSystem.cs:132 — Server/Hotfix/Module/DB/DBComponentSystem.cs:132-142 | Server/Hotfix/Module/DB/DBComponentSystem.cs:152-162 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (11 lines × 2) Server/Model/Generate/Message/InnerMessage.cs:305 — Server/Model/Generate/Message/InnerMessage.cs:305-315 | Server/Model/Generate/Message/InnerMessage.cs:323-333 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (11 lines × 2) Server/Model/Generate/Message/MongoMessage.cs:29 — Server/Model/Generate/Message/MongoMessage.cs:29-39 | Server/Model/Generate/Message/MongoMessage.cs:48-58 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Server/Model/Generate/Message/MongoMessage.cs:43` calls `ResponseType`, `nameof` and `Server/Model/Generate/Message/MongoMessage.cs:62` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) Server/Model/Generate/Message/MongoMessage.cs:66 — Server/Model/Generate/Message/MongoMessage.cs:66-76 | Server/Model/Generate/Message/MongoMessage.cs:87-97 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Server/Model/Generate/Message/MongoMessage.cs:78` calls `ProtoMember` and `Server/Model/Generate/Message/MongoMessage.cs:99` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) Unity/Codes/Model/Core/Entity/Scene.cs:26 — Unity/Codes/Model/Core/Entity/Scene.cs:26-36 | Unity/Codes/Model/Core/Entity/Scene.cs:41-51 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Model/Core/Entity/Scene.cs:26` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) Server/Model/Generate/Message/InnerMessage.cs:509 — Server/Model/Generate/Message/InnerMessage.cs:509-519 | Server/Model/Generate/Message/OuterMessage.cs:611-621 — before extracting anything, compare `Server/Model/Generate/Message/InnerMessage.cs` and `Server/Model/Generate/Message/OuterMessage.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 155 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Server/Model/Generate/Message/InnerMessage.cs:506` calls `ProtoMember` and `Server/Model/Generate/Message/OuterMessage.cs:610` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 2) Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:68 — Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:68-78 | Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:88-98 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:68` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (11 lines × 2) Server/Hotfix/Demo/Session/SessionStreamDispatcherServerOuter.cs:12 — Server/Hotfix/Demo/Session/SessionStreamDispatcherServerOuter.cs:12-22 | Unity/Codes/Hotfix/Demo/Session/SessionStreamDispatcherClientOuter.cs:11-21 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
D4 · Code Duplication · Duplicated block (5 lines × 2) · ×8
  • Duplicated block (5 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:471 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:471-475 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:518-522 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (5 lines × 2) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:92 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:92-96 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:208-212 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:92` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:133 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:133-137 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:224-228 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:133` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) Unity/Codes/Hotfix/Module/Config/ConfigComponentSystem.cs:51 — Unity/Codes/Hotfix/Module/Config/ConfigComponentSystem.cs:51-55 | Unity/Codes/Hotfix/Module/Config/ConfigComponentSystem.cs:65-69 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Unity/Codes/Hotfix/Module/Config/ConfigComponentSystem.cs:71` calls `Create` and `Unity/Codes/Hotfix/Module/Config/ConfigComponentSystem.cs:57` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (5 lines × 2) ThirdParty/UnityEngine/Quaternion.cs:461 — ThirdParty/UnityEngine/Quaternion.cs:461-465 | ThirdParty/UnityEngine/Quaternion.cs:506-510 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ThirdParty/UnityEngine/Quaternion.cs:461` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `ThirdParty/UnityEngine/Quaternion.cs:460` calls `Quaternion` and `ThirdParty/UnityEngine/Quaternion.cs:505` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (5 lines × 2) Server/Hotfix/Demo/Battle/Event/M2M_DamageHandler.cs:9 — Server/Hotfix/Demo/Battle/Event/M2M_DamageHandler.cs:9-13 | Unity/Codes/Hotfix/Demo/Battle/M2C_DamageHandler.cs:9-13 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Hotfix/Demo/Battle/Event/M2M_DamageHandler.cs:9` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `M2M_Damage` in one and `M2C_Damage` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (5 lines × 2) ThirdParty/UnityEngine/Quaternion.cs:618 — ThirdParty/UnityEngine/Quaternion.cs:618-622 | ThirdParty/UnityEngine/Quaternion.cs:661-665 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ThirdParty/UnityEngine/Quaternion.cs:618` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 2) ThirdParty/UnityEngine/Vector4.cs:275 — ThirdParty/UnityEngine/Vector4.cs:275-279 | ThirdParty/UnityEngine/Vector4.cs:297-301 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ThirdParty/UnityEngine/Vector4.cs:297` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Edited copy of a member (5 corresponding lines) · ×7
  • Edited copy of a member (5 corresponding lines) ThirdParty/UnityEngine/Mathf.cs:567 — Unity/Assets/Mono/Core/Helper/RandomHelper.cs:11-15 | ThirdParty/UnityEngine/Mathf.cs:567-571 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:241 — ThirdParty/UnityEngine/Vector3.cs:241-245 | ThirdParty/UnityEngine/Vector3.cs:257-261 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:51 — ThirdParty/UnityEngine/Vector3.cs:51-55 | ThirdParty/UnityEngine/Vector4.cs:55-59 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:394 — ThirdParty/UnityEngine/Vector3.cs:394-398 | ThirdParty/UnityEngine/Vector4.cs:381-386 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:426 — ThirdParty/UnityEngine/Vector3.cs:426-430 | ThirdParty/UnityEngine/Vector4.cs:417-422 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:458 — ThirdParty/UnityEngine/Vector3.cs:458-462 | ThirdParty/UnityEngine/Vector4.cs:453-458 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (5 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:442 — ThirdParty/UnityEngine/Vector3.cs:442-446 | ThirdParty/UnityEngine/Vector4.cs:435-440 — These two members are one piece of code written twice and then edited apart: 5 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (9 lines × 2) · ×7
  • Duplicated block (9 lines × 2) Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs:151 — Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs:151-159 | Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs:170-178 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs:151` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:259 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:259-267 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:582-590 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:259` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
  • Duplicated block (9 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:771 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:771-779 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:789-797 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:771` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (9 lines × 2) Tools/App/Apps/ChapterExporter/ChapterExporter.cs:96 — Tools/App/Apps/ChapterExporter/ChapterExporter.cs:96-104 | Tools/App/Apps/I18NExporter/I18NExporter.cs:83-91 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `Tools/App/Apps/ChapterExporter/ChapterExporter.cs:96` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (9 lines × 2) REDACTED:228 — REDACTED:228-236 | REDACTED:296-304 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `REDACTED:238` calls `ConvertType` and `REDACTED:306` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (9 lines × 2) Server/Hotfix/Demo/Battle/BattleHelper.cs:10 — Server/Hotfix/Demo/Battle/BattleHelper.cs:10-18 | Unity/Codes/Hotfix/Demo/Battle/BattleHelper.cs:23-31 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice.
  • Duplicated block (9 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:340 — ThirdParty/UnityEngine/Matrix4x4.cs:340-348 | ThirdParty/UnityEngine/Matrix4x4.cs:354-362 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (17 lines × 2) · ×6
  • Duplicated block (17 lines × 2) Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs:38 — Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs:38-54 | Server/Hotfix/Module/Router/RouterServiceInnerComponentSystem.cs:47-63 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from both call sites, so a change lands once. Note first that the copies are not typed on the same thing: the declarations holding them bind `self` to `this RouterServiceComponent` in one and `this RouterServiceInnerComponent` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (17 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:886 — ThirdParty/UnityEngine/Matrix4x4.cs:886-902 | ThirdParty/UnityEngine/Matrix4x4.cs:948-964 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `matrix` to `Matrix4x4` in one and `ref Matrix4x4` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (17 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:370 — ThirdParty/UnityEngine/Matrix4x4.cs:370-386 | ThirdParty/UnityEngine/Matrix4x4.cs:394-410 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `cameraPosition` to `Vector3` in one and `ref Vector3` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (17 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:491 — ThirdParty/UnityEngine/Matrix4x4.cs:491-507 | ThirdParty/UnityEngine/Matrix4x4.cs:514-530 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (17 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:537 — ThirdParty/UnityEngine/Matrix4x4.cs:537-553 | ThirdParty/UnityEngine/Matrix4x4.cs:560-576 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (17 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:583 — ThirdParty/UnityEngine/Matrix4x4.cs:583-599 | ThirdParty/UnityEngine/Matrix4x4.cs:606-622 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
X1 · Async correctness · Blocking `File.ReadAllBytes` inside an `async` method · ×6
  • Blocking `File.ReadAllBytes` inside an `async` method Server/Model/Config/ConfigLoader.cs:14 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
  • Blocking `File.ReadAllBytes` inside an `async` method Server/Model/Config/ConfigLoader.cs:16 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
  • Blocking `File.ReadAllBytes` inside an `async` method Server/Model/Config/ConfigLoader.cs:17 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
  • Blocking `File.ReadAllBytes` inside an `async` method Server/Model/Config/ConfigLoader.cs:18 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
  • Blocking `File.ReadAllBytes` inside an `async` method Server/Model/Config/ConfigLoader.cs:19 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
  • Blocking `File.ReadAllBytes` inside an `async` method Server/Model/Config/ConfigLoader.cs:25 — `File.ReadAllBytes` blocks the thread on I/O while `File.ReadAllBytesAsync` exists to wait without one — inside a method that is already `async`, await the twin.
D4 · Code Duplication · Edited copy of a member (21 corresponding lines) · ×5
  • Edited copy of a member (21 corresponding lines) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Condition/ConditionWatcherComponent.cs:29 — Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Condition/ConditionWatcherComponent.cs:29-49 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Event/SkillWatcherComponentSystem.cs:29-49 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:93 — Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:93-113 | Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:121-142 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) Unity/Codes/Hotfix/Module/Recast/PathfindingComponentSystem.cs:71 — Unity/Codes/Hotfix/Module/Recast/PathfindingComponentSystem.cs:71-91 | Unity/Codes/Hotfix/Module/Recast/PathfindingComponentSystem.cs:123-143 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) Unity/Codes/Model/Core/Object/Entity.cs:584 — Unity/Codes/Model/Core/Object/Entity.cs:584-604 | Unity/Codes/Model/Core/Object/Entity.cs:607-632 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (21 corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:366 — ThirdParty/UnityEngine/Matrix4x4.cs:366-388 | ThirdParty/UnityEngine/Matrix4x4.cs:391-411 — These two members are one piece of code written twice and then edited apart: 21 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (13 corresponding lines) · ×5
  • Edited copy of a member (13 corresponding lines) Unity/Codes/Model/Core/Entity/Scene.cs:24 — Unity/Codes/Model/Core/Entity/Scene.cs:24-36 | Unity/Codes/Model/Core/Entity/Scene.cs:39-51 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:12 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:12-24 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:30-42 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) Unity/Codes/Hotfix/Module/AOI/AOISceneComponentSystem.cs:145 — Unity/Codes/Hotfix/Module/AOI/AOISceneComponentSystem.cs:145-157 | Unity/Codes/Hotfix/Module/AOI/AOISceneComponentSystem.cs:185-198 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/Event/BuffWatcher_Chant.cs:9 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/Event/BuffWatcher_Chant.cs:9-21 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/Event/BuffWatcher_Chant.cs:33-45 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (13 corresponding lines) Unity/Codes/Model/Core/Object/ObjectPool.cs:17 — Unity/Codes/Model/Core/Object/ObjectPool.cs:17-30 | Unity/Codes/Model/Core/Object/ObjectPool.cs:33-45 — These two members are one piece of code written twice and then edited apart: 13 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (6 corresponding lines) · ×5
  • Edited copy of a member (6 corresponding lines) Unity/Codes/Hotfix/Module/AOI/Event/ChangePosition_MoveAOIUnit.cs:8 — Unity/Codes/Hotfix/Module/AOI/Event/ChangePosition_MoveAOIUnit.cs:8-13 | Unity/Codes/Hotfix/Module/AOI/Event/ChangeRotation_TurnAOIUnit.cs:8-13 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) ThirdParty/UnityEngine/Vector2.cs:276 — ThirdParty/UnityEngine/Vector2.cs:276-283 | ThirdParty/UnityEngine/Vector2.cs:286-291 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:852 — ThirdParty/UnityEngine/Quaternion.cs:852-857 | ThirdParty/UnityEngine/Quaternion.cs:860-865 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:475 — ThirdParty/UnityEngine/Vector3.cs:475-480 | ThirdParty/UnityEngine/Vector4.cs:472-478 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (6 corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:728 — ThirdParty/UnityEngine/Quaternion.cs:728-733 | ThirdParty/UnityEngine/Vector4.cs:363-368 — These two members are one piece of code written twice and then edited apart: 6 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (19 lines × 2) · ×5
  • Duplicated block (19 lines × 2) Server/Model/Generate/Message/InnerMessage.cs:366 — Server/Model/Generate/Message/InnerMessage.cs:366-384 | Server/Model/Generate/Message/OuterMessage.cs:252-270 — before extracting anything, compare `Server/Model/Generate/Message/InnerMessage.cs` and `Server/Model/Generate/Message/OuterMessage.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 155 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Server/Model/Generate/Message/InnerMessage.cs:362` calls `ProtoMember` and `Server/Model/Generate/Message/OuterMessage.cs:250` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (19 lines × 2) Tools/App/Apps/ChapterExporter/ChapterExporter.cs:25 — Tools/App/Apps/ChapterExporter/ChapterExporter.cs:25-43 | Tools/App/Apps/I18NExporter/I18NExporter.cs:18-36 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `Tools/App/Apps/ChapterExporter/ChapterExporter.cs:25` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (19 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:1008 — ThirdParty/UnityEngine/Matrix4x4.cs:1008-1026 | ThirdParty/UnityEngine/Matrix4x4.cs:1332-1350 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (19 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:1050 — ThirdParty/UnityEngine/Matrix4x4.cs:1050-1068 | ThirdParty/UnityEngine/Matrix4x4.cs:1354-1372 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
  • Duplicated block (19 lines × 2) ThirdParty/UnityEngine/Quaternion.cs:801 — ThirdParty/UnityEngine/Quaternion.cs:801-819 | ThirdParty/UnityEngine/Quaternion.cs:879-897 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `quaternion1` to `Quaternion` in one and `ref Quaternion` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (13 lines × 2) · ×5
  • Duplicated block (13 lines × 2) Server/Model/Module/Actor/AMActorHandler.cs:12 — Server/Model/Module/Actor/AMActorHandler.cs:12-24 | Server/Model/Module/ActorLocation/AMActorLocationHandler.cs:12-24 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Server/Model/Module/ActorLocation/AMActorLocationHandler.cs:26` calls `CreateInstance`, `GetResponseType`, `Invoke` and `Server/Model/Module/Actor/AMActorHandler.cs:26` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (13 lines × 2) Robot/App/Program.cs:14 — Robot/App/Program.cs:14-26 | Tools/App/Program.cs:12-24 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `Robot/App/Program.cs:14` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Robot/App/Program.cs:27` calls `Add`, `GetHotfixAssembly` and `Tools/App/Program.cs:26` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (13 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:916 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:916-928 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:932-944 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:916` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) Tools/App/Apps/ChapterExporter/ChapterExporter.cs:79 — Tools/App/Apps/ChapterExporter/ChapterExporter.cs:79-91 | Tools/App/Apps/ExcelExporter/ExcelExporter.cs:531-543 — `Tools/App/Apps/ChapterExporter/ChapterExporter.cs` and `Tools/App/Apps/ExcelExporter/ExcelExporter.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 4 separate duplicated blocks between them, totalling at least 80 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `Tools/App/Apps/ChapterExporter/ChapterExporter.cs:79` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (13 lines × 2) Server/Hotfix/Demo/Battle/Event/M2M_RemoveBuffHandler.cs:11 — Server/Hotfix/Demo/Battle/Event/M2M_RemoveBuffHandler.cs:11-23 | Unity/Codes/Hotfix/Demo/Battle/M2C_RemoveBuffHander.cs:10-22 — before extracting anything, compare `Server/Hotfix/Demo/Battle/Event/M2M_RemoveBuffHandler.cs` and `Unity/Codes/Hotfix/Demo/Battle/M2C_RemoveBuffHander.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 33 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `M2M_RemoveBuff` in one and `M2C_RemoveBuff` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (10 lines × 2) · ×5
  • Duplicated block (10 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:490 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:490-499 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:537-546 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (10 lines × 2) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:143 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:143-152 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:182-191 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:143` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (10 lines × 2) Server/Hotfix/Demo/Unit/UnitFactory.cs:29 — Server/Hotfix/Demo/Unit/UnitFactory.cs:29-38 | Server/Hotfix/Demo/Unit/UnitFactory.cs:78-87 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Hotfix/Demo/Unit/UnitFactory.cs:29` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (10 lines × 2) ThirdParty/UnityEngine/Mathf.cs:531 — ThirdParty/UnityEngine/Mathf.cs:531-540 | ThirdParty/UnityEngine/Mathf.cs:547-556 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (10 lines × 2) Tools/App/Apps/ChapterExporter/ChapterExporter.cs:66 — Tools/App/Apps/ChapterExporter/ChapterExporter.cs:66-75 | Tools/App/Apps/ExcelExporter/ExcelExporter.cs:518-527 — `Tools/App/Apps/ChapterExporter/ChapterExporter.cs` and `Tools/App/Apps/ExcelExporter/ExcelExporter.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 4 separate duplicated blocks between them, totalling at least 80 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `Tools/App/Apps/ChapterExporter/ChapterExporter.cs:66` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Edited copies of one member (3 members, 7+ corresponding lines) · ×5
  • Edited copies of one member (3 members, 7+ corresponding lines) ThirdParty/UnityEngine/Vector2.cs:192 — ThirdParty/UnityEngine/Vector2.cs:192-198 | ThirdParty/UnityEngine/Vector3.cs:212-220 | ThirdParty/UnityEngine/Vector3.cs:223-229 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 7+ corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:736 — ThirdParty/UnityEngine/Quaternion.cs:736-743 | ThirdParty/UnityEngine/Vector3.cs:401-407 | ThirdParty/UnityEngine/Vector4.cs:389-396 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 7+ corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:868 — ThirdParty/UnityEngine/Quaternion.cs:868-875 | ThirdParty/UnityEngine/Vector3.cs:605-611 | ThirdParty/UnityEngine/Vector4.cs:515-522 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 7+ corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:718 — ThirdParty/UnityEngine/Quaternion.cs:718-725 | ThirdParty/UnityEngine/Vector3.cs:369-375 | ThirdParty/UnityEngine/Vector4.cs:353-360 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 7+ corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:842 — ThirdParty/UnityEngine/Quaternion.cs:842-849 | ThirdParty/UnityEngine/Vector3.cs:577-583 | ThirdParty/UnityEngine/Vector4.cs:481-488 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
SC1 · Supply-chain hygiene · NuGet dependencies are not locked · ×5
  • NuGet dependencies are not locked ThirdParty/ShareLib/ShareLib.csproj:64 — ThirdParty/ShareLib/ShareLib.csproj declares NuGet packages that no committed packages.lock.json resolves and no central package management pins — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
  • NuGet dependencies are not locked Tools/Analyzer/Analyzer.csproj:20 — Tools/Analyzer/Analyzer.csproj declares NuGet packages that no committed packages.lock.json resolves and no central package management pins — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
  • NuGet dependencies are not locked Unity/Assets/ThirdParty/protobuf-net/protobuf-net.csproj:66 — Unity/Assets/ThirdParty/protobuf-net/protobuf-net.csproj declares NuGet packages that no committed packages.lock.json resolves and no central package management pins — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
  • NuGet dependencies are not locked Unity/Unity.RenderPipeline.Universal.ShaderLibrary.csproj:311 — Unity/Unity.RenderPipeline.Universal.ShaderLibrary.csproj declares NuGet packages that no committed packages.lock.json resolves and no central package management pins — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
  • NuGet dependencies are not locked Unity/Unity.RenderPipelines.Universal.Runtime.csproj:420 — Unity/Unity.RenderPipelines.Universal.Runtime.csproj declares NuGet packages that no committed packages.lock.json resolves and no central package management pins — restores aren't reproducible or pinned (SSDF PW.4.4). Enable <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile> (commit the lockfile) or adopt Directory.Packages.props. Advisory — never scored.
D4 · Code Duplication · Edited copy of a member (15 corresponding lines) · ×4
  • Edited copy of a member (15 corresponding lines) Unity/Codes/Hotfix/Module/Router/GetRouterComponentAwakeSystem.cs:11 — Unity/Assets/Mono/Module/Network/KService.cs:128-143 | Unity/Codes/Hotfix/Module/Router/GetRouterComponentAwakeSystem.cs:11-25 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) Unity/Codes/Model/Core/Object/EventSystem.cs:667 — Unity/Codes/Model/Core/Object/EventSystem.cs:667-684 | Unity/Codes/Model/Core/Object/EventSystem.cs:688-702 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) Server/Hotfix/Demo/Move/Event/M2M_PathfindingResultHandler.cs:9 — Server/Hotfix/Demo/Move/Event/M2M_PathfindingResultHandler.cs:9-31 | Unity/Codes/Hotfix/Demo/Move/M2C_PathfindingResultHandler.cs:10-24 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (15 corresponding lines) Server/Hotfix/Demo/Session/SessionStreamDispatcherServerOuter.cs:11 — Server/Hotfix/Demo/Session/SessionStreamDispatcherServerOuter.cs:11-25 | Unity/Codes/Hotfix/Demo/Session/SessionStreamDispatcherClientOuter.cs:10-24 — These two members are one piece of code written twice and then edited apart: 15 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (4 corresponding lines) · ×4
  • Edited copy of a member (4 corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:98 — ThirdParty/UnityEngine/Quaternion.cs:98-101 | ThirdParty/UnityEngine/Quaternion.cs:104-107 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:545 — ThirdParty/UnityEngine/Quaternion.cs:545-548 | ThirdParty/UnityEngine/Quaternion.cs:551-554 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:139 — ThirdParty/UnityEngine/Vector3.cs:139-142 | ThirdParty/UnityEngine/Vector4.cs:134-137 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (4 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:133 — ThirdParty/UnityEngine/Vector3.cs:133-136 | ThirdParty/UnityEngine/Vector4.cs:128-131 — These two members are one piece of code written twice and then edited apart: 4 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
GD1 · Unfinished & placeholder code · Unfinished stub · ×4
  • Unfinished stub — throws NotImplementedException Unity/Assets/Mono/Module/NetworkTCP/WService.cs:125 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException Unity/Assets/Mono/Module/Network/Circularbuffer.cs:265 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException Unity/Assets/Mono/Module/Network/Circularbuffer.cs:270 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException Unity/Assets/Mono/Module/Network/Circularbuffer.cs:275 — A shipped member still throws NotImplementedException — generated scaffolding that was never completed. Implement it or remove the dead surface.
D17 · Explicit Debt · TodoComment · ×3
  • TodoComment Server/Hotfix/Module/Router/RouterServiceInnerComponentSystem.cs:130 — //todo: 这里发送失败的话应该主动给服务端发一条FIN消息.免得服务端继续发消息 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:155 — //todo:倒计时拉回复活点 — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
  • TodoComment Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:201 — //todo: — source code is not a task system: move the work to your tracker and leave a reference instead (e.g. `// REF: #123`), so the task is planned where tasks live and the ticket links back to the code.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
  • REDACTED
D3 · God Classes · MethodTooLong · ×3
  • MethodTooLong: AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:872 — MethodTooLong — AfterTriggerChangeRotationBroadcastToMe runs 117 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 17 over it, 1.17× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AOITriggerSystem.AfterColliderChangeBroadcastToOther Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1088 — MethodTooLong — AfterColliderChangeBroadcastToOther runs 110 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 10 over it, 1.10× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
  • MethodTooLong: AOITriggerSystem.AfterTriggerChangeBroadcastToMe Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:661 — MethodTooLong — AfterTriggerChangeBroadcastToMe runs 104 significant lines (blank, comment-only and punctuation-only lines excluded) in one body. The bar is 100 significant lines; this is 4 over it, 1.04× the bar. This is length, not branching: a long straight-line body scores low on complexity and is still read whole to change any part of it, so the complexity numbers beside this row neither confirm nor excuse it. To reduce it, extract each cohesive step of the body — the runs of statements that work on the same values and would earn the same name — into its own named unit, and have this one call them in order.
D4 · Code Duplication · Edited copy of a member (23 corresponding lines) · ×3
  • Edited copy of a member (23 corresponding lines) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SpellComponentSystem.cs:130 — Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SpellComponentSystem.cs:130-156 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SpellComponentSystem.cs:164-186 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (23 corresponding lines) Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:287 — Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:287-309 | Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:320-342 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (23 corresponding lines) Unity/Codes/Model/Module/Battle/Combat/Skill/Step/StepPara.cs:27 — Unity/Codes/Model/Module/Battle/Combat/Skill/Step/StepPara.cs:27-49 | Unity/Codes/Model/Module/Battle/Combat/Skill/Step/StepPara.cs:51-73 — These two members are one piece of code written twice and then edited apart: 23 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (19 corresponding lines) · ×3
  • Edited copy of a member (19 corresponding lines) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Event/SkillWatcher_AddBuff.cs:10 — Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Event/SkillWatcher_AddBuff.cs:10-29 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Event/SkillWatcher_RemoveBuff.cs:10-28 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:223 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:223-242 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:250-268 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (19 corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:754 — ThirdParty/UnityEngine/Quaternion.cs:754-775 | ThirdParty/UnityEngine/Quaternion.cs:900-918 — These two members are one piece of code written twice and then edited apart: 19 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (18 corresponding lines) · ×3
  • Edited copy of a member (18 corresponding lines) Server/Hotfix/Module/DB/DBComponentSystem.cs:131 — Server/Hotfix/Module/DB/DBComponentSystem.cs:131-148 | Server/Hotfix/Module/DB/DBComponentSystem.cs:151-168 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) Unity/Codes/Model/Core/Object/Entity.cs:829 — Unity/Codes/Model/Core/Object/Entity.cs:829-846 | Unity/Codes/Model/Core/Object/Entity.cs:849-866 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (18 corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:813 — ThirdParty/UnityEngine/Matrix4x4.cs:813-832 | ThirdParty/UnityEngine/Matrix4x4.cs:835-852 — These two members are one piece of code written twice and then edited apart: 18 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (9 corresponding lines) · ×3
  • Edited copy of a member (9 corresponding lines) Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:12 — Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:12-20 | Unity/Codes/Hotfix/Module/Message/NetKcpComponentSystem.cs:28-37 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) Unity/Codes/Model/Core/Object/Entity.cs:907 — Unity/Codes/Model/Core/Object/Entity.cs:907-915 | Unity/Codes/Model/Core/Object/Entity.cs:918-926 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (9 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:145 — ThirdParty/UnityEngine/Vector3.cs:145-153 | ThirdParty/UnityEngine/Vector4.cs:140-150 — These two members are one piece of code written twice and then edited apart: 9 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (12 corresponding lines) · ×3
  • Edited copy of a member (12 corresponding lines) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffWatcherComponentSystem.cs:143 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffWatcherComponentSystem.cs:143-154 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffWatcherComponentSystem.cs:157-168 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:165 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:165-177 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:244-255 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (12 corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:1303 — ThirdParty/UnityEngine/Matrix4x4.cs:1303-1314 | ThirdParty/UnityEngine/Matrix4x4.cs:1317-1328 — These two members are one piece of code written twice and then edited apart: 12 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (10 lines × 4) · ×3
  • Duplicated block (10 lines × 4) Server/Model/Generate/Message/InnerMessage.cs:366 — Server/Model/Generate/Message/InnerMessage.cs:366-375 | Server/Model/Generate/Message/InnerMessage.cs:399-408 | Server/Model/Generate/Message/OuterMessage.cs:252-261 | Server/Model/Generate/Message/OuterMessage.cs:282-291 — before extracting anything, compare `Server/Model/Generate/Message/InnerMessage.cs` and `Server/Model/Generate/Message/OuterMessage.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 155 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Server/Model/Generate/Message/InnerMessage.cs:362` calls `ProtoMember` and `Server/Model/Generate/Message/OuterMessage.cs:250` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 4) Server/Model/Generate/Message/InnerMessage.cs:366 — Server/Model/Generate/Message/InnerMessage.cs:366-375 | Server/Model/Generate/Message/InnerMessage.cs:399-408 | Server/Model/Generate/Message/OuterMessage.cs:282-291 | Server/Model/Generate/Message/OuterMessage.cs:525-534 — before extracting anything, compare `Server/Model/Generate/Message/InnerMessage.cs` and `Server/Model/Generate/Message/OuterMessage.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 155 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
  • Duplicated block (10 lines × 4) Unity/Codes/Hotfix/Demo/Battle/M2C_AddBuffHandler.cs:8 — Unity/Codes/Hotfix/Demo/Battle/M2C_AddBuffHandler.cs:8-17 | Unity/Codes/Hotfix/Demo/Battle/M2C_ChangeSkillGroupHandler.cs:9-18 | Unity/Codes/Hotfix/Demo/Battle/M2C_InterruptHandler.cs:10-19 | Unity/Codes/Hotfix/Demo/Battle/M2C_RemoveBuffHander.cs:8-17 — before extracting anything, compare `Unity/Codes/Hotfix/Demo/Battle/M2C_AddBuffHandler.cs` and `Unity/Codes/Hotfix/Demo/Battle/M2C_RemoveBuffHander.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 30 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Demo/Battle/M2C_AddBuffHandler.cs:8` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `M2C_AddBuff` in one and `M2C_ChangeSkillGroup` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (12 lines × 2) · ×3
  • Duplicated block (12 lines × 2) Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:288 — Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:288-299 | Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:321-332 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/AOICellSystem.cs:288` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
  • Duplicated block (12 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:911 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:911-922 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:947-958 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:911` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:908` calls `Create` and `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:945` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (12 lines × 2) Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs:11 — Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs:11-22 | Unity/Codes/Hotfix/Demo/Battle/M2C_AddBuffHandler.cs:10-21 — before extracting anything, compare `Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs` and `Unity/Codes/Hotfix/Demo/Battle/M2C_AddBuffHandler.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `M2M_AddBuff` in one and `M2C_AddBuff` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (10 lines × 3) · ×3
  • Duplicated block (10 lines × 3) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:727 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:727-736 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:891-900 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1141-1150 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:727` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:888` calls `GetRealPos` and `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:722` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 3) Server/Model/Generate/Message/InnerMessage.cs:411 — Server/Model/Generate/Message/InnerMessage.cs:411-420 | Server/Model/Generate/Message/OuterMessage.cs:108-117 | Server/Model/Generate/Message/OuterMessage.cs:294-303 — before extracting anything, compare `Server/Model/Generate/Message/InnerMessage.cs` and `Server/Model/Generate/Message/OuterMessage.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 155 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Server/Model/Generate/Message/OuterMessage.cs:119` calls `ProtoMember` and `Server/Model/Generate/Message/InnerMessage.cs:422` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (10 lines × 3) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1162 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1162-1171 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1185-1194 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1207-1216 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1162` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (11 lines × 4) · ×3
  • Duplicated block (11 lines × 4) Server/Model/Generate/Message/MongoMessage.cs:29 — Server/Model/Generate/Message/MongoMessage.cs:29-39 | Server/Model/Generate/Message/MongoMessage.cs:48-58 | Server/Model/Generate/Message/MongoMessage.cs:66-76 | Server/Model/Generate/Message/MongoMessage.cs:87-97 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Server/Model/Generate/Message/MongoMessage.cs:43` calls `ResponseType`, `nameof` and `Server/Model/Generate/Message/MongoMessage.cs:62` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (11 lines × 4) Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs:10 — Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs:10-20 | Server/Hotfix/Demo/Battle/Event/M2M_RemoveBuffHandler.cs:10-20 | Unity/Codes/Hotfix/Demo/Battle/M2C_AddBuffHandler.cs:9-19 | Unity/Codes/Hotfix/Demo/Battle/M2C_RemoveBuffHander.cs:9-19 — before extracting anything, compare `Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs` and `Unity/Codes/Hotfix/Demo/Battle/M2C_AddBuffHandler.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs:10` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `M2M_AddBuff` in one and `M2M_RemoveBuff` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (11 lines × 4) Server/Hotfix/Demo/Battle/Event/M2M_ChangeSkillGroupHandler.cs:11 — Server/Hotfix/Demo/Battle/Event/M2M_ChangeSkillGroupHandler.cs:11-21 | Server/Hotfix/Demo/Battle/Event/M2M_InterruptHandler.cs:11-21 | Unity/Codes/Hotfix/Demo/Battle/M2C_ChangeSkillGroupHandler.cs:10-20 | Unity/Codes/Hotfix/Demo/Battle/M2C_InterruptHandler.cs:11-21 — before extracting anything, compare `Server/Hotfix/Demo/Battle/Event/M2M_ChangeSkillGroupHandler.cs` and `Unity/Codes/Hotfix/Demo/Battle/M2C_ChangeSkillGroupHandler.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 49 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Hotfix/Demo/Battle/Event/M2M_ChangeSkillGroupHandler.cs:11` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `M2M_ChangeSkillGroup` in one and `M2M_Interrupt` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Edited copy of a member (3 corresponding lines) · ×3
  • Edited copy of a member (3 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:71 — ThirdParty/UnityEngine/Vector3.cs:71-73 | ThirdParty/UnityEngine/Vector4.cs:75-78 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (3 corresponding lines) ThirdParty/UnityEngine/Vector3.cs:76 — ThirdParty/UnityEngine/Vector3.cs:76-78 | ThirdParty/UnityEngine/Vector4.cs:81-84 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (3 corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:93 — ThirdParty/UnityEngine/Quaternion.cs:93-95 | ThirdParty/UnityEngine/Vector4.cs:70-72 — These two members are one piece of code written twice and then edited apart: 3 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Duplicated block (16 lines × 2) · ×3
  • Duplicated block (16 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:233 — ThirdParty/UnityEngine/Matrix4x4.cs:233-248 | ThirdParty/UnityEngine/Matrix4x4.cs:262-277 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `position` to `Vector3` in one and `ref Vector3` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (16 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:283 — ThirdParty/UnityEngine/Matrix4x4.cs:283-298 | ThirdParty/UnityEngine/Matrix4x4.cs:319-334 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note first that the copies are not typed on the same thing: the declarations holding them bind `scales` to `Vector3` in one and `ref Vector3` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
  • Duplicated block (16 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:815 — ThirdParty/UnityEngine/Matrix4x4.cs:815-830 | ThirdParty/UnityEngine/Matrix4x4.cs:836-851 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Note what the matched lines are: every one of them assigns one field to another, so the block is a hand-written mapper between two data shapes rather than behaviour with a helper inside it. Extracting one shared function only works if both sites map the SAME pair of types in the same direction — check that first, because inverse or differently-typed mappers have no single function they can both call. Where they do not, the moves that exist are a generated or reflective mapper, a common embedded/base type the fields live on once, or accepting the run and covering it with a test that fails when a field is added to one side only. Note first that the copies are not typed on the same thing: the declarations holding them bind `matrix` to `Matrix4x4` in one and `ref Matrix4x4` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D5 · Coupling · Off the main sequence · ×3
  • Off the main sequence: UnityEngine ThirdParty/UnityEngine/UnityEngine.csproj:1 — UnityEngine: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 3 project(s), so it's rigid to change.
  • Off the main sequence: ETTask ThirdParty/ETTask/ETTask.csproj:1 — ETTask: abstractness 0.00, instability 0.00, distance 1.00 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
  • Off the main sequence: ShareLib ThirdParty/ShareLib/ShareLib.csproj:1 — ShareLib: abstractness 0.00, instability 0.25, distance 0.75 — zone of pain — concrete and depended on by 2 project(s), so it's rigid to change.
IC1 · Incompleteness & stubs · Empty method body · ×3
  • Empty method body — does nothing with its inputs Server/Hotfix/Demo/Unit/UnitComponentSystem.cs:20 — `Add` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
  • Empty method body — does nothing with its inputs Unity/Codes/Hotfix/Demo/Unit/UnitComponent.cs:21 — `Add` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
  • Empty method body — does nothing with its inputs Unity/Codes/Hotfix/Module/Message/NetThreadComponentSystem.cs:43 — `Stop` takes parameters but its body is empty — it accepts inputs and does nothing. Either implement it or remove it.
IC1 · Incompleteness & stubs · Unfinished branch · ×3
  • Unfinished branch — throws NotImplementedException Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/XR/XRPass.cs:167 — The branch `if (viewId >= views.Count)` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
  • Unfinished branch — throws NotImplementedException Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/XR/XRPass.cs:175 — The branch `if (viewId >= views.Count)` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
  • Unfinished branch — throws NotImplementedException Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/XR/XRSystem.cs:233 — The branch `if (displayList.Count > 1)` throws `NotImplementedException` while the member's other paths do the work — the branch was never written, so every input that reaches it fails at run time. Implement the branch, or reject the input where it enters with an exception that says it is not supported.
SC1 · Supply-chain hygiene · JavaScript dependencies are not locked · ×3
  • JavaScript dependencies are not locked Unity/Packages/com.tuyoogame.yooasset/package.json:38 — Unity/Packages/com.tuyoogame.yooasset/package.json declares dependencies that no committed lockfile resolves — there is no package-lock.json / yarn.lock / pnpm-lock.yaml / bun.lock beside it, and no locked workspace above it names it — so its installs aren't reproducible (SSDF PW.4.4). Commit its package manager's lockfile (or add it to the locked workspace) and install from it (`npm ci`, `yarn --immutable`, `pnpm i --frozen-lockfile` or `bun i --frozen-lockfile`). Advisory — never scored.
  • JavaScript dependencies are not locked Unity/Packages/com.unity.render-pipelines.universal@10.8.1/package.json:8 — Unity/Packages/com.unity.render-pipelines.universal@10.8.1/package.json declares dependencies that no committed lockfile resolves — there is no package-lock.json / yarn.lock / pnpm-lock.yaml / bun.lock beside it, and no locked workspace above it names it — so its installs aren't reproducible (SSDF PW.4.4). Commit its package manager's lockfile (or add it to the locked workspace) and install from it (`npm ci`, `yarn --immutable`, `pnpm i --frozen-lockfile` or `bun i --frozen-lockfile`). Advisory — never scored.
  • JavaScript dependencies are not locked Unity/Packages/com.unity.textmeshpro@3.0.6/package.json:16 — Unity/Packages/com.unity.textmeshpro@3.0.6/package.json declares dependencies that no committed lockfile resolves — there is no package-lock.json / yarn.lock / pnpm-lock.yaml / bun.lock beside it, and no locked workspace above it names it — so its installs aren't reproducible (SSDF PW.4.4). Commit its package manager's lockfile (or add it to the locked workspace) and install from it (`npm ci`, `yarn --immutable`, `pnpm i --frozen-lockfile` or `bun i --frozen-lockfile`). Advisory — never scored.
D1 · Cyclomatic Complexity · OBBComponentSystem.IsRayInTrigger (cyclomatic 65) · ×2
  • OBBComponentSystem.IsRayInTrigger (cyclomatic 65) Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:246 — OBBComponentSystem.IsRayInTrigger has cyclomatic complexity 65 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (OBBComponentSystem.IsRayInTrigger) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
  • OBBComponentSystem.IsRayInTrigger (cyclomatic 65) Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:413 — OBBComponentSystem.IsRayInTrigger has cyclomatic complexity 65 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top. This shape REPEATS in the file: one other method here (OBBComponentSystem.IsRayInTrigger) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · OBBComponentSystem.IsRayInTrigger (cognitive 92) · ×2
  • OBBComponentSystem.IsRayInTrigger (cognitive 92) Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:246 — OBBComponentSystem.IsRayInTrigger has cognitive complexity 92 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This shape REPEATS in the file: one other method here (OBBComponentSystem.IsRayInTrigger) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
  • OBBComponentSystem.IsRayInTrigger (cognitive 92) Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:413 — OBBComponentSystem.IsRayInTrigger has cognitive complexity 92 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This shape REPEATS in the file: one other method here (OBBComponentSystem.IsRayInTrigger) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D29 · Static Analysis (SAST) · REDACTED
  • REDACTED
  • REDACTED
D4 · Code Duplication · Edited copy of a member (33 corresponding lines) · ×2
  • Edited copy of a member (33 corresponding lines) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:142 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:142-174 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:181-214 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (33 corresponding lines) Unity/Codes/Model/Core/Object/Entity.cs:151 — Unity/Codes/Model/Core/Object/Entity.cs:151-183 | Unity/Codes/Model/Core/Object/Entity.cs:192-224 — These two members are one piece of code written twice and then edited apart: 33 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (17 corresponding lines) · ×2
  • Edited copy of a member (17 corresponding lines) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1495 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1495-1511 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1522-1539 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (17 corresponding lines) Server/Model/Module/Actor/AMActorHandler.cs:11 — Server/Model/Module/Actor/AMActorHandler.cs:11-27 | Server/Model/Module/ActorLocation/AMActorLocationHandler.cs:11-31 — These two members are one piece of code written twice and then edited apart: 17 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (25 corresponding lines) · ×2
  • Edited copy of a member (25 corresponding lines) Unity/Codes/Model/Core/Object/EventSystem.cs:431 — Unity/Codes/Model/Core/Object/EventSystem.cs:431-455 | Unity/Codes/Model/Core/Object/EventSystem.cs:457-481 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (25 corresponding lines) Tools/Analyzer/Analyzer/ClassDeclarationInHotfixAnalyzer.cs:39 — Tools/Analyzer/Analyzer/ClassDeclarationInHotfixAnalyzer.cs:39-63 | Tools/Analyzer/Analyzer/HotfixProjectFieldDeclarationAnalyzer.cs:37-68 — These two members are one piece of code written twice and then edited apart: 25 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (31 corresponding lines) · ×2
  • Edited copy of a member (31 corresponding lines) Unity/Codes/Model/Core/Timer/TimerComponent.cs:263 — Unity/Codes/Model/Core/Timer/TimerComponent.cs:263-293 | Unity/Codes/Model/Core/Timer/TimerComponent.cs:302-334 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (31 corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:557 — ThirdParty/UnityEngine/Quaternion.cs:557-589 | ThirdParty/UnityEngine/Quaternion.cs:592-622 — These two members are one piece of code written twice and then edited apart: 31 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 16+ corresponding lines) · ×2
  • Edited copies of one member (3 members, 16+ corresponding lines) Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:63 — Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:63-78 | Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:81-98 | Robot/Hotfix/Robot/RobotManagerComponentSystem.cs:9-24 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
  • Edited copies of one member (3 members, 16+ corresponding lines) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffWatcherComponentSystem.cs:171 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffWatcherComponentSystem.cs:171-189 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffWatcherComponentSystem.cs:206-224 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Condition/ConditionWatcherComponent.cs:52-67 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 16 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 10+ corresponding lines) · ×2
  • Edited copies of one member (4 members, 10+ corresponding lines) Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:13 — Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:13-24 | Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:30-41 | Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:48-57 | Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:63-72 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
  • Edited copies of one member (4 members, 10+ corresponding lines) Server/Hotfix/Module/Actor/ActorMessageSenderComponentSystem.cs:10 — Server/Hotfix/Module/Actor/ActorMessageSenderComponentSystem.cs:10-19 | Server/Hotfix/Module/ActorLocation/ActorLocationSenderComponentSystem.cs:10-19 | Unity/Codes/Hotfix/Module/AI/AIComponentSystem.cs:10-19 | Unity/Codes/Hotfix/Module/Message/SessionIdleCheckerComponentSystem.cs:9-18 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Duplicated block (14 lines × 2) · ×2
  • Duplicated block (14 lines × 2) Server/Model/Generate/Message/InnerMessage.cs:461 — Server/Model/Generate/Message/InnerMessage.cs:461-474 | Server/Model/Generate/Message/OuterMessage.cs:569-582 — before extracting anything, compare `Server/Model/Generate/Message/InnerMessage.cs` and `Server/Model/Generate/Message/OuterMessage.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 155 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Server/Model/Generate/Message/InnerMessage.cs:458` calls `ProtoMember` and `Server/Model/Generate/Message/OuterMessage.cs:568` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (14 lines × 2) Server/Model/Generate/Message/InnerMessage.cs:485 — Server/Model/Generate/Message/InnerMessage.cs:485-498 | Server/Model/Generate/Message/OuterMessage.cs:590-603 — before extracting anything, compare `Server/Model/Generate/Message/InnerMessage.cs` and `Server/Model/Generate/Message/OuterMessage.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 155 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Server/Model/Generate/Message/InnerMessage.cs:482` calls `ProtoMember` and `Server/Model/Generate/Message/OuterMessage.cs:589` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (8 lines × 5) · ×2
  • Duplicated block (8 lines × 5) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:918 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:918-925 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:934-941 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:954-961 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:975-982 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:995-1002 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:962` calls `Contains`, `IsInTrigger`, `GetRealPos` and `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:926` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
  • Duplicated block (8 lines × 5) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:962 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:962-969 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1010-1017 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1119-1126 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1172-1181 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1225-1233 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:962` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (8 lines × 3) · ×2
  • Duplicated block (8 lines × 3) Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:68 — Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:68-75 | Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:88-95 | Robot/Hotfix/Robot/RobotManagerComponentSystem.cs:14-21 — there are 3 copies across 2 file(s) — more copies than files, so at least one file holds the block twice. Extract it once into a single shared function every call site can reach and call it from all 3 sites; resolving a subset leaves the remainder to drift apart. Read the line range as the matched WINDOW rather than a finished unit: at `Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:68` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
  • Duplicated block (8 lines × 3) Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs:12 — Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs:12-19 | Server/Hotfix/Demo/Battle/Event/M2M_UseSkillHandler.cs:20-27 | Unity/Codes/Hotfix/Demo/Battle/M2C_UseSkillHandler.cs:18-25 — before extracting anything, compare `Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs` and `Server/Hotfix/Demo/Battle/Event/M2M_UseSkillHandler.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs:12` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `C2M_UseSkill` in one and `M2M_UseSkill` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (8–9 lines × 2) · ×2
  • Duplicated block (8–9 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:669 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:669-677 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1091-1098 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
  • Duplicated block (8–9 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:878 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:878-886 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1131-1138 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:888` calls `GetRealPos` and `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1139` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (5 lines × 3) · ×2
  • Duplicated block (5 lines × 3) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:266 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:266-270 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:285-289 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:303-307 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:266` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
  • Duplicated block (5 lines × 3) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:92 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:92-96 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:133-137 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:224-228 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:92` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Edited copy of a member (29 corresponding lines) · ×2
  • Edited copy of a member (29 corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:626 — ThirdParty/UnityEngine/Matrix4x4.cs:626-656 | ThirdParty/UnityEngine/Matrix4x4.cs:659-687 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (29 corresponding lines) REDACTED:224 — REDACTED:224-252 | REDACTED:292-320 — These two members are one piece of code written twice and then edited apart: 29 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (27 corresponding lines) · ×2
  • Edited copy of a member (27 corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:414 — ThirdParty/UnityEngine/Matrix4x4.cs:414-442 | ThirdParty/UnityEngine/Matrix4x4.cs:445-471 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (27 corresponding lines) Tools/App/Apps/ChapterExporter/ChapterExporter.cs:65 — Tools/App/Apps/ChapterExporter/ChapterExporter.cs:65-91 | Tools/App/Apps/ExcelExporter/ExcelExporter.cs:517-543 — These two members are one piece of code written twice and then edited apart: 27 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (14 corresponding lines) · ×2
  • Edited copy of a member (14 corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:1181 — ThirdParty/UnityEngine/Matrix4x4.cs:1181-1196 | ThirdParty/UnityEngine/Matrix4x4.cs:1199-1212 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (14 corresponding lines) ThirdParty/UnityEngine/Mathf.cs:530 — ThirdParty/UnityEngine/Mathf.cs:530-543 | ThirdParty/UnityEngine/Mathf.cs:546-564 — These two members are one piece of code written twice and then edited apart: 14 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (32 corresponding lines) · ×2
  • Edited copy of a member (32 corresponding lines) Server/Hotfix/Demo/Battle/BattleHelper.cs:8 — Server/Hotfix/Demo/Battle/BattleHelper.cs:8-45 | Unity/Codes/Hotfix/Demo/Battle/BattleHelper.cs:21-52 — These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
  • Edited copy of a member (32 corresponding lines) Server/Hotfix/Demo/Transfer/M2M_UnitAreaTransferRequestHandler.cs:12 — Server/Hotfix/Demo/Transfer/M2M_UnitAreaTransferRequestHandler.cs:12-44 | Server/Hotfix/Demo/Transfer/M2M_UnitAreaCreateHandler.cs:8-39 — These two members are one piece of code written twice and then edited apart: 32 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 14+ corresponding lines) · ×2
  • Edited copies of one member (4 members, 14+ corresponding lines) ThirdParty/UnityEngine/Vector3.cs:334 — ThirdParty/UnityEngine/Vector3.cs:334-349 | ThirdParty/UnityEngine/Vector3.cs:353-366 | ThirdParty/UnityEngine/Vector4.cs:304-321 | ThirdParty/UnityEngine/Vector4.cs:325-340 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
  • Edited copies of one member (4 members, 14+ corresponding lines) ThirdParty/UnityEngine/Vector3.cs:264 — ThirdParty/UnityEngine/Vector3.cs:264-279 | ThirdParty/UnityEngine/Vector3.cs:282-295 | ThirdParty/UnityEngine/Vector4.cs:222-241 | ThirdParty/UnityEngine/Vector4.cs:244-261 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 14 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
IC1 · Incompleteness & stubs · Unfinished stub · ×2
  • Unfinished stub — throws NotImplementedException Unity/Assets/Mono/Module/Network/Circularbuffer.cs:265 — `Flush` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
  • Unfinished stub — throws NotImplementedException Unity/Assets/Mono/Module/NetworkTCP/WService.cs:125 — `Get` is a shipped member whose whole body throws NotImplementedException — scaffolding that was never completed. Implement it or remove the dead surface.
X18 · Disposal-pattern correctness · Disposable created and abandoned in the method that made it · ×2
  • Disposable created and abandoned in the method that made it Unity/Assets/Mono/Core/Helper/MD5Helper.cs:13 — `md5` is a `MD5`, which implements `IDisposable`, and it is created here (line 13). Every use of it in `FileMD5` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var md5 = …;`), which releases it at the end of the scope on every path including a throw.
  • Disposable created and abandoned in the method that made it Unity/Codes/Hotfix/Demo/Unit/M2C_CreateUnitsHandler.cs:17 — `unit` is a `Unit`, which implements `IDisposable`, and it is created here (line 17). Every use of it in `Run` reads a member through it — it is never returned, never stored, never handed to anything else, and never disposed — so this method both creates the value and is the last thing that can release it, and does not. Nothing announces the leak: the object holds its resource until finalization if its type has a finalizer, and until the process ends if it does not, so the cost accumulates once per CALL rather than showing up as a failure. Declare it with `using` (`using var unit = …;`), which releases it at the end of the scope on every path including a throw.
X18 · Disposal-pattern correctness · Owned disposable field is never released · ×2
  • Owned disposable field is never released Unity/Assets/Mono/Module/NetworkTCP/TChannel.cs:18 — `TChannel` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `recvBuffer` itself (line 18), which makes that instance its own. But `recvBuffer` is named in none of the methods the disposal search covered: `Dispose` (line 95) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`recvBuffer?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
  • Owned disposable field is never released Unity/Assets/Mono/Module/NetworkTCP/TChannel.cs:19 — `TChannel` implements `IDisposable` — so it has told every caller it holds something worth releasing — and it constructs `sendBuffer` itself (line 19), which makes that instance its own. But `sendBuffer` is named in none of the methods the disposal search covered: `Dispose` (line 95) — that is `Dispose` plus every method `Dispose` calls BY NAME, so a release reached through an interface, a delegate or a base class is not followed and is worth checking before acting. On what was read, the type's disposal releases everything except the one thing it owns. A disposable the owner never disposes is held until finalization if its type has a finalizer, and forever if it does not — which for a synchronisation primitive, a timer, a stream or a handle means the resource accumulates once per instance for the life of the process. Release it in `Dispose` (`sendBuffer?.Dispose();`), or, if it truly does not need releasing, drop `IDisposable` from the type so the claim and the behaviour agree.
X5 · Nullable reference types · Null guard scopes only part of the work it protects · ×2
  • Null guard scopes only part of the work it protects Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalRenderPipeline.cs:537 — This method contradicts itself about `cameraStack`: line 433 tests it for null before doing anything with it — the author's own statement that null is an input this code expects — but that `if` scopes only the block beneath it, and line 537 then dereferences `cameraStack` as `cameraStack.Count` AFTER the block has closed, where the guard no longer applies. A null `cameraStack` skips the guarded body and reaches that line anyway, throwing NullReferenceException on exactly the input the guard was written for. If the dereference belongs to the guarded work, move it inside the block; if `cameraStack` truly cannot be null by then, the guard above is misleading and should go.
  • Null guard scopes only part of the work it protects Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalRenderPipeline.cs:944 — This method contradicts itself about `light`: line 938 tests it for null before doing anything with it — the author's own statement that null is an input this code expects — but that `if` scopes only the block beneath it, and line 944 then dereferences `light` as `light.shadowBias` AFTER the block has closed, where the guard no longer applies. A null `light` skips the guarded body and reaches that line anyway, throwing NullReferenceException on exactly the input the guard was written for. If the dereference belongs to the guarded work, move it inside the block; if `light` truly cannot be null by then, the guard above is misleading and should go.
C1 · Data Protection · No data-protection/encryption · ×1
  • No data-protection/encryption — No data-protection or encryption usage (ASP.NET Data Protection, AES, column encryption, PBKDF2) was found — sensitive data at rest may be unprotected. If TDE/KMS/vault is delegated to infrastructure, ignore.
D1 · Cyclomatic Complexity · AOITriggerSystem.IsInTrigger (cyclomatic 72) · ×1
  • AOITriggerSystem.IsInTrigger (cyclomatic 72) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1302 — AOITriggerSystem.IsInTrigger has cyclomatic complexity 72 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe (cyclomatic 62) · ×1
  • AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe (cyclomatic 62) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:872 — AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe has cyclomatic complexity 62 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AOITriggerSystem.AfterColliderChangeBroadcastToOther (cyclomatic 60) · ×1
  • AOITriggerSystem.AfterColliderChangeBroadcastToOther (cyclomatic 60) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1088 — AOITriggerSystem.AfterColliderChangeBroadcastToOther has cyclomatic complexity 60 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AOITriggerSystem.AfterTriggerChangeBroadcastToMe (cyclomatic 51) · ×1
  • AOITriggerSystem.AfterTriggerChangeBroadcastToMe (cyclomatic 51) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:661 — AOITriggerSystem.AfterTriggerChangeBroadcastToMe has cyclomatic complexity 51 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OBBComponentSystem.IsRayInTrigger2D (cyclomatic 45) · ×1
  • OBBComponentSystem.IsRayInTrigger2D (cyclomatic 45) Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:583 — OBBComponentSystem.IsRayInTrigger2D has cyclomatic complexity 45 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · Physics.Raycast (cyclomatic 34) · ×1
  • Physics.Raycast (cyclomatic 34) Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:11 — Physics.Raycast has cyclomatic complexity 34 (threshold 15). Of this number, 33 points are the body's own statements and 1 belongs to one function literal inside it that branches. To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FormulaStringFx.FormulaStringFx.ctor (cyclomatic 31) · ×1
  • FormulaStringFx.FormulaStringFx.ctor (cyclomatic 31) Unity/Codes/Model/Module/Battle/Combat/FormulaStringFx.cs:58 — FormulaStringFx.FormulaStringFx.ctor has cyclomatic complexity 31 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · EntityChildAnalyzer.AnalyzeMemberAccessExpression (cyclomatic 31) · ×1
  • EntityChildAnalyzer.AnalyzeMemberAccessExpression (cyclomatic 31) Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:47 — EntityChildAnalyzer.AnalyzeMemberAccessExpression has cyclomatic complexity 31 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · EntityComponentAnalyzer.AnalyzeMemberAccessExpression (cyclomatic 31) · ×1
  • EntityComponentAnalyzer.AnalyzeMemberAccessExpression (cyclomatic 31) Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs:47 — EntityComponentAnalyzer.AnalyzeMemberAccessExpression has cyclomatic complexity 31 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D1 · Cyclomatic Complexity · SkillWatcher_GenerateCollider.Run (cyclomatic 30) · ×1
  • SkillWatcher_GenerateCollider.Run (cyclomatic 30) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Event/SkillWatcher_GenerateCollider.cs:14 — SkillWatcher_GenerateCollider.Run has cyclomatic complexity 30 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · UIComponentAnalyzer.AnalyzeMemberAccessExpression (cyclomatic 28) · ×1
  • UIComponentAnalyzer.AnalyzeMemberAccessExpression (cyclomatic 28) Tools/Analyzer/Analyzer/UIComponentAnalyzer.cs:59 — UIComponentAnalyzer.AnalyzeMemberAccessExpression has cyclomatic complexity 28 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · ExcelExporter.Convert (cyclomatic 24) · ×1
  • ExcelExporter.Convert (cyclomatic 24) Tools/App/Apps/ExcelExporter/ExcelExporter.cs:612 — ExcelExporter.Convert has cyclomatic complexity 24 (threshold 15). To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Where every arm is uniform — the same kind of value, with no behaviour of its own — a table keyed by the case is the shorter form; wherever the arms carry different data or different behaviour, keep them as cases, because collapsing those trades an explicit, reviewable set of cases for nothing.
D1 · Cyclomatic Complexity · ExcelExporter.Export (cyclomatic 22) · ×1
  • ExcelExporter.Export (cyclomatic 22) Tools/App/Apps/ExcelExporter/ExcelExporter.cs:128 — ExcelExporter.Export has cyclomatic complexity 22 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · RouterServiceComponentSystem.Recv (cyclomatic 21) · ×1
  • RouterServiceComponentSystem.Recv (cyclomatic 21) Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs:68 — RouterServiceComponentSystem.Recv has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AOIUnitComponentSystem.ChangeTo (cyclomatic 21) · ×1
  • AOIUnitComponentSystem.ChangeTo (cyclomatic 21) Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:199 — AOIUnitComponentSystem.ChangeTo has cyclomatic complexity 21 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · InnerProto2CS.Proto2CS (cyclomatic 20) · ×1
  • InnerProto2CS.Proto2CS (cyclomatic 20) REDACTED:70 — InnerProto2CS.Proto2CS has cyclomatic complexity 20 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · UnitFactory.Create (cyclomatic 19) · ×1
  • UnitFactory.Create (cyclomatic 19) Unity/Codes/Hotfix/Demo/Unit/UnitFactory.cs:9 — UnitFactory.Create has cyclomatic complexity 19 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · FormulaStringFx.GetData (cyclomatic 17) · ×1
  • FormulaStringFx.GetData (cyclomatic 17) Unity/Codes/Model/Module/Battle/Combat/FormulaStringFx.cs:158 — FormulaStringFx.GetData has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · AOITriggerSystem.AddColliderListener (cyclomatic 17) · ×1
  • AOITriggerSystem.AddColliderListener (cyclomatic 17) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:296 — AOITriggerSystem.AddColliderListener has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · BuffWatcherComponentSystem.Init (cyclomatic 17) · ×1
  • BuffWatcherComponentSystem.Init (cyclomatic 17) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffWatcherComponentSystem.cs:29 — BuffWatcherComponentSystem.Init has cyclomatic complexity 17 (threshold 15). To reduce it, separate the cases: extract each independent branch into its own named function, and where the body has guards that only reject input, fold those into early returns at the top.
D1 · Cyclomatic Complexity · OnSkillTrigger_OnSkillTrigger.OnColliderIn (cyclomatic 16) · ×1
  • OnSkillTrigger_OnSkillTrigger.OnColliderIn (cyclomatic 16) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Event/OnSkillTrigger_OnSkillTrigger.cs:29 — OnSkillTrigger_OnSkillTrigger.OnColliderIn has cyclomatic complexity 16 (threshold 15). To reduce it, split the body: these branches sit side by side rather than nested inside one another, so extracting each one on its own would leave a function per branch. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D18 · Solution Shape · Solution references 13 projects that do not exist · ×1
  • Solution references 13 projects that do not exist Client-Server.sln — `Client-Server.sln` declares 13 project file(s) that are missing from the tree (`Unity/HybridCLR.Editor.csproj`, `Unity/HybridCLR.Runtime.csproj`, `Unity/Unity.Editor.csproj`, `Unity/Unity.Hotfix.csproj`, `Unity/Unity.HotfixView.csproj`, `Unity/Unity.Model.csproj`, +7 more). A solution-level restore or build fails on a dangling reference, so anyone building the solution rather than an individual project is blocked. Delete the stale entry from the solution, or restore the missing project file.
D2 · Cognitive Complexity · AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe (cognitive 133) · ×1
  • AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe (cognitive 133) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:872 — AOITriggerSystem.AfterTriggerChangeRotationBroadcastToMe has cognitive complexity 133 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs holds 8 of the 49 methods over the threshold — including the worst — and 487 of the 1184 points over it (41%), 2.3× the next-largest file (Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs at 211). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · AOITriggerSystem.AfterColliderChangeBroadcastToOther (cognitive 133) · ×1
  • AOITriggerSystem.AfterColliderChangeBroadcastToOther (cognitive 133) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1088 — AOITriggerSystem.AfterColliderChangeBroadcastToOther has cognitive complexity 133 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs holds 8 of the 49 methods over the threshold — including the worst — and 487 of the 1184 points over it (41%), 2.3× the next-largest file (Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs at 211). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · AOITriggerSystem.AfterTriggerChangeBroadcastToMe (cognitive 117) · ×1
  • AOITriggerSystem.AfterTriggerChangeBroadcastToMe (cognitive 117) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:661 — AOITriggerSystem.AfterTriggerChangeBroadcastToMe has cognitive complexity 117 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs holds 8 of the 49 methods over the threshold — including the worst — and 487 of the 1184 points over it (41%), 2.3× the next-largest file (Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs at 211). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · AOITriggerSystem.IsInTrigger (cognitive 94) · ×1
  • AOITriggerSystem.IsInTrigger (cognitive 94) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1302 — AOITriggerSystem.IsInTrigger has cognitive complexity 94 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs holds 8 of the 49 methods over the threshold — including the worst — and 487 of the 1184 points over it (41%), 2.3× the next-largest file (Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs at 211). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · OBBComponentSystem.IsRayInTrigger2D (cognitive 72) · ×1
  • OBBComponentSystem.IsRayInTrigger2D (cognitive 72) Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:583 — OBBComponentSystem.IsRayInTrigger2D has cognitive complexity 72 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Physics.Raycast (cognitive 67) · ×1
  • Physics.Raycast (cognitive 67) Unity/Codes/Hotfix/Module/AOI/Raycast/Physics.cs:11 — Physics.Raycast has cognitive complexity 67 (threshold 15). Of this number, 63 points are the body's own statements and 4 belong to one function literal inside it that branches. To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SkillWatcher_GenerateCollider.Run (cognitive 60) · ×1
  • SkillWatcher_GenerateCollider.Run (cognitive 60) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Event/SkillWatcher_GenerateCollider.cs:14 — SkillWatcher_GenerateCollider.Run has cognitive complexity 60 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · AOITriggerSystem.AddColliderListener (cognitive 56) · ×1
  • AOITriggerSystem.AddColliderListener (cognitive 56) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:296 — AOITriggerSystem.AddColliderListener has cognitive complexity 56 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This file is where this pass's cognitive complexity CONCENTRATES: Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs holds 8 of the 49 methods over the threshold — including the worst — and 487 of the 1184 points over it (41%), 2.3× the next-largest file (Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs at 211). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · RouterServiceComponentSystem.Recv (cognitive 49) · ×1
  • RouterServiceComponentSystem.Recv (cognitive 49) Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs:68 — RouterServiceComponentSystem.Recv has cognitive complexity 49 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · InnerProto2CS.Proto2CS (cognitive 43) · ×1
  • InnerProto2CS.Proto2CS (cognitive 43) REDACTED:70 — InnerProto2CS.Proto2CS has cognitive complexity 43 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EntityChildAnalyzer.AnalyzeMemberAccessExpression (cognitive 39) · ×1
  • EntityChildAnalyzer.AnalyzeMemberAccessExpression (cognitive 39) Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:47 — EntityChildAnalyzer.AnalyzeMemberAccessExpression has cognitive complexity 39 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · EntityComponentAnalyzer.AnalyzeMemberAccessExpression (cognitive 39) · ×1
  • EntityComponentAnalyzer.AnalyzeMemberAccessExpression (cognitive 39) Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs:47 — EntityComponentAnalyzer.AnalyzeMemberAccessExpression has cognitive complexity 39 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition, and where an else follows a branch that already returns, drop the trailing else and let the rest of the body continue at one level.
D2 · Cognitive Complexity · UIComponentAnalyzer.AnalyzeMemberAccessExpression (cognitive 39) · ×1
  • UIComponentAnalyzer.AnalyzeMemberAccessExpression (cognitive 39) Tools/Analyzer/Analyzer/UIComponentAnalyzer.cs:59 — UIComponentAnalyzer.AnalyzeMemberAccessExpression has cognitive complexity 39 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AOITriggerSystem.AddTriggerListener (cognitive 38) · ×1
  • AOITriggerSystem.AddTriggerListener (cognitive 38) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:223 — AOITriggerSystem.AddTriggerListener has cognitive complexity 38 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This file is where this pass's cognitive complexity CONCENTRATES: Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs holds 8 of the 49 methods over the threshold — including the worst — and 487 of the 1184 points over it (41%), 2.3× the next-largest file (Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs at 211). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · AOIUnitComponentSystem.ChangeTo (cognitive 37) · ×1
  • AOIUnitComponentSystem.ChangeTo (cognitive 37) Unity/Codes/Hotfix/Module/AOI/AOIUnitComponentSystem.cs:199 — AOIUnitComponentSystem.ChangeTo has cognitive complexity 37 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UnitFactory.Create (cognitive 37) · ×1
  • UnitFactory.Create (cognitive 37) Unity/Codes/Hotfix/Demo/Unit/UnitFactory.cs:9 — UnitFactory.Create has cognitive complexity 37 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · BuffSystem.AddBuffAttrValue (cognitive 36) · ×1
  • BuffSystem.AddBuffAttrValue (cognitive 36) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:141 — BuffSystem.AddBuffAttrValue has cognitive complexity 36 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This shape REPEATS in the file: one other method here (BuffSystem.RemoveBuffAttrValue) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · BuffSystem.RemoveBuffAttrValue (cognitive 36) · ×1
  • BuffSystem.RemoveBuffAttrValue (cognitive 36) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffSystem.cs:180 — BuffSystem.RemoveBuffAttrValue has cognitive complexity 36 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function. This shape REPEATS in the file: one other method here (BuffSystem.AddBuffAttrValue) has the same decision points, in the same order, at the same nesting depths — so this is one pattern written twice rather than two separate problems. Splitting this body alone leaves the other exactly as it is. Where these are variations on one operation, the change that clears both is the shared one: lift the common shape into a single routine the variants call, parameterised by whatever genuinely differs between them, and keep in each method only the part that is not shared.
D2 · Cognitive Complexity · BuffWatcherComponentSystem.Init (cognitive 33) · ×1
  • BuffWatcherComponentSystem.Init (cognitive 33) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffWatcherComponentSystem.cs:29 — BuffWatcherComponentSystem.Init has cognitive complexity 33 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FormulaStringFx.GetData (cognitive 30) · ×1
  • FormulaStringFx.GetData (cognitive 30) Unity/Codes/Model/Module/Battle/Combat/FormulaStringFx.cs:158 — FormulaStringFx.GetData has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExcelExporter.Export (cognitive 30) · ×1
  • ExcelExporter.Export (cognitive 30) Tools/App/Apps/ExcelExporter/ExcelExporter.cs:128 — ExcelExporter.Export has cognitive complexity 30 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · FormulaStringFx.FormulaStringFx.ctor (cognitive 28) · ×1
  • FormulaStringFx.FormulaStringFx.ctor (cognitive 28) Unity/Codes/Model/Module/Battle/Combat/FormulaStringFx.cs:58 — FormulaStringFx.FormulaStringFx.ctor has cognitive complexity 28 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExcelExporter.ExportSheetJson (cognitive 26) · ×1
  • ExcelExporter.ExportSheetJson (cognitive 26) Tools/App/Apps/ExcelExporter/ExcelExporter.cs:545 — ExcelExporter.ExportSheetJson has cognitive complexity 26 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Entity.Dispose (cognitive 24) · ×1
  • Entity.Dispose (cognitive 24) Unity/Codes/Model/Core/Object/Entity.cs:425 — Entity.Dispose has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · RouterServiceInnerComponentSystem.Recv (cognitive 24) · ×1
  • RouterServiceInnerComponentSystem.Recv (cognitive 24) Server/Hotfix/Module/Router/RouterServiceInnerComponentSystem.cs:78 — RouterServiceInnerComponentSystem.Recv has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · MoveComponentSystem.MoveForward (cognitive 24) · ×1
  • MoveComponentSystem.MoveForward (cognitive 24) Unity/Codes/Hotfix/Demo/Move/MoveComponentSystem.cs:116 — MoveComponentSystem.MoveForward has cognitive complexity 24 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UnitFactory.AfterCreateUnitFromMsg (cognitive 23) · ×1
  • UnitFactory.AfterCreateUnitFromMsg (cognitive 23) Server/Hotfix/Demo/Unit/UnitFactory.cs:10 — UnitFactory.AfterCreateUnitFromMsg has cognitive complexity 23 (threshold 15). The drivers above price the dispatch low by construction — a dispatch is charged once however many cases it lists, while each branch inside an arm is charged in full — so most of this count is what the case bodies hold, and the arms are where it can be reduced. To reduce it, keep the dispatch but shrink the arms: move each non-trivial case body into its own named function (or onto the value being matched) so the dispatch reads one line per case, and group related cases into a sub-dispatch. Keep every case explicit, and make the behaviour for cases you do not list a deliberate choice rather than an accident.
D2 · Cognitive Complexity · OnSkillTrigger_OnSkillTrigger.OnColliderIn (cognitive 22) · ×1
  • OnSkillTrigger_OnSkillTrigger.OnColliderIn (cognitive 22) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Event/OnSkillTrigger_OnSkillTrigger.cs:29 — OnSkillTrigger_OnSkillTrigger.OnColliderIn has cognitive complexity 22 (threshold 15). To reduce it, split the body: this score is breadth rather than depth — many checks laid out side by side rather than nested inside one another, so inverting conditions into early returns has nothing left to flatten. Group the statements between the checks into named steps and move each step into its own function, so the body reads as a short sequence of named stages.
D2 · Cognitive Complexity · SkillWatcher_Cost.Run (cognitive 22) · ×1
  • SkillWatcher_Cost.Run (cognitive 22) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Event/SkillWatcher_Cost.cs:13 — SkillWatcher_Cost.Run has cognitive complexity 22 (threshold 15). To reduce it, flatten the nesting: invert conditions into early returns or guard clauses so the happy path stays at one level, and lift the deepest nested block into its own named function.
D2 · Cognitive Complexity · BuffComponentSystem.AddBuff (cognitive 21) · ×1
  • BuffComponentSystem.AddBuff (cognitive 21) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:88 — BuffComponentSystem.AddBuff has cognitive complexity 21 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · Entity.Domain.set (cognitive 20) · ×1
  • Entity.Domain.set (cognitive 20) Unity/Codes/Model/Core/Object/Entity.cs:254 — Entity.Domain.set has cognitive complexity 20 (threshold 15). To reduce it, split the body: most of this score is breadth rather than depth — checks laid out side by side rather than stacked — so group the statements between the checks into named steps and move each step into its own function. Some of it IS depth: where a check sits inside another whose only job is to reach it, merge the two into one condition.
D2 · Cognitive Complexity · ActorLocationSenderComponentSystem.CallInner (cognitive 20) · ×1
  • ActorLocationSenderComponentSystem.CallInner (cognitive 20) Server/Hotfix/Module/ActorLocation/ActorLocationSenderComponentSystem.cs:136 — ActorLocationSenderComponentSystem.CallInner has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AreaExporter.ExportSheetEnum (cognitive 20) · ×1
  • AreaExporter.ExportSheetEnum (cognitive 20) Tools/App/Apps/AreaExporter/AreaExporter.cs:67 — AreaExporter.ExportSheetEnum has cognitive complexity 20 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · TransferHelper.AreaAdd (cognitive 19) · ×1
  • TransferHelper.AreaAdd (cognitive 19) Server/Hotfix/Demo/Transfer/TransferHelper.cs:144 — TransferHelper.AreaAdd has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AOITriggerDestroySystem.Destroy (cognitive 19) · ×1
  • AOITriggerDestroySystem.Destroy (cognitive 19) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:48 — AOITriggerDestroySystem.Destroy has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs holds 8 of the 49 methods over the threshold — including the worst — and 487 of the 1184 points over it (41%), 2.3× the next-largest file (Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs at 211). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · ExcelExporter.ExportSheetChapter (cognitive 19) · ×1
  • ExcelExporter.ExportSheetChapter (cognitive 19) Tools/App/Apps/ChapterExporter/ChapterExporter.cs:92 — ExcelExporter.ExportSheetChapter has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · InnerProto2CS.CollectOldMsgCode (cognitive 19) · ×1
  • InnerProto2CS.CollectOldMsgCode (cognitive 19) REDACTED:322 — InnerProto2CS.CollectOldMsgCode has cognitive complexity 19 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · M2M_UnitAreaAddHandler.Run (cognitive 18) · ×1
  • M2M_UnitAreaAddHandler.Run (cognitive 18) Server/Hotfix/Demo/Transfer/M2M_UnitAreaAddHandler.cs:11 — M2M_UnitAreaAddHandler.Run has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · UnitHelper.CreateUnitInfo (cognitive 18) · ×1
  • UnitHelper.CreateUnitInfo (cognitive 18) Server/Hotfix/Demo/Unit/UnitHelper.cs:15 — UnitHelper.CreateUnitInfo has cognitive complexity 18 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · EventSystem.Add (cognitive 17) · ×1
  • EventSystem.Add (cognitive 17) Unity/Codes/Model/Core/Object/EventSystem.cs:94 — EventSystem.Add has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · GhostComponentSystem.HandleMsg (cognitive 17) · ×1
  • GhostComponentSystem.HandleMsg (cognitive 17) Server/Hotfix/Module/AOI/Ghost/GhostComponentSystem.cs:133 — GhostComponentSystem.HandleMsg has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AOITriggerSystem.RemoveTriggerListener (cognitive 17) · ×1
  • AOITriggerSystem.RemoveTriggerListener (cognitive 17) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:570 — AOITriggerSystem.RemoveTriggerListener has cognitive complexity 17 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body. This file is where this pass's cognitive complexity CONCENTRATES: Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs holds 8 of the 49 methods over the threshold — including the worst — and 487 of the 1184 points over it (41%), 2.3× the next-largest file (Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs at 211). No single row can show this, because each is measured only against the threshold: reducing this one file moves this dimension further than any other file in the repository.
D2 · Cognitive Complexity · OpcodeTypeComponentAwakeSystem.Awake (cognitive 16) · ×1
  • OpcodeTypeComponentAwakeSystem.Awake (cognitive 16) Unity/Codes/Model/Module/Message/OpcodeTypeComponent.cs:12 — OpcodeTypeComponentAwakeSystem.Awake has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · M2M_UseSkillHandler.Run (cognitive 16) · ×1
  • M2M_UseSkillHandler.Run (cognitive 16) Server/Hotfix/Demo/Battle/Event/M2M_UseSkillHandler.cs:7 — M2M_UseSkillHandler.Run has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · SkillWatcher_ChangeGroup.Run (cognitive 16) · ×1
  • SkillWatcher_ChangeGroup.Run (cognitive 16) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/Event/SkillWatcher_ChangeGroup.cs:10 — SkillWatcher_ChangeGroup.Run has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · AttrExporter.Export (cognitive 16) · ×1
  • AttrExporter.Export (cognitive 16) Tools/App/Apps/AttrExporter/AttrExporter.cs:22 — AttrExporter.Export has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D2 · Cognitive Complexity · ExcelExporter.ExportSheetClass (cognitive 16) · ×1
  • ExcelExporter.ExportSheetClass (cognitive 16) Tools/App/Apps/ExcelExporter/ExcelExporter.cs:412 — ExcelExporter.ExportSheetClass has cognitive complexity 16 (threshold 15). To reduce it, split the body into named stages: move each independent step or branch into its own named function so the body reads as a short sequence of named calls rather than one long body.
D29 · Static Analysis (SAST) · REDACTED · ×1
  • REDACTED
D3 · God Classes · FileTooLong · ×1
  • FileTooLong: Trigger/AOITriggerSystem.cs Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs — FileTooLong — 729 significant lines (blank, comment-only and punctuation-only lines excluded). The bar is 500 significant lines; this is 229 over it, 1.46× the bar. To reduce it, split the file along the responsibilities already in it: move each cohesive group of declarations into its own sibling file in the same module or package, so no one file has to be read whole to change one of them.
D3 · God Classes · ClassTooLong · ×1
  • ClassTooLong: ExcelExporter Tools/App/Apps/ExcelExporter/ExcelExporter.cs — ClassTooLong — 499 significant lines (blank, comment-only and punctuation-only lines excluded), 23 methods, declared across 3 files: ExcelExporter/ExcelExporter.cs (15), ChapterExporter/ChapterExporter.cs (4), I18NExporter/I18NExporter.cs (4). The bar is 400 significant lines; this is 99 over it, 1.25× the bar. The type holds no instance state, so there is no shared data to group its members by. To reduce it, split it by area instead: give each cohesive family of members its own smaller type, so no one type has to be read whole to change one of them.
D3 · God Classes · TooManyMethods · ×1
  • TooManyMethods: Entity Unity/Codes/Model/Core/Object/Entity.cs — TooManyMethods — 484 significant lines (blank, comment-only and punctuation-only lines excluded), 36 methods. The bar is 30 methods; this is 6 over it, 1.20× the bar. To reduce it, group the members that share the same data into a smaller type of their own and delegate to it, so no single type carries every responsibility.
D4 · Code Duplication · Near-duplicate member pair (63 shared lines) · ×1
  • Near-duplicate member pair (63 shared lines) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:873 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:873-1080 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1089-1291 — These two members are variants of one another: 63 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Edited copy of a member (156 corresponding lines) · ×1
  • Edited copy of a member (156 corresponding lines) Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:247 — Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:247-403 | Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:414-570 — These two members are one piece of code written twice and then edited apart: 156 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Members sharing a duplicated core (5 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (5 members, 50+ identical tokens) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:89 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:89-146 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:204-237 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:265-274 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:284-293 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:302-311 — These 5 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 5 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 5 times.
D4 · Code Duplication · Edited copy of a member (66 corresponding lines) · ×1
  • Edited copy of a member (66 corresponding lines) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:224 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:224-289 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:297-368 — These two members are one piece of code written twice and then edited apart: 66 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (30 corresponding lines) · ×1
  • Edited copy of a member (30 corresponding lines) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:571 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:571-606 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:625-654 — These two members are one piece of code written twice and then edited apart: 30 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 30+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 30+ corresponding lines) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SkillStepComponentSystem.cs:34 — Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SkillStepComponentSystem.cs:34-63 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SkillStepComponentSystem.cs:66-96 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/SkillStepComponentSystem.cs:99-138 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 30 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 19+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 19+ corresponding lines) Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs:37 — Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs:37-55 | Server/Hotfix/Module/Router/RouterServiceInnerComponentSystem.cs:46-65 | Unity/Assets/Mono/Module/Network/KService.cs:106-125 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 19 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 12+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 12+ corresponding lines) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:470 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:470-481 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:489-505 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:517-528 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:536-552 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 12 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (22 corresponding lines) · ×1
  • Edited copy of a member (22 corresponding lines) Unity/Codes/Model/Core/ObjectWait.cs:88 — Unity/Codes/Model/Core/ObjectWait.cs:88-109 | Unity/Codes/Model/Core/ObjectWait.cs:112-148 — These two members are one piece of code written twice and then edited apart: 22 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (20 corresponding lines) · ×1
  • Edited copy of a member (20 corresponding lines) Unity/Codes/Model/Core/Object/Entity.cs:652 — Unity/Codes/Model/Core/Object/Entity.cs:652-671 | Unity/Codes/Model/Core/Object/Entity.cs:674-693 — These two members are one piece of code written twice and then edited apart: 20 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 8+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 8+ corresponding lines) Server/Hotfix/Module/DB/DBComponentSystem.cs:33 — Server/Hotfix/Module/DB/DBComponentSystem.cs:33-40 | Server/Hotfix/Module/DB/DBComponentSystem.cs:90-97 | Server/Hotfix/Module/DB/DBComponentSystem.cs:100-107 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 8 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 10+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 10+ corresponding lines) Server/Hotfix/Module/Actor/ActorMessageSenderComponentSystem.cs:10 — Server/Hotfix/Module/Actor/ActorMessageSenderComponentSystem.cs:10-19 | Unity/Codes/Hotfix/Module/AI/AIComponentSystem.cs:10-19 | Unity/Codes/Hotfix/Module/Message/SessionIdleCheckerComponentSystem.cs:9-18 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 10 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Duplicated block (130 lines × 2) · ×1
  • Duplicated block (130 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:249 — Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:249-378 | Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:416-545 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (53–54 lines × 2) · ×1
  • Duplicated block (53–54 lines × 2) Robot/App/Program.cs:14 — Robot/App/Program.cs:14-67 | Server/App/Program.cs:14-66 — before extracting anything, compare `Robot/App/Program.cs` and `Server/App/Program.cs` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Server/App/Program.cs:14` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Server/App/Program.cs:13` calls `Init` and `Robot/App/Program.cs:13` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (42 lines × 2) · ×1
  • Duplicated block (42 lines × 2) Server/Model/Module/Actor/AMActorRpcHandler.cs:12 — Server/Model/Module/Actor/AMActorRpcHandler.cs:12-53 | Server/Model/Module/ActorLocation/AMActorLocationRpcHandler.cs:12-53 — before extracting anything, compare `Server/Model/Module/Actor/AMActorRpcHandler.cs` and `Server/Model/Module/ActorLocation/AMActorLocationRpcHandler.cs` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (33 lines × 2) · ×1
  • Duplicated block (33 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:225 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:225-257 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:298-330 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:225` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (35–36 lines × 2) · ×1
  • Duplicated block (35–36 lines × 2) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/MoveAndSpellComponentSystem.cs:113 — Unity/Codes/Hotfix/Module/Battle/Combat/Skill/MoveAndSpellComponentSystem.cs:113-147 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/MoveAndSpellComponentSystem.cs:155-190 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (29–34 lines × 2) · ×1
  • Duplicated block (29–34 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:717 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:717-750 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1133-1161 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:717` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1131` calls `Ceil`, `Info`, `Create` and `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:717` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (26–33 lines × 3) · ×1
  • Duplicated block (26–33 lines × 3) Server/Model/Module/Actor/AMActorRpcHandler.cs:28 — Server/Model/Module/Actor/AMActorRpcHandler.cs:28-53 | Server/Model/Module/ActorLocation/AMActorLocationRpcHandler.cs:28-53 | Server/Model/Module/NetworkTCP/AMRpcHandler.cs:27-59 — before extracting anything, compare `Server/Model/Module/Actor/AMActorRpcHandler.cs` and `Server/Model/Module/ActorLocation/AMActorLocationRpcHandler.cs` as WHOLE FILES: 96% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Model/Module/Actor/AMActorRpcHandler.cs:28` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (23–26 lines × 3) · ×1
  • Duplicated block (23–26 lines × 3) Unity/Codes/Hotfix/Module/Battle/Combat/Skill/MoveAndSpellComponentSystem.cs:78 — Unity/Codes/Hotfix/Module/Battle/Combat/Skill/MoveAndSpellComponentSystem.cs:78-103 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/MoveAndSpellComponentSystem.cs:123-145 | Unity/Codes/Hotfix/Module/Battle/Combat/Skill/MoveAndSpellComponentSystem.cs:165-188 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (26 lines × 2) · ×1
  • Duplicated block (26 lines × 2) Server/Model/Generate/Message/InnerMessage.cs:395 — Server/Model/Generate/Message/InnerMessage.cs:395-420 | Server/Model/Generate/Message/OuterMessage.cs:278-303 — before extracting anything, compare `Server/Model/Generate/Message/InnerMessage.cs` and `Server/Model/Generate/Message/OuterMessage.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 155 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (15 lines × 2) · ×1
  • Duplicated block (15 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:87 — Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:87-101 | Unity/Codes/Hotfix/Module/AOI/Trigger/OBBComponentSystem.cs:110-124 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (20 lines × 2) · ×1
  • Duplicated block (20 lines × 2) Server/Model/Generate/Message/InnerMessage.cs:431 — Server/Model/Generate/Message/InnerMessage.cs:431-450 | Server/Model/Generate/Message/OuterMessage.cs:542-561 — before extracting anything, compare `Server/Model/Generate/Message/InnerMessage.cs` and `Server/Model/Generate/Message/OuterMessage.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 155 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Server/Model/Generate/Message/InnerMessage.cs:428` calls `ProtoMember` and `Server/Model/Generate/Message/OuterMessage.cs:541` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (16–19 lines × 2) · ×1
  • Duplicated block (16–19 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:694 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:694-712 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:792-807 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:694` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (16–18 lines × 2) · ×1
  • Duplicated block (16–18 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:958 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:958-973 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1168-1185 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:958` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (14 lines × 3) · ×1
  • Duplicated block (14 lines × 3) Server/Model/Generate/Message/InnerMessage.cs:458 — Server/Model/Generate/Message/InnerMessage.cs:458-471 | Server/Model/Generate/Message/InnerMessage.cs:527-540 | Server/Model/Generate/Message/InnerMessage.cs:548-561 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Server/Model/Generate/Message/InnerMessage.cs:473` calls `ProtoMember` and `Server/Model/Generate/Message/InnerMessage.cs:542` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (11–14 lines × 2) · ×1
  • Duplicated block (11–14 lines × 2) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1112 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1112-1122 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1216-1229 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1112` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (13 lines × 3) · ×1
  • Duplicated block (13 lines × 3) Robot/App/Program.cs:14 — Robot/App/Program.cs:14-26 | Server/App/Program.cs:14-26 | Tools/App/Program.cs:12-24 — before extracting anything, compare `Robot/App/Program.cs` and `Server/App/Program.cs` as WHOLE FILES: 89% of the shorter file's lines also appear in the other, so this reads as one file having been copied from the other rather than as a helper waiting to be extracted. The 2 duplicated block(s) this scan matched between them are fragments of that copy, not the extent of it — treat the file pair as the unit. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Robot/App/Program.cs:14` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Server/App/Program.cs:13` calls `Init` and `Robot/App/Program.cs:13` does not — after which the two agree again for 4 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (11 lines × 3) · ×1
  • Duplicated block (11 lines × 3) Server/Model/Generate/Message/OuterMessage.cs:569 — Server/Model/Generate/Message/OuterMessage.cs:569-579 | Server/Model/Generate/Message/OuterMessage.cs:629-639 | Server/Model/Generate/Message/OuterMessage.cs:647-657 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Server/Model/Generate/Message/OuterMessage.cs:581` calls `ProtoMember` and `Server/Model/Generate/Message/OuterMessage.cs:641` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (12–13 lines × 3) · ×1
  • Duplicated block (12–13 lines × 3) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:952 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:952-963 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:973-984 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:993-1005 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:952` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (10–12 lines × 3) · ×1
  • Duplicated block (10–12 lines × 3) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1004 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1004-1014 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1113-1122 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1218-1229 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1004` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (11–12 lines × 3) · ×1
  • Duplicated block (11–12 lines × 3) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1108 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1108-1118 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1190-1201 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1212-1223 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1108` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (11 lines × 6) · ×1
  • Duplicated block (11 lines × 6) Server/Model/Generate/Message/InnerMessage.cs:461 — Server/Model/Generate/Message/InnerMessage.cs:461-471 | Server/Model/Generate/Message/InnerMessage.cs:530-540 | Server/Model/Generate/Message/InnerMessage.cs:551-561 | Server/Model/Generate/Message/OuterMessage.cs:569-579 | Server/Model/Generate/Message/OuterMessage.cs:629-639 | Server/Model/Generate/Message/OuterMessage.cs:647-657 — before extracting anything, compare `Server/Model/Generate/Message/InnerMessage.cs` and `Server/Model/Generate/Message/OuterMessage.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 155 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just after the matched lines, `Server/Model/Generate/Message/InnerMessage.cs:473` calls `ProtoMember` and `Server/Model/Generate/Message/InnerMessage.cs:542` does not — after which the two agree again for 3 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (10 lines × 5) · ×1
  • Duplicated block (10 lines × 5) Server/Model/Generate/Message/InnerMessage.cs:366 — Server/Model/Generate/Message/InnerMessage.cs:366-375 | Server/Model/Generate/Message/InnerMessage.cs:399-408 | Server/Model/Generate/Message/OuterMessage.cs:252-261 | Server/Model/Generate/Message/OuterMessage.cs:282-291 | Server/Model/Generate/Message/OuterMessage.cs:525-534 — before extracting anything, compare `Server/Model/Generate/Message/InnerMessage.cs` and `Server/Model/Generate/Message/OuterMessage.cs` as WHOLE FILES: this scan already matched 11 separate duplicated blocks between them, totalling at least 155 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. ★ These copies have DRIFTED, and that is worth reading before extracting anything: just before the matched lines, `Server/Model/Generate/Message/InnerMessage.cs:362` calls `ProtoMember` and `Server/Model/Generate/Message/OuterMessage.cs:250` does not — after which the two agree again for 2 more lines. One of those two behaviours is the intended one and the other is what a copy-paste left behind, so decide which BEFORE unifying them: extracting the shared part will silently settle it, and if the copy that skips the call is the wrong one, that bug is already live.
D4 · Code Duplication · Duplicated block (9 lines × 3) · ×1
  • Duplicated block (9 lines × 3) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:962 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:962-970 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1119-1127 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1172-1182 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:962` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (7–8 lines × 4) · ×1
  • Duplicated block (7–8 lines × 4) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:957 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:957-963 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:978-984 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:998-1005 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1167-1174 — all 4 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:957` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (7–8 lines × 3) · ×1
  • Duplicated block (7–8 lines × 3) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:751 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:751-757 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:769-776 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:787-794 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:751` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (7 lines × 3) · ×1
  • Duplicated block (7 lines × 3) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:694 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:694-702 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:774-780 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:792-798 — all 3 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it.
D4 · Code Duplication · Duplicated block (6 lines × 7) · ×1
  • Duplicated block (6 lines × 7) Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:957 — Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:957-962 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:978-983 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:998-1004 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1108-1113 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1167-1173 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1190-1196 | Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:1212-1218 — all 7 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs:957` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (5 lines × 5) · ×1
  • Duplicated block (5 lines × 5) Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:133 — Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:133-137 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:224-228 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:266-270 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:285-289 | Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:303-307 — all 5 copies are in the same file, so extract the block into one function there and call it from every one of those sites — resolving only two of them leaves the rest to drift apart the first time one is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Unity/Codes/Hotfix/Module/Battle/Combat/Buff/BuffComponentSystem.cs:133` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Near-duplicate member family (3 members, 93 shared lines) · ×1
  • Near-duplicate member family (3 members, 93 shared lines) Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:48 — Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:48-230 | Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs:48-230 | Tools/Analyzer/Analyzer/UIComponentAnalyzer.cs:60-206 — These 3 members are variants of one another: a block of 93 lines reported below appears in every one of them, and the pairwise near-duplicate rows they would otherwise produce are collapsed into this row. Read them as one construct written 3 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 3 times.
D4 · Code Duplication · Near-duplicate member pair (27 shared lines) · ×1
  • Near-duplicate member pair (27 shared lines) ThirdParty/UnityEngine/Quaternion.cs:458 — ThirdParty/UnityEngine/Quaternion.cs:458-501 | ThirdParty/UnityEngine/Quaternion.cs:504-542 — These two members are variants of one another: 27 of their lines are already reported as duplicated blocks below, spread through both bodies rather than gathered into one. Read them as a single construct written twice. The repair is at the members' grain — factor the shared pipeline into one implementation the two call with their differences as parameters or as an injected step, or, where the difference is systematic (sync against async, one transport against another), generate one from the other. Extracting the individual blocks below is not the same fix: it leaves the two bodies in place and the next edit still has to be made twice.
D4 · Code Duplication · Members sharing a duplicated core (8 members, 50+ identical tokens) · ×1
  • Members sharing a duplicated core (8 members, 50+ identical tokens) Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs:8 — Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs:8-24 | Server/Hotfix/Demo/Battle/Event/M2M_ChangeSkillGroupHandler.cs:8-40 | Server/Hotfix/Demo/Battle/Event/M2M_InterruptHandler.cs:9-35 | Server/Hotfix/Demo/Battle/Event/M2M_RemoveBuffHandler.cs:8-25 | Unity/Codes/Hotfix/Demo/Battle/M2C_AddBuffHandler.cs:7-22 | Unity/Codes/Hotfix/Demo/Battle/M2C_ChangeSkillGroupHandler.cs:8-39 | Unity/Codes/Hotfix/Demo/Battle/M2C_InterruptHandler.cs:9-34 | Unity/Codes/Hotfix/Demo/Battle/M2C_RemoveBuffHander.cs:7-23 — These 8 members share a duplicated core: a run of at least 50 identical tokens appears in every one of them. That run is NOT broken out as duplicated-block rows below — it is what admitted this row, and the blocks below cover only the part of it that clears the block floor, so they understate the correspondence. Read the members as one construct written 8 times. The repair is at the members' grain — factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Extracting the individual blocks below is not the same fix: it leaves every body in place and the next edit still has to be made 8 times.
D4 · Code Duplication · Edited copy of a member (58 corresponding lines) · ×1
  • Edited copy of a member (58 corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:885 — ThirdParty/UnityEngine/Matrix4x4.cs:885-944 | ThirdParty/UnityEngine/Matrix4x4.cs:947-1004 — These two members are one piece of code written twice and then edited apart: 58 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (26 corresponding lines) · ×1
  • Edited copy of a member (26 corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:625 — ThirdParty/UnityEngine/Quaternion.cs:625-652 | ThirdParty/UnityEngine/Quaternion.cs:655-680 — These two members are one piece of code written twice and then edited apart: 26 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 15+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 15+ corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:51 — ThirdParty/UnityEngine/Quaternion.cs:51-65 | ThirdParty/UnityEngine/Quaternion.cs:188-204 | ThirdParty/UnityEngine/Quaternion.cs:441-455 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 15 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 47+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 47+ corresponding lines) Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs:10 — Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs:10-64 | Server/Hotfix/Demo/Battle/Event/M2M_UseSkillHandler.cs:8-61 | Unity/Codes/Hotfix/Demo/Battle/M2C_UseSkillHandler.cs:9-55 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 47 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (49 corresponding lines) · ×1
  • Edited copy of a member (49 corresponding lines) Tools/App/Apps/ChapterExporter/ChapterExporter.cs:94 — Tools/App/Apps/ChapterExporter/ChapterExporter.cs:94-142 | Tools/App/Apps/ExcelExporter/ExcelExporter.cs:547-610 — These two members are one piece of code written twice and then edited apart: 49 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (56 corresponding lines) · ×1
  • Edited copy of a member (56 corresponding lines) Server/Hotfix/Demo/Transfer/TransferHelper.cs:16 — Server/Hotfix/Demo/Transfer/TransferHelper.cs:16-74 | Server/Hotfix/Demo/Transfer/TransferHelper.cs:82-137 — These two members are one piece of code written twice and then edited apart: 56 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (45 corresponding lines) · ×1
  • Edited copy of a member (45 corresponding lines) Server/Hotfix/Demo/Session/InnerMessageDispatcherHelper.cs:15 — Server/Hotfix/Demo/Session/InnerMessageDispatcherHelper.cs:15-59 | Server/Hotfix/Demo/Session/InnerMessageDispatcherHelper.cs:69-113 — These two members are one piece of code written twice and then edited apart: 45 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (6 members, 20+ corresponding lines) · ×1
  • Edited copies of one member (6 members, 20+ corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:488 — ThirdParty/UnityEngine/Matrix4x4.cs:488-509 | ThirdParty/UnityEngine/Matrix4x4.cs:512-531 | ThirdParty/UnityEngine/Matrix4x4.cs:534-555 | ThirdParty/UnityEngine/Matrix4x4.cs:558-577 | ThirdParty/UnityEngine/Matrix4x4.cs:580-601 | ThirdParty/UnityEngine/Matrix4x4.cs:604-623 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 20 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (11 corresponding lines) · ×1
  • Edited copy of a member (11 corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:338 — ThirdParty/UnityEngine/Matrix4x4.cs:338-350 | ThirdParty/UnityEngine/Matrix4x4.cs:353-363 — These two members are one piece of code written twice and then edited apart: 11 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copy of a member (8 corresponding lines) · ×1
  • Edited copy of a member (8 corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:132 — ThirdParty/UnityEngine/Quaternion.cs:132-139 | ThirdParty/UnityEngine/Quaternion.cs:154-161 — These two members are one piece of code written twice and then edited apart: 8 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 7+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 7+ corresponding lines) ThirdParty/UnityEngine/Vector3.cs:314 — ThirdParty/UnityEngine/Vector3.cs:314-322 | ThirdParty/UnityEngine/Vector3.cs:325-331 | ThirdParty/UnityEngine/Vector4.cs:282-291 | ThirdParty/UnityEngine/Vector4.cs:294-301 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 7 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 11+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 11+ corresponding lines) ThirdParty/UnityEngine/Vector3.cs:164 — ThirdParty/UnityEngine/Vector3.cs:164-174 | ThirdParty/UnityEngine/Vector3.cs:177-190 | ThirdParty/UnityEngine/Vector4.cs:153-165 | ThirdParty/UnityEngine/Vector4.cs:168-183 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 11 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 18+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 18+ corresponding lines) ThirdParty/UnityEngine/Matrix4x4.cs:231 — ThirdParty/UnityEngine/Matrix4x4.cs:231-250 | ThirdParty/UnityEngine/Matrix4x4.cs:261-278 | ThirdParty/UnityEngine/Matrix4x4.cs:281-300 | ThirdParty/UnityEngine/Matrix4x4.cs:318-335 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 18 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (6 members, 6+ corresponding lines) · ×1
  • Edited copies of one member (6 members, 6+ corresponding lines) ThirdParty/UnityEngine/Vector3.cs:232 — ThirdParty/UnityEngine/Vector3.cs:232-238 | ThirdParty/UnityEngine/Vector3.cs:248-254 | ThirdParty/UnityEngine/Vector4.cs:186-193 | ThirdParty/UnityEngine/Vector4.cs:196-201 | ThirdParty/UnityEngine/Vector4.cs:204-211 | ThirdParty/UnityEngine/Vector4.cs:214-219 — These 6 members are one piece of code written 6 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 6 times and the copies will drift further apart.
D4 · Code Duplication · Edited copy of a member (36 corresponding lines) · ×1
  • Edited copy of a member (36 corresponding lines) Server/Hotfix/Demo/Unit/UnitFactory.cs:129 — Server/Hotfix/Demo/Unit/UnitFactory.cs:129-165 | Unity/Codes/Hotfix/Demo/Unit/UnitFactory.cs:122-157 — These two members are one piece of code written twice and then edited apart: 36 consecutive lines correspond almost exactly, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below — the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain — factor the shared implementation into one the two call with their differences as parameters or as an injected step, or, where the difference is systematic (an extra return value, one transport against another), generate one from the other. Left alone, the next edit has to be made twice and the two will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 9+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 9+ corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:25 — ThirdParty/UnityEngine/Quaternion.cs:25-33 | ThirdParty/UnityEngine/Quaternion.cs:164-174 | ThirdParty/UnityEngine/Quaternion.cs:177-185 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 9 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 5+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 5+ corresponding lines) ThirdParty/UnityEngine/Vector3.cs:298 — ThirdParty/UnityEngine/Vector3.cs:298-304 | ThirdParty/UnityEngine/Vector3.cs:307-311 | ThirdParty/UnityEngine/Vector4.cs:264-271 | ThirdParty/UnityEngine/Vector4.cs:274-279 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 5 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (7 members, 6+ corresponding lines) · ×1
  • Edited copies of one member (7 members, 6+ corresponding lines) ThirdParty/UnityEngine/Vector3.cs:97 — ThirdParty/UnityEngine/Vector3.cs:97-102 | ThirdParty/UnityEngine/Vector3.cs:105-111 | ThirdParty/UnityEngine/Vector3.cs:117-122 | ThirdParty/UnityEngine/Vector3.cs:125-130 | ThirdParty/UnityEngine/Vector4.cs:87-94 | ThirdParty/UnityEngine/Vector4.cs:108-115 | ThirdParty/UnityEngine/Vector4.cs:118-125 — These 7 members are one piece of code written 7 times and then edited apart: every two of them correspond over at least 6 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 7 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (4 members, 13+ corresponding lines) · ×1
  • Edited copies of one member (4 members, 13+ corresponding lines) ThirdParty/UnityEngine/Mathf.cs:124 — ThirdParty/UnityEngine/Mathf.cs:124-136 | ThirdParty/UnityEngine/Mathf.cs:156-168 | ThirdParty/UnityEngine/Mathf.cs:188-200 | ThirdParty/UnityEngine/Mathf.cs:220-232 — These 4 members are one piece of code written 4 times and then edited apart: every two of them correspond over at least 13 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 4 times and the copies will drift further apart.
D4 · Code Duplication · Edited copies of one member (3 members, 5+ corresponding lines) · ×1
  • Edited copies of one member (3 members, 5+ corresponding lines) ThirdParty/UnityEngine/Quaternion.cs:746 — ThirdParty/UnityEngine/Quaternion.cs:746-751 | ThirdParty/UnityEngine/Vector3.cs:410-414 | ThirdParty/UnityEngine/Vector4.cs:399-404 — These 3 members are one piece of code written 3 times and then edited apart: every two of them correspond over at least 5 lines, broken only by small local edits. Most of that correspondence is NOT reported as duplicated blocks below: the edits cut it into fragments and only the largest of them clear the block floor, so the rows below understate it. The repair is at the members' grain. Factor the shared implementation out once and have all of them call it with their differences as parameters or as an injected step, or, where the difference is systematic, generate them from one template. Left alone, the next edit has to be made 3 times and the copies will drift further apart.
D4 · Code Duplication · Duplicated block (90 lines × 2) · ×1
  • Duplicated block (90 lines × 2) Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:110 — Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:110-199 | Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs:110-199 — before extracting anything, compare `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs` and `Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 227 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:110` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (44–49 lines × 2) · ×1
  • Duplicated block (44–49 lines × 2) Tools/App/Apps/ChapterExporter/ChapterExporter.cs:99 — Tools/App/Apps/ChapterExporter/ChapterExporter.cs:99-142 | Tools/App/Apps/ExcelExporter/ExcelExporter.cs:562-610 — `Tools/App/Apps/ChapterExporter/ChapterExporter.cs` and `Tools/App/Apps/ExcelExporter/ExcelExporter.cs` are one unit implemented once per sibling directory, so they are most likely parallel implementations of one contract rather than a copy of each other — this scan matched 4 separate duplicated blocks between them, totalling at least 80 lines. If both are selected at run time, neither can be retired in favour of the other, and the lines that DIFFER between them are the reason both exist. The move that pays here is to hoist the identical part into a shared location the whole family can reach and give what differs a parameter or a seam, so a change lands once instead of once per sibling; extracting one helper per block leaves every sibling to drift on its own. Read the line range as the matched WINDOW rather than a finished unit: at `Tools/App/Apps/ChapterExporter/ChapterExporter.cs:99` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (41 lines × 2) · ×1
  • Duplicated block (41 lines × 2) Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs:11 — Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs:11-51 | Server/Hotfix/Demo/Battle/Event/M2M_UseSkillHandler.cs:19-59 — before extracting anything, compare `Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs` and `Server/Hotfix/Demo/Battle/Event/M2M_UseSkillHandler.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `C2M_UseSkill` in one and `M2M_UseSkill` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (34–36 lines × 3) · ×1
  • Duplicated block (34–36 lines × 3) Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:170 — Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:170-203 | Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs:170-203 | Tools/Analyzer/Analyzer/UIComponentAnalyzer.cs:144-179 — before extracting anything, compare `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs` and `Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 227 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:170` it begins part-way through the construct above it, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (30 lines × 2) · ×1
  • Duplicated block (30 lines × 2) Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:67 — Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:67-96 | Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs:67-96 — before extracting anything, compare `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs` and `Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 227 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:67` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (29 lines × 2) · ×1
  • Duplicated block (29 lines × 2) Server/Hotfix/Demo/Battle/Event/M2M_ChangeSkillGroupHandler.cs:12 — Server/Hotfix/Demo/Battle/Event/M2M_ChangeSkillGroupHandler.cs:12-40 | Unity/Codes/Hotfix/Demo/Battle/M2C_ChangeSkillGroupHandler.cs:11-39 — before extracting anything, compare `Server/Hotfix/Demo/Battle/Event/M2M_ChangeSkillGroupHandler.cs` and `Unity/Codes/Hotfix/Demo/Battle/M2C_ChangeSkillGroupHandler.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 49 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Hotfix/Demo/Battle/Event/M2M_ChangeSkillGroupHandler.cs:12` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `M2M_ChangeSkillGroup` in one and `M2C_ChangeSkillGroup` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (24 lines × 3) · ×1
  • Duplicated block (24 lines × 3) Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:80 — Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:80-103 | Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs:80-103 | Tools/Analyzer/Analyzer/UIComponentAnalyzer.cs:116-139 — before extracting anything, compare `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs` and `Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 227 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:80` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (17 lines × 3) · ×1
  • Duplicated block (17 lines × 3) Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:214 — Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:214-230 | Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs:214-230 | Tools/Analyzer/Analyzer/UIComponentAnalyzer.cs:190-206 — before extracting anything, compare `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs` and `Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 227 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:214` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (24–25 lines × 2) · ×1
  • Duplicated block (24–25 lines × 2) Server/Hotfix/Demo/Move/MoveHelper.cs:25 — Server/Hotfix/Demo/Move/MoveHelper.cs:25-49 | Server/Hotfix/Demo/Move/MoveHelper.cs:56-79 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Hotfix/Demo/Move/MoveHelper.cs:25` it runs out through the closing brace of the declaration holding it — the window is that declaration's tail, not a fragment that begins part-way through something, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that.
D4 · Code Duplication · Duplicated block (21 lines × 3) · ×1
  • Duplicated block (21 lines × 3) Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs:31 — Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs:31-51 | Server/Hotfix/Demo/Battle/Event/M2M_UseSkillHandler.cs:39-59 | Unity/Codes/Hotfix/Demo/Battle/M2C_UseSkillHandler.cs:34-54 — before extracting anything, compare `Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs` and `Server/Hotfix/Demo/Battle/Event/M2M_UseSkillHandler.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 70 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs:31` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it. The matched lines also transfer control out of the body holding them, which cannot survive a move into a called unit unchanged: have the extracted unit return that decision and let each site act on it. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `C2M_UseSkill` in one and `M2M_UseSkill` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (22 lines × 2) · ×1
  • Duplicated block (22 lines × 2) Server/Hotfix/Demo/Battle/Event/M2M_InterruptHandler.cs:12 — Server/Hotfix/Demo/Battle/Event/M2M_InterruptHandler.cs:12-33 | Unity/Codes/Hotfix/Demo/Battle/M2C_InterruptHandler.cs:12-33 — before extracting anything, compare `Server/Hotfix/Demo/Battle/Event/M2M_InterruptHandler.cs` and `Unity/Codes/Hotfix/Demo/Battle/M2C_InterruptHandler.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 42 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `M2M_Interrupt` in one and `M2C_Interrupt` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (18–20 lines × 3) · ×1
  • Duplicated block (18–20 lines × 3) Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:62 — Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:62-81 | Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs:62-81 | Tools/Analyzer/Analyzer/UIComponentAnalyzer.cs:74-91 — before extracting anything, compare `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs` and `Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 227 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (15–16 lines × 2) · ×1
  • Duplicated block (15–16 lines × 2) ThirdParty/UnityEngine/Quaternion.cs:754 — ThirdParty/UnityEngine/Quaternion.cs:754-769 | ThirdParty/UnityEngine/Quaternion.cs:900-914 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Read the line range as the matched WINDOW rather than a finished unit: at `ThirdParty/UnityEngine/Quaternion.cs:754` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note that the copies do not run to the end of the range shown: their LAST lines are different code, not the same code under different names — the matched region ends inside that line. Extract the lines above it, and read the last line of each site separately.
D4 · Code Duplication · Duplicated block (13–14 lines × 2) · ×1
  • Duplicated block (13–14 lines × 2) Server/Hotfix/Demo/Move/Event/M2M_PathfindingResultHandler.cs:16 — Server/Hotfix/Demo/Move/Event/M2M_PathfindingResultHandler.cs:16-28 | Unity/Codes/Hotfix/Demo/Move/M2C_PathfindingResultHandler.cs:11-24 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `M2M_PathfindingResult` in one and `M2C_PathfindingResult` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (9 lines × 8) · ×1
  • Duplicated block (9 lines × 8) Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs:10 — Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs:10-18 | Server/Hotfix/Demo/Battle/Event/M2M_ChangeSkillGroupHandler.cs:11-19 | Server/Hotfix/Demo/Battle/Event/M2M_InterruptHandler.cs:11-19 | Server/Hotfix/Demo/Battle/Event/M2M_RemoveBuffHandler.cs:10-18 | Unity/Codes/Hotfix/Demo/Battle/M2C_AddBuffHandler.cs:9-17 | Unity/Codes/Hotfix/Demo/Battle/M2C_ChangeSkillGroupHandler.cs:10-18 | Unity/Codes/Hotfix/Demo/Battle/M2C_InterruptHandler.cs:11-19 | Unity/Codes/Hotfix/Demo/Battle/M2C_RemoveBuffHander.cs:9-17 — before extracting anything, compare `Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs` and `Unity/Codes/Hotfix/Demo/Battle/M2C_AddBuffHandler.cs` as WHOLE FILES: this scan already matched 3 separate duplicated blocks between them, totalling at least 32 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. The two sit in different directories, so one cannot simply be deleted in favour of the other while both are reached separately: hoist the shared part into a location both already depend on and have each file call it, and retire whichever file turns out to have no caller of its own left. Extracting one helper per block leaves the fork in place. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Hotfix/Demo/Battle/Event/M2M_AddBuffHandler.cs:10` it does not close everything it opens, so those exact lines cannot be lifted as they stand — widen the region to the smallest complete statement or declaration that contains it, and extract that. Note first that the copies are not typed on the same thing: the declarations holding them bind `message` to `M2M_AddBuff` in one and `M2M_ChangeSkillGroup` in another, and the duplicated lines use it. The extracted unit therefore needs a parameter type that fits BOTH — their common supertype where they have one, or a new abstraction over them where they do not — and settling that is the step that comes BEFORE the extraction above. Where the two types are deliberately unrelated, the duplication is the price of that separation and the honest resolution is to record the decision rather than to extract.
D4 · Code Duplication · Duplicated block (43–44 lines × 2) · ×1
  • Duplicated block (43–44 lines × 2) Server/Hotfix/Demo/Transfer/TransferHelper.cs:24 — Server/Hotfix/Demo/Transfer/TransferHelper.cs:24-66 | Server/Hotfix/Demo/Transfer/TransferHelper.cs:88-131 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited.
D4 · Code Duplication · Duplicated block (28 lines × 2) · ×1
  • Duplicated block (28 lines × 2) Server/Hotfix/Demo/Unit/UnitComponentSystem.cs:7 — Server/Hotfix/Demo/Unit/UnitComponentSystem.cs:7-34 | Unity/Codes/Hotfix/Demo/Unit/UnitComponent.cs:7-35 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Hotfix/Demo/Unit/UnitComponentSystem.cs:7` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (27 lines × 2) · ×1
  • Duplicated block (27 lines × 2) Server/Model/Demo/Unit/Unit.cs:23 — Server/Model/Demo/Unit/Unit.cs:23-49 | Unity/Codes/Model/Demo/Unit/Unit.cs:22-49 — the copies span different directories, so extracting a shared function means choosing where it lives: put it somewhere both call sites can already reach — a location they all depend on today, or a new shared one if there is none — and call it from each site; until then, every change has to be made twice. Read the line range as the matched WINDOW rather than a finished unit: at `Server/Model/Demo/Unit/Unit.cs:23` it runs out through the closing brace of the declaration holding it and carries on into the declaration that follows — the window is the tail of one member plus the head of the next, so no call can be substituted for those exact lines, and the smallest declaration that contains all of them is the type they sit in. The repeated unit is the member each site sits in: where those members' bodies are the same, move one whole member to the shared location and have the others delegate to it; where the copies are a run of near-identical overloads or wrappers that differ only in their signatures, the repetition IS the run — a one-line delegation has no helper inside it to lift — so generate the run from the set it enumerates, or accept it and keep each member's own documentation with it.
D4 · Code Duplication · Duplicated block (9 lines × 4) · ×1
  • Duplicated block (9 lines × 4) Tools/Analyzer/Analyzer/ClassDeclarationInHotfixAnalyzer.cs:28 — Tools/Analyzer/Analyzer/ClassDeclarationInHotfixAnalyzer.cs:28-36 | Tools/Analyzer/Analyzer/EntityClassDeclarationAnalyzer.cs:28-36 | Tools/Analyzer/Analyzer/EntityMethodDeclarationAnalyzer.cs:36-44 | Tools/Analyzer/Analyzer/HotfixProjectFieldDeclarationAnalyzer.cs:26-34 — the copies sit in sibling files of one directory, so a shared home is within easy reach: extract the block into a single shared function the call sites can all reach — a file they already depend on, or a new one alongside them — and call it from all 4 call sites, so a change lands once. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D4 · Code Duplication · Duplicated block (9 lines × 5) · ×1
  • Duplicated block (9 lines × 5) Tools/Analyzer/Analyzer/ETTaskAnalyzer.cs:19 — Tools/Analyzer/Analyzer/ETTaskAnalyzer.cs:19-27 | Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:37-45 | Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs:37-45 | Tools/Analyzer/Analyzer/EntityFiledAccessAnalyzer.cs:36-45 | Tools/Analyzer/Analyzer/UIComponentAnalyzer.cs:49-57 — before extracting anything, compare `Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs` and `Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs` as WHOLE FILES: this scan already matched 7 separate duplicated blocks between them, totalling at least 227 lines, which is the signature of one file having been copied from the other rather than of a helper waiting to be extracted. If that is what happened, the fix is to keep one copy and have the other call it (or delete it), which resolves this row and its siblings together — extracting one helper per block leaves the fork in place.
D4 · Code Duplication · Duplicated block (35 lines × 2) · ×1
  • Duplicated block (35 lines × 2) ThirdParty/UnityEngine/Matrix4x4.cs:1092 — ThirdParty/UnityEngine/Matrix4x4.cs:1092-1126 | ThirdParty/UnityEngine/Matrix4x4.cs:1376-1410 — both copies are in the same file, so extract the block into one function there and call it from each site — the copies drift apart the first time only one of them is edited. Each matched range is the entire body of the declaration above it, so the region is already a complete unit: move that whole declaration to the shared location and have each site call it, rather than lifting the lines out of their bodies. Any `return` inside it is the body's own exit and keeps its meaning in the moved unit.
D8 · Code Coverage · Coverage not measured · ×1
  • Coverage not measured — test suite did not build — Coverage NOT MEASURED: this repository did not build in our analyzer environment (a C#/MSBuild compiler error), so no coverage could be collected. It is excluded from the score rather than counted as a near-zero defect. We did not read WHERE the failing diagnostic is, so this does not claim the fault is in your test code — a repository written for an older SDK band can compile for you and not for us. Run `dotnet build` on this commit; if it succeeds, the gap is ours. Committing the Cobertura/OpenCover/lcov report your CI already produces also lets us measure real coverage without building anything.
P1 · CI/CD gates · No CI pipeline · ×1
  • No CI pipeline — No CI workflow found (.github/workflows, azure-pipelines.yml, .gitlab-ci.yml, …) — changes aren't gated by an automated build/test.
S1 · Cryptographic Hygiene · Weak hash algorithm · ×1
  • Weak hash algorithm Unity/Assets/Mono/Core/Helper/MD5Helper.cs:13 — MD5/SHA1 is constructed here, and both are collision-broken. If this digest protects anything — a signature, an integrity or tamper check, a credential, or any value an attacker can influence — that is a real weakness: use SHA-256+ for content integrity, or a KDF (PBKDF2/Argon2/BCrypt) for password storage. If it only derives a non-security identifier (a cache key, a file or mutex name), collision resistance carries no security consequence here; make that intent explicit instead — a non-cryptographic hash such as `System.IO.Hashing.XxHash64`/`Crc32` says it in code — since the algorithm alone cannot distinguish the two uses.
X1 · Async correctness · async void method · ×1
  • async void method: WaitExitAsync Unity/Assets/Mono/Core/Helper/ProcessHelper.cs:48 — `async void` can't be awaited and its exceptions crash the process instead of propagating. Return `Task` — or, where the delegate contract requires void (timer/event/callback registrations), make this a thin void shim that awaits a Task-returning inner method inside try/catch so exceptions are contained.
X1 · Async correctness · Blocking `StreamReader.ReadToEnd` inside an `async` method · ×1
  • Blocking `StreamReader.ReadToEnd` inside an `async` method Unity/Assets/Mono/Core/Helper/ProcessHelper.cs:52 — `StreamReader.ReadToEnd` blocks the thread on I/O while `StreamReader.ReadToEndAsync` exists to wait without one — inside a method that is already `async`, await the twin.
X1 · Async correctness · Sync-over-async (deadlock risk) through `Task.WaitAll` · ×1
  • Sync-over-async (deadlock risk) through `Task.WaitAll` Tools/App/Apps/ExcelExporter/ExcelExporter.cs:236 — `Task.WaitAll` blocks this thread until the tasks complete — sync-over-async: it can deadlock under a synchronization context and it parks a thread for as long as the work runs. `await Task.WhenAll(…)` instead.
X26 · Unsynchronised callback handoff · Collection crosses a callback boundary unsynchronised · ×1
  • Collection crosses a callback boundary unsynchronised Unity/Assets/Mono/Module/NetworkTCP/TService.cs:75 — `TService.idChannels` is a `Dictionary<…>` that a `SocketAsyncEventArgs.Completed +=` callback writes (`Add` on line 75) and `Dispose` reads (line 131). The runtime runs that callback on a thread the rest of the type does not own — a pool or I/O thread for a watcher, timer or process event, the completing thread for a continuation, the cancelling thread for a token registration, the pool for a `Progress<T>` made without a UI context — while `Dispose` runs on whichever thread calls it. `Dictionary<…>` allows many readers or one writer, never both: a read that meets the write sees a torn resize, an enumeration throws `InvalidOperationException`, and two writes lose or duplicate entries. Take one `lock` over the write and every read of `idChannels`, use a `System.Collections.Concurrent` collection, or marshal the callback onto the reader's synchronisation context.
X3 · Exception handling · Swallowed exception (empty catch) · ×1
  • Swallowed exception (empty catch) Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/RenderingUtils.cs:94 — An empty catch block silently discards the error — failures vanish with no log and no rethrow. Log it, handle it, or don't catch it.
Minor — 105 finding(s)
IC1 · Incompleteness & stubs · Commented-out code · ×32
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:12 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:15 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:18 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:20 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:22 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:24 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:27 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:28 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:29 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:32 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:33 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:34 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Actor_TransferHandler.cs:37 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Demo/Unit/UnitFactory.cs:104 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Handler/C2M_ReloadHandler.cs:13 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Handler/C2M_ReloadHandler.cs:14 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Handler/C2M_ReloadHandler.cs:16 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Handler/C2M_ReloadHandler.cs:17 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Handler/C2M_ReloadHandler.cs:20 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Handler/C2M_ReloadHandler.cs:21 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Handler/C2M_ReloadHandler.cs:22 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:86 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:106 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:107 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • Commented-out code ThirdParty/UnityEngine/Quaternion.cs:388 — A line of code has been commented out rather than removed — dead weight that rots and confuses. Delete it (version control remembers).
  • + 7 more in this group — see findings.md.
D34 · Knowledge Freshness · Orphaned file · ×30
  • Orphaned file REDACTED:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Model/Generate/Message/OuterMessage.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Hotfix/Module/DB/DBComponentSystem.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Hotfix/Module/ActorLocation/ActorLocationSenderComponentSystem.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Tools/Analyzer/Extension/AnalyzerHelper.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Hotfix/Module/Actor/ActorMessageSenderComponentSystem.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Tools/Analyzer/Analyzer/EntityFiledAccessAnalyzer.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Hotfix/Module/MessageInner/NetInnerComponentSystem.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Tools/Analyzer/Analyzer/ETTaskAnalyzer.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Hotfix/AppStart_Init.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Tools/Analyzer/CodeFixer/EntityFiledAccessCodeFixProvider.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Model/Generate/ConfigPartial/StartSceneConfig.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Hotfix/Module/Http/HttpComponentSystem.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Hotfix/Module/ActorLocation/LocationComponentSystem.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Hotfix/Module/Console/ConsoleComponentSystem.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Model/Base/MongoHelper.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Tools/Analyzer/Analyzer/EntityMethodDeclarationAnalyzer.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Robot/Hotfix/Module/RobotCase/RobotCaseSystem.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Hotfix/Module/Actor/ActorMessageDispatcherComponentSystem.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Hotfix/Module/ActorLocation/LocationProxyComponentSystem.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Tools/Analyzer/Analyzer/ClassDeclarationInHotfixAnalyzer.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Model/Generate/Config/UnitConfig.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Server/Model/Generate/Config/StartSceneConfig.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • Orphaned file Robot/Hotfix/Robot/Console/CreateRobotConsoleHandler.cs:1 — No one still active in this repository holds living knowledge of this file: everyone who made a meaningful change to it has gone quiet, or what the current team did to it (moves, reformatting, log-level or import edits, renames) never needed understanding it. If it breaks, no one currently understands it. Attach the read to the next change that touches it: have a second person review that change, and leave behind a short comment or test recording what the file is for.
  • + 5 more in this group — see findings.md.
X10 · Duplicated predicate · Duplicated predicate · ×10
  • Duplicated predicate Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:67 — `!(memberAccessExpressionSyntax?.Parent is InvocationExpressionSyntax invocationExpressionSyntax) || !(context.SemanticModel.GetSymbolInfo(in…` appears character-identically in 2 files — Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs, Tools/Analyzer/Analyzer/UIComponentAnalyzer.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Tools/App/Apps/AreaExporter/AreaExporter.cs:31 — `!fileName.EndsWith(".xlsx") || fileName.StartsWith("~$") || fileName.Contains("#")` appears character-identically in 4 files — Tools/App/Apps/AreaExporter/AreaExporter.cs, Tools/App/Apps/ChapterExporter/ChapterExporter.cs, Tools/App/Apps/ExcelExporter/ExcelExporter.cs, Tools/App/Apps/I18NExporter/I18NExporter.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Unity/Assets/Mono/Core/Helper/AOIHelper.cs:252 — `-xMax <= temp.x && temp.x <= xMax && -yMax <= temp.y && temp.y <= yMax && -zMax <= temp.z && temp.z <= zMax` appears character-identically in 2 files — Unity/Assets/Mono/Core/Helper/AOIHelper.cs, Unity/Codes/Hotfix/Module/AOI/Trigger/AOITriggerSystem.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Unity/Codes/Hotfix/Module/AOI/Event/ChangePosition_MoveAOIUnit.cs:11 — `aoiUnitComponent == null || aoiUnitComponent.IsDisposed` appears character-identically in 2 files — Unity/Codes/Hotfix/Module/AOI/Event/ChangePosition_MoveAOIUnit.cs, Unity/Codes/Hotfix/Module/AOI/Event/ChangeRotation_TurnAOIUnit.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:220 — `availableParentTypeSymbol!=null && availableParentTypeSymbol.ToString()==parentTypeSymbol.ToString()` appears character-identically in 3 files — Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs, Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs, Tools/Analyzer/Analyzer/UIComponentAnalyzer.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs:12 — `combatU != null&&combatU.TryGetSkillAbility(message.SkillConfigId,out SkillAbility skill)` appears character-identically in 3 files — Server/Hotfix/Demo/Battle/C2M_UseSkillHandler.cs, Server/Hotfix/Demo/Battle/Event/M2M_UseSkillHandler.cs, Unity/Codes/Hotfix/Demo/Battle/M2C_UseSkillHandler.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs:214 — `hasParentTypeAttribute&&availableParentTypeSymbol==null` appears character-identically in 3 files — Tools/Analyzer/Analyzer/EntityChildAnalyzer.cs, Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs, Tools/Analyzer/Analyzer/UIComponentAnalyzer.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs:74 — `self.socket != null && self.socket.Available > 0` appears character-identically in 3 files — Server/Hotfix/Module/Router/RouterServiceComponentSystem.cs, Server/Hotfix/Module/Router/RouterServiceInnerComponentSystem.cs, Unity/Codes/Hotfix/Module/Router/GetRouterComponentAwakeSystem.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Server/Model/Generate/Config/AIConfig.cs:71 — `this.dict == null || this.dict.Count <= 0` appears character-identically in 23 files — Server/Model/Generate/Config/AIConfig.cs, Server/Model/Generate/Config/AttributeConfig.cs, Server/Model/Generate/Config/BuffActionControlConfig.cs, Server/Model/Generate/Config/BuffAttrConfig.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
  • Duplicated predicate Tools/App/Apps/AreaExporter/AreaExporter.cs:59 — `worksheet.Dimension==null||worksheet.Dimension.End==null` appears character-identically in 5 files — Tools/App/Apps/AreaExporter/AreaExporter.cs, Tools/App/Apps/AttrExporter/AttrExporter.cs, Tools/App/Apps/ChapterExporter/ChapterExporter.cs, Tools/App/Apps/ExcelExporter/ExcelExporter.cs. It is one line, so the duplication detector's token window never sees it; the copies drift when only one is corrected. Give the condition a name and one home.
D24 · Comment Value · redundant comment · ×8
  • redundant comment Unity/Codes/Model/Core/Object/EventSystem.cs:266 — "GetComponentSystem" repeats the code it sits on: 3 of its 3 words (get, component, system) are already in `public void GetComponent(Entity entity, Entity component)`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment Unity/Codes/Model/Core/Object/EventSystem.cs:294 — "AddComponentSystem" repeats the code it sits on: 3 of its 3 words (add, component, system) are already in `public void AddComponent(Entity entity, Entity component)`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/DeferredLights.cs:341 — "Offset of each type of lights in m_stencilVisLights." repeats the code it sits on: 4 of its 5 words (offset, lights, stencil, vis) are already in `NativeArray<ushort> m_stencilVisLightOffsets;`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/DeferredShaderData.cs:142 — "Create new buffer." repeats the code it sits on: 3 of its 3 words (create, new, buffer) are already in `m_Buffers[m_BufferCount] = new ComputeBuffer(count, stride, type, ComputeBufferMode.Immutable);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/Passes/DeferredPass.cs:36 — "ScriptableRenderPass" repeats the code it sits on: 3 of its 3 words (scriptable, render, pass) are already in `public override void Execute(ScriptableRenderContext context, ref RenderingData renderingData)`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/Passes/TransparentSettingsPass.cs:31 — "Get a command buffer..." repeats the code it sits on: 3 of its 3 words (get, command, buffer) are already in `CommandBuffer cmd = CommandBufferPool.Get();`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/ScriptableRenderer.cs:404 — "Dispose all renderer features..." repeats the code it sits on: 3 of its 3 words (dispose, renderer, features) are already in `for (int i = 0; i < m_RendererFeatures.Count; ++i)`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
  • redundant comment Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/ScriptableRenderer.cs:518 — "Sort the render pass queue" repeats the code it sits on: 4 of its 4 words (sort, render, pass, queue) are already in `SortStable(m_ActiveRenderPassQueue);`. Delete it, or replace it with what the code cannot say (why it is done here, a constraint, or a consequence).
D26 · Project Cohesion · Projects may be oversized for their cohesion · ×6
  • Projects may be oversized for their cohesion Robot/Model/Robot.Model.csproj:1 — `Robot.Model` overshoots its size bounds (15501 LoC, 480 public types across 4 namespaces). 6 of 15 project(s) overshoot their size bounds, lowering Project Cohesion to 2.5/10. Size alone is no reason to split a project: where its type references show a separable part, a Split row names it.
  • Projects may be oversized for their cohesion Server/Model/Server.Model.csproj:1 — `Server.Model` overshoots its size bounds (15548 LoC, 473 public types across 3 namespaces). 6 of 15 project(s) overshoot their size bounds, lowering Project Cohesion to 2.5/10. Size alone is no reason to split a project: where its type references show a separable part, a Split row names it.
  • Projects may be oversized for their cohesion Unity/Unity.RenderPipelines.Universal.Runtime.csproj:1 — `Unity.RenderPipelines.Universal.Runtime` overshoots its size bounds (21033 LoC, 148 public types across 6 namespaces). 6 of 15 project(s) overshoot their size bounds, lowering Project Cohesion to 2.5/10. Size alone is no reason to split a project: where its type references show a separable part, a Split row names it.
  • Projects may be oversized for their cohesion Server/Hotfix/Server.Hotfix.csproj:1 — `Server.Hotfix` overshoots its size bounds (11493 LoC, 260 public types across 1 namespaces). 6 of 15 project(s) overshoot their size bounds, lowering Project Cohesion to 2.5/10. Size alone is no reason to split a project: where its type references show a separable part, a Split row names it.
  • Projects may be oversized for their cohesion Robot/Hotfix/Robot.Hotfix.csproj:1 — `Robot.Hotfix` overshoots its size bounds (9656 LoC, 215 public types across 1 namespaces). 6 of 15 project(s) overshoot their size bounds, lowering Project Cohesion to 2.5/10. Size alone is no reason to split a project: where its type references show a separable part, a Split row names it.
  • Projects may be oversized for their cohesion Tools/App/Tools.App.csproj:1 — `Tools.App` overshoots its size bounds (7967 LoC, 156 public types across 1 namespaces). 6 of 15 project(s) overshoot their size bounds, lowering Project Cohesion to 2.5/10. Size alone is no reason to split a project: where its type references show a separable part, a Split row names it.
X4 · Structured logging · Interpolated log message defeats structured logging · ×6
  • Interpolated log message defeats structured logging Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/ScriptableRendererData.cs:135 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/UniversalAdditionalCameraData.cs:454 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/Data/UniversalRenderPipelineAsset.cs:323 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/Data/UniversalRenderPipelineAsset.cs:448 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/Passes/ColorGradingLutPass.cs:29 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
  • Interpolated log message defeats structured logging Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/Passes/PostProcessPass.cs:1272 — Logging an interpolated string (`$"..."`) collapses the event to plain text — you lose the named, queryable properties structured logging exists for. Use a message template with placeholders: `LogInformation("User {UserId} did {Action}", id, action)`. If these calls go through a logging wrapper that only accepts a pre-formatted string, give the wrapper a template+args overload that forwards to the underlying logger, then migrate call sites to it.
D19 · Documentation Quality · Documentation · ×2
  • Documentation: no build, run or usage example Unity/Packages/com.code-philosophy.hybridclr/README.md:1 — `com.code-philosophy.hybridclr` is a published package (`package.json` without `"private": true`) and neither `Unity/Packages/com.code-philosophy.hybridclr/README.md` nor the documents it links hold a code block or a command. Show the command that builds or runs it, or a usage snippet.
  • Documentation: no build, run or usage example Unity/Packages/com.tuyoogame.yooasset/README.md:1 — `com.tuyoogame.yooasset` is a published package (`package.json` without `"private": true`) and neither `Unity/Packages/com.tuyoogame.yooasset/README.md` nor the documents it links hold a code block or a command. Show the command that builds or runs it, or a usage snippet.
D20 · ADR Quality · No ADRs found · ×1
  • No ADRs found Robot/App/Robot.App.csproj:4 — No ADRs found. No recognised ADR directory (`docs/adr/`, `docs/decisions/`, `adr/`, `docs/rfcs/`, an `ADR0001/` folder, or their siblings) exists anywhere in this tree. What was searched, so you can tell an empty log from a search that missed one: every directory under the tree (build output, dependencies and VCS metadata excepted), for a document that is either any non-index page inside a recognised ADR directory, whatever its name and however deeply nested (`docs/adr/use-postgres.md`, `docs/adr/2024/0001-x.md`); or a file anywhere whose name is ADR-shaped (`0001-use-postgres.md`, `adr-012-caching.md`); or, when neither turned anything up, a document carrying the decision-record signature (an "Architecture Decision Record" heading, or Status / Context / Decision / Consequences as section headings). A decision log that clears none of these — unnumbered files outside any recognised directory, without those headings — is not seen by this check and this row is then wrong. If that is your case, say so rather than renaming anything; otherwise, consider recording architectural decisions in `docs/adr/`. ADRs are expected here because `Robot/App/Robot.App.csproj` makes this repository a deployable product (line 4).
D27 · Navigability · Pass-through layer · ×1
  • Pass-through layer Unity/Assets/Mono/Core/Log/NLogger.cs:6 — NLogger: all 12 public methods forward their arguments unchanged to logger and add no behaviour — an extra hop (and usually an extra interface) to trace through. Call logger directly, or give the layer a job.
D28 · Secrets (history) · Rotate the exposed credentials · ×1
  • REDACTED
D34 · Knowledge Freshness · Further orphaned files (smaller) · ×1
  • Further orphaned files (smaller) — 30 smaller file(s) also have no living knowledge — folded into the freshness score and metrics rather than raised one row each — most significant first: REDACTED, Server/Model/Generate/Message/OuterMessage.cs, Tools/Analyzer/Analyzer/EntityComponentAnalyzer.cs, Server/Hotfix/Module/DB/DBComponentSystem.cs, Server/Hotfix/Module/ActorLocation/ActorLocationSenderComponentSystem.cs, Tools/Analyzer/Extension/AnalyzerHelper.cs, Server/Hotfix/Module/Actor/ActorMessageSenderComponentSystem.cs, Tools/Analyzer/Analyzer/EntityFiledAccessAnalyzer.cs (and 22 more) (31 orphaned of 117 analysed files in total, counted over production source files of roughly 2,400 bytes or more, excluding vendored, generated, example/demo and scaffolding-template trees and test files identified by path convention, largest first; 117 of the 254 production source files in this repository met that bar). Attach the read to the next change that touches one of them: have a second person review that change, and leave behind a short comment or test recording what the file is for, so the knowledge comes back at the cost of a change you were making anyway.
M2 · Architecture documentation · No ADRs · ×1
  • No ADRs — No Architecture Decision Records found — no conventional ADR directory, no numbered `NNNN-title` documents in any markup this check reads, and nothing ADR-shaped by content. Design rationale recorded elsewhere (a design-notes tree, a mailing list, pull-request discussion) is not visible to this check and is not re-findable per decision, so a future maintainer cannot ask why one choice was made and get an answer.
M2 · Architecture documentation · No architecture diagram/doc · ×1
  • No architecture diagram/doc — No C4/Structurizr/PlantUML/Mermaid/Graphviz/D2 diagram, no drawn diagram named for the architecture, no file named `architecture` or `design` in any markup this check reads, and nothing in the README, docs or contributor guides that announces the shape — no `## Architecture` heading, no "architecture overview"/"high-level design" phrasing, no "the architecture is …" introduction, no guided code tour. A shape laid out in prose that never names itself as the architecture is not visible to this check, and neither is one kept outside the repository, so this row reports the absence of a re-findable shape document — not evidence that nobody wrote the shape down.
P10 · Library API & versioning · No explicit versioning · ×1
  • No explicit versioning — No explicit version was found by any of the six routes this check reads: a `<Version>` or `<VersionPrefix>` property; a `GitVersion` or `MinVer` reference; the split Arcade spelling (`<MajorVersion>` AND `<MinorVersion>` together); a hand-written `[assembly: AssemblyVersion]` in source, with `bin/` and `obj/` excluded so the SDK's generated AssemblyInfo cannot satisfy it; or a version handed to MSBuild by the pipeline, as `-p:Version=` / `-p:PackageVersion=` on a `dotnet build` or `dotnet pack` line. Only project files, first-party source and CI files are read, so a version computed somewhere none of those can see is invisible here. A published library needs explicit semantic versioning so consumers can reason about breaking changes.
P3 · Security & performance tooling · No SAST · ×1
  • No SAST — No static application security testing detected. For this repository's stack, add CodeQL's csharp pack, or a .NET security analyzer package (or `semgrep --config=auto`, which runs on any language) — this repository has no CI pipeline yet, so run it locally to clear the existing findings, then make it a step of the first workflow you add so a regression fails the build. What was searched, so you can tell an absence from a miss: the 0 CI workflow file(s) in this repository, and the scanner and linter configuration checked in beside them. A scan that runs outside CI, one configured in your forge's web UI rather than in a committed file, or a tool whose name is none of those this check carries, is not seen — if that is your case the row is wrong, and saying so is more useful than adding a second scanner.
P3 · Security & performance tooling · No dependency-update automation · ×1
  • No dependency-update automation ThirdParty/ShareLib/ShareLib.csproj:64 — `ThirdParty/ShareLib/ShareLib.csproj` declares packages, and nothing in the repository keeps them current: no Dependabot or Renovate configuration that schedules updates, and no dependency-review gate on pull requests. A pinned dependency stays at the version it was added at until someone notices — including after an advisory is published against it. Add a `.github/dependabot.yml` with one `package-ecosystem` entry per ecosystem the tree uses (or an enabled `renovate.json`), and gate pull requests with `actions/dependency-review-action`.
X2 · Cancellation propagation · Not all async methods take a CancellationToken · ×1
  • Not all async methods take a CancellationToken — Only 14/34 async methods accept a CancellationToken, so in-flight work can't be stopped early when the caller gives up — whatever ends it in your host (shutdown signal, timeout, abandoned request, user cancel). Thread a token through the call chain and honour it at each await and loop; where a method genuinely cannot be interrupted, omitting it is a deliberate choice — judge against your hosting model.
X5 · Nullable reference types · Nullable reference types not enabled everywhere · ×1
  • Nullable reference types not enabled everywhere — 1/12 NRT-eligible project(s) enable <Nullable>enable</Nullable> (projects targeting a pre-C#-8 framework are excluded — NRTs aren't available there). NRTs catch a whole class of null-deref bugs at compile time.
Minor — 4 finding(s)
D24 · Comment Value · doc comments repeat the names · ×4
  • doc comments repeat the names Server/Hotfix/Module/AOI/Ghost/GhostComponentSystem.cs:43 — 0 of 178 documented parameters and 0 of 0 summaries in `Server.Hotfix` only repeat the member or parameter name (e.g. "" for `self`). 178 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names Server/Model/Generate/Config/AIConfig.cs:82 — 0 of 15 documented parameters and 26 of 28 summaries in `Server.Model` only repeat the member or parameter name (e.g. "Id" for `Id`). 15 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names Unity/Codes/Model/Module/I18N/I18NConfig.cs:68 — 0 of 0 documented parameters and 1 of 1 summaries in `Tools.App` only repeat the member or parameter name (e.g. "Id" for `Id`). Delete the restating tags, or add what the name does not say.
  • doc comments repeat the names Unity/Packages/com.unity.render-pipelines.universal@10.8.1/Runtime/2D/Light2D.cs:72 — 5 of 125 documented parameters and 4 of 263 summaries in `Unity.RenderPipelines.Universal.Runtime` only repeat the member or parameter name (e.g. "The lights current type" for `lightType`). 35 documentation tag(s) are empty. Delete the restating tags, or add what the name does not say.

Appendix B — Reproduction & audit trail

Every external tool invocation behind a deep-scan dimension — the tool, its captured version, the exact command, how many findings it yielded, and a link to the retained raw output. To reproduce any finding: check out the same commit and run the command shown (repo-relative — never an absolute scratch path). The complete raw scanner output is retained verbatim under artifacts/raw/ (indexed in artifacts/raw/index.json); per-invocation exit codes and wall-clock durations are in sidecar.json — kept out of this table so the rendered report stays byte-identical across runs of the same commit.

DimensionToolVersionCommandFindingsRaw output
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=0 --max-count=200" --report-format json --report-path /tmp/watchdog-gitleaks-60eb8488272149ecbac5ee67703aa2bf/history.json --exit-code 0 --source .0artifacts/raw/gitleaks-history.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=200 --max-count=800" --report-format json --report-path /tmp/watchdog-gitleaks-60eb8488272149ecbac5ee67703aa2bf/history-1.json --exit-code 0 --source .0artifacts/raw/gitleaks-history-1.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --log-opts "--full-history --all --skip=1000 --max-count=1019" --report-format json --report-path /tmp/watchdog-gitleaks-60eb8488272149ecbac5ee67703aa2bf/history-2.json --exit-code 0 --source .53artifacts/raw/gitleaks-history-2.json
D28 · Secrets (history)gitleaks—gitleaks detect --no-git --no-banner --config /opt/gitleaks-rules/canine-gitleaks.toml --report-format json --report-path /tmp/watchdog-gitleaks-60eb8488272149ecbac5ee67703aa2bf/tree.json --exit-code 0 --source .0artifacts/raw/gitleaks-tree.json
D29 · Static Analysis (SAST)semgrep—semgrep --config /opt/semgrep-rules/security-audit.yml --config /opt/semgrep-rules/owasp-top-ten.yml --config /opt/semgrep-rules/canine-sast.yml --json --quiet --timeout 10 --timeout-threshold 3 --metrics off --exclude *.arrow --exclude *.avro --exclude *.csv --exclude *.dat --exclude *.db --exclude *.feather --exclude *.geojson --exclude *.h5 --exclude *.hdf5 --exclude *.jsonl --exclude *.log --exclude *.ndjson --exclude *.npy --exclude *.npz --exclude *.orc --exclude *.parquet --exclude *.pickle --exclude *.pkl --exclude *.psv --exclude *.sqlite --exclude *.sqlite3 --exclude *.tfrecord --exclude *.tsv --exclude *.txt .6artifacts/raw/semgrep.json
D30 · Dependency Vulnerabilitiesnuget—nuget: not applicable — nuget: the solution did not restore on the analyzer's .NET SDK (an SDK/target-framework/restore mismatch, common for an older codebase), so there was no restored dependency graph to scan0—
D30 · Dependency Vulnerabilitiestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** .0artifacts/raw/trivy-fs.json
D31 · IaC & Container Securitytrivy—trivy: not applicable — No Infrastructure-as-Code or container manifests found (Dockerfile, Docker Compose, Terraform, Kubernetes/Helm, CloudFormation, ARM, Bicep, Ansible); nothing to scan.0—
D32 · Data Compliance (PII/GDPR)semgrep—semgrep: not applicable — No personal data was found crossing a boundary the PII/GDPR ruleset checks — nothing written to a log or console sink, placed in a URL or query string, or persisted to browser storage. That is a clean result for the LEAK surface only: this ruleset detects personal data escaping, it does not inventory the personal data a repository holds, so it is not evidence that this repository has no personal-data surface. The personal-data map (Appendix C) and the C1-C5 compliance cards are what speak to that. semgrep could not parse 13 file(s) — `Unity/Assets/Editor/BuildEditor/BuildEditor.cs`, `Unity/Assets/Editor/BuildEditor/BuildHelper.cs`, `Unity/Assets/Editor/BuildEditor/ETBuildSettings.cs`, `Unity/Assets/ThirdParty/Mongo/MongoDB.Bson/TargetFramework.cs`, `Unity/Assets/ThirdParty/protobuf-net/GlobalSuppressions.cs`, … (+8 more) — so the PII/GDPR sweep did not cover the unparsed regions of them; rows reported elsewhere in those files are real.0—
D36 · Supply-chain Provenance & Signingprovenance—provenance: not applicable — No CI/build pipeline found (.github/.forgejo/.gitea workflows, .circleci, .buildkite, .woodpecker, .teamcity, .gitlab-ci.yml, .travis.yml, bitbucket-pipelines.yml, .drone.yml, .cirrus.yml, .woodpecker.yml, appveyor.yml, azure-pipelines*.yml, .pipelines/, .vsts-ci/, .azuredevops/, Jenkinsfile); there is no build to attest provenance for.0—
D37 · Vulnerability-disclosure Policydisclosure—disclosure: not applicable — No vulnerability-disclosure policy file found (SECURITY.md/.markdown/.rst/.txt at root or under .github/.forgejo/.gitea/docs, .well-known/security.txt). A coordinated-disclosure policy may live off-repo, so this is not evidenced rather than failed.0—
D40 · Network Egress Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; network egress policy is a cluster-native control that may live at the platform/firewall layer, so there is nothing to assess here.0—
D41 · Kernel & Syscall Confinementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; seccomp/AppArmor/SELinux confinement is a workload-level control, so there is nothing to assess here.0—
D42 · Runtime Threat Enforcementruntime-hardening—runtime-hardening: not applicable — No Kubernetes/orchestration workloads found in the repository manifests; runtime threat-detection and admission-control policy are cluster-level controls, so there is nothing to assess here.0—
D43 · Malicious Dependenciestrivy—trivy fs --scanners vuln --format json --quiet --severity CRITICAL,HIGH,MEDIUM,LOW --skip-dirs **/bin/** --skip-dirs **/obj/** .0artifacts/raw/trivy-fs.json

Run 01a1eb0b-169a-70fb-8ace-7be0262446e7 · every finding is also locatable in findings.md, and the complete scoring record (with exit codes + durations) in sidecar.json.

Downloadable artifacts

Machine-readable and reproducible from this commit + frozen rubric — drop them straight into a contract appendix, a CRA dossier, or a downstream SCA / VEX tool.

⬇ Findings, MITRE CWE-tagged .sarif⬇ Health changelog .md